57651 2011-04-01 12:39:14 -0700 Behavior of isAccelerated() for a IOSurface-backed canvas should be consistent with accelerated status of its ImageBuffer 2011-04-01 14:00:37 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mdelaney7 mdelaney7 cmarrin mdelaney7 simon.fraser oldest_to_newest 377987 0 mdelaney7 2011-04-01 12:39:14 -0700 Currently, if a canvas is backed by an IOSurface, its isAccelerated method simply reports whether or not the page settings have canvasUsesAcceleratedDrawing enabled. This leads to an inconsistency because having that preference on isn't a sufficient condition for an accelerated canvas backend (e.g. when the IOSurface backend is avoided due to size limits). Thus, when the canvas is backed by an IOSurface then isAccelerated on the context should only report true when the ImageBuffer is in fact in Accelerated Rendering mode (i.e. it did in fact create an IOSurface backing). 377991 1 87899 mdelaney7 2011-04-01 12:46:57 -0700 Created attachment 87899 Patch 378013 2 87899 simon.fraser 2011-04-01 13:09:51 -0700 Comment on attachment 87899 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87899&action=review > Source/WebCore/platform/graphics/ImageBuffer.h:89 > + bool isAccelerated() { return m_accelerateRendering; } This should be |const| 378056 3 mdelaney7 2011-04-01 14:00:37 -0700 Committed r82715: <http://trac.webkit.org/changeset/82715> 87899 2011-04-01 12:46:57 -0700 2011-04-01 13:09:51 -0700 Patch bug-57651-20110401124656.patch text/plain 2129 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyNzA2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDEgIE1hdHRoZXcg RGVsYW5leSAgPG1kZWxhbmV5QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBCZWhhdmlvciBvZiBpc0FjY2VsZXJhdGVkKCkgZm9yIGEg SU9TdXJmYWNlLWJhY2tlZCBjYW52YXMgc2hvdWxkIGJlIGNvbnNpc3RlbnQgd2l0aCBhY2NlbGVy YXRlZCBzdGF0dXMgb2YgaXRzIEltYWdlQnVmZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzY1MQorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhp cyBwYXRjaCBkb2VzIG5vdCBhZmZlY3Qgb3V0d2FyZCBiZWhhdmlvci4KKworICAgICAgICAqIGh0 bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmlzQWNjZWxlcmF0ZWQpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1 ZmZlcjo6aXNBY2NlbGVyYXRlZCk6CisKIDIwMTEtMDQtMDEgIFN0ZXZlIEJsb2NrICA8c3RldmVi bG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVy aW5nQ29udGV4dDJELmNwcAkocmV2aXNpb24gODI2MjMpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NDYsNyArMTQ2LDcgQEAgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjp+Q2FudmFzUmVuZGVyaQog Ym9vbCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmlzQWNjZWxlcmF0ZWQoKSBjb25zdAogewog I2lmIFVTRShJT1NVUkZBQ0VfQ0FOVkFTX0JBQ0tJTkdfU1RPUkUpCi0gICAgcmV0dXJuIGNhbnZh cygpLT5kb2N1bWVudCgpLT5wYWdlKCktPnNldHRpbmdzKCktPmNhbnZhc1VzZXNBY2NlbGVyYXRl ZERyYXdpbmcoKTsKKyAgICByZXR1cm4gY2FudmFzKCktPmJ1ZmZlcigpLT5pc0FjY2VsZXJhdGVk KCk7CiAjZWxpZiBFTkFCTEUoQUNDRUxFUkFURURfMkRfQ0FOVkFTKQogICAgIHJldHVybiBtX2Nv bnRleHQzRDsKICNlbHNlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9J bWFnZUJ1ZmZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0ltYWdlQnVmZmVyLmgJKHJldmlzaW9uIDgyNjIzKQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuaAkod29ya2luZyBjb3B5KQpAQCAtODYsNiArODYs NyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIAogICAgICAgICBHcmFwaGljc0NvbnRl eHQqIGNvbnRleHQoKSBjb25zdDsKIAorICAgICAgICBib29sIGlzQWNjZWxlcmF0ZWQoKSB7IHJl dHVybiBtX2FjY2VsZXJhdGVSZW5kZXJpbmc7IH0KICAgICAgICAgYm9vbCBkcmF3c1VzaW5nQ29w eSgpIGNvbnN0OyAvLyBJZiB0aGUgaW1hZ2UgYnVmZmVyIGhhcyB0byByZW5kZXIgdXNpbmcgYSBj b3BpZWQgaW1hZ2UsIGl0IHdpbGwgcmV0dXJuIHRydWUuCiAgICAgICAgIFBhc3NSZWZQdHI8SW1h Z2U+IGNvcHlJbWFnZSgpIGNvbnN0OyAvLyBSZXR1cm4gYSBuZXcgaW1hZ2UgdGhhdCBpcyBhIGNv cHkgb2YgdGhlIGJ1ZmZlci4KIAo=