57646 2011-04-01 11:16:39 -0700 add some directories to .gitignore (and svn:ignore) when opening projects in xcode4 2011-04-04 10:47:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P5 Enhancement --- 0 jonlee webkit-unassigned commit-queue darin eric webkit.review.bot oldest_to_newest 377929 0 87883 jonlee 2011-04-01 11:16:39 -0700 Created attachment 87883 Patch when opening the .xcodeproj's in xcode 4 new directories are added that can be safely ignored: project.xcworkspace xcuserdata we should add these to the .gitignore file. there was some concern that we might not be able to add them to svn:ignore, and given my own inexperience with svn i might need some help with that. 377960 1 darin 2011-04-01 12:01:00 -0700 (In reply to comment #0) > there was some concern that we might not be able to add them to svn:ignore Worded in passive voice like that I can’t figure out who to talk to. I see no reason not to add them to svn:ignore. 378059 2 87883 commit-queue 2011-04-01 14:05:48 -0700 Comment on attachment 87883 Patch Rejecting attachment 87883 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 2 Last 500 characters of output: e320df0bc2a7392c23fed272541949383a6debe (refs/remotes/trunk) M Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm r82714 = 65aa910d1095f0da99aeef9066a4c23538920523 (refs/remotes/trunk) M Source/WebCore/ChangeLog M Source/WebCore/platform/graphics/ImageBuffer.h M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp r82715 = 59e1fa091b3ee61a947f76347ef0d8a9e046f29b (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8319269 378111 3 87883 commit-queue 2011-04-01 15:08:38 -0700 Comment on attachment 87883 Patch Rejecting attachment 87883 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 2 Last 500 characters of output: nderTree.xcodeproj/project.pbxproj M Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp A Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp M Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp M Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h M Tools/ChangeLog r82723 = 820aceeac648b5c1c776d8e5a1c747c4b9afd65f (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8318307 378317 4 eric 2011-04-01 21:14:27 -0700 Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html It's failing a precommit step. Sorry the output is confusing. 378841 5 88071 jonlee 2011-04-04 09:58:54 -0700 Created attachment 88071 Patch Adding missing ChangeLog file. 378843 6 webkit.review.bot 2011-04-04 10:01:22 -0700 Attachment 88071 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1 ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 378844 7 88071 eric 2011-04-04 10:02:56 -0700 Comment on attachment 88071 Patch Go go magic xcode 4. I don't think that svn-apply can handle svn:ignore changes. the stylebot doens't like that your'e missing the bug url: https://bugs.webkit.org/show_bug.cgi?id=57646 prepare-changelog -b number will automatically add it when you create the bug. webkit-patch upload will too. Thanks for hte patch! 378852 8 88074 jonlee 2011-04-04 10:15:46 -0700 Created attachment 88074 Patch Fixed ChangeLog, and double checked that it passed webkit style. 378854 9 88074 eric 2011-04-04 10:17:25 -0700 Comment on attachment 88074 Patch Woohoo! 378874 10 88074 commit-queue 2011-04-04 10:47:22 -0700 Comment on attachment 88074 Patch Clearing flags on attachment: 88074 Committed r82846: <http://trac.webkit.org/changeset/82846> 378875 11 commit-queue 2011-04-04 10:47:27 -0700 All reviewed patches have been landed. Closing bug. 87883 2011-04-01 11:16:39 -0700 2011-04-04 09:58:54 -0700 Patch 0001-update-to-.gitignore-for-xcode-4.patch text/plain 585 jonlee RnJvbSAxMWE2OGM5OGU1NGI0ODc1NDc1MjAxYmE3ZWM0YzA1MmYzOWEwMWEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gTGVlIDxqb25sZWVAYXBwbGUuY29tPgpEYXRlOiBXZWQs IDIzIE1hciAyMDExIDE1OjIzOjI0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gdXBkYXRlIHRvIC5n aXRpZ25vcmUgZm9yIHhjb2RlIDQKCi0tLQogLmdpdGlnbm9yZSB8ICAgIDIgKysKIDEgZmlsZXMg Y2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhLy5n aXRpZ25vcmUgYi8uZ2l0aWdub3JlCmluZGV4IDMwZjBjZGMuLmU0MTIxMTAgMTAwNjQ0Ci0tLSBh Ly5naXRpZ25vcmUKKysrIGIvLmdpdGlnbm9yZQpAQCAtNyw2ICs3LDggQEAgYnVpbGQvCiAvV2Vi S2l0QnVpbGQvCiBhdXRvaW5zdGFsbC5jYWNoZS5kCiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Ro aXJkcGFydHkvYXV0b2luc3RhbGxlZAorcHJvamVjdC54Y3dvcmtzcGFjZQoreGN1c2VyZGF0YQog CiAjIElnbm9yZSBjb21tb24gdG9vbCBhdXRvLWdlbmVyYXRlZCBmaWxlcy4KIC5nZGJfaGlzdG9y eQotLSAKMS43LjMuNAoK 88071 2011-04-04 09:58:54 -0700 2011-04-04 10:15:46 -0700 Patch 0001-add-some-directories-to-.gitignore-and-svn-ignore-wh.patch text/plain 1361 jonlee RnJvbSBiMzA2YjlmYzhlOGQwMzExZTU0NDkxOGFjYjg2OTViNTNmOWYxMGE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gTGVlIDxqb25sZWVAYXBwbGUuY29tPgpEYXRlOiBXZWQs IDIzIE1hciAyMDExIDE1OjIzOjI0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gYWRkIHNvbWUgZGly ZWN0b3JpZXMgdG8gLmdpdGlnbm9yZSAoYW5kIHN2bjppZ25vcmUpIHdoZW4gb3BlbmluZyBwcm9q ZWN0cyBpbiB4Y29kZTQgKDU3NjQ2KQogPHJkYXI6Ly9wcm9ibGVtLzkyMjI1NTk+CgpSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogLmdpdGlnbm9yZTogYWRkZWQgeGNvZGUgNCByZWxhdGVk IHByb2plY3QgYW5kIHdvcmtzcGFjZSBkaXJlY3RvcmllcyB0aGF0IGFyZSBub3QgbmVlZGVkIGZv ciBjaGVja2luCi0tLQogLmdpdGlnbm9yZSB8ICAgIDIgKysKIENoYW5nZUxvZyAgfCAgICA5ICsr KysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhLy5naXRpZ25vcmUgYi8uZ2l0aWdub3JlCmluZGV4IDMwZjBjZGMuLmU0 MTIxMTAgMTAwNjQ0Ci0tLSBhLy5naXRpZ25vcmUKKysrIGIvLmdpdGlnbm9yZQpAQCAtNyw2ICs3 LDggQEAgYnVpbGQvCiAvV2ViS2l0QnVpbGQvCiBhdXRvaW5zdGFsbC5jYWNoZS5kCiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFydHkvYXV0b2luc3RhbGxlZAorcHJvamVjdC54Y3dvcmtz cGFjZQoreGN1c2VyZGF0YQogCiAjIElnbm9yZSBjb21tb24gdG9vbCBhdXRvLWdlbmVyYXRlZCBm aWxlcy4KIC5nZGJfaGlzdG9yeQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmlu ZGV4IDMyMTQ1YWIuLjZjM2UwNGUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wNC0wNCAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYWRk IHNvbWUgZGlyZWN0b3JpZXMgdG8gLmdpdGlnbm9yZSAoYW5kIHN2bjppZ25vcmUpIHdoZW4gb3Bl bmluZyBwcm9qZWN0cyBpbiB4Y29kZTQgKDU3NjQ2KQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v OTIyMjU1OT4KKworICAgICAgICAqIC5naXRpZ25vcmU6IGFkZGVkIHhjb2RlIDQgcmVsYXRlZCBw cm9qZWN0IGFuZCB3b3Jrc3BhY2UgZGlyZWN0b3JpZXMgdGhhdCBhcmUgbm90IG5lZWRlZCBmb3Ig Y2hlY2tpbgorCiAyMDExLTAzLTMxICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCi0tIAoxLjcuMy40Cgo= 88074 2011-04-04 10:15:46 -0700 2011-04-04 10:47:22 -0700 Patch 0001-add-some-directories-to-.gitignore-and-svn-ignore-wh.patch text/plain 1387 jonlee RnJvbSA4NTM3NGUxYjhlYjRlYzAzZGZiOWQxYTE0YjE2ODgxZDk2MzYxN2JmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gTGVlIDxqb25sZWVAYXBwbGUuY29tPgpEYXRlOiBXZWQs IDIzIE1hciAyMDExIDE1OjIzOjI0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gYWRkIHNvbWUgZGly ZWN0b3JpZXMgdG8gLmdpdGlnbm9yZSAoYW5kIHN2bjppZ25vcmUpIHdoZW4gb3BlbmluZyBwcm9q ZWN0cyBpbiB4Y29kZTQKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NzY0NgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIC5naXRpZ25vcmU6IGFkZGVkIHhj b2RlIDQgcmVsYXRlZCBwcm9qZWN0IGFuZCB3b3Jrc3BhY2UgZGlyZWN0b3JpZXMgdGhhdCBhcmUg bm90IG5lZWRlZCBmb3IgY2hlY2tpbgotLS0KIC5naXRpZ25vcmUgfCAgICAyICsrCiBDaGFuZ2VM b2cgIHwgICAgOSArKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwg MCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS8uZ2l0aWdub3JlIGIvLmdpdGlnbm9yZQppbmRl eCAzMGYwY2RjLi5lNDEyMTEwIDEwMDY0NAotLS0gYS8uZ2l0aWdub3JlCisrKyBiLy5naXRpZ25v cmUKQEAgLTcsNiArNyw4IEBAIGJ1aWxkLwogL1dlYktpdEJ1aWxkLwogYXV0b2luc3RhbGwuY2Fj aGUuZAogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L2F1dG9pbnN0YWxsZWQKK3By b2plY3QueGN3b3Jrc3BhY2UKK3hjdXNlcmRhdGEKIAogIyBJZ25vcmUgY29tbW9uIHRvb2wgYXV0 by1nZW5lcmF0ZWQgZmlsZXMuCiAuZ2RiX2hpc3RvcnkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi L0NoYW5nZUxvZwppbmRleCAzMjE0NWFiLi5jMzUyMGYwIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cK KysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMDQgIEpvbiBMZWUgIDxq b25sZWVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGFkZCBzb21lIGRpcmVjdG9yaWVzIHRvIC5naXRpZ25vcmUgKGFuZCBzdm46aWdu b3JlKSB3aGVuIG9wZW5pbmcgcHJvamVjdHMgaW4geGNvZGU0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzY0NgorCisgICAgICAgICogLmdpdGlnbm9y ZTogYWRkZWQgeGNvZGUgNCByZWxhdGVkIHByb2plY3QgYW5kIHdvcmtzcGFjZSBkaXJlY3Rvcmll cyB0aGF0IGFyZSBub3QgbmVlZGVkIGZvciBjaGVja2luCisKIDIwMTEtMDMtMzEgIFhhbiBMb3Bl eiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2Jp bnNvbi4KLS0gCjEuNy4zLjQKCg==