57636 2011-04-01 09:02:34 -0700 Setting defaultValue on a textarea with a modified value still clobbers the value 2011-04-05 07:29:28 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bzbarsky webkit-unassigned abarth ap darin dglazkov eric pnormand tkent webkit.review.bot zcorpan oldest_to_newest 377829 0 bzbarsky 2011-04-01 09:02:34 -0700 BUILD: Safari 5, Chrome 12 dev STEPS TO REPRODUCE: Load attached testcase. EXPECTED RESULT: Textarea says "PASS" ACTUAL RESULT: Textarea says "FAIL" 377843 1 87867 bzbarsky 2011-04-01 09:14:39 -0700 Created attachment 87867 Testcase 377903 2 ap 2011-04-01 10:34:46 -0700 Wow. 377920 3 bzbarsky 2011-04-01 11:01:15 -0700 Oh, the original context I ran into this in the page was setting .innerHTML, not .defaultValue. But I assume they end up in the same place in the end: modifying the DOM under the textarea. ;) The innerHTML case shows the same problem, of course. 378318 4 tkent 2011-04-01 21:29:15 -0700 IE 9: PASS Firefox 4: PASS Opera 11: FAIL 378321 5 bzbarsky 2011-04-01 21:39:41 -0700 Quite interesting. In Opera 11, scripted value changes (as in the attached testcase) on <textarea> allow defaultValue to override value, but if I edit the text in the textarea by typing (as in the original testcase I based mine on) then defaultValue changes don't affect value. I wasn't expecting Opera to have a difference in behavior there. None of the other three rendering engines involved seem to: WebKit shows "FAIL" in both scenarios, while Trident and Gecko show "PASS". Note also that WebKit's behavior here is inconsistent for <textarea> and <input type="text">; the latter behaves as it does in Trident and Gecko. 378328 6 tkent 2011-04-01 21:50:21 -0700 Yeah, definitely we should fix this. 378679 7 88037 tkent 2011-04-04 00:17:42 -0700 Created attachment 88037 Patch 378785 8 88037 dglazkov 2011-04-04 07:57:34 -0700 Comment on attachment 88037 Patch ok. 378801 9 88037 darin 2011-04-04 08:33:11 -0700 Comment on attachment 88037 Patch I think we can eliminate setNonDirtyValue and setValueCommon. Instead, callers can just call setValue and then set m_isDirty to false. 379297 10 tkent 2011-04-04 19:17:55 -0700 (In reply to comment #9) > (From update of attachment 88037 [details]) > I think we can eliminate setNonDirtyValue and setValueCommon. Instead, callers can just call setValue and then set m_isDirty to false. setValue() needs to call setNeedsValidityCheck(), which must be called after m_isDirty update. So, the current code is efficient. 379360 11 88037 tkent 2011-04-05 00:27:50 -0700 Comment on attachment 88037 Patch Clearing flags on attachment: 88037 Committed r82908: <http://trac.webkit.org/changeset/82908> 379361 12 tkent 2011-04-05 00:27:58 -0700 All reviewed patches have been landed. Closing bug. 379371 13 webkit.review.bot 2011-04-05 01:34:12 -0700 http://trac.webkit.org/changeset/82908 might have broken GTK Linux 32-bit Release 379382 14 pnormand 2011-04-05 02:07:23 -0700 (In reply to comment #13) > http://trac.webkit.org/changeset/82908 might have broken GTK Linux 32-bit Release fast/forms/ValidityState-tooLong-textarea.html now fails on GTK: --- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/forms/ValidityState-tooLong-textarea-expected.txt 2011-04-05 01:05:58.793116363 -0700 +++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/forms/ValidityState-tooLong-textarea-actual.txt 2011-04-05 01:05:58.793116363 -0700 @@ -31,8 +31,8 @@ PASS textarea.value is "abc" PASS textarea.validity.tooLong is false PASS textarea.validity.tooLong is true -PASS textarea.value is "abcdef" -PASS textarea.validity.tooLong is false +FAIL textarea.value should be abcdef. Was def. +FAIL textarea.validity.tooLong should be false. Was true. PASS successfullyParsed is true TEST COMPLETE 379386 15 tkent 2011-04-05 02:11:53 -0700 (In reply to comment #14) > (In reply to comment #13) > > http://trac.webkit.org/changeset/82908 might have broken GTK Linux 32-bit Release > > fast/forms/ValidityState-tooLong-textarea.html now fails on GTK: Thank you for reporting. I fixed it by r82913. 379419 16 zcorpan 2011-04-05 03:28:38 -0700 Relevant parts of the spec [[ The textarea element represents a multiline plain text edit control for the element's raw value. A textarea element has a dirty value flag, which must be initially set to false, and must be set to true whenever the user interacts with the control in a way that changes the raw value. When the textarea element's textContent IDL attribute changes value, if the element's dirty value flag is false, then the element's raw value must be set to the value of the element's textContent IDL attribute. The defaultValue IDL attribute must act like the element's textContent IDL attribute. ]] http://www.whatwg.org/specs/web-apps/current-work/complete/the-button-element.html#the-textarea-element AFAICT the old behavior matches the spec. (Setting .value doesn't set the dirty value flag.) 379539 17 bzbarsky 2011-04-05 07:29:28 -0700 I believe that's a bug in the spec, since for <input> setting .value _does_ change the dirty flag in the spec. Filed http://www.w3.org/Bugs/Public/show_bug.cgi?id=12423 87867 2011-04-01 09:14:39 -0700 2011-04-01 09:14:39 -0700 Testcase baz.html text/html 187 bzbarsky PCFET0NUWVBFIGh0bWw+Cjxib2R5PgogIDx0ZXh0YXJlYT48L3RleHRhcmVhPgogIDxzY3JpcHQ+ CiAgICB2YXIgeCA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJ0ZXh0YXJlYSIpWzBd OwogICAgeC52YWx1ZSA9ICJQQVNTIjsKICAgIHguZGVmYXVsdFZhbHVlID0gIkZBSUwiOwogIDwv c2NyaXB0Pgo8L2JvZHk+Cg== 88037 2011-04-04 00:17:42 -0700 2011-04-05 00:27:50 -0700 Patch bug-57636-20110404161740.patch text/plain 6950 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogODI3OTUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhMGUyY2M4MjA4NDVhY2I3YTAxMDdl ZGFlYmVlZGQ3MjI4OGYyMmVkLi5kOGY4Mzk5M2NhNWI2YmI5N2Y1YmRiNTI3MDAzYTA4YjdmMTJl MTcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMDQgIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFNldHRpbmcgZGVmYXVsdFZhbHVlIG9uIGEgdGV4dGFyZWEgd2l0aCBhIG1vZGlm aWVkIHZhbHVlIHN0aWxsIGNsb2JiZXJzIHRoZSB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc2MzYKKworICAgICAgICAqIGZhc3QvZm9ybXMv dGV4dGFyZWEtc2V0LWRlZmF1bHR2YWx1ZS1hZnRlci12YWx1ZS1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvZm9ybXMvdGV4dGFyZWEtc2V0LWRlZmF1bHR2YWx1ZS1hZnRlci12 YWx1ZS5odG1sOiBBZGRlZC4KKwogMjAxMS0wNC0wMyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBw bGUuY29tPgogCiAgICAgICAgIFRyeSB0byBtYWtlIHRoaXMgdGVzdCBtb3JlIHJvYnVzdC4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGV4dGFyZWEtc2V0LWRlZmF1bHR2YWx1 ZS1hZnRlci12YWx1ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRh cmVhLXNldC1kZWZhdWx0dmFsdWUtYWZ0ZXItdmFsdWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjQ3ZDE0ZjlhMGQ2MWJlYTcyYTRjZTFkZTZiZDcxODY4MTM2ZGRlNzcKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRhcmVhLXNldC1kZWZhdWx0dmFsdWUtYWZ0 ZXItdmFsdWUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjEgQEAKK1Rlc3RzIHRvIGNoZWNrIGJl aGF2aW9ycyBvZiBkaXJ0eSBmbGFnIGFuZCBkZWZhdWx0VmFsdWUgY2hhbmdlLgorCitQQVNTIGRv Y3VtZW50LmV4ZWNDb21tYW5kKCJJbnNlcnRUZXh0IiwgZmFsc2UsICJ1c2VyLXVwZGF0ZWQiKTsg dGV4dGFyZWEudmFsdWUgaXMgInVzZXItdXBkYXRlZCIKK1BBU1MgdGV4dGFyZWEuZGVmYXVsdFZh bHVlID0gImRlZmF1bHQgMiI7IHRleHRhcmVhLnZhbHVlIGlzICJ1c2VyLXVwZGF0ZWQiCitQQVNT IGZvcm0ucmVzZXQoKTsgdGV4dGFyZWEudmFsdWUgaXMgImRlZmF1bHQgMiIKK1BBU1MgdGV4dGFy ZWEuZGVmYXVsdFZhbHVlID0gImRlZmF1bHQgMyI7IHRleHRhcmVhLnZhbHVlIGlzICJkZWZhdWx0 IDMiCitQQVNTIHRleHRhcmVhLnZhbHVlID0gInNjcmlwdC11cGRhdGVkIjsgdGV4dGFyZWEudmFs dWUgaXMgInNjcmlwdC11cGRhdGVkIgorUEFTUyB0ZXh0YXJlYS5kZWZhdWx0VmFsdWUgPSAiZGVm YXVsdCA0IjsgdGV4dGFyZWEudmFsdWUgaXMgInNjcmlwdC11cGRhdGVkIgorUEFTUyBmb3JtLnJl c2V0KCk7IHRleHRhcmVhLnZhbHVlIGlzICJkZWZhdWx0IDQiCitQQVNTIHRleHRhcmVhLnZhbHVl ID0gInNjcmlwdC11cGRhdGVkIjsgdGV4dGFyZWEudmFsdWUgaXMgInNjcmlwdC11cGRhdGVkIgor UEFTUyB0ZXh0YXJlYS5pbm5lckhUTUwgPSAiZGVmYXVsdCA1IjsgdGV4dGFyZWEudmFsdWUgaXMg InNjcmlwdC11cGRhdGVkIgorUEFTUyBmb3JtLnJlc2V0KCk7IHRleHRhcmVhLnZhbHVlIGlzICJk ZWZhdWx0IDUiCitQQVNTIHRleHRhcmVhLmlubmVySFRNTCA9ICJkZWZhdWx0IDYiOyB0ZXh0YXJl YS52YWx1ZSBpcyAiZGVmYXVsdCA2IgorUEFTUyB0ZXh0YXJlYS52YWx1ZSA9ICJzY3JpcHQtdXBk YXRlZCI7IHRleHRhcmVhLnZhbHVlIGlzICJzY3JpcHQtdXBkYXRlZCIKK1BBU1MgdGV4dGFyZWEu cmVtb3ZlQ2hpbGQodGV4dGFyZWEuZmlyc3RDaGlsZCk7IHRleHRhcmVhLmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZVRleHROb2RlKCJkZWZhdWx0IDUiKSk7IHRleHRhcmVhLnZhbHVlIGlzICJz Y3JpcHQtdXBkYXRlZCIKK1BBU1MgZm9ybS5yZXNldCgpOyB0ZXh0YXJlYS52YWx1ZSBpcyAiZGVm YXVsdCA1IgorUEFTUyB0ZXh0YXJlYS5yZW1vdmVDaGlsZCh0ZXh0YXJlYS5maXJzdENoaWxkKTsg dGV4dGFyZWEuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoImRlZmF1bHQgNiIp KTsgdGV4dGFyZWEudmFsdWUgaXMgImRlZmF1bHQgNiIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL3RleHRhcmVhLXNldC1kZWZhdWx0dmFsdWUtYWZ0ZXItdmFsdWUuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvdGV4dGFyZWEtc2V0LWRlZmF1bHR2YWx1ZS1hZnRlci12YWx1ZS5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLmNjYzAwZGY5NzI5YzI5YjJmZjRhNmYyOWExNGE5MDYwYjYxMDVkZGYK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRhcmVhLXNldC1k ZWZhdWx0dmFsdWUtYWZ0ZXItdmFsdWUuaHRtbApAQCAtMCwwICsxLDUxIEBACis8IURPQ1RZUEUg aHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4u L2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8u Li9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8 Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+VGVzdHMgdG8gY2hlY2sgYmVoYXZpb3JzIG9mIGRp cnR5IGZsYWcgYW5kIGRlZmF1bHRWYWx1ZSBjaGFuZ2UuPC9wPgorPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+Cis8Zm9ybSBpZD1mb3JtPgorPHRleHRhcmVhIG5hbWU9dGV4dGFyZWEgaWQ9dGV4dGFy ZWE+CitkZWZhdWx0Cis8L3RleHRhcmVhPgorPC9mb3JtPgorCis8c2NyaXB0PgordmFyIGZvcm0g PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZm9ybScpOwordmFyIHRleHRhcmVhID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoJ3RleHRhcmVhJyk7CisKKy8vIERpcnR5IGJ5IGV4ZWNDb21tYW5k KCksIHRoZW4gc2V0RGVmYXVsdFZhbHVlKCkuCit0ZXh0YXJlYS5mb2N1cygpOwordGV4dGFyZWEu c2VsZWN0KCk7CitzaG91bGRCZSgnZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydFRleHQiLCBm YWxzZSwgInVzZXItdXBkYXRlZCIpOyB0ZXh0YXJlYS52YWx1ZScsICcidXNlci11cGRhdGVkIicp Oworc2hvdWxkQmUoJ3RleHRhcmVhLmRlZmF1bHRWYWx1ZSA9ICJkZWZhdWx0IDIiOyB0ZXh0YXJl YS52YWx1ZScsICcidXNlci11cGRhdGVkIicpOworc2hvdWxkQmUoJ2Zvcm0ucmVzZXQoKTsgdGV4 dGFyZWEudmFsdWUnLCAnImRlZmF1bHQgMiInKTsKK3Nob3VsZEJlKCd0ZXh0YXJlYS5kZWZhdWx0 VmFsdWUgPSAiZGVmYXVsdCAzIjsgdGV4dGFyZWEudmFsdWUnLCAnImRlZmF1bHQgMyInKTsKKwor Ly8gRGlydHkgYnkgc2V0VmFsdWUoKSwgdGhlbiBzZXREZWZhdWx0VmFsdWUoKS4KK3Nob3VsZEJl KCd0ZXh0YXJlYS52YWx1ZSA9ICJzY3JpcHQtdXBkYXRlZCI7IHRleHRhcmVhLnZhbHVlJywgJyJz Y3JpcHQtdXBkYXRlZCInKTsKK3Nob3VsZEJlKCd0ZXh0YXJlYS5kZWZhdWx0VmFsdWUgPSAiZGVm YXVsdCA0IjsgdGV4dGFyZWEudmFsdWUnLCAnInNjcmlwdC11cGRhdGVkIicpOworc2hvdWxkQmUo J2Zvcm0ucmVzZXQoKTsgdGV4dGFyZWEudmFsdWUnLCAnImRlZmF1bHQgNCInKTsKKworLy8gRGly dHkgYnkgc2V0VmFsdWUoKSwgdGhlbiB1cGRhdGUgZGVmYXVsdFZhbHVlIGJ5IGlubmVySFRNTC4K K3Nob3VsZEJlKCd0ZXh0YXJlYS52YWx1ZSA9ICJzY3JpcHQtdXBkYXRlZCI7IHRleHRhcmVhLnZh bHVlJywgJyJzY3JpcHQtdXBkYXRlZCInKTsKK3Nob3VsZEJlKCd0ZXh0YXJlYS5pbm5lckhUTUwg PSAiZGVmYXVsdCA1IjsgdGV4dGFyZWEudmFsdWUnLCAnInNjcmlwdC11cGRhdGVkIicpOworc2hv dWxkQmUoJ2Zvcm0ucmVzZXQoKTsgdGV4dGFyZWEudmFsdWUnLCAnImRlZmF1bHQgNSInKTsKK3No b3VsZEJlKCd0ZXh0YXJlYS5pbm5lckhUTUwgPSAiZGVmYXVsdCA2IjsgdGV4dGFyZWEudmFsdWUn LCAnImRlZmF1bHQgNiInKTsKKworLy8gRGlydHkgYnkgc2V0VmFsdWUoKSwgdGhlbiB1cGRhdGUg ZGVmYXVsdFZhbHVlIGJ5IERPTSB0cmVlIG9wZXJhdGlvbnMuCitzaG91bGRCZSgndGV4dGFyZWEu dmFsdWUgPSAic2NyaXB0LXVwZGF0ZWQiOyB0ZXh0YXJlYS52YWx1ZScsICcic2NyaXB0LXVwZGF0 ZWQiJyk7CitzaG91bGRCZSgndGV4dGFyZWEucmVtb3ZlQ2hpbGQodGV4dGFyZWEuZmlyc3RDaGls ZCk7IHRleHRhcmVhLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJkZWZhdWx0 IDUiKSk7IHRleHRhcmVhLnZhbHVlJywgJyJzY3JpcHQtdXBkYXRlZCInKTsKK3Nob3VsZEJlKCdm b3JtLnJlc2V0KCk7IHRleHRhcmVhLnZhbHVlJywgJyJkZWZhdWx0IDUiJyk7CitzaG91bGRCZSgn dGV4dGFyZWEucmVtb3ZlQ2hpbGQodGV4dGFyZWEuZmlyc3RDaGlsZCk7IHRleHRhcmVhLmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJkZWZhdWx0IDYiKSk7IHRleHRhcmVhLnZh bHVlJywgJyJkZWZhdWx0IDYiJyk7CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwor Zm9ybS5pbm5lckhUTUwgPSAnJzsKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4vLi4vZmFz dC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRt bD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCBkMzMzYmYyNWMyNzJlNThkY2JiYTU1ZTQ4NGNlMGVlZDVhNTBmNzFj Li44OTUxMzg5ZmQ4NDBjNDQzYzQ2NWQ5NGZjY2UwYThmYWM3NmEzNjU0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMDQgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNl dHRpbmcgZGVmYXVsdFZhbHVlIG9uIGEgdGV4dGFyZWEgd2l0aCBhIG1vZGlmaWVkIHZhbHVlIHN0 aWxsIGNsb2JiZXJzIHRoZSB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTc2MzYKKworICAgICAgICBJZiB0aGUgZGlydHkgZmxhZyBpcyB0cnVl LCB3ZSBzaG91bGRuJ3QgdXBkYXRlIHRoZSB2YWx1ZSB3aGVuIHRoZQorICAgICAgICBkZWZhdWx0 VmFsdWUgaXMgdXBkYXRlZAorCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvdGV4dGFyZWEtc2V0 LWRlZmF1bHR2YWx1ZS1hZnRlci12YWx1ZS5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxUZXh0 QXJlYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRleHRBcmVhRWxlbWVudDo6 Y2hpbGRyZW5DaGFuZ2VkKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUZXh0QXJlYUVsZW1lbnQ6 OnNldERlZmF1bHRWYWx1ZSk6CisKIDIwMTEtMDQtMDMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCmluZGV4IDg4MzE5ZDFlNDQ4 ZDkyM2NkZWQ3MjQ0NzFmNjQ3MzQzZWE1Y2NkYTUuLmUwNDYzZmZkZTc5MTI1ZmJhMmIxNDZjNDY4 NDhjNzRiZDdlMDE3MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRB cmVhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEFyZWFFbGVt ZW50LmNwcApAQCAtMTA0LDcgKzEwNCw4IEBAIHZvaWQgSFRNTFRleHRBcmVhRWxlbWVudDo6cmVz dG9yZUZvcm1Db250cm9sU3RhdGUoY29uc3QgU3RyaW5nJiBzdGF0ZSkKIAogdm9pZCBIVE1MVGV4 dEFyZWFFbGVtZW50OjpjaGlsZHJlbkNoYW5nZWQoYm9vbCBjaGFuZ2VkQnlQYXJzZXIsIE5vZGUq IGJlZm9yZUNoYW5nZSwgTm9kZSogYWZ0ZXJDaGFuZ2UsIGludCBjaGlsZENvdW50RGVsdGEpCiB7 Ci0gICAgc2V0Tm9uRGlydHlWYWx1ZShkZWZhdWx0VmFsdWUoKSk7CisgICAgaWYgKCFtX2lzRGly dHkpCisgICAgICAgIHNldE5vbkRpcnR5VmFsdWUoZGVmYXVsdFZhbHVlKCkpOwogICAgIEhUTUxF bGVtZW50OjpjaGlsZHJlbkNoYW5nZWQoY2hhbmdlZEJ5UGFyc2VyLCBiZWZvcmVDaGFuZ2UsIGFm dGVyQ2hhbmdlLCBjaGlsZENvdW50RGVsdGEpOwogfQogICAgIApAQCAtMzYzLDcgKzM2NCw4IEBA IHZvaWQgSFRNTFRleHRBcmVhRWxlbWVudDo6c2V0RGVmYXVsdFZhbHVlKGNvbnN0IFN0cmluZyYg ZGVmYXVsdFZhbHVlKQogCiAgICAgaW5zZXJ0QmVmb3JlKGRvY3VtZW50KCktPmNyZWF0ZVRleHRO b2RlKHZhbHVlKSwgZmlyc3RDaGlsZCgpLCBlYyk7CiAKLSAgICBzZXROb25EaXJ0eVZhbHVlKHZh bHVlKTsKKyAgICBpZiAoIW1faXNEaXJ0eSkKKyAgICAgICAgc2V0Tm9uRGlydHlWYWx1ZSh2YWx1 ZSk7CiB9CiAKIGludCBIVE1MVGV4dEFyZWFFbGVtZW50OjptYXhMZW5ndGgoKSBjb25zdAo=