57632 2011-04-01 08:18:48 -0700 Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function 2011-08-21 12:31:09 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED Regression P1 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 377797 0 apavlov 2011-04-01 08:18:48 -0700 As advised by pfeldman, appropriateSelectorForNode() should become DOMNode.prototype.appropriateSelectorFor. This is the root cause of http://code.google.com/p/chromium/issues/detail?id=77531 377853 1 87869 apavlov 2011-04-01 09:30:14 -0700 Created attachment 87869 [PATCH] Suggested fix 378722 2 apavlov 2011-04-04 04:00:33 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/DOMAgent.js M Source/WebCore/inspector/front-end/EventListenersSidebarPane.js M Source/WebCore/inspector/front-end/StylesSidebarPane.js M Source/WebCore/inspector/front-end/utilities.js Committed r82818 454417 3 87869 pfeldman 2011-08-21 12:31:09 -0700 Comment on attachment 87869 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=87869&action=review > Source/WebCore/inspector/front-end/DOMAgent.js:228 > + var lowerCaseName = this.localName() || node.nodeName().toLowerCase(); Alexander, Yury, this code is not right: "node" is not defined in this context. Could you please cover this with a test? 87869 2011-04-01 09:30:14 -0700 2011-08-21 12:31:09 -0700 [PATCH] Suggested fix getter.patch text/plain 4859 apavlov Y29tbWl0IDBhMjQxOWRkY2Q3YTU4MTU5YTAzYjkyMTVhYmFlNGNkMTgxYmJiYzEKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBGcmkgQXByIDEg MjA6MDI6MzUgMjAxMSArMDQwMAoKICAgIEZpeAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmZmU0MWYyLi5lY2Jk NTI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDQtMDEgIEFsZXhhbmRlciBQ YXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBhcHByb3ByaWF0ZVNlbGVjdG9y Rm9yTm9kZSgpIGludm9rZXMgdGhlICJsb2NhbE5hbWUiIGdldHRlciBvbiBET01Ob2RlIHJhdGhl ciB0aGFuIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NzYzMgorCisgICAgICAgIE1vdmVkIHRoZSBhZmZlY3RlZCBtZXRob2Qgb250byB0 aGUgRE9NTm9kZS5wcm90b3R5cGUgYXMgImFwcHJvcHJpYXRlU2VsZWN0b3JGb3IiLgorCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5ET01Ob2RlLnByb3RvdHlwZS5hcHByb3ByaWF0ZVNlbGVjdG9yRm9yKToKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL0V2ZW50TGlzdGVuZXJzU2lkZWJhclBhbmUuanM6CisgICAg ICAgICgpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUucHJvdG90eXBlLmFk ZEJsYW5rU2VjdGlvbik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMu anM6CisKIDIwMTEtMDMtMjMgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFnZW50LmpzCmluZGV4IDU5MTg5NDEuLjg2NWMz NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NQWdl bnQuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5q cwpAQCAtMjIzLDYgKzIyMywyOCBAQCBXZWJJbnNwZWN0b3IuRE9NTm9kZS5wcm90b3R5cGUgPSB7 CiAgICAgICAgIHJldHVybiBwYXRoLmpvaW4oIiwiKTsKICAgICB9LAogCisgICAgYXBwcm9wcmlh dGVTZWxlY3RvckZvcjogZnVuY3Rpb24oanVzdFNlbGVjdG9yKQorICAgIHsKKyAgICAgICAgdmFy IGxvd2VyQ2FzZU5hbWUgPSB0aGlzLmxvY2FsTmFtZSgpIHx8IG5vZGUubm9kZU5hbWUoKS50b0xv d2VyQ2FzZSgpOworCisgICAgICAgIHZhciBpZCA9IHRoaXMuZ2V0QXR0cmlidXRlKCJpZCIpOwor ICAgICAgICBpZiAoaWQpIHsKKyAgICAgICAgICAgIHZhciBzZWxlY3RvciA9ICIjIiArIGlkOwor ICAgICAgICAgICAgcmV0dXJuIChqdXN0U2VsZWN0b3IgPyBzZWxlY3RvciA6IGxvd2VyQ2FzZU5h bWUgKyBzZWxlY3Rvcik7CisgICAgICAgIH0KKworICAgICAgICB2YXIgY2xhc3NOYW1lID0gdGhp cy5nZXRBdHRyaWJ1dGUoImNsYXNzIik7CisgICAgICAgIGlmIChjbGFzc05hbWUpIHsKKyAgICAg ICAgICAgIHZhciBzZWxlY3RvciA9ICIuIiArIGNsYXNzTmFtZS5yZXBsYWNlKC9ccysvLCAiLiIp OworICAgICAgICAgICAgcmV0dXJuIChqdXN0U2VsZWN0b3IgPyBzZWxlY3RvciA6IGxvd2VyQ2Fz ZU5hbWUgKyBzZWxlY3Rvcik7CisgICAgICAgIH0KKworICAgICAgICBpZiAobG93ZXJDYXNlTmFt ZSA9PT0gImlucHV0IiAmJiB0aGlzLmdldEF0dHJpYnV0ZSgidHlwZSIpKQorICAgICAgICAgICAg cmV0dXJuIGxvd2VyQ2FzZU5hbWUgKyAiW3R5cGU9XCIiICsgdGhpcy5nZXRBdHRyaWJ1dGUoInR5 cGUiKSArICJcIl0iOworCisgICAgICAgIHJldHVybiBsb3dlckNhc2VOYW1lOworICAgIH0sCisK ICAgICBfc2V0QXR0cmlidXRlc1BheWxvYWQ6IGZ1bmN0aW9uKGF0dHJzKQogICAgIHsKICAgICAg ICAgdGhpcy5fYXR0cmlidXRlcyA9IFtdOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9FdmVudExpc3RlbmVyc1NpZGViYXJQYW5lLmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FdmVudExpc3RlbmVyc1NpZGViYXJQYW5lLmpzCmlu ZGV4IDAwNTc2ZjEuLjJkY2U3ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRXZlbnRMaXN0ZW5lcnNTaWRlYmFyUGFuZS5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V2ZW50TGlzdGVuZXJzU2lkZWJhclBhbmUuanMKQEAg LTIxNCw3ICsyMTQsNyBAQCBXZWJJbnNwZWN0b3IuRXZlbnRMaXN0ZW5lckJhci5wcm90b3R5cGUg PSB7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAobm9kZS5pZCA9PT0gdGhpcy5fbm9kZUlkKSB7 Ci0gICAgICAgICAgICB0aGlzLnRpdGxlRWxlbWVudC50ZXh0Q29udGVudCA9IGFwcHJvcHJpYXRl U2VsZWN0b3JGb3JOb2RlKG5vZGUpOworICAgICAgICAgICAgdGhpcy50aXRsZUVsZW1lbnQudGV4 dENvbnRlbnQgPSBub2RlLmFwcHJvcHJpYXRlU2VsZWN0b3JGb3IoKTsKICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwppbmRleCA0YzgwNTc1Li40MDJiYzFiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGVi YXJQYW5lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVz U2lkZWJhclBhbmUuanMKQEAgLTUwMyw3ICs1MDMsNyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVzU2lk ZWJhclBhbmUucHJvdG90eXBlID0gewogCiAgICAgYWRkQmxhbmtTZWN0aW9uOiBmdW5jdGlvbigp CiAgICAgewotICAgICAgICB2YXIgYmxhbmtTZWN0aW9uID0gbmV3IFdlYkluc3BlY3Rvci5CbGFu a1N0eWxlUHJvcGVydGllc1NlY3Rpb24odGhpcywgYXBwcm9wcmlhdGVTZWxlY3RvckZvck5vZGUo dGhpcy5ub2RlLCB0cnVlKSk7CisgICAgICAgIHZhciBibGFua1NlY3Rpb24gPSBuZXcgV2ViSW5z cGVjdG9yLkJsYW5rU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbih0aGlzLCB0aGlzLm5vZGUgPyB0aGlz Lm5vZGUuYXBwcm9wcmlhdGVTZWxlY3RvckZvcih0cnVlKSA6ICIiKTsKICAgICAgICAgYmxhbmtT ZWN0aW9uLnBhbmUgPSB0aGlzOwogCiAgICAgICAgIHZhciBlbGVtZW50U3R5bGVTZWN0aW9uID0g dGhpcy5zZWN0aW9uc1swXVsxXTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC91dGlsaXRpZXMuanMKaW5kZXggZmJmZGZiYi4uNDg2MDc3MiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMKQEAgLTU5MiwzMSArNTky LDYgQEAgZnVuY3Rpb24gdHJhdmVyc2VQcmV2aW91c05vZGUoc3RheVdpdGhpbikKICAgICByZXR1 cm4gdGhpcy5wYXJlbnROb2RlOwogfQogCi1mdW5jdGlvbiBhcHByb3ByaWF0ZVNlbGVjdG9yRm9y Tm9kZShub2RlLCBqdXN0U2VsZWN0b3IpCi17Ci0gICAgaWYgKCFub2RlKQotICAgICAgICByZXR1 cm4gIiI7Ci0KLSAgICB2YXIgbG93ZXJDYXNlTmFtZSA9IG5vZGUubG9jYWxOYW1lIHx8IG5vZGUu bm9kZU5hbWUudG9Mb3dlckNhc2UoKTsKLQotICAgIHZhciBpZCA9IG5vZGUuZ2V0QXR0cmlidXRl KCJpZCIpOwotICAgIGlmIChpZCkgewotICAgICAgICB2YXIgc2VsZWN0b3IgPSAiIyIgKyBpZDsK LSAgICAgICAgcmV0dXJuIChqdXN0U2VsZWN0b3IgPyBzZWxlY3RvciA6IGxvd2VyQ2FzZU5hbWUg KyBzZWxlY3Rvcik7Ci0gICAgfQotCi0gICAgdmFyIGNsYXNzTmFtZSA9IG5vZGUuZ2V0QXR0cmli dXRlKCJjbGFzcyIpOwotICAgIGlmIChjbGFzc05hbWUpIHsKLSAgICAgICAgdmFyIHNlbGVjdG9y ID0gIi4iICsgY2xhc3NOYW1lLnJlcGxhY2UoL1xzKy8sICIuIik7Ci0gICAgICAgIHJldHVybiAo anVzdFNlbGVjdG9yID8gc2VsZWN0b3IgOiBsb3dlckNhc2VOYW1lICsgc2VsZWN0b3IpOwotICAg IH0KLQotICAgIGlmIChsb3dlckNhc2VOYW1lID09PSAiaW5wdXQiICYmIG5vZGUuZ2V0QXR0cmli dXRlKCJ0eXBlIikpCi0gICAgICAgIHJldHVybiBsb3dlckNhc2VOYW1lICsgIlt0eXBlPVwiIiAr IG5vZGUuZ2V0QXR0cmlidXRlKCJ0eXBlIikgKyAiXCJdIjsKLQotICAgIHJldHVybiBsb3dlckNh c2VOYW1lOwotfQotCiBmdW5jdGlvbiBnZXREb2N1bWVudEZvck5vZGUobm9kZSkKIHsKICAgICBy ZXR1cm4gbm9kZS5ub2RlVHlwZSA9PSBOb2RlLkRPQ1VNRU5UX05PREUgPyBub2RlIDogbm9kZS5v d25lckRvY3VtZW50Owo=