57631 2011-04-01 08:16:29 -0700 Web Inspector: search in resources panel is broken. 2011-04-04 07:18:02 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 377794 0 podivilov 2011-04-01 08:16:29 -0700 Web Inspector: search in resources panel is broken. Search in resources panel should trigger source frame content load. 377795 1 87858 podivilov 2011-04-01 08:17:22 -0700 Created attachment 87858 Patch. 378697 2 87858 yurys 2011-04-04 01:29:46 -0700 Comment on attachment 87858 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=87858&action=review > Source/WebCore/inspector/front-end/SourceFrame.js:99 > + _ensureContentLoaded: function() We should consider implementing search on the back-end to avoid pulling all content of all resources when search is being performed. 378770 3 87858 podivilov 2011-04-04 07:17:53 -0700 Comment on attachment 87858 Patch. Clearing flags on attachment: 87858 Committed r82830: <http://trac.webkit.org/changeset/82830> 378771 4 podivilov 2011-04-04 07:18:02 -0700 All reviewed patches have been landed. Closing bug. 87858 2011-04-01 08:17:22 -0700 2011-04-04 07:17:53 -0700 Patch. patch text/plain 5150 podivilov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZTcxM2VjLi43YjUzMTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMDQtMDEgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIElu c3BlY3Rvcjogc2VhcmNoIGluIHJlc291cmNlcyBwYW5lbCBpcyBicm9rZW4uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzYzMQorCisgICAgICAgIFNl YXJjaCBpbiByZXNvdXJjZXMgcGFuZWwgc2hvdWxkIHRyaWdnZXIgc291cmNlIGZyYW1lIGNvbnRl bnQgbG9hZC4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUGFuZWwuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuUGFuZWwucHJvdG90eXBlLmp1bXBUb05leHRTZWFyY2hSZXN1bHQp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBhbmVsLnByb3RvdHlwZS5qdW1wVG9QcmV2aW91c1Nl YXJjaFJlc3VsdCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5l bC5qczoKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NlYXJjaENvbnRyb2xsZXIuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2VhcmNoQ29udHJvbGxlci5wcm90b3R5cGUuaGFuZGxl U2hvcnRjdXQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNlYXJjaENvbnRyb2xsZXIucHJvdG90 eXBlLmZvY3VzU2VhcmNoRmllbGQpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU291 cmNlRnJhbWUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBl LnNob3cpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZS5fZW5z dXJlQ29udGVudExvYWRlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJv dG90eXBlLnBlcmZvcm1TZWFyY2gpOgorCiAyMDExLTAzLTMwICBQYXZlbCBQb2Rpdmlsb3YgIDxw b2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRt YW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BhbmVs LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9QYW5lbC5qcwppbmRleCAx Yjk5ZGQ0Li43NDI3ZmJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UGFuZWwuanMKQEAgLTIzNSw3ICsyMzUsNyBAQCBXZWJJbnNwZWN0b3IuUGFuZWwucHJvdG90eXBl ID0gewogCiAgICAgICAgIGlmIChjdXJyZW50VmlldyAhPT0gdGhpcy52aXNpYmxlVmlldykgewog ICAgICAgICAgICAgdGhpcy5zaG93VmlldyhjdXJyZW50Vmlldyk7Ci0gICAgICAgICAgICBXZWJJ bnNwZWN0b3IuZm9jdXNTZWFyY2hGaWVsZCgpOworICAgICAgICAgICAgV2ViSW5zcGVjdG9yLnNl YXJjaENvbnRyb2xsZXIuZm9jdXNTZWFyY2hGaWVsZCgpOwogICAgICAgICB9CiAKICAgICAgICAg aWYgKHNob3dGaXJzdFJlc3VsdCkKQEAgLTI2OCw3ICsyNjgsNyBAQCBXZWJJbnNwZWN0b3IuUGFu ZWwucHJvdG90eXBlID0gewogCiAgICAgICAgIGlmIChjdXJyZW50VmlldyAhPT0gdGhpcy52aXNp YmxlVmlldykgewogICAgICAgICAgICAgdGhpcy5zaG93VmlldyhjdXJyZW50Vmlldyk7Ci0gICAg ICAgICAgICBXZWJJbnNwZWN0b3IuZm9jdXNTZWFyY2hGaWVsZCgpOworICAgICAgICAgICAgV2Vi SW5zcGVjdG9yLnNlYXJjaENvbnRyb2xsZXIuZm9jdXNTZWFyY2hGaWVsZCgpOwogICAgICAgICB9 CiAKICAgICAgICAgaWYgKHNob3dMYXN0UmVzdWx0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKaW5kZXggYzY1ZTZiNy4uOTNj MzM2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNv dXJjZXNQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jl c291cmNlc1BhbmVsLmpzCkBAIC02OTUsNyArNjk1LDcgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNl c1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIHZpZXdzID0gW107CiAKICAgICAgICAg Y29uc3QgdmlzaWJsZVZpZXcgPSB0aGlzLnZpc2libGVWaWV3OwotICAgICAgICBpZiAodmlzaWJs ZVZpZXcucGVyZm9ybVNlYXJjaCkKKyAgICAgICAgaWYgKHZpc2libGVWaWV3ICYmIHZpc2libGVW aWV3LnBlcmZvcm1TZWFyY2gpCiAgICAgICAgICAgICB2aWV3cy5wdXNoKHZpc2libGVWaWV3KTsK IAogICAgICAgICBmdW5jdGlvbiBjYWxsYmFjayhyZXNvdXJjZVRyZWVFbGVtZW50KQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZWFyY2hDb250cm9sbGVy LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZWFyY2hDb250cm9sbGVy LmpzCmluZGV4IDczNWM0MjQuLmQwZjljYjQgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvU2VhcmNoQ29udHJvbGxlci5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NlYXJjaENvbnRyb2xsZXIuanMKQEAgLTg0LDcgKzg0LDcg QEAgV2ViSW5zcGVjdG9yLlNlYXJjaENvbnRyb2xsZXIucHJvdG90eXBlID0gewogICAgICAgICAg ICAgICAgICAgICB2YXIgaXNGaW5kS2V5ID0gZXZlbnQuY3RybEtleSAmJiAhZXZlbnQubWV0YUtl eSAmJiAhZXZlbnQuYWx0S2V5ICYmICFldmVudC5zaGlmdEtleTsKIAogICAgICAgICAgICAgICAg IGlmIChpc0ZpbmRLZXkpIHsKLSAgICAgICAgICAgICAgICAgICAgdGhpcy5fZm9jdXNTZWFyY2hG aWVsZCgpOworICAgICAgICAgICAgICAgICAgICB0aGlzLmZvY3VzU2VhcmNoRmllbGQoKTsKICAg ICAgICAgICAgICAgICAgICAgZXZlbnQuaGFuZGxlZCA9IHRydWU7CiAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgICAgIGJyZWFrOwpAQCAtOTIsNyArOTIsNyBAQCBXZWJJbnNwZWN0b3Iu U2VhcmNoQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgICAgIGNhc2UgIkYzIjoK ICAgICAgICAgICAgICAgICBpZiAoIWlzTWFjKSB7Ci0gICAgICAgICAgICAgICAgICAgIHRoaXMu X2ZvY3VzU2VhcmNoRmllbGQoKTsKKyAgICAgICAgICAgICAgICAgICAgdGhpcy5mb2N1c1NlYXJj aEZpZWxkKCk7CiAgICAgICAgICAgICAgICAgICAgIGV2ZW50LmhhbmRsZWQgPSB0cnVlOwogICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBicmVhazsKQEAgLTE1Nyw3ICsxNTcsNyBA QCBXZWJJbnNwZWN0b3IuU2VhcmNoQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIFdl Ykluc3BlY3Rvci50b29sYmFyLnJlc2l6ZSgpOwogICAgIH0sCiAKLSAgICBfZm9jdXNTZWFyY2hG aWVsZDogZnVuY3Rpb24oKQorICAgIGZvY3VzU2VhcmNoRmllbGQ6IGZ1bmN0aW9uKCkKICAgICB7 CiAgICAgICAgIHRoaXMuZWxlbWVudC5mb2N1cygpOwogICAgICAgICB0aGlzLmVsZW1lbnQuc2Vs ZWN0KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Nv dXJjZUZyYW1lLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VG cmFtZS5qcwppbmRleCAzZjkzYzgxLi5hOTgwNmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMKQEAgLTYxLDEwICs2MSw3IEBAIFdl Ykluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBXZWJJ bnNwZWN0b3IuVmlldy5wcm90b3R5cGUuc2hvdy5jYWxsKHRoaXMsIHBhcmVudEVsZW1lbnQpOwog Ci0gICAgICAgIGlmICghdGhpcy5fY29udGVudFJlcXVlc3RlZCkgewotICAgICAgICAgICAgdGhp cy5fY29udGVudFJlcXVlc3RlZCA9IHRydWU7Ci0gICAgICAgICAgICB0aGlzLl9kZWxlZ2F0ZS5y ZXF1ZXN0Q29udGVudCh0aGlzLl9jcmVhdGVUZXh0Vmlld2VyLmJpbmQodGhpcykpOwotICAgICAg ICB9CisgICAgICAgIHRoaXMuX2Vuc3VyZUNvbnRlbnRMb2FkZWQoKTsKIAogICAgICAgICBpZiAo dGhpcy5fdGV4dFZpZXdlcikgewogICAgICAgICAgICAgaWYgKHRoaXMuX3Njcm9sbFRvcCkKQEAg LTk5LDYgKzk2LDE0IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7CiAg ICAgICAgIHJldHVybiB0cnVlOwogICAgIH0sCiAKKyAgICBfZW5zdXJlQ29udGVudExvYWRlZDog ZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgaWYgKCF0aGlzLl9jb250ZW50UmVxdWVzdGVkKSB7 CisgICAgICAgICAgICB0aGlzLl9jb250ZW50UmVxdWVzdGVkID0gdHJ1ZTsKKyAgICAgICAgICAg IHRoaXMuX2RlbGVnYXRlLnJlcXVlc3RDb250ZW50KHRoaXMuX2NyZWF0ZVRleHRWaWV3ZXIuYmlu ZCh0aGlzKSk7CisgICAgICAgIH0KKyAgICB9LAorCiAgICAgbWFya0RpZmY6IGZ1bmN0aW9uKGRp ZmZEYXRhKQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX2RpZmZMaW5lcyAmJiB0aGlzLl90ZXh0 Vmlld2VyKQpAQCAtMzI0LDYgKzMyOSw3IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90 b3R5cGUgPSB7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHRoaXMuX2RlbGF5ZWRGaW5kU2Vh cmNoTWF0Y2hlcyA9IGRvRmluZFNlYXJjaE1hdGNoZXMuYmluZCh0aGlzLCBxdWVyeSk7CiAKKyAg ICAgICAgdGhpcy5fZW5zdXJlQ29udGVudExvYWRlZCgpOwogICAgIH0sCiAKICAgICBzZWFyY2hD YW5jZWxlZDogZnVuY3Rpb24oKQo=