57628 2011-04-01 06:43:37 -0700 Web Inspector: event should have "data" attribute, not "body" 2011-04-01 07:11:08 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 377760 0 pfeldman 2011-04-01 06:43:37 -0700 Patch to follow. 377763 1 87852 pfeldman 2011-04-01 06:49:39 -0700 Created attachment 87852 Patch 377767 2 87852 yurys 2011-04-01 06:54:04 -0700 Comment on attachment 87852 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87852&action=review > Source/WebCore/inspector/CodeGeneratorInspector.pm:861 > + for (var key in messageObject.body) This code is quite fragile since we rely on the keys order in the message but probably that's fine while the messages are formed also by our code. 377777 3 pfeldman 2011-04-01 07:11:08 -0700 M LayoutTests/ChangeLog M LayoutTests/inspector/protocol/console-agent-expected.txt M Source/WebCore/ChangeLog M Source/WebCore/inspector/CodeGeneratorInspector.pm Committed r82680 87852 2011-04-01 06:49:39 -0700 2011-04-01 06:54:03 -0700 Patch bug-57628-20110401174937.patch text/plain 5018 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogODI2NTkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzOTE3NjI1ZWY5NGMzZTY4ZjIxZGJh NmE1Mzg4NTE4NmQ1ZmViZGQ3Li4xNjEzMGE4Y2NkOTNhZWU1NGY4ODNjN2ZjYjhkODYzNzk3ZTY5 NDM1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMDEgIFBhdmVsIEZlbGRtYW4gIDxw ZmVsZG1hbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGV2ZW50IHNob3VsZCBoYXZlICJkYXRhIiBhdHRy aWJ1dGUsIG5vdCAiYm9keSIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU3NjI4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvcHJvdG9jb2wvY29uc29sZS1h Z2VudC1leHBlY3RlZC50eHQ6CisKIDIwMTEtMDMtMzEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZWJhc2VsaW5lIG15IG93biB0ZXN0IG9uIExpbnV4ISAgVGhl IGdyZWF0IEphdmFTY3JpcHQgTUlNRSB0eXBlIHdhcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL3Byb3RvY29sL2NvbnNvbGUtYWdlbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL3Byb3RvY29sL2NvbnNvbGUtYWdlbnQtZXhwZWN0ZWQudHh0CmluZGV4IDFm YjgzZjJjMDFlNWYxNjY0OWNiZGE3MmMzY2E0NzU5MDM1YjA2ZmIuLjMzMjVmZjBkNWRjZDgzY2Fi MDkxZWZkMWE4NjM5ZGYwNjZkM2M3ZTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rv ci9wcm90b2NvbC9jb25zb2xlLWFnZW50LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvcHJvdG9jb2wvY29uc29sZS1hZ2VudC1leHBlY3RlZC50eHQKQEAgLTU5LDcgKzU5 LDcgQEAgZXZlbnQgQ29uc29sZUFnZW50LmNvbnNvbGVNZXNzYWdlCiAgICAgdHlwZSA6ICJldmVu dCIKICAgICBkb21haW4gOiAiQ29uc29sZSIKICAgICBldmVudCA6ICJjb25zb2xlTWVzc2FnZSIK LSAgICBib2R5IDogeworICAgIGRhdGEgOiB7CiAgICAgICAgIG1lc3NhZ2VPYmogOiB7CiAgICAg ICAgICAgICBzb3VyY2UgOiAzCiAgICAgICAgICAgICB0eXBlIDogMApAQCAtODQsNyArODQsNyBA QCBldmVudCBDb25zb2xlQWdlbnQuY29uc29sZU1lc3NhZ2VSZXBlYXRDb3VudFVwZGF0ZWQKICAg ICB0eXBlIDogImV2ZW50IgogICAgIGRvbWFpbiA6ICJDb25zb2xlIgogICAgIGV2ZW50IDogImNv bnNvbGVNZXNzYWdlUmVwZWF0Q291bnRVcGRhdGVkIgotICAgIGJvZHkgOiB7CisgICAgZGF0YSA6 IHsKICAgICAgICAgY291bnQgOiAyCiAgICAgfQogfQpAQCAtMTE3LDcgKzExNyw3IEBAIGV2ZW50 IENvbnNvbGVBZ2VudC5jb25zb2xlTWVzc2FnZXNDbGVhcmVkCiAgICAgdHlwZSA6ICJldmVudCIK ICAgICBkb21haW4gOiAiQ29uc29sZSIKICAgICBldmVudCA6ICJjb25zb2xlTWVzc2FnZXNDbGVh cmVkIgotICAgIGJvZHkgOiB7CisgICAgZGF0YSA6IHsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBmMzczZWRlODNiMzgyNTdiZjE1ZmM2OTY5OGZmM2Y1MTZiN2JkOGUwLi5lNzU1OWRmZGJlZTNm ZTIzZTFlMThjMjUyNjZlYWNmOGVkYjFjZDVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDQtMDEgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IGV2ZW50IHNob3VsZCBoYXZlICJkYXRhIiBhdHRyaWJ1dGUsIG5vdCAiYm9keSIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NjI4CisKKyAgICAgICAg KiBpbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbToKKwogMjAxMS0wMy0zMSAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjgyNjUyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucG0gYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbQppbmRleCBlYTY1ZjJlMWUwNzA2MzQ5N2MxNzAw ZGY1NmFlN2QxZDkzMWViZDIzLi5kMjEzODViNWVjNGQ2MzlhZWY2MTUyYTE2NjY2Y2ExZTYxNGY4 ODEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvcklu c3BlY3Rvci5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvcklu c3BlY3Rvci5wbQpAQCAtMzg5LDEwICszODksMTAgQEAgc3ViIGdlbmVyYXRlRnJvbnRlbmRGdW5j dGlvbgogICAgIHB1c2goQGZ1bmN0aW9uLCAiICAgICR7ZnVuY3Rpb25OYW1lfU1lc3NhZ2UtPnNl dFN0cmluZyhcInR5cGVcIiwgXCJldmVudFwiKTsiKTsKICAgICBwdXNoKEBmdW5jdGlvbiwgIiAg ICAke2Z1bmN0aW9uTmFtZX1NZXNzYWdlLT5zZXRTdHJpbmcoXCJkb21haW5cIiwgXCIkZG9tYWlu XCIpOyIpOwogICAgIHB1c2goQGZ1bmN0aW9uLCAiICAgICR7ZnVuY3Rpb25OYW1lfU1lc3NhZ2Ut PnNldFN0cmluZyhcImV2ZW50XCIsIFwiJGZ1bmN0aW9uTmFtZVwiKTsiKTsKLSAgICBwdXNoKEBm dW5jdGlvbiwgIiAgICBSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBib2R5T2JqZWN0ID0gSW5zcGVj dG9yT2JqZWN0OjpjcmVhdGUoKTsiKTsKLSAgICBteSBAcHVzaEFyZ3VtZW50cyA9IG1hcCgiICAg IGJvZHlPYmplY3QtPnNldCIgLiB0eXBlVHJhaXRzKCRfLT50eXBlLCAiSlNPTlR5cGUiKSAuICIo XCIiIC4gJF8tPm5hbWUgLiAiXCIsICIgLiAkXy0+bmFtZSAuICIpOyIsIEBhcmdzRmlsdGVyZWQp OworICAgIHB1c2goQGZ1bmN0aW9uLCAiICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGRhdGFP YmplY3QgPSBJbnNwZWN0b3JPYmplY3Q6OmNyZWF0ZSgpOyIpOworICAgIG15IEBwdXNoQXJndW1l bnRzID0gbWFwKCIgICAgZGF0YU9iamVjdC0+c2V0IiAuIHR5cGVUcmFpdHMoJF8tPnR5cGUsICJK U09OVHlwZSIpIC4gIihcIiIgLiAkXy0+bmFtZSAuICJcIiwgIiAuICRfLT5uYW1lIC4gIik7Iiwg QGFyZ3NGaWx0ZXJlZCk7CiAgICAgcHVzaChAZnVuY3Rpb24sIEBwdXNoQXJndW1lbnRzKTsKLSAg ICBwdXNoKEBmdW5jdGlvbiwgIiAgICAke2Z1bmN0aW9uTmFtZX1NZXNzYWdlLT5zZXRPYmplY3Qo XCJib2R5XCIsIGJvZHlPYmplY3QpOyIpOworICAgIHB1c2goQGZ1bmN0aW9uLCAiICAgICR7ZnVu Y3Rpb25OYW1lfU1lc3NhZ2UtPnNldE9iamVjdChcImRhdGFcIiwgZGF0YU9iamVjdCk7Iik7CiAg ICAgcHVzaChAZnVuY3Rpb24sICIgICAgbV9pbnNwZWN0b3JDbGllbnQtPnNlbmRNZXNzYWdlVG9G cm9udGVuZCgke2Z1bmN0aW9uTmFtZX1NZXNzYWdlLT50b0pTT05TdHJpbmcoKSk7Iik7CiAgICAg cHVzaChAZnVuY3Rpb24sICJ9Iik7CiAgICAgcHVzaChAZnVuY3Rpb24sICIiKTsKQEAgLTg1Miwx NSArODUyLDE2IEBAIEluc3BlY3RvckJhY2tlbmRTdHViLnByb3RvdHlwZSA9IHsKIAogICAgICAg ICB2YXIgbWVzc2FnZU9iamVjdCA9ICh0eXBlb2YgbWVzc2FnZSA9PT0gInN0cmluZyIpID8gSlNP Ti5wYXJzZShtZXNzYWdlKSA6IG1lc3NhZ2U7CiAKLSAgICAgICAgdmFyIGFyZ3VtZW50cyA9IFtd OwotICAgICAgICBpZiAobWVzc2FnZU9iamVjdC5ib2R5KQotICAgICAgICAgICAgZm9yICh2YXIg a2V5IGluIG1lc3NhZ2VPYmplY3QuYm9keSkKLSAgICAgICAgICAgICAgICBhcmd1bWVudHMucHVz aChtZXNzYWdlT2JqZWN0LmJvZHlba2V5XSk7Ci0KICAgICAgICAgaWYgKCJyZXF1ZXN0SWQiIGlu IG1lc3NhZ2VPYmplY3QpIHsgLy8ganVzdCBhIHJlc3BvbnNlIGZvciBzb21lIHJlcXVlc3QKICAg ICAgICAgICAgIGlmIChtZXNzYWdlT2JqZWN0LnByb3RvY29sRXJyb3JzKQogICAgICAgICAgICAg ICAgIHRoaXMucmVwb3J0UHJvdG9jb2xFcnJvcihtZXNzYWdlT2JqZWN0KTsKIAorICAgICAgICAg ICAgdmFyIGFyZ3VtZW50cyA9IFtdOworICAgICAgICAgICAgaWYgKG1lc3NhZ2VPYmplY3QuYm9k eSkgeworICAgICAgICAgICAgICAgIGZvciAodmFyIGtleSBpbiBtZXNzYWdlT2JqZWN0LmJvZHkp CisgICAgICAgICAgICAgICAgICAgIGFyZ3VtZW50cy5wdXNoKG1lc3NhZ2VPYmplY3QuYm9keVtr ZXldKTsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgdmFyIGNhbGxiYWNrID0gdGhpcy5f Y2FsbGJhY2tzW21lc3NhZ2VPYmplY3QucmVxdWVzdElkXTsKICAgICAgICAgICAgIGlmIChjYWxs YmFjaykgewogICAgICAgICAgICAgICAgIGlmICghbWVzc2FnZU9iamVjdC5wcm90b2NvbEVycm9y cykgewpAQCAtODg4LDYgKzg4OSwxMiBAQCBJbnNwZWN0b3JCYWNrZW5kU3R1Yi5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogCisgICAgICAgICAg ICB2YXIgYXJndW1lbnRzID0gW107CisgICAgICAgICAgICBpZiAobWVzc2FnZU9iamVjdC5kYXRh KSB7CisgICAgICAgICAgICAgICAgZm9yICh2YXIga2V5IGluIG1lc3NhZ2VPYmplY3QuZGF0YSkK KyAgICAgICAgICAgICAgICAgICAgYXJndW1lbnRzLnB1c2gobWVzc2FnZU9iamVjdC5kYXRhW2tl eV0pOworICAgICAgICAgICAgfQorCiAgICAgICAgICAgICBkaXNwYXRjaGVyW21lc3NhZ2VPYmpl Y3QuZXZlbnRdLmFwcGx5KGRpc3BhdGNoZXIsIGFyZ3VtZW50cyk7CiAgICAgICAgIH0KICAgICB9 LAo=