57614 2011-04-01 04:49:13 -0700 ARIA Grid tables should return GridRole in roleValue() method 2011-04-14 07:17:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 REOPENED P2 Normal --- 57643 1 mario mario abarth cfleizach eric webkit.review.bot oldest_to_newest 377712 0 mario 2011-04-01 04:49:13 -0700 ARIA Grid tables should return GridRole in roleValue() method 377713 1 87840 mario 2011-04-01 04:53:43 -0700 Created attachment 87840 Patch 377715 2 mario 2011-04-01 04:54:44 -0700 Added Chris to CC 377826 3 87840 cfleizach 2011-04-01 08:58:28 -0700 Comment on attachment 87840 Patch r=me 377847 4 mario 2011-04-01 09:16:16 -0700 Committed r82687: <http://trac.webkit.org/changeset/82687> 377900 5 webkit.review.bot 2011-04-01 10:29:17 -0700 http://trac.webkit.org/changeset/82687 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: platform/mac/accessibility/aria-treegrid.html 377912 6 mario 2011-04-01 10:41:51 -0700 Reopening, as current patch broke one test in the Mac bots: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r82689%20(27607)/platform/mac/accessibility ...seems like something else in the Mac code needs changing. Ideas? 377917 7 cfleizach 2011-04-01 10:55:51 -0700 i don't know. i'll have to apply the patch and figure out 385745 8 87840 mario 2011-04-14 07:17:14 -0700 Comment on attachment 87840 Patch Clearing flags. Not proposing anything yet since I found out that some more changes would be needed in the GTK port in order to keep working as expected (like checking GridRole's in places where only TableRole is checked at the moment), hence a Layout Test would also be needed so we can automate the detection for this kind of regressions. 87840 2011-04-01 04:53:43 -0700 2011-04-14 07:17:14 -0700 Patch bug-57614-20110401135300.patch text/plain 4171 mario U3VidmVyc2lvbiBSZXZpc2lvbjogODI2NjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMzczZWRlODNiMzgyNTdi ZjE1ZmM2OTY5OGZmM2Y1MTZiN2JkOGUwLi5kOGY4ZjA3NjkzY2I0ZDllZmIwNDcxZGQ0NTk1MTg2 Y2EzNWMzNjllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDQtMDEgIE1hcmlv IFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFSSUEgR3JpZCB0YWJsZXMgc2hvdWxkIHJl dHVybiBHcmlkUm9sZSBpbiByb2xlVmFsdWUoKSBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NjE0CisKKyAgICAgICAgVGhpcyBjaGFuZ2Ug ZG9lcyBub3QgbmVlZCBhbnkgdGVzdCBzaW5jZSBpdCBkb2Vzbid0IGNoYW5nZSBhbnl0aGluZwor ICAgICAgICBmcm9tIHRoZSBwb2ludCBvZiB2aWV3IG9mIHRoZSBjb25zdW1lcnMgKEFzc2lzdGl2 ZSBUZWNobm9nbG9naWVzKS4KKyAgICAgICAgSXQncyBqdXN0IGFuIGludGVybmFsIGNoYW5nZSB0 byBzaW1wbGlmeSBpZGVudGlmeWluZyBIVE1MIGFuZCBBUklBCisgICAgICAgIHRhYmxlcyBieSBj YWxsaW5nIHRvIHRoZSBBY2Nlc3NpYmlsaXR5T2JqZWN0Ojpyb2xlVmFsdWUgbWV0aG9kLgorCisg ICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5QVJJQUdyaWQuaDoKKyAgICAgICAg KiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlBUklBR3JpZC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpBY2Nlc3NpYmlsaXR5QVJJQUdyaWQ6OnJvbGVWYWx1ZSk6IFJldHVybiBHcmlkUm9sZS4K KworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy QXRrLmNwcDoKKyAgICAgICAgKGF0a1JvbGUpOiBSZW1vdmVkIHVubmVlZGVkIGNvbW1lbnQuCisK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L21hYy9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlci5t bTogTWFwIEdyaWRSb2xlIHRvCisgICAgICAgIE5TQWNjZXNzaWJpbGl0eVRhYmxlUm9sZSwgdG8g a2VlcCB0aGUgc2FtZSBiZWhhdmlvdXIuCisKIDIwMTEtMDMtMzEgIFNoZXJpZmYgQm90ICA8d2Vi a2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHI4MjY1Mi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eUFSSUFHcmlkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eUFSSUFHcmlkLmNwcAppbmRleCBkNTE3NTBhY2NiM2Y0ZjlkN2I2NzA3YmQxMDQz MWE3N2NmYjY4ZWUwLi44NDIzZjVmNzM5OGJhMTMyYzJlNzQ4ZDhmNzU1MGNhODg4OTllOThjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlBUklB R3JpZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 QVJJQUdyaWQuY3BwCkBAIC0xNzIsNSArMTcyLDEzIEBAIEFjY2Vzc2liaWxpdHlUYWJsZUNlbGwq IEFjY2Vzc2liaWxpdHlBUklBR3JpZDo6Y2VsbEZvckNvbHVtbkFuZFJvdyh1bnNpZ25lZCBjb2x1 CiAKICAgICByZXR1cm4gMDsKIH0KLSAgICAKKworQWNjZXNzaWJpbGl0eVJvbGUgQWNjZXNzaWJp bGl0eUFSSUFHcmlkOjpyb2xlVmFsdWUoKSBjb25zdAoreworICAgIGlmICghaXNBY2Nlc3NpYmls aXR5VGFibGUoKSkKKyAgICAgICAgcmV0dXJuIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnJv bGVWYWx1ZSgpOworCisgICAgcmV0dXJuIEdyaWRSb2xlOworfQorCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlBUklBR3JpZC5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5QVJJQUdyaWQuaAppbmRleCAwMmZmNGQwZTQwNGE5OTEwOTQ0ODI5ZjFjYWZhOWQyZGVjOGJj NWIzLi5iMWYyNzk4ZTJiNDZlMWY5OTNlODc2N2FmZDFlZGI2M2RjNDQwYWEzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlBUklBR3JpZC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUFSSUFHcmlkLmgK QEAgLTQ0LDcgKzQ0LDggQEAgcHJpdmF0ZToKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0 cjxBY2Nlc3NpYmlsaXR5QVJJQUdyaWQ+IGNyZWF0ZShSZW5kZXJPYmplY3QqKTsKICAgICB2aXJ0 dWFsIH5BY2Nlc3NpYmlsaXR5QVJJQUdyaWQoKTsKLSAgICAKKworICAgIHZpcnR1YWwgQWNjZXNz aWJpbGl0eVJvbGUgcm9sZVZhbHVlKCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlzQXJpYVRh YmxlKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfSAgICAKICAgICAKICAgICB2aXJ0dWFsIHZvaWQg YWRkQ2hpbGRyZW4oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv Z3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcAppbmRleCBh NTU4ZTIyODkwOTU3MDE3ZjNiZTk1ZDdjMDQxYWRkNjFiZDc2ODc4Li40NzZjZjU5ODI4YTIxMGVj NmQ2OTU4OTBkMGQ0NDgzNWI1NmYwNzBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJB dGsuY3BwCkBAIC00NDcsNyArNDQ3LDcgQEAgc3RhdGljIEF0a1JvbGUgYXRrUm9sZShBY2Nlc3Np YmlsaXR5Um9sZSByb2xlKQogICAgICAgICByZXR1cm4gQVRLX1JPTEVfU0NST0xMX0JBUjsKICAg ICBjYXNlIFNjcm9sbEFyZWFSb2xlOgogICAgICAgICByZXR1cm4gQVRLX1JPTEVfU0NST0xMX1BB TkU7Ci0gICAgY2FzZSBHcmlkUm9sZTogLy8gSXMgdGhpcyByaWdodD8KKyAgICBjYXNlIEdyaWRS b2xlOgogICAgIGNhc2UgVGFibGVSb2xlOgogICAgICAgICByZXR1cm4gQVRLX1JPTEVfVEFCTEU7 CiAgICAgY2FzZSBBcHBsaWNhdGlvblJvbGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L21hYy9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlci5tbSBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tCmlu ZGV4IGMwZGQ3OTU1OTY1YjQ1MjljMzdjNDFiYjU4M2EyNTdkZDYzMDU1OGUuLmRjY2ZiMDY2NmYz MmRkOGM3NWYxODY4YmY4ODY2YWU2NzAyOTMzYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy Lm1tCkBAIC0xMjQzLDcgKzEyNDMsNyBAQCBzdGF0aWMgY29uc3QgQWNjZXNzaWJpbGl0eVJvbGVN YXAmIGNyZWF0ZUFjY2Vzc2liaWxpdHlSb2xlTWFwKCkKICAgICAgICAgeyBMaW5rUm9sZSwgTlNB Y2Nlc3NpYmlsaXR5TGlua1JvbGUgfSwKICNpZm5kZWYgQlVJTERJTkdfT05fVElHRVIgICAgICAg IAogICAgICAgICB7IERpc2Nsb3N1cmVUcmlhbmdsZVJvbGUsIE5TQWNjZXNzaWJpbGl0eURpc2Ns b3N1cmVUcmlhbmdsZVJvbGUgfSwKLSAgICAgICAgeyBHcmlkUm9sZSwgTlNBY2Nlc3NpYmlsaXR5 R3JpZFJvbGUgfSwKKyAgICAgICAgeyBHcmlkUm9sZSwgTlNBY2Nlc3NpYmlsaXR5VGFibGVSb2xl IH0sCiAjZW5kaWYKICAgICAgICAgeyBXZWJDb3JlTGlua1JvbGUsIE5TQWNjZXNzaWJpbGl0eUxp bmtSb2xlIH0sIAogICAgICAgICB7IEltYWdlTWFwTGlua1JvbGUsIE5TQWNjZXNzaWJpbGl0eUxp bmtSb2xlIH0sCg==