57608 2011-03-31 22:33:42 -0700 Implement CSSPropertyDirection in CSSStyleApplyProperty 2011-04-05 08:36:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 46592 0 macpherson webkit-unassigned commit-queue eric macpherson oldest_to_newest 377647 0 macpherson 2011-03-31 22:33:42 -0700 Implement CSSPropertyDirection in CSSStyleApplyProperty 377648 1 87826 macpherson 2011-03-31 22:39:05 -0700 Created attachment 87826 Patch 378635 2 87826 eric 2011-04-03 21:37:47 -0700 Comment on attachment 87826 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87826&action=review Otherwise looks OK. > Source/WebCore/css/CSSStyleApplyProperty.cpp:145 > + ApplyPropertyDirection(TextDirection (RenderStyle::*getter)() const, void (RenderStyle::*setter)(TextDirection), TextDirection (*initial)()) > + : ApplyPropertyDefault<TextDirection>(getter, setter, initial) > + { > + } This isn't needed, or? 378659 3 macpherson 2011-04-03 22:38:41 -0700 From IRC: mikelawther: yeah - you can only automatically call a default constructor mikelawther: ie one with no args mikelawther: or one where all the args have default values mikelawther: which is not the case here - so you have to call it explicitly 379559 4 87826 dglazkov 2011-04-05 07:48:47 -0700 Comment on attachment 87826 Patch ok. 379586 5 commit-queue 2011-04-05 08:33:39 -0700 The commit-queue encountered the following flaky tests while processing attachment 87826: http/tests/security/xssAuditor/post-from-iframe.html bug 57852 (author: dbates@webkit.org) The commit-queue is continuing to process your patch. 379590 6 87826 commit-queue 2011-04-05 08:36:35 -0700 Comment on attachment 87826 Patch Clearing flags on attachment: 87826 Committed r82942: <http://trac.webkit.org/changeset/82942> 379591 7 commit-queue 2011-04-05 08:36:39 -0700 All reviewed patches have been landed. Closing bug. 87826 2011-03-31 22:39:05 -0700 2011-04-05 08:36:35 -0700 Patch bug-57608-20110401163902.patch text/plain 4882 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyNjYwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDMtMzEgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgQ1NTUHJvcGVydHlEaXJlY3Rp b24gaW4gQ1NTU3R5bGVBcHBseVByb3BlcnR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01NzYwOAorCisgICAgICAgIE5vIG5ldyB0ZXN0cyByZXF1aXJl ZCBhcyBubyBuZXcgZnVuY3Rpb25hbGl0eSBpbnRyb2R1Y2VkLgorCisgICAgICAgICogY3NzL0NT U1N0eWxlQXBwbHlQcm9wZXJ0eS5jcHA6CisgICAgICAgIEFkZCBpbXBsZW1lbnRhdGlvbiBjbGFz cyBmb3IgQ1NTUHJvcGVydHlEaXJlY3Rpb24KKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rv ci5jcHA6CisgICAgICAgIFJlbW92ZSBleGlzdGluZyBpbXBsZW1lbnRhdGlvbiBmb3IgQ1NTUHJv cGVydHlEaXJlY3Rpb24KKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5oOgorICAgICAg ICBBZGQgZ2V0dGVyIGZvciBlbGVtZW50CisKIDIwMTEtMDMtMzEgIFNoZXJpZmYgQm90ICA8d2Vi a2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHI4MjY1Mi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZUFwcGx5UHJvcGVy dHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZUFwcGx5UHJv cGVydHkuY3BwCShyZXZpc2lvbiA4MjY1NCkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHls ZUFwcGx5UHJvcGVydHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw2ICsyNyw4IEBACiAKICNp bmNsdWRlICJDU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgiCiAjaW5jbHVkZSAiQ1NTU3R5bGVT ZWxlY3Rvci5oIgorI2luY2x1ZGUgIkRvY3VtZW50LmgiCisjaW5jbHVkZSAiRWxlbWVudC5oIgog I2luY2x1ZGUgIlJlbmRlclN0eWxlLmgiCiAjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgog I2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5oPgpAQCAtMTM0LDYgKzEzNiwyMyBAQCBwcm90ZWN0 ZWQ6CiAgICAgQ29sb3IgKCptX2luaXRpYWxWYWx1ZSkoKTsKIH07CiAKKy8vIENTU1Byb3BlcnR5 RGlyZWN0aW9uCitjbGFzcyBBcHBseVByb3BlcnR5RGlyZWN0aW9uIDogcHVibGljIEFwcGx5UHJv cGVydHlEZWZhdWx0PFRleHREaXJlY3Rpb24+IHsKK3B1YmxpYzoKKyAgICBBcHBseVByb3BlcnR5 RGlyZWN0aW9uKFRleHREaXJlY3Rpb24gKFJlbmRlclN0eWxlOjoqZ2V0dGVyKSgpIGNvbnN0LCB2 b2lkIChSZW5kZXJTdHlsZTo6KnNldHRlcikoVGV4dERpcmVjdGlvbiksIFRleHREaXJlY3Rpb24g KCppbml0aWFsKSgpKQorICAgICAgICA6IEFwcGx5UHJvcGVydHlEZWZhdWx0PFRleHREaXJlY3Rp b24+KGdldHRlciwgc2V0dGVyLCBpbml0aWFsKQorICAgIHsKKyAgICB9CisKKyAgICB2aXJ0dWFs IHZvaWQgdmFsdWUoQ1NTU3R5bGVTZWxlY3Rvciogc2VsZWN0b3IsIENTU1ZhbHVlKiB2YWx1ZSkg Y29uc3QKKyAgICB7CisgICAgICAgIEFwcGx5UHJvcGVydHlEZWZhdWx0PFRleHREaXJlY3Rpb24+ Ojp2YWx1ZShzZWxlY3RvciwgdmFsdWUpOworICAgICAgICBFbGVtZW50KiBlbGVtZW50ID0gc2Vs ZWN0b3ItPmVsZW1lbnQoKTsKKyAgICAgICAgaWYgKGVsZW1lbnQgJiYgc2VsZWN0b3ItPmVsZW1l bnQoKSA9PSBlbGVtZW50LT5kb2N1bWVudCgpLT5kb2N1bWVudEVsZW1lbnQoKSkKKyAgICAgICAg ICAgIGVsZW1lbnQtPmRvY3VtZW50KCktPnNldERpcmVjdGlvblNldE9uRG9jdW1lbnRFbGVtZW50 KHRydWUpOworICAgIH0KK307CisKIGNvbnN0IENTU1N0eWxlQXBwbHlQcm9wZXJ0eSYgQ1NTU3R5 bGVBcHBseVByb3BlcnR5OjpzaGFyZWRDU1NTdHlsZUFwcGx5UHJvcGVydHkoKQogewogICAgIERF RklORV9TVEFUSUNfTE9DQUwoQ1NTU3R5bGVBcHBseVByb3BlcnR5LCBjc3NTdHlsZUFwcGx5UHJv cGVydHlJbnN0YW5jZSwgKCkpOwpAQCAtMTQ3LDYgKzE2Niw3IEBAIENTU1N0eWxlQXBwbHlQcm9w ZXJ0eTo6Q1NTU3R5bGVBcHBseVByb3AKICAgICAgICBtX3Byb3BlcnR5TWFwW2ldID0gMDsKIAog ICAgIHNldFByb3BlcnR5VmFsdWUoQ1NTUHJvcGVydHlDb2xvciwgbmV3IEFwcGx5UHJvcGVydHlD b2xvcigmUmVuZGVyU3R5bGU6OmNvbG9yLCAmUmVuZGVyU3R5bGU6OnNldENvbG9yLCBSZW5kZXJT dHlsZTo6aW5pdGlhbENvbG9yKSk7CisgICAgc2V0UHJvcGVydHlWYWx1ZShDU1NQcm9wZXJ0eURp cmVjdGlvbiwgbmV3IEFwcGx5UHJvcGVydHlEaXJlY3Rpb24oJlJlbmRlclN0eWxlOjpkaXJlY3Rp b24sICZSZW5kZXJTdHlsZTo6c2V0RGlyZWN0aW9uLCBSZW5kZXJTdHlsZTo6aW5pdGlhbERpcmVj dGlvbikpOwogICAgIHNldFByb3BlcnR5VmFsdWUoQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ29sb3Is IG5ldyBBcHBseVByb3BlcnR5Q29sb3JCYXNlKCZSZW5kZXJTdHlsZTo6YmFja2dyb3VuZENvbG9y LCAwLCAmUmVuZGVyU3R5bGU6OnNldEJhY2tncm91bmRDb2xvcikpOwogICAgIHNldFByb3BlcnR5 VmFsdWUoQ1NTUHJvcGVydHlCb3JkZXJCb3R0b21Db2xvciwgbmV3IEFwcGx5UHJvcGVydHlDb2xv ckJhc2UoJlJlbmRlclN0eWxlOjpib3JkZXJCb3R0b21Db2xvciwgJlJlbmRlclN0eWxlOjpjb2xv ciwgJlJlbmRlclN0eWxlOjpzZXRCb3JkZXJCb3R0b21Db2xvcikpOwogICAgIHNldFByb3BlcnR5 VmFsdWUoQ1NTUHJvcGVydHlCb3JkZXJMZWZ0Q29sb3IsIG5ldyBBcHBseVByb3BlcnR5Q29sb3JC YXNlKCZSZW5kZXJTdHlsZTo6Ym9yZGVyTGVmdENvbG9yLCAmUmVuZGVyU3R5bGU6OmNvbG9yLCAm UmVuZGVyU3R5bGU6OnNldEJvcmRlckxlZnRDb2xvcikpOwpJbmRleDogU291cmNlL1dlYkNvcmUv Y3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nz cy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkocmV2aXNpb24gODI2NTQpCisrKyBTb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3MjIsMTEgKzM3 MjIsNiBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkoaW50CiAgICAgY2Fz ZSBDU1NQcm9wZXJ0eUNsZWFyOgogICAgICAgICBIQU5ETEVfSU5IRVJJVF9BTkRfSU5JVElBTF9B TkRfUFJJTUlUSVZFKGNsZWFyLCBDbGVhcikKICAgICAgICAgcmV0dXJuOwotICAgIGNhc2UgQ1NT UHJvcGVydHlEaXJlY3Rpb246Ci0gICAgICAgIEhBTkRMRV9JTkhFUklUX0FORF9JTklUSUFMX0FO RF9QUklNSVRJVkUoZGlyZWN0aW9uLCBEaXJlY3Rpb24pCi0gICAgICAgIGlmICghaXNJbmhlcml0 ICYmICFpc0luaXRpYWwgJiYgbV9lbGVtZW50ICYmIG1fZWxlbWVudCA9PSBtX2VsZW1lbnQtPmRv Y3VtZW50KCktPmRvY3VtZW50RWxlbWVudCgpKQotICAgICAgICAgICAgbV9lbGVtZW50LT5kb2N1 bWVudCgpLT5zZXREaXJlY3Rpb25TZXRPbkRvY3VtZW50RWxlbWVudCh0cnVlKTsKLSAgICAgICAg cmV0dXJuOwogICAgIGNhc2UgQ1NTUHJvcGVydHlEaXNwbGF5OgogICAgICAgICBIQU5ETEVfSU5I RVJJVF9BTkRfSU5JVElBTF9BTkRfUFJJTUlUSVZFKGRpc3BsYXksIERpc3BsYXkpCiAjaWYgRU5B QkxFKFdDU1MpCkBAIC02MTk3LDYgKzYxOTIsNyBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFw cGx5UHJvcGVydHkoaW50CiAKICAgICAvLyBUaGVzZSBwcm9wZXJ0aWVzIGFyZSBpbXBsZW1lbnRl ZCBpbiB0aGUgQ1NTU3R5bGVBcHBseVByb3BlcnR5IGxvb2t1cCB0YWJsZS4KICAgICBjYXNlIENT U1Byb3BlcnR5Q29sb3I6CisgICAgY2FzZSBDU1NQcm9wZXJ0eURpcmVjdGlvbjoKICAgICBjYXNl IENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yOgogICAgIGNhc2UgQ1NTUHJvcGVydHlCb3JkZXJC b3R0b21Db2xvcjoKICAgICBjYXNlIENTU1Byb3BlcnR5Qm9yZGVyTGVmdENvbG9yOgpJbmRleDog U291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5oCShyZXZpc2lvbiA4MjY1NCkKKysrIFNv dXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTEx NSw2ICsxMTUsNyBAQCBwdWJsaWM6CiAKICAgICAgICAgUmVuZGVyU3R5bGUqIHN0eWxlKCkgY29u c3QgeyByZXR1cm4gbV9zdHlsZS5nZXQoKTsgfQogICAgICAgICBSZW5kZXJTdHlsZSogcGFyZW50 U3R5bGUoKSBjb25zdCB7IHJldHVybiBtX3BhcmVudFN0eWxlOyB9CisgICAgICAgIEVsZW1lbnQq IGVsZW1lbnQoKSBjb25zdCB7IHJldHVybiBtX2VsZW1lbnQ7IH0KIAogICAgIHByaXZhdGU6CiAg ICAgICAgIHZvaWQgaW5pdEZvclN0eWxlUmVzb2x2ZShFbGVtZW50KiwgUmVuZGVyU3R5bGUqIHBh cmVudFN0eWxlID0gMCwgUHNldWRvSWQgPSBOT1BTRVVETyk7Cg==