57602 2011-03-31 19:48:07 -0700 [Qt] DumpRenderTree breaks compilation in some uClibc environments 2011-04-04 10:30:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Linux RESOLVED FIXED Qt, QtTriaged P5 Enhancement --- 1 kamaji webkit-unassigned benjamin commit-queue kamaji kling laszlo.gombos ossy yael oldest_to_newest 377608 0 kamaji 2011-03-31 19:48:07 -0700 When using uClibc, depending on how it was compiled, it can pretend to be glibc, by defining __GLIBC__. DumpRenderTree uses __GLIBC__ guards around a backtrace debugging helper that is defined in glibc, but not defined in uClibc. kit/Tools/DumpRenderTree/qt -I. -o obj/release/main.o ../../../../webkit/Tools/DumpRenderTree/qt/main.cpp ../../../../webkit/Tools/DumpRenderTree/qt/main.cpp:59:22: error: execinfo.h: No such file or directory ../../../../webkit/Tools/DumpRenderTree/qt/main.cpp: In function 'QString get_backtrace()': ../../../../webkit/Tools/DumpRenderTree/qt/main.cpp:79: error: 'backtrace' was not declared in this scope ../../../../webkit/Tools/DumpRenderTree/qt/main.cpp:84: error: 'backtrace_symbols' was not declared in this scope make: *** [obj/release/main.o] Error 1 377613 1 87820 kamaji 2011-03-31 19:53:21 -0700 Created attachment 87820 Patch 377615 2 kamaji 2011-03-31 19:54:00 -0700 add myself to CC 377679 3 87820 laszlo.gombos 2011-04-01 01:41:16 -0700 Comment on attachment 87820 Patch r=me. Please fix the typo in the title (uClbc) before committing. 377816 4 87820 kamaji 2011-04-01 08:42:27 -0700 Comment on attachment 87820 Patch Title fixed. 377817 5 87820 webkit.review.bot 2011-04-01 08:42:41 -0700 Comment on attachment 87820 Patch Rejecting attachment 87820 from commit-queue. keith.kyzivat@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 377845 6 87820 benjamin 2011-04-01 09:15:23 -0700 Comment on attachment 87820 Patch WTF 377846 7 benjamin 2011-04-01 09:15:59 -0700 Why would you cq+ this? The title has not been fixed in the patch. 377940 8 kamaji 2011-04-01 11:27:46 -0700 Doh, my fault -- I didn't realize (or closely check) that the typo was in the commit message... Fixing shortly. 377944 9 87887 kamaji 2011-04-01 11:38:04 -0700 Created attachment 87887 Patch 378865 10 87887 commit-queue 2011-04-04 10:30:14 -0700 Comment on attachment 87887 Patch Clearing flags on attachment: 87887 Committed r82844: <http://trac.webkit.org/changeset/82844> 378866 11 commit-queue 2011-04-04 10:30:20 -0700 All reviewed patches have been landed. Closing bug. 87820 2011-03-31 19:53:21 -0700 2011-04-01 11:38:00 -0700 Patch bug-57602-20110331225428.patch text/plain 1257 kamaji U3VidmVyc2lvbiBSZXZpc2lvbjogODI0NTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzN2Y4YjhiYzM4ZTE4NzU3ZDBkYzgwMTA0MDVlODJkN2U4 NGI3M2EyLi5iMmQwNjI5MjY3OTA1MDNlNDM5MDM5MDViZGRkYTgyOWMwMmEyNjNiIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDMtMzEgIEtlaXRoIEt5eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIER1 bXBSZW5kZXJUcmVlIGJyZWFrcyBjb21waWxhdGlvbiBpbiBzb21lIHVDbGJjIGVudmlyb25tZW50 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc2MDIK KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L21haW4uY3BwOgorICAgICAgICAoZ2V0X2Jh Y2t0cmFjZSk6CisKIDIwMTEtMDMtMzAgIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9xdC9tYWluLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L21h aW4uY3BwCmluZGV4IGJjNzYyZTU5YWZlOGMwOWU0ZWYwNDMxNzZjZTRiODYzY2RmYWI3YzYuLjg5 YTUxMjgzMzY0YzJjZGQ0MDhmNmM1YzVmYzJiZTI3NDJhOThkN2IgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL3F0L21haW4uY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0 L21haW4uY3BwCkBAIC01NCw3ICs1NCw3IEBACiAjaW5jbHVkZSA8bGltaXRzLmg+CiAjaW5jbHVk ZSA8c2lnbmFsLmg+CiAKLSNpZiBkZWZpbmVkKF9fR0xJQkNfXykKKyNpZiBkZWZpbmVkKF9fR0xJ QkNfXykgJiYgIWRlZmluZWQoX19VQ0xJQkNfXykKICNpbmNsdWRlIDxleGVjaW5mby5oPgogI2Vu ZGlmCiAKQEAgLTk3LDcgKzk3LDcgQEAgdm9pZCBwcmludFVzYWdlKCkKIFFTdHJpbmcgZ2V0X2Jh Y2t0cmFjZSgpIHsKICAgICBRU3RyaW5nIHM7CiAKLSNpZiBkZWZpbmVkKF9fR0xJQkNfXykKKyNp ZiBkZWZpbmVkKF9fR0xJQkNfXykgJiYgIWRlZmluZWQoX19VQ0xJQkNfXykKICAgICB2b2lkKiBh cnJheVsyNTZdOwogICAgIHNpemVfdCBzaXplOyAvKiBudW1iZXIgb2Ygc3RhY2sgZnJhbWVzICov CiAK 87887 2011-04-01 11:38:04 -0700 2011-04-04 10:30:14 -0700 Patch bug-57602-20110401143924.patch text/plain 1258 kamaji U3VidmVyc2lvbiBSZXZpc2lvbjogODI0NTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzN2Y4YjhiYzM4ZTE4NzU3ZDBkYzgwMTA0MDVlODJkN2U4 NGI3M2EyLi4xMjk4ODAyN2VlMThlNmFkNjhhZWZjZWY5MjIzMjliN2FlOWMzMmFjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDMtMzEgIEtlaXRoIEt5eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIER1 bXBSZW5kZXJUcmVlIGJyZWFrcyBjb21waWxhdGlvbiBpbiBzb21lIHVDbGliYyBlbnZpcm9ubWVu dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NjAy CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9tYWluLmNwcDoKKyAgICAgICAgKGdldF9i YWNrdHJhY2UpOgorCiAyMDExLTAzLTMwICBZdXRhIEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvcXQvbWFpbi5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9t YWluLmNwcAppbmRleCBiYzc2MmU1OWFmZThjMDllNGVmMDQzMTc2Y2U0Yjg2M2NkZmFiN2M2Li44 OWE1MTI4MzM2NGMyY2RkNDA4ZjZjNWM1ZmMyYmUyNzQyYTk4ZDdiIDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9xdC9tYWluLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9x dC9tYWluLmNwcApAQCAtNTQsNyArNTQsNyBAQAogI2luY2x1ZGUgPGxpbWl0cy5oPgogI2luY2x1 ZGUgPHNpZ25hbC5oPgogCi0jaWYgZGVmaW5lZChfX0dMSUJDX18pCisjaWYgZGVmaW5lZChfX0dM SUJDX18pICYmICFkZWZpbmVkKF9fVUNMSUJDX18pCiAjaW5jbHVkZSA8ZXhlY2luZm8uaD4KICNl bmRpZgogCkBAIC05Nyw3ICs5Nyw3IEBAIHZvaWQgcHJpbnRVc2FnZSgpCiBRU3RyaW5nIGdldF9i YWNrdHJhY2UoKSB7CiAgICAgUVN0cmluZyBzOwogCi0jaWYgZGVmaW5lZChfX0dMSUJDX18pCisj aWYgZGVmaW5lZChfX0dMSUJDX18pICYmICFkZWZpbmVkKF9fVUNMSUJDX18pCiAgICAgdm9pZCog YXJyYXlbMjU2XTsKICAgICBzaXplX3Qgc2l6ZTsgLyogbnVtYmVyIG9mIHN0YWNrIGZyYW1lcyAq LwogCg==