57579 2011-03-31 14:22:18 -0700 webkit-patch is too strict about bug URL formatting 2011-04-04 11:35:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 aroben aroben abarth bweinstein darin eric ojan oldest_to_newest 377443 0 aroben 2011-03-31 14:22:18 -0700 webkit-patch is too strict about bug URL formatting 377445 1 87786 aroben 2011-03-31 14:23:27 -0700 Created attachment 87786 Patch 377446 2 87786 abarth 2011-03-31 14:25:05 -0700 Comment on attachment 87786 Patch We changed this recently because other folks were sad that we were being too loose. We should be sure we're making progress here instead of just flip/flopping between what two different camps want. 377448 3 abarth 2011-03-31 14:25:35 -0700 https://bugs.webkit.org/show_bug.cgi?id=56989 is the earlier bug. 377451 4 aroben 2011-03-31 14:26:07 -0700 See my comments in bug 56989 for why I think this is justified. 377455 5 abarth 2011-03-31 14:30:13 -0700 I don't have strong feelings about this topic. 377474 6 87786 darin 2011-03-31 15:06:13 -0700 Comment on attachment 87786 Patch Seems fine. 377508 7 ojan 2011-03-31 15:50:15 -0700 I'm not totally opposed to this change, but I don't really see the benefit in supporting different changelog formats. IMO, it helps the project if we're all consistent in how we write changelogs. Some pros of consistency: -easier to scan changelog entries quickly -easier to write tooling for dealing with changelog descriptions -easier for people new to the project to understand them and understand how to write their own descriptions 377511 8 aroben 2011-03-31 15:55:07 -0700 I agree consistency is a good thing. I feel a little guilty every time I write a non-standard ChangeLog. I was just surprised that the tools started encouraging the format so strongly. And, as stated in bug 56989 comment 15, it seems like a bug that webkit-patch can no longer figure out a bug number for r81850. 377530 9 ojan 2011-03-31 16:18:26 -0700 (In reply to comment #8) > And, as stated in bug 56989 comment 15, it seems like a bug that webkit-patch can no longer figure out a bug number for r81850. I guess this is the bit I don't agree with. The bug is only used to update/close the bug. But the patch wasn't actually fixing the bug. The bug is relevant to understanding the patch, but webkit-patch shouldn't be updating the bug. 377540 10 aroben 2011-03-31 16:31:33 -0700 (In reply to comment #9) > (In reply to comment #8) > > And, as stated in bug 56989 comment 15, it seems like a bug that webkit-patch can no longer figure out a bug number for r81850. > > I guess this is the bit I don't agree with. The bug is only used to update/close the bug. But the patch wasn't actually fixing the bug. The bug is relevant to understanding the patch, but webkit-patch shouldn't be updating the bug. In that case --no-close seems appropriate. It would still be helpful to have webkit-patch add a comment to the bug even if you aren't closing it. 377791 11 aroben 2011-04-01 08:12:42 -0700 Given that Darin and Eric seem to agree this patch is an improvement (see Eric's comment in bug 56989 comment 16) and that other people are running into trouble because of this (c.f. bug 57605), I'm going to land this patch. We can keep discussing further, but it seems good to make stylebot etc. stop complaining about ChangeLog formats that have long been in use (and worked just fine until this week). 377792 12 aroben 2011-04-01 08:13:55 -0700 Committed r82681: <http://trac.webkit.org/changeset/82681> 378297 13 ojan 2011-04-01 19:36:08 -0700 (In reply to comment #11) > Given that Darin and Eric seem to agree this patch is an improvement (see Eric's comment in bug 56989 comment 16) and that other people are running into trouble because of this (c.f. bug 57605), I'm going to land this patch. We can keep discussing further, but it seems good to make stylebot etc. stop complaining about ChangeLog formats that have long been in use (and worked just fine until this week). Sorry, I though the patch had already been committed. I was just trying to understand what makes sense going forward. 378916 14 aroben 2011-04-04 11:35:31 -0700 Don't worry, I didn't think you were trying to hold things up. :-) And I'm glad you want to improve the tools, too. 87786 2011-03-31 14:23:27 -0700 2011-03-31 15:06:12 -0700 Patch bug-57579-20110331172322.patch text/plain 3553 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogODI2MTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZWY5YTA2ZGFjOWM1ZjNjYzg5ODZiMzM1NjFiNjIxYmMw OGEwY2EyLi5jYzgyNzYzNDY1ZWI0NTc2NGFkMWExNWEyMTUwM2M2ODNkZTk4ZmJlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDMtMzEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCisgICAgICAg IFByZWZlciAoYnV0IGRvbid0IHJlcXVpcmUpIGJ1ZyBVUkxzIHRvIGJlIG9uIHRoZWlyIG93biBs aW5lIHdoZW4gcGFyc2luZyBidWcgbnVtYmVycyBmcm9tIENoYW5nZUxvZ3MKKworICAgICAgICBG aXhlcyA8aHR0cDovL3dlYmtpdC5vcmcvYi81NzU3OT4gd2Via2l0LXBhdGNoIGlzIHRvbyBzdHJp Y3QgYWJvdXQgYnVnIFVSTCBmb3JtYXR0aW5nCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemls bGEvYnVnemlsbGEucHk6CisgICAgICAgIChwYXJzZV9idWdfaWRfZnJvbV9jaGFuZ2Vsb2cpOiBG YWxsIGJhY2sgdG8gcGFyc2VfYnVnX2lkIGlmIHdlIHdlcmVuJ3QgYWJsZSB0byBmaW5kIGEgYnVn CisgICAgICAgIFVSTCBvbiBpdHMgb3duIGxpbmUuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGFfdW5pdHRlc3QucHk6CisgICAgICAgIChC dWd6aWxsYVRlc3QudGVzdF9wYXJzZV9idWdfaWRfZnJvbV9jaGFuZ2Vsb2cpOiBVcGRhdGVkIGV4 cGVjdGVkIHJlc3VsdHMgZm9yIHRlc3QKKyAgICAgICAgcHJvZ3Jlc3Npb24sIGFuZCBhZGRlZCBh IG5ldyB0ZXN0IHRoYXQgdXNlcyBhIHNob3J0IGJ1ZyBVUkwgd2hpbGUgSSB3YXMgYXQgaXQuCisK IDIwMTEtMDMtMzEgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CmluZGV4IDhk YWY5MmUyZTgwOGM2OTZlZmVmNmJkY2U3OGY3OTI0NGUyNzZmNjUuLjZlMDgyZDY4YTc2YTk0Y2Zj YWE0MWNmNWI0YTRkNGZjNmY1ODExNTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHkKQEAgLTc0LDcgKzc0LDkgQEAg ZGVmIHBhcnNlX2J1Z19pZF9mcm9tX2NoYW5nZWxvZyhtZXNzYWdlKToKICAgICBtYXRjaCA9IHJl LnNlYXJjaCgiXlxzKiIgKyBCdWd6aWxsYS5idWdfdXJsX2xvbmcgKyAiJCIsIG1lc3NhZ2UsIHJl Lk1VTFRJTElORSkKICAgICBpZiBtYXRjaDoKICAgICAgICAgcmV0dXJuIGludChtYXRjaC5ncm91 cCgnYnVnX2lkJykpCi0gICAgcmV0dXJuIE5vbmUKKyAgICAjIFdlIHdlcmVuJ3QgYWJsZSB0byBm aW5kIGEgYnVnIFVSTCBpbiB0aGUgZm9ybWF0IHVzZWQgYnkgcHJlcGFyZS1DaGFuZ2VMb2cuIEZh bGwgYmFjayB0byB0aGUKKyAgICAjIGZpcnN0IGJ1ZyBVUkwgZm91bmQgYW55d2hlcmUgaW4gdGhl IG1lc3NhZ2UuCisgICAgcmV0dXJuIHBhcnNlX2J1Z19pZChtZXNzYWdlKQogCiBkZWYgdGltZXN0 YW1wKCk6CiAgICAgcmV0dXJuIGRhdGV0aW1lLm5vdygpLnN0cmZ0aW1lKCIlWSVtJWQlSCVNJVMi KQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxh L2J1Z3ppbGxhX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0 L2J1Z3ppbGxhL2J1Z3ppbGxhX3VuaXR0ZXN0LnB5CmluZGV4IDJlNzVjYTlmNmM4YmZhMjFhODg0 OGEwMDZjOGQxN2FhOTAyMmM5N2MuLjJjNzlhNDVhYmQ2MDk1ZjY2MWZiNmUzNWEyZjc3ZjBlM2Nm NmRiOTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6 aWxsYS9idWd6aWxsYV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGFfdW5pdHRlc3QucHkKQEAgLTIwMyw3ICsyMDMsNyBA QCBaRVpwYm1semFFeHZZV1JYYVhSb1VtVmhjMjl1T25KbFlYTnZibDA3Q2l0OUNpc0tJRUJsYm1R S0lBb2dJMlZ1WkdsbUNnPT0KIAogICAgICAgICAnJycKIAotICAgICAgICBzZWxmLmFzc2VydEVx dWFscyhOb25lLCBwYXJzZV9idWdfaWRfZnJvbV9jaGFuZ2Vsb2coY29tbWl0X3RleHQpKQorICAg ICAgICBzZWxmLmFzc2VydEVxdWFscyg1Njk4OCwgcGFyc2VfYnVnX2lkX2Zyb21fY2hhbmdlbG9n KGNvbW1pdF90ZXh0KSkKIAogICAgICAgICBjb21taXRfdGV4dCA9ICcnJwogMjAxMS0wMy0yMyAg T2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgpAQCAtMjE4LDYgKzIxOCwyNSBAQCBaRVpw Ym1semFFeHZZV1JYYVhSb1VtVmhjMjl1T25KbFlYTnZibDA3Q2l0OUNpc0tJRUJsYm1RS0lBb2dJ MlZ1WkdsbUNnPT0KIAogICAgICAgICBzZWxmLmFzc2VydEVxdWFscygxMjM0NSwgcGFyc2VfYnVn X2lkX2Zyb21fY2hhbmdlbG9nKGNvbW1pdF90ZXh0KSkKIAorICAgICAgICBjb21taXRfdGV4dCA9 ICcnJworMjAxMS0wMy0zMSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgUXVvdGUgdGhlIGV4ZWN1dGFibGUgcGF0aCB3ZSBwYXNzIHRvIDo6Q3JlYXRlUHJvY2Vzc1cK KworICAgICAgICBUaGlzIHdpbGwgZW5zdXJlIHRoYXQgc3BhY2VzIGluIHRoZSBwYXRoIHdpbGwg YmUgaW50ZXJwcmV0ZWQgY29ycmVjdGx5LgorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0 Lm9yZy9iLzU3NTY5PiBXZWIgcHJvY2VzcyBzb21ldGltZXMgZmFpbHMgdG8gbGF1bmNoIHdoZW4g dGhlcmUgYXJlCisgICAgICAgIHNwYWNlcyBpbiBpdHMgcGF0aAorCisgICAgICAgIFJldmlld2Vk IGJ5IFN0ZXZlIEZhbGtlbmJ1cmcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvd2lu L1Byb2Nlc3NMYXVuY2hlcldpbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OlByb2Nlc3NMYXVuY2hl cjo6bGF1bmNoUHJvY2Vzcyk6IFN1cnJvdW5kIHRoZSBleGVjdXRhYmxlIHBhdGggaW4gcXVvdGVz LgorCisgICAgICAgICcnJworCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKDU3NTY5LCBwYXJz ZV9idWdfaWRfZnJvbV9jaGFuZ2Vsb2coY29tbWl0X3RleHQpKQorCiAKICAgICAjIEZJWE1FOiBU aGlzIHNob3VsZCBtb3ZlIHRvIGEgY2VudHJhbCBsb2NhdGlvbiBhbmQgYmUgc2hhcmVkIGJ5IG1v cmUgdW5pdCB0ZXN0cy4KICAgICBkZWYgX2Fzc2VydF9kaWN0aW9uYXJpZXNfZXF1YWwoc2VsZiwg YWN0dWFsLCBleHBlY3RlZCk6Cg==