57566 2011-03-31 11:55:50 -0700 Can't identify file entities with WebKit::WebContextMenuData enum 2011-04-06 01:52:46 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 zelidrag zelidrag abarth commit-queue ericu eric levin shanestephens webkit.review.bot oldest_to_newest 377367 0 zelidrag 2011-03-31 11:55:50 -0700 We need to be able to use ContextMenuParams for file entity identification for ChromeOS file browser. The only change needed on WK side is to add a new enum WebKit::WebContextMenuData value to WebContextMenuData::MediaType - MediaTypeFile. 377369 1 87774 zelidrag 2011-03-31 11:59:25 -0700 Created attachment 87774 Added MediaTypeFile enum value to WebContextMenuData::MediaType 378254 2 levin 2011-04-01 17:55:08 -0700 This is a trivial change and by itself it seems fine, but I find it hard to understand how this enum change does anything and why it is beneficial and if it useful (w/o doing any other changes in WebKit), why this enum is upstream at all. Thus my reluctance to r+. 379777 3 levin 2011-04-05 11:46:48 -0700 Summary: There is a function/strucutre in WebKit that stores these enum values without caring what they are and a new one is needed for purposes on the Chromium side. 379842 4 87774 commit-queue 2011-04-05 13:44:36 -0700 Comment on attachment 87774 Added MediaTypeFile enum value to WebContextMenuData::MediaType Clearing flags on attachment: 87774 Committed r82976: <http://trac.webkit.org/changeset/82976> 379843 5 commit-queue 2011-04-05 13:44:41 -0700 All reviewed patches have been landed. Closing bug. 380025 6 shanestephens 2011-04-05 18:46:48 -0700 Reopening this bug as we need to roll out the patch - it breaks chromium build 380039 7 levin 2011-04-05 19:03:57 -0700 Here's how to do this patch in a way that won't break any builds. 1. Submit a patch on the chromium side which fixes the build for when this enum is added but ifdef all the places. Something like #ifdef WebContextMenuDataFileTypeDefined but with proper casing. 2. Put up with patch and add a #define WebContextMenuDataFileTypeDefined in the header file file. 3. Once it gets into chromium, you remove all the ifdef's and submit that patch. 4. Then one final patch in WebKit which removes #define WebContextMenuDataFileTypeDefined from this header. 380068 8 88356 zelidrag 2011-04-05 19:56:30 -0700 Created attachment 88356 Added MediaTypeFile enum value to WebContextMenuData::MediaType... with fix for Chromium side added new define WEBCONTEXT_MEDIATYPEFILE_DEFINED that should prevent Chromium build from breaking this needs to land after http://codereview.chromium.org/6799005/ 380157 9 88356 commit-queue 2011-04-05 23:30:12 -0700 Comment on attachment 88356 Added MediaTypeFile enum value to WebContextMenuData::MediaType... with fix for Chromium side Clearing flags on attachment: 88356 Committed r83023: <http://trac.webkit.org/changeset/83023> 380158 10 commit-queue 2011-04-05 23:30:16 -0700 All reviewed patches have been landed. Closing bug. 380216 11 webkit.review.bot 2011-04-06 01:52:46 -0700 http://trac.webkit.org/changeset/83023 might have broken GTK Linux 32-bit Debug 87774 2011-03-31 11:59:25 -0700 2011-04-05 19:56:30 -0700 Added MediaTypeFile enum value to WebContextMenuData::MediaType wk-57566.diff text/plain 1119 zelidrag SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MjYwMikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDMtMzEgIFplbGlkcmFnIEhvcm51bmcgIDx6ZWxpZHJhZ0BjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQg TWVkaWFUeXBlRmlsZSBlbnVtIHZhbHVlIHRvIFdlYkNvbnRleHRNZW51RGF0YTo6TWVkaWFUeXBl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc1NjYK KworICAgICAgICAqIHB1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaDoKKwogMjAxMS0wMy0zMSAg RXZhbiBNYXJ0aW4gIDxldmFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBF cmljIFNlaWRlbC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRl eHRNZW51RGF0YS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkNvbnRleHRNZW51RGF0YS5oCShyZXZpc2lvbiA4MjUxOCkKKysrIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC01 Miw2ICs1Miw4IEBAIHN0cnVjdCBXZWJDb250ZXh0TWVudURhdGEgewogICAgICAgICBNZWRpYVR5 cGVWaWRlbywKICAgICAgICAgLy8gQW4gYXVkaW8gbm9kZSBpcyBzZWxlY3RlZC4KICAgICAgICAg TWVkaWFUeXBlQXVkaW8sCisgICAgICAgIC8vIEEgZmlsZSBub2RlIGlzIHNlbGVjdGVkLgorICAg ICAgICBNZWRpYVR5cGVGaWxlLAogICAgICAgICAvLyBBIHBsdWdpbiBub2RlIGlzIHNlbGVjdGVk LgogICAgICAgICBNZWRpYVR5cGVQbHVnaW4sCiAgICAgfTsK 88356 2011-04-05 19:56:30 -0700 2011-04-05 23:30:12 -0700 Added MediaTypeFile enum value to WebContextMenuData::MediaType... with fix for Chromium side wk-57566.diff text/plain 1308 zelidrag SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MjkwNikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDQtMDUgIFplbGlkcmFnIEhvcm51bmcgIDx6ZWxpZHJhZ0BjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQg TWVkaWFUeXBlRmlsZSBlbnVtIHZhbHVlIHRvIFdlYkNvbnRleHRNZW51RGF0YTo6TWVkaWFUeXBl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc1NjYK KworICAgICAgICAqIHB1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaDoKKwogMjAxMS0wNC0wNCAg Q2hhbmcgU2h1ICA8Y3NodUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1 a2UgTml3YS4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRN ZW51RGF0YS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkNvbnRleHRNZW51RGF0YS5oCShyZXZpc2lvbiA4Mjg3MCkKKysrIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw2 ICszOSw4IEBACiAjaW5jbHVkZSAiV2ViVVJMLmgiCiAjaW5jbHVkZSAiV2ViVmVjdG9yLmgiCiAK KyNkZWZpbmUgV0VCQ09OVEVYVF9NRURJQVRZUEVGSUxFX0RFRklORUQKKwogbmFtZXNwYWNlIFdl YktpdCB7CiAKIC8vIFRoaXMgc3RydWN0IGlzIHBhc3NlZCB0byBXZWJWaWV3Q2xpZW50OjpTaG93 Q29udGV4dE1lbnUuCkBAIC01Miw2ICs1NCw4IEBAIHN0cnVjdCBXZWJDb250ZXh0TWVudURhdGEg ewogICAgICAgICBNZWRpYVR5cGVWaWRlbywKICAgICAgICAgLy8gQW4gYXVkaW8gbm9kZSBpcyBz ZWxlY3RlZC4KICAgICAgICAgTWVkaWFUeXBlQXVkaW8sCisgICAgICAgIC8vIEEgZmlsZSBub2Rl IGlzIHNlbGVjdGVkLgorICAgICAgICBNZWRpYVR5cGVGaWxlLAogICAgICAgICAvLyBBIHBsdWdp biBub2RlIGlzIHNlbGVjdGVkLgogICAgICAgICBNZWRpYVR5cGVQbHVnaW4sCiAgICAgfTsK