57557 2011-03-31 09:55:16 -0700 [Crash] Web Inspector: inspected page crashes on attempt to log object with broken .toString 2011-04-01 01:59:47 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys antonm apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 377263 0 yurys 2011-03-31 09:55:16 -0700 Steps to reproduce: 1. Navigate to a page with the following content: <script> console.log({toString:{}}); </script> 2. Open inspector. 3. Reload the inspected page. Result: Page crashes. Original Chromium bug report: http://code.google.com/p/chromium/issues/detail?id=74411 377298 1 yurys 2011-03-31 10:26:24 -0700 Clearing [V8] prefix since it's reproducible with JSC as well. 377331 2 87765 yurys 2011-03-31 10:55:25 -0700 Created attachment 87765 Patch 377332 3 yurys 2011-03-31 10:57:11 -0700 A big thanks to Anton Muhin for his help in finding the real cause of this crash. 377362 4 87765 antonm 2011-03-31 11:36:02 -0700 Comment on attachment 87765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87765&action=review LGTM > LayoutTests/inspector/console/console-log-toString-object.html:20 > +Tests passing object with broken toString attribute into console.log won't crash nit: I am having some troubles parsing this sentence, maybe Test <that> passing object... And maybe you should generalize the case: passing an object which throws on string conversion or something of this kind > Source/WebCore/ChangeLog:8 > + If ScriptValue.toString causes a JavaScript exception the exception is cleared nit: exception<,> the exception (add a comma) > Source/WebCore/bindings/v8/ScriptValue.cpp:72 > + return v8StringToWebCoreString<String>(s, DoNotExternalize); Another option would be to teach V8Parameter not to rethrow an exception. The benefit would be your code would be shorter and others can use the same logic too. Up to you though, 377663 5 87829 yurys 2011-04-01 00:17:37 -0700 Created attachment 87829 Patch 377664 6 yurys 2011-04-01 00:18:48 -0700 (In reply to comment #4) > (From update of attachment 87765 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87765&action=review > > LayoutTests/inspector/console/console-log-toString-object.html:20 > > +Tests passing object with broken toString attribute into console.log won't crash > > nit: I am having some troubles parsing this sentence, maybe Test <that> passing object... And maybe you should generalize the case: passing an object which throws on string conversion or something of this kind > Done. > > Source/WebCore/ChangeLog:8 > > + If ScriptValue.toString causes a JavaScript exception the exception is cleared > > nit: exception<,> the exception (add a comma) > Done. > > Source/WebCore/bindings/v8/ScriptValue.cpp:72 > > + return v8StringToWebCoreString<String>(s, DoNotExternalize); > > Another option would be to teach V8Parameter not to rethrow an exception. The benefit would be your code would be shorter and others can use the same logic too. Up to you though, I'd rather do this in a separate change. 377681 7 yurys 2011-04-01 01:59:47 -0700 Committed r82664: <http://trac.webkit.org/changeset/82664> 87765 2011-03-31 10:55:25 -0700 2011-04-01 00:17:31 -0700 Patch bug-57557-20110331215523.patch text/plain 6620 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogODI1OTMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3ZDQxNmU3ODZkYTlhNTk4MjRmMzkw ZTU2ZDllOTRkZWYxMDllNGJkLi5mMzNlNDZlN2VhNDBhMTM0NTczODQxZTIxYzg5N2M4NGM3ZTc2 ODY5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMzEgIFl1cnkgU2VtaWtoYXRza3kg IDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogaW5zcGVjdGVkIHBhZ2UgY3Jhc2hlcyBvbiBh dHRlbXB0IHRvIGxvZyBvYmplY3Qgd2l0aCBicm9rZW4gLnRvU3RyaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzU1NworCisgICAgICAgICogaW5z cGVjdG9yL2NvbnNvbGUvY29uc29sZS1sb2ctdG9TdHJpbmctb2JqZWN0LWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1sb2ctdG9TdHJpbmct b2JqZWN0Lmh0bWw6IEFkZGVkLgorCiAyMDExLTAzLTMxICBTZXJnaW8gVmlsbGFyIFNlbmluICA8 c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNv bi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtbG9n LXRvU3RyaW5nLW9iamVjdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29u c29sZS9jb25zb2xlLWxvZy10b1N0cmluZy1vYmplY3QtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNzU1CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LmY0ZmUyOWRkMjY3NjExNjBkMjc1ZWRjOTNiYzJmYjk1MmMzNTVhNDIKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWxvZy10b1N0cmluZy1v YmplY3QtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorQ09OU09MRSBNRVNTQUdFOiBsaW5l IDc6IAorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDc6IAorVGVzdHMgcGFzc2luZyBvYmplY3Qgd2l0 aCBicm9rZW4gdG9TdHJpbmcgYXR0cmlidXRlIGludG8gY29uc29sZS5sb2cgd29uJ3QgY3Jhc2gg aW5zcGVjdGVkIFBhZ2UuIFRoZSB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IGNyYXNoLiBCdWcg NTc1NTcKKworUGFnZSByZWxvYWRlZC4KK2NvbnNvbGUtbG9nLXRvU3RyaW5nLW9iamVjdC5odG1s OjdPYmplY3QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29u c29sZS1sb2ctdG9TdHJpbmctb2JqZWN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29u c29sZS9jb25zb2xlLWxvZy10b1N0cmluZy1vYmplY3QuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDc1 NQppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lZDRhMmNl NWQzMjc2N2IxMjkxNzUwZDYzMWJiZjQ2Yzc0NDA1ZTJjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1sb2ctdG9TdHJpbmctb2JqZWN0Lmh0 bWwKQEAgLTAsMCArMSwyNSBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9o dHRwL3Rlc3RzL2luc3BlY3Rvci9pbnNwZWN0b3ItdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0 IHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNwZWN0b3IvY29uc29sZS10ZXN0LmpzIj48L3Njcmlw dD4KKzxzY3JpcHQ+CisKK2NvbnNvbGUubG9nKHt0b1N0cmluZzp7fX0pOworCitmdW5jdGlvbiB0 ZXN0KCkKK3sKKyAgICBJbnNwZWN0b3JUZXN0LnJlbG9hZFBhZ2UoZnVuY3Rpb24oKSB7CisgICAg ICAgIEluc3BlY3RvclRlc3QuZHVtcENvbnNvbGVNZXNzYWdlcygpOworICAgICAgICBJbnNwZWN0 b3JUZXN0LmNvbXBsZXRlVGVzdCgpOworICAgIH0pOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8 Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8cD4KK1Rlc3RzIHBhc3Npbmcgb2JqZWN0IHdpdGgg YnJva2VuIHRvU3RyaW5nIGF0dHJpYnV0ZSBpbnRvIGNvbnNvbGUubG9nIHdvbid0IGNyYXNoCitp bnNwZWN0ZWQgUGFnZS4gVGhlIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXNuJ3QgY3Jhc2guCis8YSBo cmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc1NTciPkJ1ZyA1 NzU1NzwvYT4KKzwvcD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NjVkZTMyNjc1 YjZiNWIwMjA4NTBiOTc3YWFhNTdiMmU1Y2ViZDQ2Li42NmUxZTZiNWQwMDdmYTUyMjliMjU4NWYz OWM5YjZlYTRlZThjMjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDMtMzEg IFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogaW5zcGVjdGVk IHBhZ2UgY3Jhc2hlcyBvbiBhdHRlbXB0IHRvIGxvZyBvYmplY3Qgd2l0aCBicm9rZW4gLnRvU3Ry aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzU1 NworCisgICAgICAgIElmIFNjcmlwdFZhbHVlLnRvU3RyaW5nIGNhdXNlcyBhIEphdmFTY3JpcHQg ZXhjZXB0aW9uIHRoZSBleGNlcHRpb24gaXMgY2xlYXJlZAorICAgICAgICBiZWZvcmUgcmV0dXJu aW5nIGZyb20gdGhlIHRvU3RyaW5nIG1ldGhvZC4KKworICAgICAgICBUZXN0OiBpbnNwZWN0b3Iv Y29uc29sZS9jb25zb2xlLWxvZy10b1N0cmluZy1vYmplY3QuaHRtbAorCisgICAgICAgICogYmlu ZGluZ3MvanMvU2NyaXB0VmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0VmFsdWU6 OnRvU3RyaW5nKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRWYWx1ZS5oOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L1NjcmlwdFZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlw dFZhbHVlOjp0b1N0cmluZyk6CisKIDIwMTEtMDMtMzEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQnVpbGQgZml4IGFmdGVyIHI4MjU4OC4gUmV2ZXJ0ZWQgdW5p bnRlbnRpb25hbCBjaGFuZ2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9TY3JpcHRWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRWYWx1 ZS5jcHAKaW5kZXggNmZlNmVhMzhkMWM0NDYzMjhhZWRhYzNlMzE3OTU2MjVkNTFjZTNmNC4uNTNm N2ZhNjE4NGY4YWVkYmQ0OTMxNzNjZWQ2OWJhOTZkZjZhNTA2MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0VmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmNwcApAQCAtMSw1ICsxLDYgQEAKIC8qCiAgKiBDb3B5 cmlnaHQgKEMpIDIwMDYsIDIwMDcsIDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICogQ29weXJpZ2h0IChjKSAyMDExIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTU1LDYgKzU2LDE1IEBAIGJvb2wg U2NyaXB0VmFsdWU6OmdldFN0cmluZyhTY3JpcHRTdGF0ZSogc2NyaXB0U3RhdGUsIFN0cmluZyYg cmVzdWx0KSBjb25zdAogICAgIHJldHVybiB0cnVlOwogfQogCitTdHJpbmcgU2NyaXB0VmFsdWU6 OnRvU3RyaW5nKFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZSkgY29uc3QKK3sKKyAgICBTdHJpbmcg cmVzdWx0ID0gdXN0cmluZ1RvU3RyaW5nKG1fdmFsdWUuZ2V0KCkudG9TdHJpbmcoc2NyaXB0U3Rh dGUpKTsKKyAgICAvLyBIYW5kbGUgdGhlIGNhc2Ugd2hlcmUgYW4gZXhjZXB0aW9uIGlzIHRocm93 biBhcyBwYXJ0IG9mIGludm9raW5nIHRvU3RyaW5nIG9uIHRoZSBvYmplY3QuCisgICAgaWYgKHNj cmlwdFN0YXRlLT5oYWRFeGNlcHRpb24oKSkKKyAgICAgICAgc2NyaXB0U3RhdGUtPmNsZWFyRXhj ZXB0aW9uKCk7CisgICAgcmV0dXJuIHJlc3VsdDsKK30KKwogYm9vbCBTY3JpcHRWYWx1ZTo6aXNF cXVhbChTY3JpcHRTdGF0ZSogc2NyaXB0U3RhdGUsIGNvbnN0IFNjcmlwdFZhbHVlJiBhbm90aGVy VmFsdWUpIGNvbnN0CiB7CiAgICAgaWYgKGhhc05vVmFsdWUoKSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9TY3JpcHRWYWx1ZS5oCmluZGV4IDM3Y2YyNDM2NTFiYTlhNDRlYzg5NTdiNWE2NzUx N2RiNGY0ZmRkZTYuLmI2OWFjZTc1ODgyZTk4NzY0NzA3YjMyYmFjOWUyNTMzOTg1ZWNlMmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmgKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0VmFsdWUuaApAQCAtMSw1ICsxLDUgQEAK IC8qCi0gKiBDb3B5cmlnaHQgKGMpIDIwMDgsIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCisgKiBDb3B5cmlnaHQgKGMpIDIwMDgsIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KICAqIAogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCkBAIC01MSw3ICs1 MSw3IEBAIHB1YmxpYzoKIAogICAgIEpTQzo6SlNWYWx1ZSBqc1ZhbHVlKCkgY29uc3QgeyByZXR1 cm4gbV92YWx1ZS5nZXQoKTsgfQogICAgIGJvb2wgZ2V0U3RyaW5nKFNjcmlwdFN0YXRlKiwgU3Ry aW5nJiByZXN1bHQpIGNvbnN0OwotICAgIFN0cmluZyB0b1N0cmluZyhTY3JpcHRTdGF0ZSogc2Ny aXB0U3RhdGUpIGNvbnN0IHsgcmV0dXJuIHVzdHJpbmdUb1N0cmluZyhtX3ZhbHVlLmdldCgpLnRv U3RyaW5nKHNjcmlwdFN0YXRlKSk7IH0KKyAgICBTdHJpbmcgdG9TdHJpbmcoU2NyaXB0U3RhdGUq KSBjb25zdDsKICAgICBib29sIGlzRXF1YWwoU2NyaXB0U3RhdGUqLCBjb25zdCBTY3JpcHRWYWx1 ZSYpIGNvbnN0OwogICAgIGJvb2wgaXNOdWxsKCkgY29uc3Q7CiAgICAgYm9vbCBpc1VuZGVmaW5l ZCgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0 VmFsdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0VmFsdWUuY3BwCmlu ZGV4IGViZTljY2M3MjhmYjg2NDA2ZGI4NGViZGU0ZTNiYzVlZTQ0ODA5N2UuLjM0ODdkMzliOWUz Y2E2NmQ4MTkyMDQyZWE4OTM3Y2ZkMzYwZjVjNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1NjcmlwdFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9TY3JpcHRWYWx1ZS5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChD KSAyMDA4LCAyMDA5IEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmln aHQgKEMpIDIwMDgsIDIwMDksIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTY0LDcgKzY0LDEyIEBAIGJv b2wgU2NyaXB0VmFsdWU6OmdldFN0cmluZyhTdHJpbmcmIHJlc3VsdCkgY29uc3QKIAogU3RyaW5n IFNjcmlwdFZhbHVlOjp0b1N0cmluZyhTY3JpcHRTdGF0ZSopIGNvbnN0CiB7Ci0gICAgcmV0dXJu IHRvV2ViQ29yZVN0cmluZyhtX3ZhbHVlKTsKKyAgICB2ODo6VHJ5Q2F0Y2ggYmxvY2s7CisgICAg djg6OkhhbmRsZTx2ODo6U3RyaW5nPiBzID0gbV92YWx1ZS0+VG9TdHJpbmcoKTsKKyAgICAvLyBI YW5kbGUgdGhlIGNhc2Ugd2hlcmUgYW4gZXhjZXB0aW9uIGlzIHRocm93biBhcyBwYXJ0IG9mIGlu dm9raW5nIHRvU3RyaW5nIG9uIHRoZSBvYmplY3QuCisgICAgaWYgKGJsb2NrLkhhc0NhdWdodCgp KQorICAgICAgICByZXR1cm4gU3RyaW5nKCk7CisgICAgcmV0dXJuIHY4U3RyaW5nVG9XZWJDb3Jl U3RyaW5nPFN0cmluZz4ocywgRG9Ob3RFeHRlcm5hbGl6ZSk7CiB9CiAKICNpZiBFTkFCTEUoSU5T UEVDVE9SKQo= 87829 2011-04-01 00:17:37 -0700 2011-04-01 01:55:09 -0700 Patch bug-57557-20110401111735.patch text/plain 6649 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogODI2NjEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0NzM4MDgxY2E4OWMxNjVhOTNiYjUy ODllMjY0ODg3ZTE0NTJlNWU2Li5jMTFmNjY4NzAwZjE4MzI1OGNmY2Q5OTg1N2ZmYzdjM2FlZDEy NTM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMzEgIFl1cnkgU2VtaWtoYXRza3kg IDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogaW5zcGVjdGVkIHBhZ2UgY3Jhc2hlcyBvbiBh dHRlbXB0IHRvIGxvZyBvYmplY3Qgd2l0aCBicm9rZW4gLnRvU3RyaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzU1NworCisgICAgICAgICogaW5z cGVjdG9yL2NvbnNvbGUvY29uc29sZS1sb2ctdG9TdHJpbmctb2JqZWN0LWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1sb2ctdG9TdHJpbmct b2JqZWN0Lmh0bWw6IEFkZGVkLgorCiAyMDExLTAzLTMxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIHR3byBtb3JlIHByZWxvYWRlciB0ZXN0cyB0byB0aGUg V2ViS2l0MiBTa2lwcGVkIGxpc3QuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv Y29uc29sZS9jb25zb2xlLWxvZy10b1N0cmluZy1vYmplY3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1sb2ctdG9TdHJpbmctb2JqZWN0LWV4cGVj dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi4xZTI0MzdmN2EzN2Q5N2FjMGEyYjczODcyMzI1NWQ2YmQ5MWUw YmY2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29u c29sZS1sb2ctdG9TdHJpbmctb2JqZWN0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDcgQEAKK0NP TlNPTEUgTUVTU0FHRTogbGluZSA3OiAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSA3OiAKK1Rlc3Rz IHRoYXQgcGFzc2luZyBhbiBvYmplY3Qgd2hpY2ggdGhyb3dzIG9uIHN0cmluZyBjb252ZXJzaW9u IGludG8gY29uc29sZS5sb2cgd29uJ3QgY3Jhc2ggaW5zcGVjdGVkIFBhZ2UuIFRoZSB0ZXN0IHBh c3NlcyBpZiBpdCBkb2Vzbid0IGNyYXNoLiBCdWcgNTc1NTcKKworUGFnZSByZWxvYWRlZC4KK2Nv bnNvbGUtbG9nLXRvU3RyaW5nLW9iamVjdC5odG1sOjdPYmplY3QKKwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1sb2ctdG9TdHJpbmctb2JqZWN0Lmh0 bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWxvZy10b1N0cmluZy1v YmplY3QuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45OTg2ODk0YzdiZDEwM2U4OGZkYmI1ZDE0NjQ0Zjk5OWMy M2NhOThlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUv Y29uc29sZS1sb2ctdG9TdHJpbmctb2JqZWN0Lmh0bWwKQEAgLTAsMCArMSwyNSBAQAorPGh0bWw+ Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9pbnNwZWN0 b3ItdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNw ZWN0b3IvY29uc29sZS10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2NvbnNvbGUubG9n KHt0b1N0cmluZzp7fX0pOworCitmdW5jdGlvbiB0ZXN0KCkKK3sKKyAgICBJbnNwZWN0b3JUZXN0 LnJlbG9hZFBhZ2UoZnVuY3Rpb24oKSB7CisgICAgICAgIEluc3BlY3RvclRlc3QuZHVtcENvbnNv bGVNZXNzYWdlcygpOworICAgICAgICBJbnNwZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOworICAg IH0pOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8 cD4KK1Rlc3RzIHRoYXQgcGFzc2luZyBhbiBvYmplY3Qgd2hpY2ggdGhyb3dzIG9uIHN0cmluZyBj b252ZXJzaW9uIGludG8gY29uc29sZS5sb2cgd29uJ3QgY3Jhc2gKK2luc3BlY3RlZCBQYWdlLiBU aGUgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4KKzxhIGhyZWY9Imh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzU1NyI+QnVnIDU3NTU3PC9hPgorPC9wPgor PC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGYzNzNlZGU4M2IzODI1N2JmMTVmYzY5Njk4 ZmYzZjUxNmI3YmQ4ZTAuLmUxZWQ0OWE4N2E0M2Y2MmFhNzI2NGNhMmY4MTc4ZmZiNWEyZGRkY2Ig MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMS0wMy0zMSAgWXVyeSBTZW1pa2hhdHNr eSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBpbnNwZWN0ZWQgcGFnZSBjcmFzaGVzIG9u IGF0dGVtcHQgdG8gbG9nIG9iamVjdCB3aXRoIGJyb2tlbiAudG9TdHJpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NTU3CisKKyAgICAgICAgSWYg U2NyaXB0VmFsdWUudG9TdHJpbmcgY2F1c2VzIGEgSmF2YVNjcmlwdCBleGNlcHRpb24sIHRoZSBl eGNlcHRpb24gaXMgY2xlYXJlZAorICAgICAgICBiZWZvcmUgcmV0dXJuaW5nIGZyb20gdGhlIHRv U3RyaW5nIG1ldGhvZC4KKworICAgICAgICBUZXN0OiBpbnNwZWN0b3IvY29uc29sZS9jb25zb2xl LWxvZy10b1N0cmluZy1vYmplY3QuaHRtbAorCisgICAgICAgICogYmluZGluZ3MvanMvU2NyaXB0 VmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0VmFsdWU6OnRvU3RyaW5nKToKKyAg ICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRWYWx1ZS5oOgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L1NjcmlwdFZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFZhbHVlOjp0b1N0cmlu Zyk6CisKIDIwMTEtMDMtMzEgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4MjY1Mi4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmNwcAppbmRleCA2ZmU2ZWEzOGQxYzQ0NjMy OGFlZGFjM2UzMTc5NTYyNWQ1MWNlM2Y0Li41M2Y3ZmE2MTg0ZjhhZWRiZDQ5MzE3M2NlZDY5YmE5 NmRmNmE1MDYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRW YWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0VmFsdWUuY3Bw CkBAIC0xLDUgKzEsNiBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAwNiwgMjAwNywgMjAwOCBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKGMpIDIwMTEgR29v Z2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQg dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlm aWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0 aW9ucwpAQCAtNTUsNiArNTYsMTUgQEAgYm9vbCBTY3JpcHRWYWx1ZTo6Z2V0U3RyaW5nKFNjcmlw dFN0YXRlKiBzY3JpcHRTdGF0ZSwgU3RyaW5nJiByZXN1bHQpIGNvbnN0CiAgICAgcmV0dXJuIHRy dWU7CiB9CiAKK1N0cmluZyBTY3JpcHRWYWx1ZTo6dG9TdHJpbmcoU2NyaXB0U3RhdGUqIHNjcmlw dFN0YXRlKSBjb25zdAoreworICAgIFN0cmluZyByZXN1bHQgPSB1c3RyaW5nVG9TdHJpbmcobV92 YWx1ZS5nZXQoKS50b1N0cmluZyhzY3JpcHRTdGF0ZSkpOworICAgIC8vIEhhbmRsZSB0aGUgY2Fz ZSB3aGVyZSBhbiBleGNlcHRpb24gaXMgdGhyb3duIGFzIHBhcnQgb2YgaW52b2tpbmcgdG9TdHJp bmcgb24gdGhlIG9iamVjdC4KKyAgICBpZiAoc2NyaXB0U3RhdGUtPmhhZEV4Y2VwdGlvbigpKQor ICAgICAgICBzY3JpcHRTdGF0ZS0+Y2xlYXJFeGNlcHRpb24oKTsKKyAgICByZXR1cm4gcmVzdWx0 OworfQorCiBib29sIFNjcmlwdFZhbHVlOjppc0VxdWFsKFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0 ZSwgY29uc3QgU2NyaXB0VmFsdWUmIGFub3RoZXJWYWx1ZSkgY29uc3QKIHsKICAgICBpZiAoaGFz Tm9WYWx1ZSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0 VmFsdWUuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmgKaW5kZXgg MzdjZjI0MzY1MWJhOWE0NGVjODk1N2I1YTY3NTE3ZGI0ZjRmZGRlNi4uYjY5YWNlNzU4ODJlOTg3 NjQ3MDdiMzJiYWM5ZTI1MzM5ODVlY2UyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvU2NyaXB0VmFsdWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9T Y3JpcHRWYWx1ZS5oCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoYykgMjAwOCwg R29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoYykgMjAwOCwg MjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICogCiAgKiBSZWRpc3RyaWJ1 dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK ICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp bmcgY29uZGl0aW9ucyBhcmUKQEAgLTUxLDcgKzUxLDcgQEAgcHVibGljOgogCiAgICAgSlNDOjpK U1ZhbHVlIGpzVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX3ZhbHVlLmdldCgpOyB9CiAgICAgYm9v bCBnZXRTdHJpbmcoU2NyaXB0U3RhdGUqLCBTdHJpbmcmIHJlc3VsdCkgY29uc3Q7Ci0gICAgU3Ry aW5nIHRvU3RyaW5nKFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZSkgY29uc3QgeyByZXR1cm4gdXN0 cmluZ1RvU3RyaW5nKG1fdmFsdWUuZ2V0KCkudG9TdHJpbmcoc2NyaXB0U3RhdGUpKTsgfQorICAg IFN0cmluZyB0b1N0cmluZyhTY3JpcHRTdGF0ZSopIGNvbnN0OwogICAgIGJvb2wgaXNFcXVhbChT Y3JpcHRTdGF0ZSosIGNvbnN0IFNjcmlwdFZhbHVlJikgY29uc3Q7CiAgICAgYm9vbCBpc051bGwo KSBjb25zdDsKICAgICBib29sIGlzVW5kZWZpbmVkKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9TY3JpcHRWYWx1ZS5jcHAKaW5kZXggZWJlOWNjYzcyOGZiODY0MDZkYjg0ZWJk ZTRlM2JjNWVlNDQ4MDk3ZS4uMzQ4N2QzOWI5ZTNjYTY2ZDgxOTIwNDJlYTg5MzdjZmQzNjBmNWM1 NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0VmFsdWUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFZhbHVlLmNwcApAQCAtMSw1 ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDgsIDIwMDkgR29vZ2xlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOCwgMjAwOSwgMjAxMSBHb29n bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1 c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZp Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp b25zIGFyZQpAQCAtNjQsNyArNjQsMTIgQEAgYm9vbCBTY3JpcHRWYWx1ZTo6Z2V0U3RyaW5nKFN0 cmluZyYgcmVzdWx0KSBjb25zdAogCiBTdHJpbmcgU2NyaXB0VmFsdWU6OnRvU3RyaW5nKFNjcmlw dFN0YXRlKikgY29uc3QKIHsKLSAgICByZXR1cm4gdG9XZWJDb3JlU3RyaW5nKG1fdmFsdWUpOwor ICAgIHY4OjpUcnlDYXRjaCBibG9jazsKKyAgICB2ODo6SGFuZGxlPHY4OjpTdHJpbmc+IHMgPSBt X3ZhbHVlLT5Ub1N0cmluZygpOworICAgIC8vIEhhbmRsZSB0aGUgY2FzZSB3aGVyZSBhbiBleGNl cHRpb24gaXMgdGhyb3duIGFzIHBhcnQgb2YgaW52b2tpbmcgdG9TdHJpbmcgb24gdGhlIG9iamVj dC4KKyAgICBpZiAoYmxvY2suSGFzQ2F1Z2h0KCkpCisgICAgICAgIHJldHVybiBTdHJpbmcoKTsK KyAgICByZXR1cm4gdjhTdHJpbmdUb1dlYkNvcmVTdHJpbmc8U3RyaW5nPihzLCBEb05vdEV4dGVy bmFsaXplKTsKIH0KIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCg==