57554 2011-03-31 09:22:27 -0700 [Qt] QML Webview causes performance drops 2011-07-01 07:46:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED https://qtrequirements.europe.nokia.com/browse/QT-4834 Qt, QtTriaged P3 Normal --- 1 timo.vitikainen webkit-unassigned ademar benjamin damian.jansen joel.parks webkit.review.bot oldest_to_newest 377229 0 timo.vitikainen 2011-03-31 09:22:27 -0700 Performance issue is revealed using two demo applications on N8: a) QML wrapper app and b) QGraphicsWebview (non-QML) app. Both of these demo apps have the same HTML5 code (including e.g. HTML5 canvas and full-screen transitions) - see the URL. Root cause for the revealed perf drops problem is assumed to be the page level tiling in QDeclarativeWebview. Another problem with the tiling (enabled in the QML WebView) is that it does not support HTML5 parallax scrolling, actually tiling kills the whole rendering of the content that includes parallax scrolling. Proposed fix is to disable the page level tiling from the QDeclarativeWebview. After that change tiling could be still enabled in global QWebSettings in application code (main.cpp) similarly as currently e.g. AC, if needed by the application. 377247 1 benjamin 2011-03-31 09:39:26 -0700 You mix two concepts very different concepts here: -mobile layout of website -performance I suggest you to clarify what is this bug about. 377250 2 timo.vitikainen 2011-03-31 09:44:49 -0700 (In reply to comment #1) > You mix two concepts very different concepts here: > -mobile layout of website > -performance > > I suggest you to clarify what is this bug about. Perf issue is the main problem and explained here: https://qtrequirements.europe.nokia.com/browse/QT-4834 377258 3 benjamin 2011-03-31 09:50:49 -0700 (In reply to comment #2) > Perf issue is the main problem and explained here: > https://qtrequirements.europe.nokia.com/browse/QT-4834 Ok, so this bug is a meta-bug for many problems. I suggest you to create dependencies for each problem and put the right people in CC for each one. 377669 4 timo.vitikainen 2011-04-01 00:43:00 -0700 (In reply to comment #3) This bug is about perf drops problem in QML WebView. Proposed fix (i.e. disabling of tiling) to that problem also enables QML WebView to get same support for parallax scrolling than now available via QGraphicsWebView (ref. MWC mobile-hybrid-demo on N8). 426864 5 98489 fabrizio.machado 2011-06-24 06:52:01 -0700 Created attachment 98489 Disable tiling in QML WebView 426869 6 benjamin 2011-06-24 06:59:14 -0700 Could you at least share a profile/trace of a reduction so one can see if the patch is the best solution? 426870 7 98489 benjamin 2011-06-24 07:00:52 -0700 Comment on attachment 98489 Disable tiling in QML WebView I clear the review flag. No problem with the patch itself but we need more info in order to make a review. (Note that you should also remove the 2 blank lines before the end of the block). 426880 8 98491 fabrizio.machado 2011-06-24 07:29:07 -0700 Created attachment 98491 remove extraneous whitespace Hi Benjamin, Timo posted the use case in: https://qtrequirements.europe.nokia.com/browse/QT-4834 I don't have any profiling data handy, maybe Timo can chime in if it is necessary. But the impact is severe to the user, and we have observed much improved responsiveness of the demo app with tiling disabled in qml webview. Please let me know if you need further details. Hopefully Timo is reading as well and adds his comments. 427922 9 timo.vitikainen 2011-06-27 07:29:44 -0700 (In reply to comment #8) This patch has clear/visible perf boost for dynamic HTML5 content, see QT-4834. With this patch the default tiling setting in QDeclarativeWebview (QML WebView) and QGraphicsWebview will get aligned for developers, since tiling is currently disabled in QGraphicsWebview used in Qt hybrid apps. After integration of this patch it will be still possible for QML hybrid apps developers to enable tiling (with one code line) if use case/content can get benefit out from that feature. This possibility is currently available for Qt hybrid apps developers. 427933 10 benjamin 2011-06-27 07:55:50 -0700 I don't see any profile on QT-4834 (?). How can a reviewer know if that is not graphics system related for example? This might well be a problem only for the Symbian 3 platform (OpenVG + dedicated memory is a special case of rendering). Maybe a #ifdef for SYMBIAN_3 is necessary, but one cannot tell without a clear profile. 428722 11 timo.vitikainen 2011-06-28 01:36:16 -0700 (In reply to comment #10) Platform (of this bug): S60 Harware, S60 3rd edition. I.e. Symbian 3 platform. 428877 12 98920 fabrizio.machado 2011-06-28 07:48:27 -0700 Created attachment 98920 Disable tiling only for Symbian Thanks TImo. Benjamin, will this fly?? 430372 13 98920 benjamin 2011-06-30 06:48:53 -0700 Comment on attachment 98920 Disable tiling only for Symbian Let's try and see how that behave. 430377 14 98920 webkit.review.bot 2011-06-30 06:59:54 -0700 Comment on attachment 98920 Disable tiling only for Symbian Clearing flags on attachment: 98920 Committed r90113: <http://trac.webkit.org/changeset/90113> 430378 15 webkit.review.bot 2011-06-30 06:59:58 -0700 All reviewed patches have been landed. Closing bug. 431152 16 ademar 2011-07-01 07:46:23 -0700 Revision r90113 cherry-picked into qtwebkit-2.2 with commit 74bcfbc <http://gitorious.org/webkit/qtwebkit/commit/74bcfbc> 98489 2011-06-24 06:52:01 -0700 2011-06-24 07:29:07 -0700 Disable tiling in QML WebView 57554.patch text/plain 1213 fabrizio.machado SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4OTY3MSkKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjQgIEZh YnJpemlvIE1hY2hhZG8gIDxmYWJyaXppby5tYWNoYWRvQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFtRdF0gUU1MIFdl YnZpZXcgY2F1c2VzIHBlcmZvcm1hbmNlIGRyb3BzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzU1NAorCisgICAgICAgIFJlbW92ZSB0aWxlZEJhY2tp bmdTdG9yZUVuYWJsZWQgZnJvbSBRTUwgV2ViVmlldy4KKyAgICAgICAgCisgICAgICAgICogZGVj bGFyYXRpdmUvcWRlY2xhcmF0aXZld2Vidmlldy5jcHA6CisgICAgICAgIChRRGVjbGFyYXRpdmVX ZWJWaWV3OjpzZXRQYWdlKToKKwogMjAxMS0wNi0yMyAgSm9lIFdpbGQgIDxqb3NlcGgud2lsZEBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KSW5kZXg6IFNv dXJjZS9XZWJLaXQvcXQvZGVjbGFyYXRpdmUvcWRlY2xhcmF0aXZld2Vidmlldy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9xZGVjbGFyYXRpdmV3ZWJ2aWV3 LmNwcAkocmV2aXNpb24gODkwMjMpCisrKyBTb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0aXZlL3Fk ZWNsYXJhdGl2ZXdlYnZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03ODIsNyArNzgyLDYgQEAg dm9pZCBRRGVjbGFyYXRpdmVXZWJWaWV3OjpzZXRQYWdlKFFXZWJQYQogCiAgICAgY29ubmVjdChw YWdlLT5tYWluRnJhbWUoKSwgU0lHTkFMKGphdmFTY3JpcHRXaW5kb3dPYmplY3RDbGVhcmVkKCkp LCB0aGlzLCBTTE9UKHdpbmRvd09iamVjdENsZWFyZWQoKSkpOwogCi0gICAgcGFnZS0+c2V0dGlu Z3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6VGlsZWRCYWNraW5nU3RvcmVFbmFibGVk LCB0cnVlKTsKIAogfQogCg== 98491 2011-06-24 07:29:07 -0700 2011-06-28 07:48:27 -0700 remove extraneous whitespace 57554_n2.patch text/plain 1309 fabrizio.machado SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4OTY3MSkKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjQgIEZh YnJpemlvIE1hY2hhZG8gIDxmYWJyaXppby5tYWNoYWRvQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFtRdF0gUU1MIFdl YnZpZXcgY2F1c2VzIHBlcmZvcm1hbmNlIGRyb3BzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzU1NAorCisgICAgICAgIFJlbW92ZSB0aWxlZEJhY2tp bmdTdG9yZUVuYWJsZWQgZnJvbSBRTUwgV2ViVmlldy4KKyAgICAgICAgCisgICAgICAgICogZGVj bGFyYXRpdmUvcWRlY2xhcmF0aXZld2Vidmlldy5jcHA6CisgICAgICAgIChRRGVjbGFyYXRpdmVX ZWJWaWV3OjpzZXRQYWdlKToKKwogMjAxMS0wNi0yMyAgSm9lIFdpbGQgIDxqb3NlcGgud2lsZEBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KSW5kZXg6IFNv dXJjZS9XZWJLaXQvcXQvZGVjbGFyYXRpdmUvcWRlY2xhcmF0aXZld2Vidmlldy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9xZGVjbGFyYXRpdmV3ZWJ2aWV3 LmNwcAkocmV2aXNpb24gODkwMjMpCisrKyBTb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0aXZlL3Fk ZWNsYXJhdGl2ZXdlYnZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03ODEsOSArNzgxLDYgQEAg dm9pZCBRRGVjbGFyYXRpdmVXZWJWaWV3OjpzZXRQYWdlKFFXZWJQYQogICAgIGNvbm5lY3QocGFn ZSwgU0lHTkFMKHN0YXR1c0Jhck1lc3NhZ2UoUVN0cmluZykpLCB0aGlzLCBTTE9UKHNldFN0YXR1 c1RleHQoUVN0cmluZykpKTsKIAogICAgIGNvbm5lY3QocGFnZS0+bWFpbkZyYW1lKCksIFNJR05B TChqYXZhU2NyaXB0V2luZG93T2JqZWN0Q2xlYXJlZCgpKSwgdGhpcywgU0xPVCh3aW5kb3dPYmpl Y3RDbGVhcmVkKCkpKTsKLQotICAgIHBhZ2UtPnNldHRpbmdzKCktPnNldEF0dHJpYnV0ZShRV2Vi U2V0dGluZ3M6OlRpbGVkQmFja2luZ1N0b3JlRW5hYmxlZCwgdHJ1ZSk7Ci0KIH0KIAogLyohCg== 98920 2011-06-28 07:48:27 -0700 2011-06-30 06:59:54 -0700 Disable tiling only for Symbian 57554_n3.patch text/plain 1258 fabrizio.machado SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4OTkyMikKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjggIEZh YnJpemlvIE1hY2hhZG8gIDxmYWJyaXppby5tYWNoYWRvQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFtRdF0gUU1MIFdl YnZpZXcgY2F1c2VzIHBlcmZvcm1hbmNlIGRyb3BzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzU1NAorCisgICAgICAgIFJlbW92ZSB0aWxlZEJhY2tp bmdTdG9yZUVuYWJsZWQgZnJvbSBRTUwgV2ViVmlldy4KKyAgICAgICAgCisgICAgICAgICogZGVj bGFyYXRpdmUvcWRlY2xhcmF0aXZld2Vidmlldy5jcHA6CisgICAgICAgIChRRGVjbGFyYXRpdmVX ZWJWaWV3OjpzZXRQYWdlKToKKwogMjAxMS0wNi0yNyAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5t ZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvZGVjbGFyYXRpdmUvcWRlY2xhcmF0aXZld2Vidmlldy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9xZGVjbGFyYXRp dmV3ZWJ2aWV3LmNwcAkocmV2aXNpb24gODkwMjMpCisrKyBTb3VyY2UvV2ViS2l0L3F0L2RlY2xh cmF0aXZlL3FkZWNsYXJhdGl2ZXdlYnZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03ODIsNyAr NzgyLDkgQEAgdm9pZCBRRGVjbGFyYXRpdmVXZWJWaWV3OjpzZXRQYWdlKFFXZWJQYQogCiAgICAg Y29ubmVjdChwYWdlLT5tYWluRnJhbWUoKSwgU0lHTkFMKGphdmFTY3JpcHRXaW5kb3dPYmplY3RD bGVhcmVkKCkpLCB0aGlzLCBTTE9UKHdpbmRvd09iamVjdENsZWFyZWQoKSkpOwogCisjaWYgIWRl ZmluZWQoUV9PU19TWU1CSUFOKQogICAgIHBhZ2UtPnNldHRpbmdzKCktPnNldEF0dHJpYnV0ZShR V2ViU2V0dGluZ3M6OlRpbGVkQmFja2luZ1N0b3JlRW5hYmxlZCwgdHJ1ZSk7CisjZW5kaWYKIAog fQogCg==