57551 2011-03-31 08:40:17 -0700 [GTK] Expose the shadow DOM to DumpRenderTree JS tests. 2011-04-02 13:56:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 57687 0 dominicc webkit-unassigned commit-queue mrobinson oldest_to_newest 377176 0 dominicc 2011-03-31 08:40:17 -0700 GTK DRT should implement layoutTestController.shadowRoot like Chromium DRT (bug 56573) and Mac DRT (bug 57415). 377269 1 87752 dominicc 2011-03-31 09:58:09 -0700 Created attachment 87752 Patch 377850 2 87752 mrobinson 2011-04-01 09:20:53 -0700 Comment on attachment 87752 Patch Great! Thanks for looking after our DRT. 378087 3 commit-queue 2011-04-01 14:33:46 -0700 The commit-queue encountered the following flaky tests while processing attachment 87752: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 378089 4 87752 commit-queue 2011-04-01 14:36:36 -0700 Comment on attachment 87752 Patch Clearing flags on attachment: 87752 Committed r82721: <http://trac.webkit.org/changeset/82721> 378090 5 commit-queue 2011-04-01 14:36:41 -0700 All reviewed patches have been landed. Closing bug. 378264 6 mrobinson 2011-04-01 18:20:05 -0700 This caused an assertion failure on the debug bots so I rolled it out. I think that you just need to add a JSLock lock(SilenceAssertionsOnly); at the beginning of the DRTSupportGtk method. Sorry that I did not notice this in my review! #0 0x00002b40c08cca85 in JSC::Heap::allocate (this=0x2b40d0019140, bytes=48) at ../../Source/JavaScriptCore/runtime/JSCell.h:415 415 ASSERT(JSLock::lockCount() > 0); Thread 1 (Thread 4222): #0 0x00002b40c08cca85 in JSC::Heap::allocate (this=0x2b40d0019140, bytes=48) at ../../Source/JavaScriptCore/runtime/JSCell.h:415 #1 0x00002b40c08ccbd5 in JSC::JSCell::operator new (size=48, exec=0x2b4114012088) at ../../Source/JavaScriptCore/runtime/JSCell.h:436 #2 0x00002b40c145d344 in WebCore::JSHTMLSelectElement::createPrototype (exec=0x2b4114012088, globalObject=0x2b4114420850) at DerivedSources/WebCore/JSHTMLSelectElement.cpp:179 #3 0x00002b40c141da7b in WebCore::getDOMStructure<WebCore::JSHTMLSelectElement> (exec=0x2b4114012088, globalObject=0x2b4114420850) at ../../Source/WebCore/bindings/js/JSDOMBinding.h:146 #4 0x00002b40c141a177 in WebCore::createDOMNodeWrapper<WebCore::JSHTMLSelectElement, WebCore::HTMLSelectElement> (exec=0x2b4114012088, globalObject=0x2b4114420850, node=0x2b40d097ddb0) at ../../Source/WebCore/bindings/js/JSDOMBinding.h:181 #5 0x00002b40c1411933 in WebCore::createHTMLSelectElementWrapper (exec=0x2b4114012088, globalObject=0x2b4114420850, element=...) at DerivedSources/WebCore/JSHTMLElementWrapperFactory.cpp:517 #6 0x00002b40c1413b30 in WebCore::createJSHTMLWrapper (exec=0x2b4114012088, globalObject=0x2b4114420850, element=...) at DerivedSources/WebCore/JSHTMLElementWrapperFactory.cpp:694 #7 0x00002b40c091d751 in WebCore::createWrapperInline (exec=0x2b4114012088, globalObject=0x2b4114420850, node=0x2b40d097ddb0) at ../../Source/WebCore/bindings/js/JSNodeCustom.cpp:173 #8 0x00002b40c091d984 in WebCore::createWrapper (exec=0x2b4114012088, globalObject=0x2b4114420850, node=0x2b40d097ddb0) at ../../Source/WebCore/bindings/js/JSNodeCustom.cpp:223 #9 0x00002b40c07b2807 in WebCore::toJS (exec=0x2b4114012088, globalObject=0x2b4114420850, node=0x2b40d097ddb0) at ../../Source/WebCore/bindings/js/JSNodeCustom.h:57 #10 0x00002b40c07b34cd in WebCore::toJS<WebCore::Node> (exec=0x2b4114012088, ptr=0x2b40d097ddb0) at ../../Source/WebCore/bindings/js/JSDOMBinding.h:252 #11 0x00002b40c07b0894 in DumpRenderTreeSupportGtk::shadowRoot (context=0x2b4114012088, value=0x2b411442ad80) at ../../Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:647 #12 0x0000000000427da3 in LayoutTestController::shadowRoot (this=0x2b40d08b4790, context=0x2b4114012088, element=0x2b411442ad80) at ../../Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:922 #13 0x0000000000414638 in shadowRootCallback (context=0x2b4114012088, function=0x2b411442af08, thisObject=0x2b411442a648, argumentCount=1, arguments=0x7fff448936b8, exception=0x7fff44893758) at ../../Tools/DumpRenderTree/LayoutTestController.cpp:1695 #14 0x00002b40c1613b60 in JSC::JSCallbackFunction::call (exec=0x2b4114012088) at ../../Source/JavaScriptCore/API/JSCallbackFunction.cpp:67 #15 0x00002b40c16bb2b8 in JSC::cti_op_call_NotJSFunction (args=0x7fff44893890) at ../../Source/JavaScriptCore/jit/JITStubs.cpp:2096 #16 0x00002b40c16b630f in JSC::JITThunks::tryCacheGetByID (callFrame=0x2b4114012038, codeBlock=0x7fff44893890, returnAddress=..., baseValue=..., propertyName=..., slot=..., stubInfo=0x2b40d00178f0) at ../../Source/JavaScriptCore/jit/JITStubs.cpp:871 #17 0x00002b40c16895fd in JSC::JITCode::execute (this=0x2b4114790d68, registerFile=0x2b40d001f668, callFrame=0x2b4114012038, globalData=0x2b40d00178f0) at ../../Source/JavaScriptCore/jit/JITCode.h:77 #18 0x00002b40c16860c6 in JSC::Interpreter::execute (this=0x2b40d001f650, program=0x2b4114790d50, callFrame=0x2b41144208d8, scopeChain=0x2b411442a300, thisObj=0x2b4114414150) at ../../Source/JavaScriptCore/interpreter/Interpreter.cpp:773 #19 0x00002b40c171df7a in JSC::evaluate (exec=0x2b41144208d8, scopeChain=0x2b411442a300, source=..., thisValue=...) at ../../Source/JavaScriptCore/runtime/Completion.cpp:64 #20 0x00002b40c091211f in WebCore::JSMainThreadExecState::evaluate (exec=0x2b41144208d8, chain=0x2b411442a300, source=..., thisValue=...) at ../../Source/WebCore/bindings/js/JSMainThreadExecState.h:54 #21 0x00002b40c093ef36 in WebCore::ScriptController::evaluateInWorld (this=0x1ba40e8, sourceCode=..., world=0x2b40d001f870) at ../../Source/WebCore/bindings/js/ScriptController.cpp:142 #22 0x00002b40c093f0f6 in WebCore::ScriptController::evaluate (this=0x1ba40e8, sourceCode=...) at ../../Source/WebCore/bindings/js/ScriptController.cpp:165 #23 0x00002b40c0b50729 in WebCore::ScriptElement::executeScript (this=0x224bdc0, sourceCode=...) at ../../Source/WebCore/dom/ScriptElement.cpp:268 #24 0x00002b40c0b503fa in WebCore::ScriptElement::prepareScript (this=0x224bdc0, scriptStartPosition=..., supportLegacyTypes=WebCore::ScriptElement::DisallowLegacyTypeInTypeAttribute) at ../../Source/WebCore/dom/ScriptElement.cpp:228 #25 0x00002b40c0cdbb3e in WebCore::HTMLScriptRunner::runScript (this=0x2b40d08c7440, script=0x224bd40, scriptStartPosition=...) at ../../Source/WebCore/html/parser/HTMLScriptRunner.cpp:294 #26 0x00002b40c0cdb1c0 in WebCore::HTMLScriptRunner::execute (this=0x2b40d08c7440, scriptElement=..., scriptStartPosition=...) at ../../Source/WebCore/html/parser/HTMLScriptRunner.cpp:175 #27 0x00002b40c0ccee69 in WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder (this=0x2b40d095acc0) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:206 #28 0x00002b40c0ccef25 in WebCore::HTMLDocumentParser::canTakeNextToken (this=0x2b40d095acc0, mode=WebCore::HTMLDocumentParser::AllowYield, session=...) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:224 #29 0x00002b40c0ccf2c7 in WebCore::HTMLDocumentParser::pumpTokenizer (this=0x2b40d095acc0, mode=WebCore::HTMLDocumentParser::AllowYield) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:262 #30 0x00002b40c0ccecbe in WebCore::HTMLDocumentParser::pumpTokenizerIfPossible (this=0x2b40d095acc0, mode=WebCore::HTMLDocumentParser::AllowYield) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:176 #31 0x00002b40c0ccf70f in WebCore::HTMLDocumentParser::append (this=0x2b40d095acc0, source=...) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:358 #32 0x00002b40c0aa5db9 in WebCore::DecodedDataDocumentParser::appendBytes (this=0x2b40d095acc0, writer=0x2b40d094cd70, data=0x0, length=0, shouldFlush=true) at ../../Source/WebCore/dom/DecodedDataDocumentParser.cpp:54 #33 0x00002b40c0de844f in WebCore::DocumentWriter::addData (this=0x2b40d094cd70, str=0x0, len=0, flush=true) at ../../Source/WebCore/loader/DocumentWriter.cpp:201 #34 0x00002b40c0de8518 in WebCore::DocumentWriter::endIfNotLoadingMainResource (this=0x2b40d094cd70) at ../../Source/WebCore/loader/DocumentWriter.cpp:221 #35 0x00002b40c0de8485 in WebCore::DocumentWriter::end (this=0x2b40d094cd70) at ../../Source/WebCore/loader/DocumentWriter.cpp:207 #36 0x00002b40c0ddc657 in WebCore::DocumentLoader::finishedLoading (this=0x2b40d094cc70) at ../../Source/WebCore/loader/DocumentLoader.cpp:288 #37 0x00002b40c0df4d89 in WebCore::FrameLoader::finishedLoading (this=0x1ba3ca0) at ../../Source/WebCore/loader/FrameLoader.cpp:2230 #38 0x00002b40c0e26e36 in WebCore::MainResourceLoader::didFinishLoading (this=0x2b40d085bc90, finishTime=0) at ../../Source/WebCore/loader/MainResourceLoader.cpp:467 #39 0x00002b40c0e33019 in WebCore::ResourceLoader::didFinishLoading (this=0x2b40d085bc90, finishTime=0) at ../../Source/WebCore/loader/ResourceLoader.cpp:436 #40 0x00002b40c07837c8 in WebCore::readCallback (source=0x1bb7760, asyncResult=0x1b4a520, data=0x0) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:784 #41 0x00002b40c4843f65 in async_ready_callback_wrapper (source_object=0x1bb7760, res=0x1b4a520, user_data=0x0) at /tmp/buildd/glib2.0-2.27.91/./gio/ginputstream.c:470 #42 0x00002b40c4855628 in complete_in_idle_cb_for_thread (_data=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./gio/gsimpleasyncresult.c:812 #43 0x00002b40c53bc362 in g_main_dispatch (context=0x1b26780) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:2440 #44 g_main_context_dispatch (context=0x1b26780) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3013 #45 0x00002b40c53c0a28 in g_main_context_iterate (context=0x1b26780, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3091 #46 0x00002b40c53c0f35 in g_main_loop_run (loop=0x2b40d098e240) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3299 #47 0x00002b40c332f657 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #48 0x000000000041ff30 in runTest (testPathOrURL=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:701 #49 0x000000000041f5cd in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:493 #50 0x000000000042185b in main (argc=2, argv=0x7fff448951a8) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1179 378265 7 mrobinson 2011-04-01 18:21:02 -0700 Here's the rollout: https://bugs.webkit.org/show_bug.cgi?id=57687 378289 8 87956 dominicc 2011-04-01 19:09:08 -0700 Created attachment 87956 Patch 378398 9 dominicc 2011-04-02 10:29:01 -0700 Reopening this. 378406 10 87956 mrobinson 2011-04-02 11:46:43 -0700 Comment on attachment 87956 Patch Thanks for fixing this! 378424 11 87956 commit-queue 2011-04-02 13:56:32 -0700 Comment on attachment 87956 Patch Clearing flags on attachment: 87956 Committed r82774: <http://trac.webkit.org/changeset/82774> 378425 12 commit-queue 2011-04-02 13:56:38 -0700 All reviewed patches have been landed. Closing bug. 87752 2011-03-31 09:58:09 -0700 2011-04-01 19:09:05 -0700 Patch bug-57551-20110331165808.patch text/plain 5436 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogODI1ODIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4YWZlMzFmZDRmOTQyMDhjMDQ3Mzhh MTk2NzU0MDA0ZmQyY2EzYmExLi5lNmY4YWFhMDc4MmU4MWU3Yjk1NTk0YjkxOWNkZjM1NDljYjVj M2UxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMtMzEgIERvbWluaWMgQ29vbmV5ICA8 ZG9taW5pY2NAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2hhZG93Um9vdCB0byBHVEsg RHVtcFJlbmRlclRyZWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NzU1MQorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6IHVuc2tpcCB0 ZXN0IHRoYXQgYWNjZXNzZXMgc2hhZG93Um9vdAorCiAyMDExLTAzLTMxICBQYXZlbCBQb2Rpdmls b3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0 ZSBjaHJvbWl1bSB0ZXN0IGV4cGVjdGF0aW9ucy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5k ZXggMDExYTExODk0ODE4YjY0YWRlNzE3MTA3Nzc0ODk2ZTU4YzVhZWVjYS4uNzk4Nzg3MzEyNThj ZjIxMjEyMGZkNzdjNTA3NTE5YmJmOWU0MWVkYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQK QEAgLTQ3OCwxMCArNDc4LDYgQEAgZmFzdC9jYW52YXMvcGF0dGVybmZpbGwtcmVwZWF0Lmh0bWwK ICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MTM2CiBmYXN0L2h0 bWwva2V5Z2VuLmh0bWwKIAotIyBsYXlvdXRUZXN0Q29udHJvbGxlciBkb2VzIG5vdCBpbXBsZW1l bnQgc2hhZG93Um9vdCBhY2Nlc3NvcgotIyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU2NTczCi1mYXN0L2RvbS9IVE1MS2V5Z2VuRWxlbWVudC9rZXlnZW4uaHRt bAotCiAjIFtHVEtdIEdUSysgZG9lcyBub3Qgc3VwcG9ydCBoeXBoZW5hdGlvbgogIyBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ0NzgKIGZhc3QvdGV4dC9oeXBoZW5h dGUtY2hhcmFjdGVyLmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBmNmExZTM0YjFhMTM3NDJhN2Rj YWNiNDlmMTkzMGE2NDkzNTk5ZGMxLi5lYjg1ZDE1N2VkY2VjNGRmY2ZmOGIwMWJiN2YzM2YwMGNi MDliNGViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMtMzEgIERv bWluaWMgQ29vbmV5ICA8ZG9taW5pY2NAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2hh ZG93Um9vdCB0byBHVEsgRHVtcFJlbmRlclRyZWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzU1MQorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQv RHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3Vw cG9ydEd0azo6c2hhZG93Um9vdCk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRl clRyZWVTdXBwb3J0R3RrLmg6CisKIDIwMTEtMDMtMzEgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgQnVpbGQgZml4IGZyb20gcHJldmlvdXMgY2hhbmdlLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVT dXBwb3J0R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydEd0ay5jcHAKaW5kZXggMTMzNmYxMTg2MWFlMDRlZWE4NjQwYzNhZjIxYjA5 NjFhNjU3NDYzZS4uNmQ5NDkzODQzNTkxYTU3MjU1NWRmYjg2M2NkMzFiYWVkMmU0OTA4NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVT dXBwb3J0R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1w UmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwCkBAIC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSAiQW5p bWF0aW9uQ29udHJvbGxlci5oIgogI2luY2x1ZGUgIkRPTVdyYXBwZXJXb3JsZC5oIgogI2luY2x1 ZGUgIkRvY3VtZW50LmgiCisjaW5jbHVkZSAiRWxlbWVudC5oIgogI2luY2x1ZGUgIkZvY3VzQ29u dHJvbGxlci5oIgogI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50R3RrLmgiCiAjaW5jbHVkZSAi RnJhbWVUcmVlLmgiCkBAIC02MzYsNiArNjM3LDE2IEBAIHZvaWQgRHVtcFJlbmRlclRyZWVTdXBw b3J0R3RrOjpjbGVhck9wZW5lcihXZWJLaXRXZWJGcmFtZSogZnJhbWUpCiAgICAgICAgIGNvcmVG cmFtZS0+bG9hZGVyKCktPnNldE9wZW5lcigwKTsKIH0KIAorSlNWYWx1ZVJlZiBEdW1wUmVuZGVy VHJlZVN1cHBvcnRHdGs6OnNoYWRvd1Jvb3QoSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTVmFsdWVS ZWYgdmFsdWUpCit7CisgICAgSlNDOjpFeGVjU3RhdGUqIGV4ZWMgPSB0b0pTKGNvbnRleHQpOwor ICAgIEVsZW1lbnQqIGVsZW1lbnQgPSB0b0VsZW1lbnQodG9KUyhleGVjLCB2YWx1ZSkpOworICAg IGlmICghZWxlbWVudCkKKyAgICAgIHJldHVybiBKU1ZhbHVlTWFrZU51bGwoY29udGV4dCk7CisK KyAgICByZXR1cm4gdG9SZWYoZXhlYywgdG9KUyhleGVjLCBlbGVtZW50LT5zaGFkb3dSb290KCkp KTsKK30KKwogdW5zaWduZWQgaW50IER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6d29ya2VyVGhy ZWFkQ291bnQoKQogewogI2lmIEVOQUJMRShXT1JLRVJTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmggYi9Tb3Vy Y2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuaApp bmRleCA3YWQ1YWY2MGUyOTcwYzgzZTI0YzYyNDFkZjg1OWUyYTgzZmE4NjA5Li5kOGRkMDlmZjdh NDhmZWVkYmVjNzZjZjZlYTU5ZTA3OTFmMmM0NDBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuaApA QCAtNjEsNiArNjEsOCBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgdm9pZCBjbGVhck9wZW5lcihX ZWJLaXRXZWJGcmFtZSopOwogCisgICAgc3RhdGljIEpTVmFsdWVSZWYgc2hhZG93Um9vdChKU0Nv bnRleHRSZWYsIEpTVmFsdWVSZWYpOworCiAgICAgLy8gRklYTUU6IE1vdmUgdGhlc2UgdG8gd2Vi a2l0d2ViZnJhbWUuaCBvbmNlIHRoZWlyIEFQSSBoYXMgYmVlbiBkaXNjdXNzZWQuCiAgICAgc3Rh dGljIEdTTGlzdCogZ2V0RnJhbWVDaGlsZHJlbihXZWJLaXRXZWJGcmFtZSopOwogICAgIHN0YXRp YyBXVEY6OkNTdHJpbmcgZ2V0SW5uZXJUZXh0KFdlYktpdFdlYkZyYW1lKik7CmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjE4YjY0ZmZmMmFmZTU4 NTViYzYwYjU2MmUwMTM0NDBkZTk0OWRjMi4uMTU0ZjViNjZkMzJhMDRkNTEwODNjMTBhYTQ2M2U3 NWZiZjlhZDJlMSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAzLTMxICBEb21pbmljIENvb25leSAgPGRvbWlu aWNjQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIGxheW91dFRlc3RDb250cm9sbGVyLnNoYWRvd1Jvb3QgdG8gR1RLIER1bXBS ZW5kZXJUcmVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTc1NTEKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJv bGxlckd0ay5jcHA6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2hhZG93Um9vdCk6 CisKIDIwMTEtMDMtMzEgIFZhbXNoaWtyaXNobmEuWWVsbGVua2kgIDx2YW1zaGlAbW90b3JvbGEu Y29tPiBhbmQgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9sbGVyR3RrLmNwcAppbmRleCA4NDkyMDVhM2VmYzQ2 MDQxMzI4YTc1YjVlZjQ2NTQ5Y2IxODczYjAxLi4wOTc5ZGQ1YzAzNmU1Y2Q5YTE3NjVmYmY5YzU4 OWU3YzZlMDEyMGExIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0 VGVzdENvbnRyb2xsZXJHdGsuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlv dXRUZXN0Q29udHJvbGxlckd0ay5jcHAKQEAgLTkxNywxMCArOTE3LDkgQEAgdm9pZCBMYXlvdXRU ZXN0Q29udHJvbGxlcjo6c2V0RWRpdGluZ0JlaGF2aW9yKGNvbnN0IGNoYXIqIGVkaXRpbmdCZWhh dmlvcikKICAgICAgICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNUKHNldHRpbmdzKSwgImVkaXRpbmct YmVoYXZpb3IiLCBXRUJLSVRfRURJVElOR19CRUhBVklPUl9VTklYLCBOVUxMKTsKIH0KIAotSlNW YWx1ZVJlZiBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2hhZG93Um9vdChKU0NvbnRleHRSZWYgY29u dGV4dCwgSlNWYWx1ZVJlZiBqc0VsZW1lbnQpCitKU1ZhbHVlUmVmIExheW91dFRlc3RDb250cm9s bGVyOjpzaGFkb3dSb290KEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU1ZhbHVlUmVmIGVsZW1lbnQp CiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudCB0aGlzLgotICAgIHJldHVybiBKU1ZhbHVlTWFr ZVVuZGVmaW5lZChjb250ZXh0KTsKKyAgICByZXR1cm4gRHVtcFJlbmRlclRyZWVTdXBwb3J0R3Rr OjpzaGFkb3dSb290KGNvbnRleHQsIGVsZW1lbnQpOwogfQogCiB2b2lkIExheW91dFRlc3RDb250 cm9sbGVyOjphYm9ydE1vZGFsKCkK 87956 2011-04-01 19:09:08 -0700 2011-04-02 13:56:32 -0700 Patch bug-57551-20110402020906.patch text/plain 5430 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogODI3NTcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3NDQ1NTExMzYyZjcwNjUwMmVkOTdk NDcxNzRmYWMzY2E4ZDYxMTJjLi5mMDMxZTQ2MDdhZDk1NDYyMjdhYzA1NDk2OWJmYTg0MTk0MTE4 YTQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMtMzEgIERvbWluaWMgQ29vbmV5ICA8 ZG9taW5pY2NAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2hhZG93Um9vdCB0byBHVEsg RHVtcFJlbmRlclRyZWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NzU1MQorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6IHVuc2tpcCB0 ZXN0IHRoYXQgYWNjZXNzZXMgc2hhZG93Um9vdAorCiAyMDExLTA0LTAxICBTaGVyaWZmIEJvdCAg PHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByODI3MjEuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tp cHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmluZGV4IDRjZjE0NDRkZTIw ZTMxOThmNTIwNzA2NDhmOWU3ZjZlNzhkNWFkMDIuLjZmMjliYzRkZmE5Y2NiNTI1YzE3MjM5ODlm NGUxOWE1ZmEwMjA3MmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lw cGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCkBAIC00NzgsMTAgKzQ3 OCw2IEBAIGZhc3QvY2FudmFzL3BhdHRlcm5maWxsLXJlcGVhdC5odG1sCiAjIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDEzNgogZmFzdC9odG1sL2tleWdlbi5odG1s CiAKLSMgbGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50IHNoYWRvd1Jvb3Qg YWNjZXNzb3IKLSMgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NjU3MwotZmFzdC9kb20vSFRNTEtleWdlbkVsZW1lbnQva2V5Z2VuLmh0bWwKLQogIyBbR1RLXSBH VEsrIGRvZXMgbm90IHN1cHBvcnQgaHlwaGVuYXRpb24KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ0NDc4CiBmYXN0L3RleHQvaHlwaGVuYXRlLWNoYXJhY3Rlci5o dG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggYTExMzIzNzgzYzY3YjExNGY3NDY4NDBiN2UxMGE3ODY3 ODliMDBmNi4uMjQ4MWQxMDM1MjMzZWRhNTQzNDdjYzRhZTc1MDM1NGM2MTk0NmQzYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTAzLTMxICBEb21pbmljIENvb25leSAg PGRvbWluaWNjQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGxheW91dFRlc3RDb250cm9sbGVyLnNoYWRvd1Jvb3QgdG8gR1RL IER1bXBSZW5kZXJUcmVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTc1NTEKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydEd0ay5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OnNoYWRv d1Jvb3QpOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0 ay5oOgorCiAyMDExLTA0LTAxICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWls LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByODI3MjEuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRHdGsuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRy ZWVTdXBwb3J0R3RrLmNwcAppbmRleCAxMzM2ZjExODYxYWUwNGVlYTg2NDBjM2FmMjFiMDk2MWE2 NTc0NjNlLi44MTc0OWVjMTlkOTMwNzJkMzNjMDBmNWE4ZTU1ZjNlMDRjMTM4NDc1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydEd0ay5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKICNpbmNsdWRlICJBbmltYXRp b25Db250cm9sbGVyLmgiCiAjaW5jbHVkZSAiRE9NV3JhcHBlcldvcmxkLmgiCiAjaW5jbHVkZSAi RG9jdW1lbnQuaCIKKyNpbmNsdWRlICJFbGVtZW50LmgiCiAjaW5jbHVkZSAiRm9jdXNDb250cm9s bGVyLmgiCiAjaW5jbHVkZSAiRnJhbWVMb2FkZXJDbGllbnRHdGsuaCIKICNpbmNsdWRlICJGcmFt ZVRyZWUuaCIKQEAgLTYzNiw2ICs2MzcsMTcgQEAgdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRH dGs6OmNsZWFyT3BlbmVyKFdlYktpdFdlYkZyYW1lKiBmcmFtZSkKICAgICAgICAgY29yZUZyYW1l LT5sb2FkZXIoKS0+c2V0T3BlbmVyKDApOwogfQogCitKU1ZhbHVlUmVmIER1bXBSZW5kZXJUcmVl U3VwcG9ydEd0azo6c2hhZG93Um9vdChKU0NvbnRleHRSZWYgY29udGV4dCwgSlNWYWx1ZVJlZiB2 YWx1ZSkKK3sKKyAgICBKU0xvY2sgbG9jayhTaWxlbmNlQXNzZXJ0aW9uc09ubHkpOworICAgIEpT Qzo6RXhlY1N0YXRlKiBleGVjID0gdG9KUyhjb250ZXh0KTsKKyAgICBFbGVtZW50KiBlbGVtZW50 ID0gdG9FbGVtZW50KHRvSlMoZXhlYywgdmFsdWUpKTsKKyAgICBpZiAoIWVsZW1lbnQpCisgICAg ICByZXR1cm4gSlNWYWx1ZU1ha2VOdWxsKGNvbnRleHQpOworCisgICAgcmV0dXJuIHRvUmVmKGV4 ZWMsIHRvSlMoZXhlYywgZWxlbWVudC0+c2hhZG93Um9vdCgpKSk7Cit9CisKIHVuc2lnbmVkIGlu dCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OndvcmtlclRocmVhZENvdW50KCkKIHsKICNpZiBF TkFCTEUoV09SS0VSUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5oIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29y ZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKaW5kZXggN2FkNWFmNjBlMjk3MGM4 M2UyNGM2MjQxZGY4NTllMmE4M2ZhODYwOS4uZDhkZDA5ZmY3YTQ4ZmVlZGJlYzc2Y2Y2ZWE1OWUw NzkxZjJjNDQwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQv RHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKKysrIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29y ZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKQEAgLTYxLDYgKzYxLDggQEAgcHVi bGljOgogCiAgICAgc3RhdGljIHZvaWQgY2xlYXJPcGVuZXIoV2ViS2l0V2ViRnJhbWUqKTsKIAor ICAgIHN0YXRpYyBKU1ZhbHVlUmVmIHNoYWRvd1Jvb3QoSlNDb250ZXh0UmVmLCBKU1ZhbHVlUmVm KTsKKwogICAgIC8vIEZJWE1FOiBNb3ZlIHRoZXNlIHRvIHdlYmtpdHdlYmZyYW1lLmggb25jZSB0 aGVpciBBUEkgaGFzIGJlZW4gZGlzY3Vzc2VkLgogICAgIHN0YXRpYyBHU0xpc3QqIGdldEZyYW1l Q2hpbGRyZW4oV2ViS2l0V2ViRnJhbWUqKTsKICAgICBzdGF0aWMgV1RGOjpDU3RyaW5nIGdldElu bmVyVGV4dChXZWJLaXRXZWJGcmFtZSopOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIv VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDM2OWU0YjZhMDEzODFiOTc5NmJhYWYyNmQ0N2E5YzkwNDlh YTc3ZGUuLjRkMmQ0NDFmMTQwODJlOTM1YmM0YTMwOTQ5YzFjNGYwNGE3MzA5MjAgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBA QAorMjAxMS0wMy0zMSAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0Bnb29nbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsYXlvdXRU ZXN0Q29udHJvbGxlci5zaGFkb3dSb290IHRvIEdUSyBEdW1wUmVuZGVyVHJlZS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NTUxCisKKyAgICAgICAg KiBEdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwOgorICAgICAg ICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNoYWRvd1Jvb3QpOgorCiAyMDExLTA0LTAxICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByODI3MjEuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv Z3RrL0xheW91dFRlc3RDb250cm9sbGVyR3RrLmNwcAppbmRleCA4NDkyMDVhM2VmYzQ2MDQxMzI4 YTc1YjVlZjQ2NTQ5Y2IxODczYjAxLi4wOTc5ZGQ1YzAzNmU1Y2Q5YTE3NjVmYmY5YzU4OWU3YzZl MDEyMGExIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENv bnRyb2xsZXJHdGsuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0 Q29udHJvbGxlckd0ay5jcHAKQEAgLTkxNywxMCArOTE3LDkgQEAgdm9pZCBMYXlvdXRUZXN0Q29u dHJvbGxlcjo6c2V0RWRpdGluZ0JlaGF2aW9yKGNvbnN0IGNoYXIqIGVkaXRpbmdCZWhhdmlvcikK ICAgICAgICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNUKHNldHRpbmdzKSwgImVkaXRpbmctYmVoYXZp b3IiLCBXRUJLSVRfRURJVElOR19CRUhBVklPUl9VTklYLCBOVUxMKTsKIH0KIAotSlNWYWx1ZVJl ZiBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2hhZG93Um9vdChKU0NvbnRleHRSZWYgY29udGV4dCwg SlNWYWx1ZVJlZiBqc0VsZW1lbnQpCitKU1ZhbHVlUmVmIExheW91dFRlc3RDb250cm9sbGVyOjpz aGFkb3dSb290KEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU1ZhbHVlUmVmIGVsZW1lbnQpCiB7Ci0g ICAgLy8gRklYTUU6IEltcGxlbWVudCB0aGlzLgotICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVm aW5lZChjb250ZXh0KTsKKyAgICByZXR1cm4gRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpzaGFk b3dSb290KGNvbnRleHQsIGVsZW1lbnQpOwogfQogCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVy OjphYm9ydE1vZGFsKCkK