57550 2011-03-31 08:32:10 -0700 Rename BidiResolver::lastBeforeET to m_lastBeforeET to match modern style 2011-03-31 15:15:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth commit-queue eric rniwa webkit.review.bot oldest_to_newest 377172 0 eric 2011-03-31 08:32:10 -0700 Rename BidiResolver::lastBeforeET to m_lastBeforeET to match modern style 377173 1 87731 eric 2011-03-31 08:32:55 -0700 Created attachment 87731 Patch 377174 2 87731 commit-queue 2011-03-31 08:37:13 -0700 Comment on attachment 87731 Patch Rejecting attachment 87731 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2 Last 500 characters of output: fs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/text/BidiResolver.h Hunk #1 FAILED at 213. Hunk #5 FAILED at 905. Hunk #6 FAILED at 951. Hunk #7 FAILED at 975. Hunk #8 FAILED at 990. 5 out of 8 hunks FAILED -- saving rejects to file Source/WebCore/platform/text/BidiResolver.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8309377 377457 3 87731 commit-queue 2011-03-31 14:33:27 -0700 Comment on attachment 87731 Patch Clearing flags on attachment: 87731 Committed r82618: <http://trac.webkit.org/changeset/82618> 377458 4 commit-queue 2011-03-31 14:33:32 -0700 All reviewed patches have been landed. Closing bug. 377488 5 webkit.review.bot 2011-03-31 15:15:34 -0700 http://trac.webkit.org/changeset/82618 might have broken Qt Linux Release 87731 2011-03-31 08:32:55 -0700 2011-03-31 14:33:27 -0700 Patch bug-57550-20110331173253.patch text/plain 5150 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODI1NzYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMWYxZDA1MTNkODRkOTRj NmUyZmMxYTgwYzZkZjU0NDk5YjZlZWM1Li5hNWY4N2E0NDJkNTdlODExYTQ5Yjc0YzYwYTMxN2M2 YjMzN2M5MDFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTYgQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBSZW5hbWUgQmlkaVJlc29sdmVyOjpsYXN0 QmVmb3JlRVQgdG8gbV9sYXN0QmVmb3JlRVQgdG8gbWF0Y2ggbW9kZXJuIHN0eWxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzU1MAorCisgICAgICAg ICogcGxhdGZvcm0vdGV4dC9CaWRpUmVzb2x2ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6Ojo6Y3Jl YXRlQmlkaVJ1bnNGb3JMaW5lKToKKworMjAxMS0wMy0zMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAg ICAgUmVuYW1lIEJpZGlSZXNvbHZlcjo6ZW1wdHlSdW4gdG8gbV9lbXRweVJ1biB0byBtYXRjaCBt b2Rlcm4gc3R5bGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU3NTQ5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvQmlk aVJlc29sdmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0JpZGlSZXNvbHZlci5o CmluZGV4IGFhYjhhODVmMTcyNzc0OTkwZDUxNzZiODQ0OGFiMDQ3YWNkMTM4MjQuLmY3MzM0NjVi ZjRmYjQ0M2VhZmMwNzIxNGY1YWIwOTQ1NDJjYzU4OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3RleHQvQmlkaVJlc29sdmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vdGV4dC9CaWRpUmVzb2x2ZXIuaApAQCAtMjEzLDcgKzIxMyw3IEBAIHByb3RlY3RlZDoK ICAgICBXVEY6OlVuaWNvZGU6OkRpcmVjdGlvbiBtX2RpcmVjdGlvbjsKICAgICBJdGVyYXRvciBl bmRPZkxpbmU7CiAgICAgYm9vbCBtX3JlYWNoZWRFbmRPZkxpbmU7Ci0gICAgSXRlcmF0b3IgbGFz dEJlZm9yZUVUOworICAgIEl0ZXJhdG9yIG1fbGFzdEJlZm9yZUVUOyAvLyBCZWZvcmUgYSBFdXJv cGVhbk51bWJlclRlcm1pbmF0b3IKICAgICBib29sIG1fZW1wdHlSdW47CiAKICAgICBSdW4qIG1f Zmlyc3RSdW47CkBAIC04MTgsNyArODE4LDcgQEAgdm9pZCBCaWRpUmVzb2x2ZXI8SXRlcmF0b3Is IFJ1bj46OmNyZWF0ZUJpZGlSdW5zRm9yTGluZShjb25zdCBJdGVyYXRvciYgZW5kLCBWaXMKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gVGVybWluYXRlIHRoZSBFTiBydW4uCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFwcGVuZFJ1bigpOwogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAvLyBNYWtlIGFuIFIgcnVuLgotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBtX2VvciA9IG1fc3RhdHVzLmxhc3QgPT0gRXVyb3BlYW5OdW1iZXJUZXJt aW5hdG9yID8gbGFzdEJlZm9yZUVUIDogbV9sYXN0OworICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBtX2VvciA9IG1fc3RhdHVzLmxhc3QgPT0gRXVyb3BlYW5OdW1iZXJUZXJtaW5hdG9y ID8gbV9sYXN0QmVmb3JlRVQgOiBtX2xhc3Q7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIG1fZGlyZWN0aW9uID0gUmlnaHRUb0xlZnQ7CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGFwcGVuZFJ1bigpOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvLyBC ZWdpbiBhIG5ldyBFTiBydW4uCkBAIC04MjksNyArODI5LDcgQEAgdm9pZCBCaWRpUmVzb2x2ZXI8 SXRlcmF0b3IsIFJ1bj46OmNyZWF0ZUJpZGlSdW5zRm9yTGluZShjb25zdCBJdGVyYXRvciYgZW5k LCBWaXMKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhcHBlbmRSdW4oKTsKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpZiAobV9zdGF0dXMubGFzdFN0cm9uZyA9PSBSaWdodFRvTGVm dCB8fCBjb250ZXh0KCktPmRpcigpID09IFJpZ2h0VG9MZWZ0KSB7CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIC8vIE1ha2UgYW4gUiBydW4uCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIG1fZW9yID0gbV9zdGF0dXMubGFzdCA9PSBFdXJvcGVhbk51bWJlclRlcm1pbmF0 b3IgPyBsYXN0QmVmb3JlRVQgOiBtX2xhc3Q7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIG1fZW9yID0gbV9zdGF0dXMubGFzdCA9PSBFdXJvcGVhbk51bWJlclRlcm1pbmF0b3IgPyBt X2xhc3RCZWZvcmVFVCA6IG1fbGFzdDsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bV9kaXJlY3Rpb24gPSBSaWdodFRvTGVmdDsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYXBwZW5kUnVuKCk7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8vIEJlZ2lu IGEgbmV3IEVOIHJ1bi4KQEAgLTgzNyw3ICs4MzcsNyBAQCB2b2lkIEJpZGlSZXNvbHZlcjxJdGVy YXRvciwgUnVuPjo6Y3JlYXRlQmlkaVJ1bnNGb3JMaW5lKGNvbnN0IEl0ZXJhdG9yJiBlbmQsIFZp cwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgICAg IH0gZWxzZSBpZiAobV9zdGF0dXMubGFzdFN0cm9uZyA9PSBSaWdodFRvTGVmdCkgewogICAgICAg ICAgICAgICAgICAgICAgICAgICAgIC8vIEV4dGVuZCB0aGUgUiBydW4gdG8gaW5jbHVkZSB0aGUg bmV1dHJhbHMuCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgbV9lb3IgPSBtX3N0YXR1cy5s YXN0ID09IEV1cm9wZWFuTnVtYmVyVGVybWluYXRvciA/IGxhc3RCZWZvcmVFVCA6IG1fbGFzdDsK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICBtX2VvciA9IG1fc3RhdHVzLmxhc3QgPT0gRXVy b3BlYW5OdW1iZXJUZXJtaW5hdG9yID8gbV9sYXN0QmVmb3JlRVQgOiBtX2xhc3Q7CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbV9kaXJlY3Rpb24gPSBSaWdodFRvTGVmdDsKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBhcHBlbmRSdW4oKTsKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAvLyBCZWdpbiBhIG5ldyBFTiBydW4uCkBAIC05MDUsNyArOTA1LDcgQEAgdm9pZCBCaWRp UmVzb2x2ZXI8SXRlcmF0b3IsIFJ1bj46OmNyZWF0ZUJpZGlSdW5zRm9yTGluZShjb25zdCBJdGVy YXRvciYgZW5kLCBWaXMKICAgICAgICAgICAgICAgICBtX2VvciA9IG1fY3VycmVudDsKICAgICAg ICAgICAgICAgICBtX3N0YXR1cy5lb3IgPSBkaXJDdXJyZW50OwogICAgICAgICAgICAgfSBlbHNl IGlmIChtX3N0YXR1cy5sYXN0ICE9IEV1cm9wZWFuTnVtYmVyVGVybWluYXRvcikKLSAgICAgICAg ICAgICAgICBsYXN0QmVmb3JlRVQgPSBtX2VtcHR5UnVuID8gbV9lb3IgOiBtX2xhc3Q7CisgICAg ICAgICAgICAgICAgbV9sYXN0QmVmb3JlRVQgPSBtX2VtcHR5UnVuID8gbV9lb3IgOiBtX2xhc3Q7 CiAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICAvLyBib3VuZGFyeSBuZXV0cmFscyBzaG91 bGQgYmUgaWdub3JlZApAQCAtOTUxLDcgKzk1MSw3IEBAIHZvaWQgQmlkaVJlc29sdmVyPEl0ZXJh dG9yLCBSdW4+OjpjcmVhdGVCaWRpUnVuc0ZvckxpbmUoY29uc3QgSXRlcmF0b3ImIGVuZCwgVmlz CiAgICAgICAgICAgICBtX2VvciA9IHN0YXRlQXRFbmQubV9lb3I7CiAgICAgICAgICAgICBtX2xh c3QgPSBzdGF0ZUF0RW5kLm1fbGFzdDsKICAgICAgICAgICAgIG1fcmVhY2hlZEVuZE9mTGluZSA9 IHN0YXRlQXRFbmQubV9yZWFjaGVkRW5kT2ZMaW5lOwotICAgICAgICAgICAgbGFzdEJlZm9yZUVU ID0gc3RhdGVBdEVuZC5sYXN0QmVmb3JlRVQ7CisgICAgICAgICAgICBtX2xhc3RCZWZvcmVFVCA9 IHN0YXRlQXRFbmQubV9sYXN0QmVmb3JlRVQ7CiAgICAgICAgICAgICBtX2VtcHR5UnVuID0gc3Rh dGVBdEVuZC5tX2VtcHR5UnVuOwogICAgICAgICAgICAgbV9kaXJlY3Rpb24gPSBPdGhlck5ldXRy YWw7CiAgICAgICAgICAgICBicmVhazsKQEAgLTk3NSw3ICs5NzUsNyBAQCB2b2lkIEJpZGlSZXNv bHZlcjxJdGVyYXRvciwgUnVuPjo6Y3JlYXRlQmlkaVJ1bnNGb3JMaW5lKGNvbnN0IEl0ZXJhdG9y JiBlbmQsIFZpcwogICAgICAgICAgICAgICAgIG1fZW9yID0gc3RhdGVBdEVuZC5tX2VvcjsKICAg ICAgICAgICAgICAgICBtX2xhc3QgPSBzdGF0ZUF0RW5kLm1fbGFzdDsKICAgICAgICAgICAgICAg ICBtX3JlYWNoZWRFbmRPZkxpbmUgPSBzdGF0ZUF0RW5kLm1fcmVhY2hlZEVuZE9mTGluZTsKLSAg ICAgICAgICAgICAgICBsYXN0QmVmb3JlRVQgPSBzdGF0ZUF0RW5kLmxhc3RCZWZvcmVFVDsKKyAg ICAgICAgICAgICAgICBtX2xhc3RCZWZvcmVFVCA9IHN0YXRlQXRFbmQubV9sYXN0QmVmb3JlRVQ7 CiAgICAgICAgICAgICAgICAgbV9lbXB0eVJ1biA9IHN0YXRlQXRFbmQubV9lbXB0eVJ1bjsKICAg ICAgICAgICAgICAgICBtX2RpcmVjdGlvbiA9IE90aGVyTmV1dHJhbDsKICAgICAgICAgICAgICAg ICBicmVhazsKQEAgLTk5MCw3ICs5OTAsNyBAQCB2b2lkIEJpZGlSZXNvbHZlcjxJdGVyYXRvciwg UnVuPjo6Y3JlYXRlQmlkaVJ1bnNGb3JMaW5lKGNvbnN0IEl0ZXJhdG9yJiBlbmQsIFZpcwogICAg ICAgICAgICAgc3RhdGVBdEVuZC5tX2VvciA9IG1fZW9yOwogICAgICAgICAgICAgc3RhdGVBdEVu ZC5tX2xhc3QgPSBtX2xhc3Q7CiAgICAgICAgICAgICBzdGF0ZUF0RW5kLm1fcmVhY2hlZEVuZE9m TGluZSA9IG1fcmVhY2hlZEVuZE9mTGluZTsKLSAgICAgICAgICAgIHN0YXRlQXRFbmQubGFzdEJl Zm9yZUVUID0gbGFzdEJlZm9yZUVUOworICAgICAgICAgICAgc3RhdGVBdEVuZC5tX2xhc3RCZWZv cmVFVCA9IG1fbGFzdEJlZm9yZUVUOwogICAgICAgICAgICAgc3RhdGVBdEVuZC5tX2VtcHR5UnVu ID0gbV9lbXB0eVJ1bjsKICAgICAgICAgICAgIGVuZE9mTGluZSA9IG1fbGFzdDsKICAgICAgICAg ICAgIHBhc3RFbmQgPSB0cnVlOwo=