57549 2011-03-31 08:25:53 -0700 Rename BidiResolver::emptyRun to m_emtpyRun to match modern style 2011-03-31 10:26:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth commit-queue rniwa oldest_to_newest 377167 0 eric 2011-03-31 08:25:53 -0700 Rename BidiResolver::emptyRun to m_emtpyRun to match modern style 377169 1 87730 eric 2011-03-31 08:27:13 -0700 Created attachment 87730 Patch 377296 2 87730 commit-queue 2011-03-31 10:26:12 -0700 Comment on attachment 87730 Patch Clearing flags on attachment: 87730 Committed r82597: <http://trac.webkit.org/changeset/82597> 377297 3 commit-queue 2011-03-31 10:26:17 -0700 All reviewed patches have been landed. Closing bug. 87730 2011-03-31 08:27:13 -0700 2011-03-31 10:26:12 -0700 Patch bug-57549-20110331172710.patch text/plain 7404 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODI1NzYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1M2FhOWM1ZDI2NTAyZjk2 ZWY1YTA0MTViMGQ5MWM3NDEwODQwMDgxLi4xMWYxZDA1MTNkODRkOTRjNmUyZmMxYTgwYzZkZjU0 NDk5YjZlZWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDMtMzEgIEVyaWMg U2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlbmFtZSBCaWRpUmVzb2x2ZXI6OmVtcHR5UnVuIHRvIG1fZW10 cHlSdW4gdG8gbWF0Y2ggbW9kZXJuIHN0eWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01NzU0OQorCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9CaWRp UmVzb2x2ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkJpZGlSZXNvbHZlcjo6QmlkaVJlc29sdmVy KToKKyAgICAgICAgKFdlYkNvcmU6Ojo6YXBwZW5kUnVuKToKKyAgICAgICAgKFdlYkNvcmU6Ojo6 bG93ZXJFeHBsaWNpdEVtYmVkZGluZ0xldmVsKToKKyAgICAgICAgKFdlYkNvcmU6Ojo6cmFpc2VF eHBsaWNpdEVtYmVkZGluZ0xldmVsKToKKyAgICAgICAgKFdlYkNvcmU6Ojo6ZGVsZXRlUnVucyk6 CisgICAgICAgIChXZWJDb3JlOjo6OmNyZWF0ZUJpZGlSdW5zRm9yTGluZSk6CisgICAgICAgICog cmVuZGVyaW5nL0lubGluZUl0ZXJhdG9yLmg6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVCaWRp UmVzb2x2ZXI6OmFwcGVuZFJ1bik6CisKIDIwMTEtMDMtMzEgIFNoZXJpZmYgQm90ICA8d2Via2l0 LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHI4MjU2NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvQmlkaVJl c29sdmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0JpZGlSZXNvbHZlci5oCmlu ZGV4IDViOTJlZTJjYmVkMTViZjJlNDczZDA2ZmEwOTI0NWNmNWMwMWI5YWUuLmFhYjhhODVmMTcy Nzc0OTkwZDUxNzZiODQ0OGFiMDQ3YWNkMTM4MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3RleHQvQmlkaVJlc29sdmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vdGV4dC9CaWRpUmVzb2x2ZXIuaApAQCAtMTUzLDcgKzE1Myw3IEBAIHB1YmxpYzoKICAgICBC aWRpUmVzb2x2ZXIoKQogICAgICAgICA6IG1fZGlyZWN0aW9uKFdURjo6VW5pY29kZTo6T3RoZXJO ZXV0cmFsKQogICAgICAgICAsIG1fcmVhY2hlZEVuZE9mTGluZShmYWxzZSkKLSAgICAgICAgLCBl bXB0eVJ1bih0cnVlKQorICAgICAgICAsIG1fZW1wdHlSdW4odHJ1ZSkKICAgICAgICAgLCBtX2Zp cnN0UnVuKDApCiAgICAgICAgICwgbV9sYXN0UnVuKDApCiAgICAgICAgICwgbV9sb2dpY2FsbHlM YXN0UnVuKDApCkBAIC0yMTQsNyArMjE0LDcgQEAgcHJvdGVjdGVkOgogICAgIEl0ZXJhdG9yIGVu ZE9mTGluZTsKICAgICBib29sIG1fcmVhY2hlZEVuZE9mTGluZTsKICAgICBJdGVyYXRvciBsYXN0 QmVmb3JlRVQ7Ci0gICAgYm9vbCBlbXB0eVJ1bjsKKyAgICBib29sIG1fZW1wdHlSdW47CiAKICAg ICBSdW4qIG1fZmlyc3RSdW47CiAgICAgUnVuKiBtX2xhc3RSdW47CkBAIC0zMDYsNyArMzA2LDcg QEAgaW5saW5lIHZvaWQgQmlkaVJlc29sdmVyPEl0ZXJhdG9yLCBSdW4+Ojptb3ZlUnVuVG9CZWdp bm5pbmcoUnVuKiBydW4pCiB0ZW1wbGF0ZSA8Y2xhc3MgSXRlcmF0b3IsIGNsYXNzIFJ1bj4KIHZv aWQgQmlkaVJlc29sdmVyPEl0ZXJhdG9yLCBSdW4+OjphcHBlbmRSdW4oKQogewotICAgIGlmICgh ZW1wdHlSdW4gJiYgIW1fZW9yLmF0RW5kKCkpIHsKKyAgICBpZiAoIW1fZW1wdHlSdW4gJiYgIW1f ZW9yLmF0RW5kKCkpIHsKICAgICAgICAgdW5zaWduZWQgc3RhcnRPZmZzZXQgPSBtX3Nvci5vZmZz ZXQoKTsKICAgICAgICAgdW5zaWduZWQgZW5kT2Zmc2V0ID0gbV9lb3Iub2Zmc2V0KCk7CiAKQEAg LTM1Nyw3ICszNTcsNyBAQCB2b2lkIEJpZGlSZXNvbHZlcjxJdGVyYXRvciwgUnVuPjo6bG93ZXJF eHBsaWNpdEVtYmVkZGluZ0xldmVsKFdURjo6VW5pY29kZTo6RGlyZQogewogICAgIHVzaW5nIG5h bWVzcGFjZSBXVEY6OlVuaWNvZGU7CiAKLSAgICBpZiAoIWVtcHR5UnVuICYmIG1fZW9yICE9IG1f bGFzdCkgeworICAgIGlmICghbV9lbXB0eVJ1biAmJiBtX2VvciAhPSBtX2xhc3QpIHsKICAgICAg ICAgY2hlY2tEaXJlY3Rpb25Jbkxvd2VyUmFpc2VFbWJlZGRpbmdMZXZlbCgpOwogICAgICAgICAv LyBiaWRpLnNvciAuLi4gYmlkaS5lb3IgLi4uIGJpZGkubGFzdCBlb3I7IG5lZWQgdG8gYXBwZW5k IHRoZSBiaWRpLnNvci1iaWRpLmVvciBydW4gb3IgZXh0ZW5kIGl0IHRocm91Z2ggYmlkaS5sYXN0 CiAgICAgICAgIGlmIChmcm9tID09IExlZnRUb1JpZ2h0KSB7CkBAIC0zODEsNyArMzgxLDcgQEAg dm9pZCBCaWRpUmVzb2x2ZXI8SXRlcmF0b3IsIFJ1bj46Omxvd2VyRXhwbGljaXRFbWJlZGRpbmdM ZXZlbChXVEY6OlVuaWNvZGU6OkRpcmUKICAgICAgICAgbV9lb3IgPSBtX2xhc3Q7CiAgICAgfQog ICAgIGFwcGVuZFJ1bigpOwotICAgIGVtcHR5UnVuID0gdHJ1ZTsKKyAgICBtX2VtcHR5UnVuID0g dHJ1ZTsKICAgICAvLyBzb3IgZm9yIHRoZSBuZXcgcnVuIGlzIGRldGVybWluZWQgYnkgdGhlIGhp Z2hlciBsZXZlbCAocnVsZSBYMTApCiAgICAgc2V0TGFzdERpcihmcm9tKTsKICAgICBzZXRMYXN0 U3Ryb25nRGlyKGZyb20pOwpAQCAtMzkzLDcgKzM5Myw3IEBAIHZvaWQgQmlkaVJlc29sdmVyPEl0 ZXJhdG9yLCBSdW4+OjpyYWlzZUV4cGxpY2l0RW1iZWRkaW5nTGV2ZWwoV1RGOjpVbmljb2RlOjpE aXJlCiB7CiAgICAgdXNpbmcgbmFtZXNwYWNlIFdURjo6VW5pY29kZTsKIAotICAgIGlmICghZW1w dHlSdW4gJiYgbV9lb3IgIT0gbV9sYXN0KSB7CisgICAgaWYgKCFtX2VtcHR5UnVuICYmIG1fZW9y ICE9IG1fbGFzdCkgewogICAgICAgICBjaGVja0RpcmVjdGlvbkluTG93ZXJSYWlzZUVtYmVkZGlu Z0xldmVsKCk7CiAgICAgICAgIC8vIGJpZGkuc29yIC4uLiBiaWRpLmVvciAuLi4gYmlkaS5sYXN0 IGVvcjsgbmVlZCB0byBhcHBlbmQgdGhlIGJpZGkuc29yLWJpZGkuZW9yIHJ1biBvciBleHRlbmQg aXQgdGhyb3VnaCBiaWRpLmxhc3QKICAgICAgICAgaWYgKHRvID09IExlZnRUb1JpZ2h0KSB7CkBA IC00MTksNyArNDE5LDcgQEAgdm9pZCBCaWRpUmVzb2x2ZXI8SXRlcmF0b3IsIFJ1bj46OnJhaXNl RXhwbGljaXRFbWJlZGRpbmdMZXZlbChXVEY6OlVuaWNvZGU6OkRpcmUKICAgICAgICAgbV9lb3Ig PSBtX2xhc3Q7CiAgICAgfQogICAgIGFwcGVuZFJ1bigpOwotICAgIGVtcHR5UnVuID0gdHJ1ZTsK KyAgICBtX2VtcHR5UnVuID0gdHJ1ZTsKICAgICBzZXRMYXN0RGlyKHRvKTsKICAgICBzZXRMYXN0 U3Ryb25nRGlyKHRvKTsKICAgICBtX2VvciA9IEl0ZXJhdG9yKCk7CkBAIC00NjgsNyArNDY4LDcg QEAgYm9vbCBCaWRpUmVzb2x2ZXI8SXRlcmF0b3IsIFJ1bj46OmNvbW1pdEV4cGxpY2l0RW1iZWRk aW5nKCkKIHRlbXBsYXRlIDxjbGFzcyBJdGVyYXRvciwgY2xhc3MgUnVuPgogdm9pZCBCaWRpUmVz b2x2ZXI8SXRlcmF0b3IsIFJ1bj46OmRlbGV0ZVJ1bnMoKQogewotICAgIGVtcHR5UnVuID0gdHJ1 ZTsKKyAgICBtX2VtcHR5UnVuID0gdHJ1ZTsKICAgICBpZiAoIW1fZmlyc3RSdW4pCiAgICAgICAg IHJldHVybjsKIApAQCAtNjIxLDcgKzYyMSw3IEBAIHZvaWQgQmlkaVJlc29sdmVyPEl0ZXJhdG9y LCBSdW4+OjpjcmVhdGVCaWRpUnVuc0ZvckxpbmUoY29uc3QgSXRlcmF0b3ImIGVuZCwgVmlzCiAg ICAgQVNTRVJUKG1fZGlyZWN0aW9uID09IE90aGVyTmV1dHJhbCk7CiAKICAgICBpZiAob3ZlcnJp ZGUgIT0gTm9WaXN1YWxPdmVycmlkZSkgewotICAgICAgICBlbXB0eVJ1biA9IGZhbHNlOworICAg ICAgICBtX2VtcHR5UnVuID0gZmFsc2U7CiAgICAgICAgIG1fc29yID0gbV9jdXJyZW50OwogICAg ICAgICBtX2VvciA9IEl0ZXJhdG9yKCk7CiAgICAgICAgIHdoaWxlIChtX2N1cnJlbnQgIT0gZW5k ICYmICFtX2N1cnJlbnQuYXRFbmQoKSkgewpAQCAtNjM2LDcgKzYzNiw3IEBAIHZvaWQgQmlkaVJl c29sdmVyPEl0ZXJhdG9yLCBSdW4+OjpjcmVhdGVCaWRpUnVuc0ZvckxpbmUoY29uc3QgSXRlcmF0 b3ImIGVuZCwgVmlzCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBlbXB0eVJ1biA9IHRy dWU7CisgICAgbV9lbXB0eVJ1biA9IHRydWU7CiAKICAgICBtX2VvciA9IEl0ZXJhdG9yKCk7CiAK QEAgLTkwNSw3ICs5MDUsNyBAQCB2b2lkIEJpZGlSZXNvbHZlcjxJdGVyYXRvciwgUnVuPjo6Y3Jl YXRlQmlkaVJ1bnNGb3JMaW5lKGNvbnN0IEl0ZXJhdG9yJiBlbmQsIFZpcwogICAgICAgICAgICAg ICAgIG1fZW9yID0gbV9jdXJyZW50OwogICAgICAgICAgICAgICAgIG1fc3RhdHVzLmVvciA9IGRp ckN1cnJlbnQ7CiAgICAgICAgICAgICB9IGVsc2UgaWYgKG1fc3RhdHVzLmxhc3QgIT0gRXVyb3Bl YW5OdW1iZXJUZXJtaW5hdG9yKQotICAgICAgICAgICAgICAgIGxhc3RCZWZvcmVFVCA9IGVtcHR5 UnVuID8gbV9lb3IgOiBtX2xhc3Q7CisgICAgICAgICAgICAgICAgbGFzdEJlZm9yZUVUID0gbV9l bXB0eVJ1biA/IG1fZW9yIDogbV9sYXN0OwogICAgICAgICAgICAgYnJlYWs7CiAKICAgICAgICAg Ly8gYm91bmRhcnkgbmV1dHJhbHMgc2hvdWxkIGJlIGlnbm9yZWQKQEAgLTk1Miw3ICs5NTIsNyBA QCB2b2lkIEJpZGlSZXNvbHZlcjxJdGVyYXRvciwgUnVuPjo6Y3JlYXRlQmlkaVJ1bnNGb3JMaW5l KGNvbnN0IEl0ZXJhdG9yJiBlbmQsIFZpcwogICAgICAgICAgICAgbV9sYXN0ID0gc3RhdGVBdEVu ZC5tX2xhc3Q7CiAgICAgICAgICAgICBtX3JlYWNoZWRFbmRPZkxpbmUgPSBzdGF0ZUF0RW5kLm1f cmVhY2hlZEVuZE9mTGluZTsKICAgICAgICAgICAgIGxhc3RCZWZvcmVFVCA9IHN0YXRlQXRFbmQu bGFzdEJlZm9yZUVUOwotICAgICAgICAgICAgZW1wdHlSdW4gPSBzdGF0ZUF0RW5kLmVtcHR5UnVu OworICAgICAgICAgICAgbV9lbXB0eVJ1biA9IHN0YXRlQXRFbmQubV9lbXB0eVJ1bjsKICAgICAg ICAgICAgIG1fZGlyZWN0aW9uID0gT3RoZXJOZXV0cmFsOwogICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIH0KQEAgLTk2MCw5ICs5NjAsOSBAQCB2b2lkIEJpZGlSZXNvbHZlcjxJdGVyYXRvciwg UnVuPjo6Y3JlYXRlQmlkaVJ1bnNGb3JMaW5lKGNvbnN0IEl0ZXJhdG9yJiBlbmQsIFZpcwogICAg ICAgICB1cGRhdGVTdGF0dXNMYXN0RnJvbUN1cnJlbnREaXJlY3Rpb24oZGlyQ3VycmVudCk7CiAg ICAgICAgIG1fbGFzdCA9IG1fY3VycmVudDsKIAotICAgICAgICBpZiAoZW1wdHlSdW4pIHsKKyAg ICAgICAgaWYgKG1fZW1wdHlSdW4pIHsKICAgICAgICAgICAgIG1fc29yID0gbV9jdXJyZW50Owot ICAgICAgICAgICAgZW1wdHlSdW4gPSBmYWxzZTsKKyAgICAgICAgICAgIG1fZW1wdHlSdW4gPSBm YWxzZTsKICAgICAgICAgfQogCiAgICAgICAgIGluY3JlbWVudCgpOwpAQCAtOTc2LDE0ICs5NzYs MTQgQEAgdm9pZCBCaWRpUmVzb2x2ZXI8SXRlcmF0b3IsIFJ1bj46OmNyZWF0ZUJpZGlSdW5zRm9y TGluZShjb25zdCBJdGVyYXRvciYgZW5kLCBWaXMKICAgICAgICAgICAgICAgICBtX2xhc3QgPSBz dGF0ZUF0RW5kLm1fbGFzdDsKICAgICAgICAgICAgICAgICBtX3JlYWNoZWRFbmRPZkxpbmUgPSBz dGF0ZUF0RW5kLm1fcmVhY2hlZEVuZE9mTGluZTsKICAgICAgICAgICAgICAgICBsYXN0QmVmb3Jl RVQgPSBzdGF0ZUF0RW5kLmxhc3RCZWZvcmVFVDsKLSAgICAgICAgICAgICAgICBlbXB0eVJ1biA9 IHN0YXRlQXRFbmQuZW1wdHlSdW47CisgICAgICAgICAgICAgICAgbV9lbXB0eVJ1biA9IHN0YXRl QXRFbmQubV9lbXB0eVJ1bjsKICAgICAgICAgICAgICAgICBtX2RpcmVjdGlvbiA9IE90aGVyTmV1 dHJhbDsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgfQog CiAgICAgICAgIGlmICghcGFzdEVuZCAmJiAobV9jdXJyZW50ID09IGVuZCB8fCBtX2N1cnJlbnQu YXRFbmQoKSkpIHsKLSAgICAgICAgICAgIGlmIChlbXB0eVJ1bikKKyAgICAgICAgICAgIGlmICht X2VtcHR5UnVuKQogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgc3RhdGVBdEVu ZC5tX3N0YXR1cyA9IG1fc3RhdHVzOwogICAgICAgICAgICAgc3RhdGVBdEVuZC5tX3NvciA9IG1f c29yOwpAQCAtOTkxLDcgKzk5MSw3IEBAIHZvaWQgQmlkaVJlc29sdmVyPEl0ZXJhdG9yLCBSdW4+ OjpjcmVhdGVCaWRpUnVuc0ZvckxpbmUoY29uc3QgSXRlcmF0b3ImIGVuZCwgVmlzCiAgICAgICAg ICAgICBzdGF0ZUF0RW5kLm1fbGFzdCA9IG1fbGFzdDsKICAgICAgICAgICAgIHN0YXRlQXRFbmQu bV9yZWFjaGVkRW5kT2ZMaW5lID0gbV9yZWFjaGVkRW5kT2ZMaW5lOwogICAgICAgICAgICAgc3Rh dGVBdEVuZC5sYXN0QmVmb3JlRVQgPSBsYXN0QmVmb3JlRVQ7Ci0gICAgICAgICAgICBzdGF0ZUF0 RW5kLmVtcHR5UnVuID0gZW1wdHlSdW47CisgICAgICAgICAgICBzdGF0ZUF0RW5kLm1fZW1wdHlS dW4gPSBtX2VtcHR5UnVuOwogICAgICAgICAgICAgZW5kT2ZMaW5lID0gbV9sYXN0OwogICAgICAg ICAgICAgcGFzdEVuZCA9IHRydWU7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9JbmxpbmVJdGVyYXRvci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L0lubGluZUl0ZXJhdG9yLmgKaW5kZXggNzVkOTc2MzE2YzU3ODJlZTdlMDQwNDg0OTRlN2ZmOWU4 MWQ2Y2RiZS4uYTVlYmU5NjRlMThjMzU1YmZjNjJiYjQ0ZmFlZjE4MzlkY2ZjNzZmMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUl0ZXJhdG9yLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUl0ZXJhdG9yLmgKQEAgLTI0Nyw3ICsyNDcsNyBA QCBpbmxpbmUgdm9pZCBJbmxpbmVCaWRpUmVzb2x2ZXI6OmluY3JlbWVudCgpCiB0ZW1wbGF0ZSA8 PgogaW5saW5lIHZvaWQgSW5saW5lQmlkaVJlc29sdmVyOjphcHBlbmRSdW4oKQogewotICAgIGlm ICghZW1wdHlSdW4gJiYgIW1fZW9yLmF0RW5kKCkpIHsKKyAgICBpZiAoIW1fZW1wdHlSdW4gJiYg IW1fZW9yLmF0RW5kKCkpIHsKICAgICAgICAgaW50IHN0YXJ0ID0gbV9zb3IubV9wb3M7CiAgICAg ICAgIFJlbmRlck9iamVjdCogb2JqID0gbV9zb3IubV9vYmo7CiAgICAgICAgIHdoaWxlIChvYmog JiYgb2JqICE9IG1fZW9yLm1fb2JqICYmIG9iaiAhPSBlbmRPZkxpbmUubV9vYmopIHsK