57542 2011-03-31 06:33:25 -0700 [Qt] Make WebKitLibraries optional for building QtWebKit 2011-04-05 08:08:03 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P4 Normal --- 1 laszlo.gombos webkit-unassigned abecsi buildbot kbalazs ossy oldest_to_newest 377109 0 laszlo.gombos 2011-03-31 06:33:25 -0700 build-webkit scripts fails if WebKitLibraries directory is not available even though it is not required to build QtWebKit. Perhaps we should guard with WebKitLibraries test with isQt(). This could be useful if one would only want to check out Tools and Source directory or for releasing QtWebKit into various platforms. 377151 1 87727 ossy 2011-03-31 07:53:01 -0700 Created attachment 87727 Patch 377155 2 87729 ossy 2011-03-31 07:55:44 -0700 Created attachment 87729 Patch 377157 3 87729 abecsi 2011-03-31 07:59:03 -0700 Comment on attachment 87729 Patch LGTM. 377159 4 buildbot 2011-03-31 08:10:19 -0700 Attachment 87727 did not build on win: Build output: http://queues.webkit.org/results/8313353 378816 5 ossy 2011-04-04 09:03:53 -0700 Laszlo: review ping? 379562 6 87729 laszlo.gombos 2011-04-05 07:54:46 -0700 Comment on attachment 87729 Patch r=me. Thanks. 379568 7 87729 ossy 2011-04-05 08:07:57 -0700 Comment on attachment 87729 Patch Landed in http://trac.webkit.org/changeset/82939 87727 2011-03-31 07:53:01 -0700 2011-03-31 07:54:10 -0700 Patch bug-57542-20110331075259.patch text/plain 1509 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogODI1NDIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmM2M3NTU3ZDQxYjZlMjhkMWRmOGU0Y2I2MDEwMTE2NzYy Nzk3MmI1Li5jMDk5NjJjZTgyZjdkZDE2Nzk5ZGI5YmFiYjMzYzQ4NTAyOTA5M2FmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDMtMzEgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIE1ha2Ug V2ViS2l0TGlicmFyaWVzIG9wdGlvbmFsIGZvciBidWlsZGluZyBRdFdlYktpdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc1NDIKKworICAgICAgICAq IFNjcmlwdHMvYnVpbGQtd2Via2l0OgorCiAyMDExLTAzLTMwICBEb21pbmljIENvb25leSAgPGRv bWluaWNjQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292 LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgYi9Ub29scy9TY3JpcHRz L2J1aWxkLXdlYmtpdAppbmRleCA4ZmY2MzhkNGFiZDBiZThlYzlhMmQ1NDI4NWZkYTU0ZGZkM2Q3 YWU4Li5mMTIwOTExZmU4NzFmNDEwMjFjNTcwMDk5NzA1MzhkYTc3NTIwMDM2IDEwMDc1NQotLS0g YS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAorKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdApAQCAtNDE0LDEzICs0MTQsMTYgQEAgc3ViIHVubGlua1plcm9GaWxlcygpCiAjIENoZWNr IHRoYXQgYWxsIHRoZSBwcm9qZWN0IGRpcmVjdG9yaWVzIGFyZSB0aGVyZS4KIG15IEBwcm9qZWN0 cyA9ICgiU291cmNlL0phdmFTY3JpcHRDb3JlIiwgIlNvdXJjZS9XZWJDb3JlIiwgIlNvdXJjZS9X ZWJLaXQiKTsKIAotbXkgQG90aGVyRGlycyA9ICgiV2ViS2l0TGlicmFyaWVzIik7Ci1mb3IgbXkg JGRpciAoQHByb2plY3RzLCBAb3RoZXJEaXJzKSB7Citmb3IgbXkgJGRpciAoQHByb2plY3RzKSB7 CiAgICAgaWYgKCEgLWQgJGRpcikgewogICAgICAgICBkaWUgIkVycm9yOiBObyAkZGlyIGRpcmVj dG9yeSBmb3VuZC4gUGxlYXNlIGRvIGEgZnJlc2ggY2hlY2tvdXQuXG4iOwogICAgIH0KIH0KIAor aWYgKCFpc1F0KCkgJiYgLWQgIldlYktpdExpYnJhcmllcyIpIHsKKyAgICBkaWUgIkVycm9yOiBO byBXZWJLaXRMaWJyYXJpZXMgZGlyZWN0b3J5IGZvdW5kLiBQbGVhc2UgZG8gYSBmcmVzaCBjaGVj a291dC5cbiI7Cit9CisKICMgR2VuZXJhdGUgdGhlIGdlbmVyYXRlIHByb2plY3QgZmlsZXMgZnJv bSAuZ3lwIGZpbGVzCiBpZiAoJHVzZUdZUCkgewogICAgIHN5c3RlbSgicGVybCIsICJUb29scy9T Y3JpcHRzL2dlbmVyYXRlLXByb2plY3QtZmlsZXMiKSA9PSAwIG9yIGRpZSAiRmFpbGVkIHRvIHJ1 biBnZW5lcmF0ZS1wcm9qZWN0LWZpbGVzIjsK 87729 2011-03-31 07:55:44 -0700 2011-04-05 08:07:57 -0700 Patch bug-57542-20110331075541.patch text/plain 1510 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogODI1NDIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmM2M3NTU3ZDQxYjZlMjhkMWRmOGU0Y2I2MDEwMTE2NzYy Nzk3MmI1Li5jMDk5NjJjZTgyZjdkZDE2Nzk5ZGI5YmFiYjMzYzQ4NTAyOTA5M2FmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDMtMzEgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIE1ha2Ug V2ViS2l0TGlicmFyaWVzIG9wdGlvbmFsIGZvciBidWlsZGluZyBRdFdlYktpdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc1NDIKKworICAgICAgICAq IFNjcmlwdHMvYnVpbGQtd2Via2l0OgorCiAyMDExLTAzLTMwICBEb21pbmljIENvb25leSAgPGRv bWluaWNjQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292 LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgYi9Ub29scy9TY3JpcHRz L2J1aWxkLXdlYmtpdAppbmRleCA4ZmY2MzhkNGFiZDBiZThlYzlhMmQ1NDI4NWZkYTU0ZGZkM2Q3 YWU4Li5mNjhhNTg0MWM1NmNiOGM0OTQ0Yjg0MTc2NTYwNzZhNjAyZmIwMmMwIDEwMDc1NQotLS0g YS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAorKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdApAQCAtNDE0LDEzICs0MTQsMTYgQEAgc3ViIHVubGlua1plcm9GaWxlcygpCiAjIENoZWNr IHRoYXQgYWxsIHRoZSBwcm9qZWN0IGRpcmVjdG9yaWVzIGFyZSB0aGVyZS4KIG15IEBwcm9qZWN0 cyA9ICgiU291cmNlL0phdmFTY3JpcHRDb3JlIiwgIlNvdXJjZS9XZWJDb3JlIiwgIlNvdXJjZS9X ZWJLaXQiKTsKIAotbXkgQG90aGVyRGlycyA9ICgiV2ViS2l0TGlicmFyaWVzIik7Ci1mb3IgbXkg JGRpciAoQHByb2plY3RzLCBAb3RoZXJEaXJzKSB7Citmb3IgbXkgJGRpciAoQHByb2plY3RzKSB7 CiAgICAgaWYgKCEgLWQgJGRpcikgewogICAgICAgICBkaWUgIkVycm9yOiBObyAkZGlyIGRpcmVj dG9yeSBmb3VuZC4gUGxlYXNlIGRvIGEgZnJlc2ggY2hlY2tvdXQuXG4iOwogICAgIH0KIH0KIAor aWYgKCFpc1F0KCkgJiYgIS1kICJXZWJLaXRMaWJyYXJpZXMiKSB7CisgICAgZGllICJFcnJvcjog Tm8gV2ViS2l0TGlicmFyaWVzIGRpcmVjdG9yeSBmb3VuZC4gUGxlYXNlIGRvIGEgZnJlc2ggY2hl Y2tvdXQuXG4iOworfQorCiAjIEdlbmVyYXRlIHRoZSBnZW5lcmF0ZSBwcm9qZWN0IGZpbGVzIGZy b20gLmd5cCBmaWxlcwogaWYgKCR1c2VHWVApIHsKICAgICBzeXN0ZW0oInBlcmwiLCAiVG9vbHMv U2NyaXB0cy9nZW5lcmF0ZS1wcm9qZWN0LWZpbGVzIikgPT0gMCBvciBkaWUgIkZhaWxlZCB0byBy dW4gZ2VuZXJhdGUtcHJvamVjdC1maWxlcyI7Cg==