57537 2011-03-31 03:41:06 -0700 Setting document.title doesn't affect contents of title tag of XHTML documents 2011-09-12 20:49:13 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 evan rwlbuis ap darin jkjiang rwlbuis shinyak webkit.review.bot oldest_to_newest 377038 0 evan 2011-03-31 03:41:06 -0700 This snippet has different behavior in HTML vs XHTML documents: <head><title id='t'>test</title></head> <body> <script>document.title = 'foo'; console.log(document.getElementById('t').innerText);</script> In HTML, we update the <title> tag. In XHTML, we don't. 377041 1 evan 2011-03-31 03:43:01 -0700 The problem is in Document::setTitle(), which tests isHTMLDocument, which isn't true for XHTML documents. 464522 2 jkjiang 2011-09-08 17:29:50 -0700 This in XHTML document works fine on Opera. Is there a specific reason that we are not taking XHTML documents into account in Document::setTitle()? It looks that should be the same with HTML documents. 464990 3 106907 jkjiang 2011-09-09 12:53:38 -0700 Created attachment 106907 Patch 464997 4 106910 rwlbuis 2011-09-09 13:18:29 -0700 Created attachment 106910 Patch 465004 5 rwlbuis 2011-09-09 13:35:20 -0700 (In reply to comment #4) > Created an attachment (id=106910) [details] > Patch For anyone curious, Jacky is not a committer so I uploaded the patch for him, trying to get EWS results.... Ignore for now. Cheers, Rob. 465010 6 106916 rwlbuis 2011-09-09 13:48:24 -0700 Created attachment 106916 Patch 465059 7 106916 ap 2011-09-09 15:28:35 -0700 Comment on attachment 106916 Patch Please add a a test. 465061 8 jkjiang 2011-09-09 15:29:50 -0700 (In reply to comment #7) > (From update of attachment 106916 [details]) > Please add a a test. I'll add it. 465176 9 106953 jkjiang 2011-09-09 18:55:23 -0700 Created attachment 106953 Patch 465179 10 jkjiang 2011-09-09 18:57:15 -0700 Patch with a test case. 465203 11 darin 2011-09-09 20:16:19 -0700 This patch makes me curious about how many of the 66 call sites of isHTMLDocument() are mishandling XHTML documents. 465213 12 106953 ap 2011-09-09 20:57:20 -0700 Comment on attachment 106953 Patch What is the reason why you didn't use regular WebKit script test machinery? That would make the test much shorter and more consistent with others. See e.g. <http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/allowed-children.html>. 465607 13 jkjiang 2011-09-12 08:05:05 -0700 (In reply to comment #12) > (From update of attachment 106953 [details]) > What is the reason why you didn't use regular WebKit script test machinery? That would make the test much shorter and more consistent with others. See e.g. <http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/allowed-children.html>. Ah, I see, I followed some other tests under dom directory. Thanks for your advice, I will take the advice and update the test case then. 465774 14 107078 jkjiang 2011-09-12 13:50:36 -0700 Created attachment 107078 Patch 465811 15 107078 ap 2011-09-12 14:58:53 -0700 Comment on attachment 107078 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107078&action=review Looks good, thank you! As Darin said, there can be a lot of interesting finds around other places that call isHTMLDocument(). > LayoutTests/fast/dom/title-content-set-innerText-get.xhtml:12 > +<p id="description"></p> > +<div id="console"></div> > +<script> > +description("This test ensures that we can update the contents of the title tag of the XHTML document when setting document.title"); This is how it's done it the test I gave a link to, but there is really no reason to set the description via a JavaScript function - one can just put it directly in a <p> element. 465827 16 jkjiang 2011-09-12 15:18:02 -0700 (In reply to comment #15) > (From update of attachment 107078 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107078&action=review > > Looks good, thank you! > > As Darin said, there can be a lot of interesting finds around other places that call isHTMLDocument(). > > > LayoutTests/fast/dom/title-content-set-innerText-get.xhtml:12 > > +<p id="description"></p> > > +<div id="console"></div> > > +<script> > > +description("This test ensures that we can update the contents of the title tag of the XHTML document when setting document.title"); > > This is how it's done it the test I gave a link to, but there is really no reason to set the description via a JavaScript function - one can just put it directly in a <p> element. Thanks for your grant! If I find other places that call isHTMLDocument and mishandling XHTML documents, I'll file bugs and try to fix them. 466087 17 107078 webkit.review.bot 2011-09-12 20:49:06 -0700 Comment on attachment 107078 Patch Clearing flags on attachment: 107078 Committed r95009: <http://trac.webkit.org/changeset/95009> 466088 18 webkit.review.bot 2011-09-12 20:49:13 -0700 All reviewed patches have been landed. Closing bug. 106907 2011-09-09 12:53:38 -0700 2011-09-09 13:18:22 -0700 Patch bug-57537-20110909115552.patch text/plain 1269 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4NjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3YjExMThiOWIwZjhiMTQw ZDI4MTE0NTk5YTEwZmMyY2EyYzU0OTNmLi4xNmY0ZWYxZGM3ZDM2NWI2YmZhOWQyN2Q5ZTg2YmQz NjBlOWQwMGIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMDkgIEphY2t5 IEppYW5nICA8emhhamlhbmdAcmltLmNvbT4KKworICAgICAgICBTZXR0aW5nIGRvY3VtZW50LnRp dGxlIGRvZXNuJ3QgYWZmZWN0IGNvbnRlbnRzIG9mIHRpdGxlIHRhZyBvZiBYSFRNTCBkb2N1bWVu dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NTM3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20v RG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldFRpdGxlKToKKwog MjAxMS0wOS0wOSAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CiAK ICAgICAgICAgW1F0XSBSZW1vdmUgY29tbW9uLnByaQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5k ZXggMTJmNDQ1YjU1MWI3YjZkNmQyMzkyNGQ2ZTA2MmJhNmJhMDE3NjIyZi4uYjQ5ZmQzZWVkN2Nl MGEyZWZmZDdmNzk1OTJkMzg3ZGI3MTljZDI3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBA IC0xMzI5LDcgKzEzMjksNyBAQCB2b2lkIERvY3VtZW50OjpzZXRUaXRsZShjb25zdCBTdHJpbmcm IHRpdGxlKQogewogICAgIC8vIFRpdGxlIHNldCBieSBKYXZhU2NyaXB0IC0tIG92ZXJyaWRlcyBh bnkgdGl0bGUgZWxlbWVudHMuCiAgICAgbV90aXRsZVNldEV4cGxpY2l0bHkgPSB0cnVlOwotICAg IGlmICghaXNIVE1MRG9jdW1lbnQoKSkKKyAgICBpZiAoIWlzSFRNTERvY3VtZW50KCkgJiYgIWlz WEhUTUxEb2N1bWVudCgpKQogICAgICAgICBtX3RpdGxlRWxlbWVudCA9IDA7CiAgICAgZWxzZSBp ZiAoIW1fdGl0bGVFbGVtZW50KSB7CiAgICAgICAgIGlmIChIVE1MRWxlbWVudCogaGVhZEVsZW1l bnQgPSBoZWFkKCkpIHsK 106910 2011-09-09 13:18:29 -0700 2011-09-09 13:48:19 -0700 Patch bug-57537-20110909162025.patch text/plain 1414 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4NzEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YTJiYjQ2OWZhMGMwM2M1 NDk5MjRmNTU0MzJhZDIxZmMyZGFlM2FlLi5lNWU5YTFjZWI1ZDBhNGQyMjYxY2UwY2JkMTY0ZTlh M2U1ZGNjM2M3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMDkgIFJvYiBC dWlzICA8cmJ1aXNAcmltLmNvbT4KKworICAgICAgICBTZXR0aW5nIGRvY3VtZW50LnRpdGxlIGRv ZXNuJ3QgYWZmZWN0IGNvbnRlbnRzIG9mIHRpdGxlIHRhZyBvZiBYSFRNTCBkb2N1bWVudHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NTM3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRoZSBj b250ZW50cyBvZiB0aGUgPHRpdGxlPiB0YWcgb2YgWEhUTUwgZG9jdW1lbnRzIHdoZW4gc2V0dGlu ZyBkb2N1bWVudC50aXRsZS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAg ICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2V0 VGl0bGUpOgorCiAyMDExLTA5LTA5ICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIEluaXRpYWxpemUgRXhjZXB0aW9uQ29kZSBpbiBFbGVtZW50OjpyZW1vdmVBdHRy aWJ1dGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDEyZjQ0NWI1NTFiN2I2ZDZkMjM5MjRk NmUwNjJiYTZiYTAxNzYyMmYuLmI0OWZkM2VlZDdjZTBhMmVmZmQ3Zjc5NTkyZDM4N2RiNzE5Y2Qy NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMTMyOSw3ICsxMzI5LDcgQEAgdm9pZCBE b2N1bWVudDo6c2V0VGl0bGUoY29uc3QgU3RyaW5nJiB0aXRsZSkKIHsKICAgICAvLyBUaXRsZSBz ZXQgYnkgSmF2YVNjcmlwdCAtLSBvdmVycmlkZXMgYW55IHRpdGxlIGVsZW1lbnRzLgogICAgIG1f dGl0bGVTZXRFeHBsaWNpdGx5ID0gdHJ1ZTsKLSAgICBpZiAoIWlzSFRNTERvY3VtZW50KCkpCisg ICAgaWYgKCFpc0hUTUxEb2N1bWVudCgpICYmICFpc1hIVE1MRG9jdW1lbnQoKSkKICAgICAgICAg bV90aXRsZUVsZW1lbnQgPSAwOwogICAgIGVsc2UgaWYgKCFtX3RpdGxlRWxlbWVudCkgewogICAg ICAgICBpZiAoSFRNTEVsZW1lbnQqIGhlYWRFbGVtZW50ID0gaGVhZCgpKSB7Cg== 106916 2011-09-09 13:48:24 -0700 2011-09-09 15:28:35 -0700 Patch bug-57537-20110909165020.patch text/plain 1414 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4NzEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YTJiYjQ2OWZhMGMwM2M1 NDk5MjRmNTU0MzJhZDIxZmMyZGFlM2FlLi5lNWU5YTFjZWI1ZDBhNGQyMjYxY2UwY2JkMTY0ZTlh M2U1ZGNjM2M3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMDkgIFJvYiBC dWlzICA8cmJ1aXNAcmltLmNvbT4KKworICAgICAgICBTZXR0aW5nIGRvY3VtZW50LnRpdGxlIGRv ZXNuJ3QgYWZmZWN0IGNvbnRlbnRzIG9mIHRpdGxlIHRhZyBvZiBYSFRNTCBkb2N1bWVudHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NTM3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRoZSBj b250ZW50cyBvZiB0aGUgPHRpdGxlPiB0YWcgb2YgWEhUTUwgZG9jdW1lbnRzIHdoZW4gc2V0dGlu ZyBkb2N1bWVudC50aXRsZS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAg ICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2V0 VGl0bGUpOgorCiAyMDExLTA5LTA5ICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIEluaXRpYWxpemUgRXhjZXB0aW9uQ29kZSBpbiBFbGVtZW50OjpyZW1vdmVBdHRy aWJ1dGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDEyZjQ0NWI1NTFiN2I2ZDZkMjM5MjRk NmUwNjJiYTZiYTAxNzYyMmYuLmI0OWZkM2VlZDdjZTBhMmVmZmQ3Zjc5NTkyZDM4N2RiNzE5Y2Qy NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMTMyOSw3ICsxMzI5LDcgQEAgdm9pZCBE b2N1bWVudDo6c2V0VGl0bGUoY29uc3QgU3RyaW5nJiB0aXRsZSkKIHsKICAgICAvLyBUaXRsZSBz ZXQgYnkgSmF2YVNjcmlwdCAtLSBvdmVycmlkZXMgYW55IHRpdGxlIGVsZW1lbnRzLgogICAgIG1f dGl0bGVTZXRFeHBsaWNpdGx5ID0gdHJ1ZTsKLSAgICBpZiAoIWlzSFRNTERvY3VtZW50KCkpCisg ICAgaWYgKCFpc0hUTUxEb2N1bWVudCgpICYmICFpc1hIVE1MRG9jdW1lbnQoKSkKICAgICAgICAg bV90aXRsZUVsZW1lbnQgPSAwOwogICAgIGVsc2UgaWYgKCFtX3RpdGxlRWxlbWVudCkgewogICAg ICAgICBpZiAoSFRNTEVsZW1lbnQqIGhlYWRFbGVtZW50ID0gaGVhZCgpKSB7Cg== 106953 2011-09-09 18:55:23 -0700 2011-09-12 13:50:31 -0700 Patch bug-57537-20110909175738.patch text/plain 4046 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4OTQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzM2FmMTMyZDI4NWQwNGUxMzQ3ZmQ1 MmU3YjAxZTJhZDhlYWMyOTE3Li5jYTk2YWJlMDhkNWVhYzMyZTUyZmQ0MTY2N2ExZjNmNDE3ODM2 OTEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMDkgIEphY2t5IEppYW5nICA8emhh amlhbmdAcmltLmNvbT4KKworICAgICAgICBTZXR0aW5nIGRvY3VtZW50LnRpdGxlIGRvZXNuJ3Qg YWZmZWN0IGNvbnRlbnRzIG9mIHRpdGxlIHRhZyBvZiBYSFRNTCBkb2N1bWVudHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NTM3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS90aXRsZS1j b250ZW50LXNldC1pbm5lclRleHQtZ2V0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9kb20vdGl0bGUtY29udGVudC1zZXQtaW5uZXJUZXh0LWdldC54aHRtbDogQWRkZWQuCisK IDIwMTEtMDktMDkgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KIAogICAgICAg ICBHZW5lcmF0ZSBhIFdlYktpdENTU01hdHJpeCBjb25zdHJ1Y3RvciBvZiBWOCB1c2luZyB0aGUg SURMICdDb25zdHJ1Y3RvcicgZXh0ZW5kZWQgYXR0cmlidXRlCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2RvbS90aXRsZS1jb250ZW50LXNldC1pbm5lclRleHQtZ2V0LWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3RpdGxlLWNvbnRlbnQtc2V0LWlubmVyVGV4dC1nZXQt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjg5OTRkMmM4NGZmMWYwYTRjNTAwMjEwMTFjOGJjNzY5 ZTU4YzJhMjAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS90aXRsZS1j b250ZW50LXNldC1pbm5lclRleHQtZ2V0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1RJ VExFIENIQU5HRUQ6IFRoaXMgaXMgdGhlIG5ldyB0aXRsZQorRXhwZWN0ZWQ6IFRoaXMgaXMgdGhl IG5ldyB0aXRsZSwgZ290OiBUaGlzIGlzIHRoZSBuZXcgdGl0bGUsIFBBU1MKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvZG9tL3RpdGxlLWNvbnRlbnQtc2V0LWlubmVyVGV4dC1nZXQueGh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS90aXRsZS1jb250ZW50LXNldC1pbm5lclRleHQtZ2V0 LnhodG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjA4YjE3MjY2NjBmNTcyMTFhNTZkYTZhNDNjZWQzOWIyNzJjM2E2 NzUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS90aXRsZS1jb250ZW50 LXNldC1pbm5lclRleHQtZ2V0LnhodG1sCkBAIC0wLDAgKzEsMzkgQEAKKzwhRE9DVFlQRSBodG1s IFBVQkxJQyAiLS8vVzNDLy9EVEQgWEhUTUwgMS4xLy9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RS L3hodG1sMTEvRFREL3hodG1sMTEuZHRkIj4KKzxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9y Zy8xOTk5L3hodG1sIj4KKzxoZWFkPgorPHRpdGxlIGlkPSd0Jz5PcmlnaW5hbCBUaXRsZTwvdGl0 bGU+Cis8c2NyaXB0PgorZnVuY3Rpb24gbG9nKG1lc3NhZ2UpCit7CisgICAgdmFyIHBhcmFncmFw aCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInAiKTsKKyAgICBwYXJhZ3JhcGguYXBwZW5kQ2hp bGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobWVzc2FnZSkpOworICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJjb25zb2xlIikuYXBwZW5kQ2hpbGQocGFyYWdyYXBoKTsKK30KKworZnVuY3Rp b24gZXhwZWN0KGV4cGVjdGVkLCBhY3R1YWwpCit7CisgICAgdmFyIG1zZyA9ICJFeHBlY3RlZDog IiArIGV4cGVjdGVkICsgIiwgZ290OiAiICsgYWN0dWFsICsgIiwgIjsKKyAgICBpZiAoZXhwZWN0 ZWQgPT0gYWN0dWFsKQorICAgICAgICBsb2cobXNnICsgIlBBU1MiKTsKKyAgICBlbHNlCisgICAg ICAgIGxvZyhtc2cgKyAiRkFJTCIpOworfQorCitmdW5jdGlvbiBydW5UZXN0cygpIHsKKyAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcFRp dGxlQ2hhbmdlcygpOworICAgIH0KKworICAgIGRvY3VtZW50LnRpdGxlID0gJ1RoaXMgaXMgdGhl IG5ldyB0aXRsZSc7CisgICAgZXhwZWN0KCdUaGlzIGlzIHRoZSBuZXcgdGl0bGUnLCBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgndCcpLmlubmVyVGV4dCk7Cit9CisKKzwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHkgb25sb2FkPSdydW5UZXN0cygpOyc+Cis8ZGl2IGlkPSdjb25zb2xlJz4KKzwvZGl2 PgorPC9ib2R5PgorPC9odG1sPgorCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjBiZmVmOTM4ZjkzODkzNjdjODBj ZGVkMWZkNDE0ZjFiNGVhYjYxZS4uMjg3NjhkMmI3NWRjYTBjMTg2YjdmOTA3MGQ4ODIzNmI0ZWFl ZjAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTA5LTA5ICBKYWNreSBKaWFu ZyAgPHpoYWppYW5nQHJpbS5jb20+CisKKyAgICAgICAgU2V0dGluZyBkb2N1bWVudC50aXRsZSBk b2Vzbid0IGFmZmVjdCBjb250ZW50cyBvZiB0aXRsZSB0YWcgb2YgWEhUTUwgZG9jdW1lbnRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzUzNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0aGUg Y29udGVudHMgb2YgdGhlIDx0aXRsZT4gdGFnIG9mIFhIVE1MIGRvY3VtZW50cyB3aGVuIHNldHRp bmcKKyAgICAgICAgZG9jdW1lbnQudGl0bGUuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vdGl0 bGUtY29udGVudC1zZXQtaW5uZXJUZXh0LWdldC54aHRtbAorCisgICAgICAgICogV2ViQ29yZS5w cmk6CisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3Vt ZW50OjpzZXRUaXRsZSk6CisKIDIwMTEtMDktMDkgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZy YWl4QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1Y4XSBWOFdlYktpdFBvaW50Ojpjb25zdHJ1Y3Rv ckNhbGxiYWNrIGxlYWtzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCAxMmY0NDViNTUxYjdi NmQ2ZDIzOTI0ZDZlMDYyYmE2YmEwMTc2MjJmLi5iNDlmZDNlZWQ3Y2UwYTJlZmZkN2Y3OTU5MmQz ODdkYjcxOWNkMjc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTEzMjksNyArMTMyOSw3 IEBAIHZvaWQgRG9jdW1lbnQ6OnNldFRpdGxlKGNvbnN0IFN0cmluZyYgdGl0bGUpCiB7CiAgICAg Ly8gVGl0bGUgc2V0IGJ5IEphdmFTY3JpcHQgLS0gb3ZlcnJpZGVzIGFueSB0aXRsZSBlbGVtZW50 cy4KICAgICBtX3RpdGxlU2V0RXhwbGljaXRseSA9IHRydWU7Ci0gICAgaWYgKCFpc0hUTUxEb2N1 bWVudCgpKQorICAgIGlmICghaXNIVE1MRG9jdW1lbnQoKSAmJiAhaXNYSFRNTERvY3VtZW50KCkp CiAgICAgICAgIG1fdGl0bGVFbGVtZW50ID0gMDsKICAgICBlbHNlIGlmICghbV90aXRsZUVsZW1l bnQpIHsKICAgICAgICAgaWYgKEhUTUxFbGVtZW50KiBoZWFkRWxlbWVudCA9IGhlYWQoKSkgewo= 107078 2011-09-12 13:50:36 -0700 2011-09-12 20:49:06 -0700 Patch bug-57537-20110912125253.patch text/plain 4019 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4OTQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzM2FmMTMyZDI4NWQwNGUxMzQ3ZmQ1 MmU3YjAxZTJhZDhlYWMyOTE3Li5jYTk2YWJlMDhkNWVhYzMyZTUyZmQ0MTY2N2ExZjNmNDE3ODM2 OTEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMDkgIEphY2t5IEppYW5nICA8emhh amlhbmdAcmltLmNvbT4KKworICAgICAgICBTZXR0aW5nIGRvY3VtZW50LnRpdGxlIGRvZXNuJ3Qg YWZmZWN0IGNvbnRlbnRzIG9mIHRpdGxlIHRhZyBvZiBYSFRNTCBkb2N1bWVudHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NTM3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS90aXRsZS1j b250ZW50LXNldC1pbm5lclRleHQtZ2V0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9kb20vdGl0bGUtY29udGVudC1zZXQtaW5uZXJUZXh0LWdldC54aHRtbDogQWRkZWQuCisK IDIwMTEtMDktMDkgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KIAogICAgICAg ICBHZW5lcmF0ZSBhIFdlYktpdENTU01hdHJpeCBjb25zdHJ1Y3RvciBvZiBWOCB1c2luZyB0aGUg SURMICdDb25zdHJ1Y3RvcicgZXh0ZW5kZWQgYXR0cmlidXRlCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2RvbS90aXRsZS1jb250ZW50LXNldC1pbm5lclRleHQtZ2V0LWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3RpdGxlLWNvbnRlbnQtc2V0LWlubmVyVGV4dC1nZXQt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmJjMDdiMTNiMjE3N2ZmZjRjMzA0NmEyZDRjOTQzMTdj ODdhN2ZiZGMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS90aXRsZS1j b250ZW50LXNldC1pbm5lclRleHQtZ2V0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitU aGlzIHRlc3QgZW5zdXJlcyB0aGF0IHdlIGNhbiB1cGRhdGUgdGhlIGNvbnRlbnRzIG9mIHRoZSB0 aXRsZSB0YWcgb2YgdGhlIFhIVE1MIGRvY3VtZW50IHdoZW4gc2V0dGluZyBkb2N1bWVudC50aXRs ZQorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgndCcpLmlubmVyVGV4dCBpcyAnVGhpcyBpcyB0aGUgbmV3IHRpdGxlJworUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvZG9tL3RpdGxlLWNvbnRlbnQtc2V0LWlubmVyVGV4dC1nZXQueGh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS90aXRsZS1jb250ZW50LXNldC1pbm5lclRleHQtZ2V0 LnhodG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjM3M2UyYTFkNTYyNjFiMWIxNzZhZTRlY2FiODcwNmU2NjBmNjM0 MjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS90aXRsZS1jb250ZW50 LXNldC1pbm5lclRleHQtZ2V0LnhodG1sCkBAIC0wLDAgKzEsMjEgQEAKKzwhRE9DVFlQRSBodG1s IFBVQkxJQyAiLS8vVzNDLy9EVEQgWEhUTUwgMS4xLy9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RS L3hodG1sMTEvRFREL3hodG1sMTEuZHRkIj4KKzxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9y Zy8xOTk5L3hodG1sIj4KKzxoZWFkPgorPHRpdGxlIGlkPSd0Jz5PcmlnaW5hbCBUaXRsZTwvdGl0 bGU+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0 LXN0eWxlLmNzcyIgLz4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUu anMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4K KzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PiAKKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGhpcyB0 ZXN0IGVuc3VyZXMgdGhhdCB3ZSBjYW4gdXBkYXRlIHRoZSBjb250ZW50cyBvZiB0aGUgdGl0bGUg dGFnIG9mIHRoZSBYSFRNTCBkb2N1bWVudCB3aGVuIHNldHRpbmcgZG9jdW1lbnQudGl0bGUiKTsK KworZG9jdW1lbnQudGl0bGUgPSAnVGhpcyBpcyB0aGUgbmV3IHRpdGxlJzsKK3Nob3VsZEJlKCJk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgndCcpLmlubmVyVGV4dCIsICInVGhpcyBpcyB0aGUgbmV3 IHRpdGxlJyIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0Pgor PHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgor PC9ib2R5PiAKKzwvaHRtbD4gCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjBiZmVmOTM4ZjkzODkzNjdjODBjZGVk MWZkNDE0ZjFiNGVhYjYxZS4uNGI0NGVmMDJmZDcwZjFhZmQxYTc0NWQzMDZhZWE5ZTU5YzQyMmIz MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTA5LTA5ICBKYWNreSBKaWFuZyAg PHpoYWppYW5nQHJpbS5jb20+CisKKyAgICAgICAgU2V0dGluZyBkb2N1bWVudC50aXRsZSBkb2Vz bid0IGFmZmVjdCBjb250ZW50cyBvZiB0aXRsZSB0YWcgb2YgWEhUTUwgZG9jdW1lbnRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzUzNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0aGUgY29u dGVudHMgb2YgdGhlIDx0aXRsZT4gdGFnIG9mIFhIVE1MIGRvY3VtZW50cyB3aGVuIHNldHRpbmcK KyAgICAgICAgZG9jdW1lbnQudGl0bGUuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vdGl0bGUt Y29udGVudC1zZXQtaW5uZXJUZXh0LWdldC54aHRtbAorCisgICAgICAgICogZG9tL0RvY3VtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzZXRUaXRsZSk6CisKIDIwMTEtMDkt MDkgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CiAKICAgICAgICAg W1Y4XSBWOFdlYktpdFBvaW50Ojpjb25zdHJ1Y3RvckNhbGxiYWNrIGxlYWtzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcAppbmRleCAxMmY0NDViNTUxYjdiNmQ2ZDIzOTI0ZDZlMDYyYmE2YmEwMTc2MjJm Li5iNDlmZDNlZWQ3Y2UwYTJlZmZkN2Y3OTU5MmQzODdkYjcxOWNkMjc1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAKQEAgLTEzMjksNyArMTMyOSw3IEBAIHZvaWQgRG9jdW1lbnQ6OnNldFRpdGxl KGNvbnN0IFN0cmluZyYgdGl0bGUpCiB7CiAgICAgLy8gVGl0bGUgc2V0IGJ5IEphdmFTY3JpcHQg LS0gb3ZlcnJpZGVzIGFueSB0aXRsZSBlbGVtZW50cy4KICAgICBtX3RpdGxlU2V0RXhwbGljaXRs eSA9IHRydWU7Ci0gICAgaWYgKCFpc0hUTUxEb2N1bWVudCgpKQorICAgIGlmICghaXNIVE1MRG9j dW1lbnQoKSAmJiAhaXNYSFRNTERvY3VtZW50KCkpCiAgICAgICAgIG1fdGl0bGVFbGVtZW50ID0g MDsKICAgICBlbHNlIGlmICghbV90aXRsZUVsZW1lbnQpIHsKICAgICAgICAgaWYgKEhUTUxFbGVt ZW50KiBoZWFkRWxlbWVudCA9IGhlYWQoKSkgewo=