<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>57535</bug_id>
          
          <creation_ts>2011-03-31 03:27:26 -0700</creation_ts>
          <short_desc>Fix compilation on Solaris 10 with Sun Studio 12, missing definition for time_t</short_desc>
          <delta_ts>2011-04-11 16:06:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Ben Taylor">bentaylor.solx86</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>buildbot</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>levin</cc>
    
    <cc>webkit-ews</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>377031</commentid>
    <comment_count>0</comment_count>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-03-31 03:27:26 -0700</bug_when>
    <thetext>Compiling webkit in Qt-4.7.2, we see the following errors due to missing &lt;sys/time.h&gt; includes

&quot;platform/network/ResourceResponseBase.h&quot;, line 90: Error: time_t is not defined.
&quot;page/Page.h&quot;, line 372: Error: No storage class or type for this declaration.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>377059</commentid>
    <comment_count>1</comment_count>
      <attachid>87700</attachid>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-03-31 04:46:41 -0700</bug_when>
    <thetext>Created attachment 87700
Fix compilation on Solaris 10 with Sun Studio 12, missing definition for time_t

Bug report extracted from the original by Thiago Macieria in https://bugs.webkit.org/show_bug.cgi?id=24932
in patch 04 of 17.  This code compiles fine against webkit in qt-4.7.2, but patch is from webkit head.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>377063</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-03-31 04:50:17 -0700</bug_when>
    <thetext>Attachment 87700 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1

Source/WebCore/page/Page.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/loader/icon/IconRecord.h:41:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/loader/icon/IconRecord.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/network/ResourceResponseBase.h:38:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/network/ResourceResponseBase.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>377074</commentid>
    <comment_count>3</comment_count>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-03-31 05:05:59 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Attachment 87700 [details] did not pass style-queue:
&gt; 
&gt; Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1
&gt; 
&gt; Source/WebCore/page/Page.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
&gt; Source/WebCore/loader/icon/IconRecord.h:41:  One space before end of line comments  [whitespace/comments] [5]
&gt; Source/WebCore/loader/icon/IconRecord.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
&gt; Source/WebCore/platform/network/ResourceResponseBase.h:38:  One space before end of line comments  [whitespace/comments] [5]
&gt; Source/WebCore/platform/network/ResourceResponseBase.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
&gt; Total errors found: 5 in 4 files
&gt; 
&gt; 
&gt; If any of these errors are false positives, please file a bug against check-webkit-style.

They look like false positives to me. Reverting the patch and rerunning check-webkit-style on loader/icon/IconRecord.h emits the following messages.  However, if someone can tell me if the order needs to be changed on the includes, happy to make the change.  The space issue is clearly false positive since the C++ style comments in the lines cause that issue

Source/WebCore/loader/icon/IconRecord.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/loader/icon/IconRecord.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/loader/icon/IconRecord.h:78:  The parameter name &quot;data&quot; adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/icon/IconRecord.h:107:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/loader/icon/IconRecord.h:114:  Should have a space between // and comment  [whitespace/comments] [4]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>377090</commentid>
    <comment_count>4</comment_count>
    <who name="Build Bot">buildbot</who>
    <bug_when>2011-03-31 05:55:02 -0700</bug_when>
    <thetext>Attachment 87700 did not build on win:
Build output: http://queues.webkit.org/results/8314266</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>377158</commentid>
    <comment_count>5</comment_count>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-03-31 08:08:37 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Attachment 87700 [details] did not build on win:
&gt; Build output: http://queues.webkit.org/results/8314266

Do I need to resubmit the patch, isolating the includes with an #ifdef/ifndef

like:
#ifdef OS(SOLARIS)
#include &lt;sys/time.h&gt;
#endif 

 or 
#ifndef OS(WINDOWS)
#include &lt;sys/time.h&gt;
#endif</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378320</commentid>
    <comment_count>6</comment_count>
      <attachid>87961</attachid>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-04-01 21:36:18 -0700</bug_when>
    <thetext>Created attachment 87961
Updated patch to isolate includes only for Solaris, since it caused a failure on the windows build bots

Updated the patch to isolate the includes only for Solaris, since it caused a failure on windows build bots.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378326</commentid>
    <comment_count>7</comment_count>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2011-04-01 21:47:32 -0700</bug_when>
    <thetext>Attachment 87961 did not build on qt:
Build output: http://queues.webkit.org/results/8315685</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378327</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-01 21:47:45 -0700</bug_when>
    <thetext>Attachment 87961 did not build on chromium:
Build output: http://queues.webkit.org/results/8307355</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378330</commentid>
    <comment_count>9</comment_count>
    <who name="Build Bot">buildbot</who>
    <bug_when>2011-04-01 22:00:05 -0700</bug_when>
    <thetext>Attachment 87961 did not build on win:
Build output: http://queues.webkit.org/results/8320384</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>379009</commentid>
    <comment_count>10</comment_count>
      <attachid>87961</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-04 13:23:43 -0700</bug_when>
    <thetext>Comment on attachment 87961
Updated patch to isolate includes only for Solaris, since it caused a failure on the windows build bots

This broke the build on several platforms so r-.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>379034</commentid>
    <comment_count>11</comment_count>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-04-04 13:53:01 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; (From update of attachment 87961 [details])
&gt; This broke the build on several platforms so r-.

What&apos;s the recommended way to isolate the header for a specific OS?

I thought the second solution, based on previous patches that I&apos;ve submitted would have been the right way to solve this problem.  I was very surprised to see the Linux/GTK systems fail the way they did.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>379042</commentid>
    <comment_count>12</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-04 13:56:56 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (In reply to comment #10)
&gt; &gt; (From update of attachment 87961 [details] [details])
&gt; &gt; This broke the build on several platforms so r-.
&gt; 
&gt; What&apos;s the recommended way to isolate the header for a specific OS?
&gt; 
&gt; I thought the second solution, based on previous patches that I&apos;ve submitted would have been the right way to solve this problem.  I was very surprised to see the Linux/GTK systems fail the way they did.

It looks like the failures for the QT and cr-linux builds are because the files which include the header must not have the define for OS(). I believe this is in config.h, so I would make sure those files include it.  (The may involve modified a script which generates some files.)

For Windows, I don&apos;t quite get what went wrong there (maybe something similar?).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382722</commentid>
    <comment_count>13</comment_count>
      <attachid>88917</attachid>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-04-08 22:31:59 -0700</bug_when>
    <thetext>Created attachment 88917
This should fix the issue of this patch causing issues with the build bots for linux and windows

This patch includes wtf/Platform.h so that the macro OS(SOLARIS) can be used to isolate the include.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382723</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-08 22:33:15 -0700</bug_when>
    <thetext>Attachment 88917 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1

Source/WebCore/loader/icon/IconRecord.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/loader/icon/IconRecord.h:43:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/network/ResourceResponseBase.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382724</commentid>
    <comment_count>15</comment_count>
      <attachid>88918</attachid>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-04-08 22:39:22 -0700</bug_when>
    <thetext>Created attachment 88918
This should fix the issue of this patch causing issues with the build bots for linux and windows, and clear some of the style bot issues

cosmetic fix, despite having logged bugs against check-webkit-style</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382725</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-08 22:41:56 -0700</bug_when>
    <thetext>Attachment 88918 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1

Source/WebCore/loader/icon/IconRecord.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/network/ResourceResponseBase.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382765</commentid>
    <comment_count>17</comment_count>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-04-09 04:15:37 -0700</bug_when>
    <thetext>(In reply to comment #16)
&gt; Attachment 88918 [details] did not pass style-queue:
&gt; 
&gt; Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1
&gt; 
&gt; Source/WebCore/loader/icon/IconRecord.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
&gt; Source/WebCore/platform/network/ResourceResponseBase.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
&gt; Total errors found: 2 in 4 files
&gt; 
&gt; 
&gt; If any of these errors are false positives, please file a bug against check-webkit-style.

They are falso positives, as previously indicated with previous versions of this patch series.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382838</commentid>
    <comment_count>18</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-09 20:30:12 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; cosmetic fix, despite having logged bugs against check-webkit-style

I see no bugs filed by you about check-webkit-style.

Also I&apos;ve looked at all issues mentioned in the bug and they are all real problems in your patches.

1. There should only be one space before end of line comments, so this
# &quot;header.h&quot;        // This is for whatever.
doesn&apos;t follow the proper style, but this does
# &quot;header.h&quot; // This is for whatever.

2. Headers that aren&apos;t ifdef&apos;ed are sorted.  Yours is not. I see
#include &lt;wtf/Platform.h&gt;
   occurring after things like
#include &lt;wtf/Vector.h&gt;

which isn&apos;t alphabetical.

3. When you run check-webkit-style on a file without your changes and get other issues, you can actually see that it is working correctly. It did not point out these problems on your patches because they were not in lines that you changed. However, in the patches that you submitted, it is pointing out correct issues on correct lines. :)

PS check-webkit-style does have some issues at times but we strive to have them be pretty rare and none are exhibited in these issues as far as I see.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382876</commentid>
    <comment_count>19</comment_count>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-04-10 04:57:34 -0700</bug_when>
    <thetext>(In reply to comment #18)
&gt; (In reply to comment #15)
&gt; &gt; cosmetic fix, despite having logged bugs against check-webkit-style
&gt; I see no bugs filed by you about check-webkit-style.

I know I filed one. Perhaps it was closed.

&gt; Also I&apos;ve looked at all issues mentioned in the bug and they are all real problems in your patches.
&gt; 1. There should only be one space before end of line comments, so this
&gt; # &quot;header.h&quot;        // This is for whatever.
&gt; doesn&apos;t follow the proper style, but this does
&gt; # &quot;header.h&quot; // This is for whatever.

Noted. Will make the fix. There are lots of place in webkit where
this was not followed, specifically made for &quot;formatting&quot; reasons.

&gt; 2. Headers that aren&apos;t ifdef&apos;ed are sorted.  Yours is not. I see
&gt; #include &lt;wtf/Platform.h&gt;
&gt;    occurring after things like
&gt; #include &lt;wtf/Vector.h&gt;
&gt; which isn&apos;t alphabetical.

Noted.  Will make the fix.  Obviously, sys/time.h will have to come after
wtf/Platform.h, since the macro protecting the include requires wtf/Platform.h

&gt; 3. When you run check-webkit-style on a file without your changes and get other issues, you can actually see that it is working correctly. It did not point out these problems on your patches because they were not in lines that you changed. However, in the patches that you submitted, it is pointing out correct issues on correct lines. :)

Noted.

&gt; PS check-webkit-style does have some issues at times but we strive to have them be pretty rare and none are exhibited in these issues as far as I see.

Will resubmit shortly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382877</commentid>
    <comment_count>20</comment_count>
      <attachid>88949</attachid>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-04-10 05:29:56 -0700</bug_when>
    <thetext>Created attachment 88949
Patch to fix a compile issue on Solaris 10 with Sun Studio 12, which includes &lt;sys/time.h&gt;, updated per bug comments

Patch resubmitted with include files ordered and comments structured. check-webkit-style run against the patch produced:

Total errors found: 0 in 1 files

This should resolve the remaining issues</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382919</commentid>
    <comment_count>21</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-10 11:52:36 -0700</bug_when>
    <thetext>(In reply to comment #20)
&gt; Created an attachment (id=88949) [details]
&gt; Patch to fix a compile issue on Solaris 10 with Sun Studio 12, which includes &lt;sys/time.h&gt;, updated per bug comments

OK the patch is well structured. Looking at the patch, I still believe what I said before is correct:

&quot;It looks like the failures for the QT and cr-linux builds are because the files which include the header must not have the define for OS(). I believe this is in config.h, so I would make sure those files include it.  (The may involve modified a script which generates some files.)&quot;

Specifically, I&apos;m saying that the real problem is that there are cpp files which aren&apos;t doing #include &quot;config.h&quot; and fixing that is what should be done as opposed to including wtf/Platform.h

So I can&apos;t r+ this, but I&apos;ll leave this open (without an r- just in case some other reviewer really believes this is the correct way to address the issue).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382927</commentid>
    <comment_count>22</comment_count>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-04-10 13:19:50 -0700</bug_when>
    <thetext>(In reply to comment #21)
&gt; (In reply to comment #20)
&gt; &gt; Created an attachment (id=88949) [details] [details]
&gt; &gt; Patch to fix a compile issue on Solaris 10 with Sun Studio 12, which includes &lt;sys/time.h&gt;, updated per bug comments
&gt; 
&gt; OK the patch is well structured. Looking at the patch, I still believe what I said before is correct:
&gt; 
&gt; &quot;It looks like the failures for the QT and cr-linux builds are because the files which include the header must not have the define for OS(). I believe this is in config.h, so I would make sure those files include it.  (The may involve modified a script which generates some files.)&quot;

The only time the QT and cr-linux tests failed were when I isolated the sys/time.h include with #if OS(SOLARIS), which failed because QT and cr-linux 
because the OS macro was not available there. 

&gt; Specifically, I&apos;m saying that the real problem is that there are cpp files which aren&apos;t doing #include &quot;config.h&quot; and fixing that is what should be done as opposed to including wtf/Platform.h

so including a &quot;config.h&quot; file which includes a pile of stuff is preferable to a surgical include with wtf/Platform.h?  Whatever.  I&apos;ll test your method and if it works, great, and I can be done with this patch and this disagreement.

&gt; So I can&apos;t r+ this, but I&apos;ll leave this open (without an r- just in case some other reviewer really believes this is the correct way to address the issue).

I hope someone else can review and either confirm your suspicion or confirm my patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382929</commentid>
    <comment_count>23</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-10 13:35:40 -0700</bug_when>
    <thetext>(In reply to comment #22) 
&gt; so including a &quot;config.h&quot; file which includes a pile of stuff is preferable to a surgical include with wtf/Platform.h?  Whatever.  I&apos;ll test your method and if it works, great, and I can be done with this patch and this disagreement.

Note including config.h in the cpp&apos;s not the header file.

&quot;All implementation files must #include &quot;config.h&quot; first. Header files should never include &quot;config.h&quot;.&quot; -- http://www.webkit.org/coding/coding-style.html

Really the include of wtf/Platform.h is working around a problem in a cpp file. No header should have to include wtf/Platform.h The only thing I don&apos;t know is if we make exceptions in some odd cases but I&apos;m not aware of them.

fwiw, I&apos;m trying to help you. I&apos;ll admit that my note about sorting headers was off. At that point I wasn&apos;t looking at the patch. Only looking at and reacting to the notes about check-webkit-style giving false positives and a quick glance showed me this wasn&apos;t true.

if you feel that I&apos;m not being helpful, I&apos;m willing to go away and not touch this bug anymore.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382933</commentid>
    <comment_count>24</comment_count>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-04-10 14:12:05 -0700</bug_when>
    <thetext>(In reply to comment #23)
&gt; (In reply to comment #22) 
&gt; &gt; so including a &quot;config.h&quot; file which includes a pile of stuff is preferable to a surgical include with wtf/Platform.h?  Whatever.  I&apos;ll test your method and if it works, great, and I can be done with this patch and this disagreement.
&gt; 
&gt; Note including config.h in the cpp&apos;s not the header file.

I&apos;m assuming (other than the style issues) that you meant that I should be able to replace &lt;wtf/Platform.h&gt; and expect that &lt;sys/time.h&gt; would be included on SOLARIS systems only.  (Which is exactly what I&apos;ve done on my
local base for compile testing) 

&gt; &quot;All implementation files must #include &quot;config.h&quot; first. Header files should never include &quot;config.h&quot;.&quot; -- http://www.webkit.org/coding/coding-style.html

indirect includes are always bad..

&gt; Really the include of wtf/Platform.h is working around a problem in a cpp file. No header should have to include wtf/Platform.h The only thing I don&apos;t know is if we make exceptions in some odd cases but I&apos;m not aware of them.

oh, I&apos;m starting to see where you&apos;re going here.  So any cpp file that includes those three patched includes, would require the config.h, if they don&apos;t. I bet this patch now explodes with the number of files now required to be modified.  

&gt; fwiw, I&apos;m trying to help you. I&apos;ll admit that my note about sorting headers was off. At that point I wasn&apos;t looking at the patch. Only looking at and reacting to the notes about check-webkit-style giving false positives and a quick glance showed me this wasn&apos;t true.

Consider that running check-webkit-style against the files I&apos;m working on,
and having it spit out a bunch of errors prior to modification, and then be told you&apos;re not doing it the right way.  Seems a bit hypocritical. But I can also see that the style engine may have come later and other files may still have style issues that won&apos;t be fixed, just for style issues.   I&apos;m ok with that.  Just confusing..

&gt; if you feel that I&apos;m not being helpful, I&apos;m willing to go away and not touch this bug anymore.

I&apos;m happy for reviews, just having a hard time trying to get this patch into shape given all the &quot;constraints&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382937</commentid>
    <comment_count>25</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-10 14:53:54 -0700</bug_when>
    <thetext>(In reply to comment #24)
&gt; oh, I&apos;m starting to see where you&apos;re going here.  So any cpp file that includes those three patched includes, would require the config.h, if they don&apos;t.

Yes.

&gt; I bet this patch now explodes with the number of files now required to be modified.  

Hopefully not. We&apos;re pretty good about this, but I bet you&apos;re hitting a problem in the autogenerated files. It is unfortunate if they don&apos;t properly include config.h, but I guess no one noticed and since they are autogenerated our style checker wouldn&apos;t have caught that like it normally would.

 Perhaps I can work up a fix for that (if you don&apos;t get to it first... I think the files are here: http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts (Well on the web but you can find them locally as well).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382946</commentid>
    <comment_count>26</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-10 15:46:57 -0700</bug_when>
    <thetext>(In reply to comment #25)
&gt; (In reply to comment #24)
&gt;  Perhaps I can work up a fix for that (if you don&apos;t get to it first... I think the files are here: http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts (Well on the web but you can find them locally as well).

Hmm I started looking into this and it isn&apos;t obvious to me that I pointed out the correct place. (This isn&apos;t an area that I deal with a lot.) I need to attend to some other items at the moment, but I&apos;ll try to fix the include config.h issue for the v8 files at least this evening (in about 5 hours).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>383294</commentid>
    <comment_count>27</comment_count>
      <attachid>89034</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-11 11:18:17 -0700</bug_when>
    <thetext>Created attachment 89034
Test Patch for EWS</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>383326</commentid>
    <comment_count>28</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-11 11:50:24 -0700</bug_when>
    <thetext>(In reply to comment #27)
&gt; Created an attachment (id=89034) [details]
&gt; Patch

Ok, the problem in the original patches appears to have been the use of #ifdef instead of #if.

I missed that and unfortunately brought config.h into the picture which just confused things.

Waiting a bit longer on the win build to make sure it passes before r+&apos;ing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>383636</commentid>
    <comment_count>29</comment_count>
      <attachid>89034</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-11 16:06:38 -0700</bug_when>
    <thetext>Comment on attachment 89034
Test Patch for EWS


Clearing flags on attachment: 89034

Committed r83526: &lt;http://trac.webkit.org/changeset/83526&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>383637</commentid>
    <comment_count>30</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-11 16:06:44 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>87700</attachid>
            <date>2011-03-31 04:46:41 -0700</date>
            <delta_ts>2011-04-01 21:36:18 -0700</delta_ts>
            <desc>Fix compilation on Solaris 10 with Sun Studio 12, missing definition for time_t</desc>
            <filename>webkit-bug-57535-fix-missing-time.h-include.diff</filename>
            <type>text/plain</type>
            <size>1883</size>
            <attacher name="Ben Taylor">bentaylor.solx86</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyNTYxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMzEgIEJlbiBUYXls
b3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NTc1MzUKKworICAgICAgICBGaXggY29tcGlsYXRpb24gb24gU29sYXJpcyAxMC9T
dW4gU3R1ZGlvIDEyLCBtaXNzaW5nIAorICAgICAgICBkZWZpbml0aW9uIGZvciB0aW1lX3QKKwor
ICAgICAgICAqIGxvYWRlci9pY29uL0ljb25SZWNvcmQuaDoKKyAgICAgICAgKiBwYWdlL1BhZ2Uu
aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmg6CisK
IDIwMTEtMDMtMzEgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1zdW5nLmNvbT4KIAogICAg
ICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9p
Y29uL0ljb25SZWNvcmQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNv
bi9JY29uUmVjb3JkLmgJKHJldmlzaW9uIDgyNTM1KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVy
L2ljb24vSWNvblJlY29yZC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw2ICszOCw4IEBACiAjaW5j
bHVkZSA8d3RmL093blB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0hhc2guaD4KIAor
I2luY2x1ZGUgPHN5cy90eXBlcy5oPiAgICAgICAgICAvLyBmb3IgdGltZV90CisKIG5hbWVzcGFj
ZSBXZWJDb3JlIHsgCiAKIGNsYXNzIEljb25EYXRhU25hcHNob3Q7CkluZGV4OiBTb3VyY2UvV2Vi
Q29yZS9wYWdlL1BhZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2Uu
aAkocmV2aXNpb24gODI1MzUpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuaAkod29ya2lu
ZyBjb3B5KQpAQCAtMjgsNiArMjgsNyBAQAogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CiAjaW5j
bHVkZSA8d3RmL0hhc2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KKyNpbmNs
dWRlIDxzeXMvdGltZS5oPgogCiAjaWYgUExBVEZPUk0oTUFDKQogI2luY2x1ZGUgIlNjaGVkdWxl
UGFpci5oIgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJl
c3BvbnNlQmFzZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv
cmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuaAkocmV2aXNpb24gODI1MzUpCisrKyBTb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmgJKHdvcmtpbmcgY29w
eSkKQEAgLTM1LDYgKzM1LDggQEAKICNpbmNsdWRlIDx3dGYvUGFzc093blB0ci5oPgogI2luY2x1
ZGUgPHd0Zi9SZWZQdHIuaD4KIAorI2luY2x1ZGUgPHN5cy90aW1lLmg+ICAgICAgICAgIC8vIGZv
ciB0aW1lX3QKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBSZXNvdXJjZVJlc3BvbnNl
Owo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>87961</attachid>
            <date>2011-04-01 21:36:18 -0700</date>
            <delta_ts>2011-04-08 22:31:59 -0700</delta_ts>
            <desc>Updated patch to isolate includes only for Solaris, since it caused a failure on the windows build bots</desc>
            <filename>webkit-bug-57535-solaris-needs-time_t.diff</filename>
            <type>text/plain</type>
            <size>1921</size>
            <attacher name="Ben Taylor">bentaylor.solx86</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyNTYxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMzEgIEJlbiBUYXls
b3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NTc1MzUKKworICAgICAgICBGaXggY29tcGlsYXRpb24gb24gU29sYXJpcyAxMC9T
dW4gU3R1ZGlvIDEyLCBtaXNzaW5nIAorICAgICAgICBkZWZpbml0aW9uIGZvciB0aW1lX3QKKwor
ICAgICAgICAqIGxvYWRlci9pY29uL0ljb25SZWNvcmQuaDoKKyAgICAgICAgKiBwYWdlL1BhZ2Uu
aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmg6CisK
IDIwMTEtMDMtMzEgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1zdW5nLmNvbT4KIAogICAg
ICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9p
Y29uL0ljb25SZWNvcmQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNv
bi9JY29uUmVjb3JkLmgJKHJldmlzaW9uIDgyNTM1KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVy
L2ljb24vSWNvblJlY29yZC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw2ICszNyw5IEBACiAjaW5j
bHVkZSA8d3RmL0hhc2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8
d3RmL3RleHQvU3RyaW5nSGFzaC5oPgorI2lmZGVmIE9TKFNPTEFSSVMpCisjaW5jbHVkZSA8c3lz
L3R5cGVzLmg+CisjZW5kaWYKIAogbmFtZXNwYWNlIFdlYkNvcmUgeyAKIApJbmRleDogU291cmNl
L1dlYkNvcmUvcGFnZS9QYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9Q
YWdlLmgJKHJldmlzaW9uIDgyNTM1KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgJKHdv
cmtpbmcgY29weSkKQEAgLTI4LDYgKzI4LDkgQEAKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgog
I2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAjaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+Cisj
aWZkZWYgT1MoU09MQVJJUykKKyNpbmNsdWRlIDxzeXMvdGltZS5oPgorI2VuZGlmCiAKICNpZiBQ
TEFURk9STShNQUMpCiAjaW5jbHVkZSAiU2NoZWR1bGVQYWlyLmgiCkluZGV4OiBTb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmgKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5o
CShyZXZpc2lvbiA4MjUzNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVz
b3VyY2VSZXNwb25zZUJhc2UuaAkod29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUsMTAgQEAKICNp
bmNsdWRlIDx3dGYvUGFzc093blB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIAorI2lm
ZGVmIE9TKFNPTEFSSVMpCisjaW5jbHVkZSA8c3lzL3RpbWUuaD4KKyNlbmRpZgorCiBuYW1lc3Bh
Y2UgV2ViQ29yZSB7CiAKIGNsYXNzIFJlc291cmNlUmVzcG9uc2U7Cg==
</data>
<flag name="review"
          id="80422"
          type_id="1"
          status="-"
          setter="levin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88917</attachid>
            <date>2011-04-08 22:31:59 -0700</date>
            <delta_ts>2011-04-08 22:43:22 -0700</delta_ts>
            <desc>This should fix the issue of this patch causing issues with the build bots for linux and windows</desc>
            <filename>webkit-bug-57535-compile-fix-for-Solaris10-sys_time.h.diff</filename>
            <type>text/plain</type>
            <size>2015</size>
            <attacher name="Ben Taylor">bentaylor.solx86</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMzc0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMDggIEJlbiBUYXls
b3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NTc1MzUKKworICAgICAgICBCZXR0ZXIgY29tcGlsZSBmaXggZm9yIFNvbGFyaXMg
MTAvU3VuIFN0dWRpbyAxMiBDQyAKKyAgICAgICAgbmVlZGluZyA8c3lzL3RpbWUuaD4KKworICAg
ICAgICAqIGxvYWRlci9pY29uL0ljb25SZWNvcmQuaDoKKyAgICAgICAgKiBwYWdlL1BhZ2UuaDoK
KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmg6CisKIDIw
MTEtMDQtMDggIERhdmlkIEh1bXBocmV5ICA8ZGF2aWQuaHVtcGhyZXlAc2VuZWNhYy5vbi5jYT4K
IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCkluZGV4OiBTb3VyY2UvV2ViQ29y
ZS9sb2FkZXIvaWNvbi9JY29uUmVjb3JkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv
bG9hZGVyL2ljb24vSWNvblJlY29yZC5oCShyZXZpc2lvbiA4MzM3MikKKysrIFNvdXJjZS9XZWJD
b3JlL2xvYWRlci9pY29uL0ljb25SZWNvcmQuaAkod29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgs
MTEgQEAKICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5n
SGFzaC5oPgogCisjaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CisjaWYgT1MoU09MQVJJUykgCisj
aW5jbHVkZSA8c3lzL3R5cGVzLmg+ICAgICAgICAgIC8vIGZvciB0aW1lX3QKKyNlbmRpZgorCiBu
YW1lc3BhY2UgV2ViQ29yZSB7IAogCiBjbGFzcyBJY29uRGF0YVNuYXBzaG90OwpJbmRleDogU291
cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFn
ZS9QYWdlLmgJKHJldmlzaW9uIDgzMzcyKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgJ
KHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDExIEBACiAjaW5jbHVkZSA8d3RmL0hhc2hTZXQu
aD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KIAorI2luY2x1ZGUgPHd0Zi9QbGF0Zm9y
bS5oPgorI2lmIE9TKFNPTEFSSVMpIAorI2luY2x1ZGUgPHN5cy90aW1lLmg+CisjZW5kaWYKKwog
I2lmIFBMQVRGT1JNKE1BQykKICNpbmNsdWRlICJTY2hlZHVsZVBhaXIuaCIKICNlbmRpZgpJbmRl
eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5o
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VS
ZXNwb25zZUJhc2UuaAkocmV2aXNpb24gODMzNzIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYg
KzM1LDExIEBACiAjaW5jbHVkZSA8d3RmL1Bhc3NPd25QdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVm
UHRyLmg+CiAKKyNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KKyNpZiBPUyhTT0xBUklTKQorI2lu
Y2x1ZGUgPHN5cy90aW1lLmg+CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFz
cyBSZXNvdXJjZVJlc3BvbnNlOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88918</attachid>
            <date>2011-04-08 22:39:22 -0700</date>
            <delta_ts>2011-04-10 05:30:28 -0700</delta_ts>
            <desc>This should fix the issue of this patch causing issues with the build bots for linux and windows, and clear some of the style bot issues</desc>
            <filename>webkit-bug-57535-compile-fix-for-Solaris10-sys_time.h.diff</filename>
            <type>text/plain</type>
            <size>1990</size>
            <attacher name="Ben Taylor">bentaylor.solx86</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMzc0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMDggIEJlbiBUYXls
b3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NTc1MzUKKworICAgICAgICBCZXR0ZXIgY29tcGlsZSBmaXggZm9yIFNvbGFyaXMg
MTAvU3VuIFN0dWRpbyAxMiBDQyAKKyAgICAgICAgbmVlZGluZyA8c3lzL3RpbWUuaD4KKworICAg
ICAgICAqIGxvYWRlci9pY29uL0ljb25SZWNvcmQuaDoKKyAgICAgICAgKiBwYWdlL1BhZ2UuaDoK
KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmg6CisKIDIw
MTEtMDQtMDggIERhdmlkIEh1bXBocmV5ICA8ZGF2aWQuaHVtcGhyZXlAc2VuZWNhYy5vbi5jYT4K
IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCkluZGV4OiBTb3VyY2UvV2ViQ29y
ZS9sb2FkZXIvaWNvbi9JY29uUmVjb3JkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv
bG9hZGVyL2ljb24vSWNvblJlY29yZC5oCShyZXZpc2lvbiA4MzM3MikKKysrIFNvdXJjZS9XZWJD
b3JlL2xvYWRlci9pY29uL0ljb25SZWNvcmQuaAkod29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgs
MTEgQEAKICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5n
SGFzaC5oPgogCisjaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CisjaWYgT1MoU09MQVJJUykKKyNp
bmNsdWRlIDxzeXMvdHlwZXMuaD4KKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7IAogCiBj
bGFzcyBJY29uRGF0YVNuYXBzaG90OwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgJKHJldmlzaW9uIDgzMzcy
KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTI5LDYg
KzI5LDExIEBACiAjaW5jbHVkZSA8d3RmL0hhc2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvTm9uY29w
eWFibGUuaD4KIAorI2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybS5oPgorI2lmIE9TKFNPTEFSSVMpCisj
aW5jbHVkZSA8c3lzL3RpbWUuaD4KKyNlbmRpZgorCiAjaWYgUExBVEZPUk0oTUFDKQogI2luY2x1
ZGUgIlNjaGVkdWxlUGFpci5oIgogI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5oCShyZXZpc2lvbiA4
MzM3MikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNwb25z
ZUJhc2UuaAkod29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUsMTEgQEAKICNpbmNsdWRlIDx3dGYv
UGFzc093blB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIAorI2luY2x1ZGUgPHd0Zi9Q
bGF0Zm9ybS5oPgorI2lmIE9TKFNPTEFSSVMpCisjaW5jbHVkZSA8c3lzL3RpbWUuaD4KKyNlbmRp
ZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIFJlc291cmNlUmVzcG9uc2U7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88949</attachid>
            <date>2011-04-10 05:29:56 -0700</date>
            <delta_ts>2011-04-11 11:18:13 -0700</delta_ts>
            <desc>Patch to fix a compile issue on Solaris 10 with Sun Studio 12, which includes &lt;sys/time.h&gt;, updated per bug comments</desc>
            <filename>webkit-bug-57535-compile-fix-for-Solaris10-sys_time.h.diff</filename>
            <type>text/plain</type>
            <size>2283</size>
            <attacher name="Ben Taylor">bentaylor.solx86</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMzc0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMDggIEJlbiBUYXls
b3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NTc1MzUKKworICAgICAgICBCZXR0ZXIgY29tcGlsZSBmaXggZm9yIFNvbGFyaXMg
MTAvU3VuIFN0dWRpbyAxMiBDQyAKKyAgICAgICAgbmVlZGluZyA8c3lzL3RpbWUuaD4KKworICAg
ICAgICAqIGxvYWRlci9pY29uL0ljb25SZWNvcmQuaDoKKyAgICAgICAgKiBwYWdlL1BhZ2UuaDoK
KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmg6CisKIDIw
MTEtMDQtMDggIERhdmlkIEh1bXBocmV5ICA8ZGF2aWQuaHVtcGhyZXlAc2VuZWNhYy5vbi5jYT4K
IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCkluZGV4OiBTb3VyY2UvV2ViQ29y
ZS9sb2FkZXIvaWNvbi9JY29uUmVjb3JkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv
bG9hZGVyL2ljb24vSWNvblJlY29yZC5oCShyZXZpc2lvbiA4MzM3MikKKysrIFNvdXJjZS9XZWJD
b3JlL2xvYWRlci9pY29uL0ljb25SZWNvcmQuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsOCArMzYs
MTMgQEAKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5oIgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0
Lmg+CiAjaW5jbHVkZSA8d3RmL093blB0ci5oPgorI2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybS5oPiAv
LyBGb3IgdGhlIE9TKFNPTEFSSVMpIG1hY3JvIGJlbG93LgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0
cmluZ0hhc2guaD4KIAorI2lmIE9TKFNPTEFSSVMpIAorI2luY2x1ZGUgPHN5cy90eXBlcy5oPiAv
LyBGb3IgdGltZV90IHN0cnVjdHVyZS4KKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7IAog
CiBjbGFzcyBJY29uRGF0YVNuYXBzaG90OwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl
LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgJKHJldmlzaW9uIDgz
MzcyKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTI4
LDYgKzI4LDExIEBACiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNpbmNsdWRlIDx3dGYvSGFz
aFNldC5oPgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgorI2luY2x1ZGUgPHd0Zi9QbGF0
Zm9ybS5oPiAvLyBGb3IgdGhlIE9TKFNPTEFSSVMpIG1hY3JvIGJlbG93LgorCisjaWYgT1MoU09M
QVJJUykgCisjaW5jbHVkZSA8c3lzL3RpbWUuaD4gLy8gRm9yIHRpbWVfdCBzdHJ1Y3R1cmUuCisj
ZW5kaWYKIAogI2lmIFBMQVRGT1JNKE1BQykKICNpbmNsdWRlICJTY2hlZHVsZVBhaXIuaCIKSW5k
ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNwb25zZUJhc2Uu
aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNl
UmVzcG9uc2VCYXNlLmgJKHJldmlzaW9uIDgzMzcyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw4
ICszMywxMyBAQAogI2luY2x1ZGUgIlJlc291cmNlTG9hZFRpbWluZy5oIgogCiAjaW5jbHVkZSA8
d3RmL1Bhc3NPd25QdHIuaD4KKyNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4gLy8gRm9yIHRoZSBP
UyhTT0xBUklTKSBtYWNybyBiZWxvdy4KICNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CiAKKyNpZiBP
UyhTT0xBUklTKQorI2luY2x1ZGUgPHN5cy90aW1lLmg+IC8vIEZvciB0aW1lX3Qgc3RydWN0dXJl
LgorI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgUmVzb3VyY2VSZXNwb25z
ZTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89034</attachid>
            <date>2011-04-11 11:18:17 -0700</date>
            <delta_ts>2011-04-11 16:06:38 -0700</delta_ts>
            <desc>Test Patch for EWS
</desc>
            <filename>bug-57535-20110411111816.patch</filename>
            <type>text/plain</type>
            <size>2160</size>
            <attacher name="David Levin">levin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODM0NTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ZWFmZmNiZjIwYzY4Y2Iy
OGU5NWFlM2QxMzlkOTE4YjkzNjI3YjcyLi4wMGJiNjA2ZWJmMDMyN2YyZTFjMDM1YjQ2NDdmZGZh
ZTgyNzI5Yjk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTEgIEJlbiBU
YXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9NTc1MzUKKworICAgICAgICBCZXR0ZXIgY29tcGlsZSBmaXggZm9yIFNvbGFy
aXMgMTAvU3VuIFN0dWRpbyAxMiBDQyAKKyAgICAgICAgbmVlZGluZyA8c3lzL3RpbWUuaD4KKwor
ICAgICAgICAqIGxvYWRlci9pY29uL0ljb25SZWNvcmQuaDoKKyAgICAgICAgKiBwYWdlL1BhZ2Uu
aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmg6CisK
IDIwMTEtMDQtMTEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBC
dWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uUmVj
b3JkLmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uUmVjb3JkLmgKaW5kZXggNjI5
OWY1NGNlMDMwYzk1NzVhOGFkNGI5NGVhOTc5MDYxOWFmNGIxZS4uNTBlZjdmNzYyZmZkMzIxOTNl
NmU1ZmYyZGRhY2RiMDU3YTA0ZmM0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVy
L2ljb24vSWNvblJlY29yZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25S
ZWNvcmQuaApAQCAtMzgsNiArMzgsMTAgQEAKICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5j
bHVkZSA8d3RmL3RleHQvU3RyaW5nSGFzaC5oPgogCisjaWYgT1MoU09MQVJJUykKKyNpbmNsdWRl
IDxzeXMvdHlwZXMuaD4gLy8gRm9yIHRpbWVfdCBzdHJ1Y3R1cmUuCisjZW5kaWYKKwogbmFtZXNw
YWNlIFdlYkNvcmUgeyAKIAogY2xhc3MgSWNvbkRhdGFTbmFwc2hvdDsKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKaW5k
ZXggODMwNzEyM2IyMTEzMDYwM2U5N2I4NjBlYzJiZWQ1YTA5ODVmNzc4Ni4uYWM0YzE2MDRiZGM5
Mjc4YjhlOWY5YmQ0MmJiMjQ3NzI2OTM2NjU0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv
cGFnZS9QYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKQEAgLTI5LDYgKzI5
LDEwIEBACiAjaW5jbHVkZSA8d3RmL0hhc2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFi
bGUuaD4KIAorI2lmIE9TKFNPTEFSSVMpCisjaW5jbHVkZSA8c3lzL3RpbWUuaD4gLy8gRm9yIHRp
bWVfdCBzdHJ1Y3R1cmUuCisjZW5kaWYKKwogI2lmIFBMQVRGT1JNKE1BQykKICNpbmNsdWRlICJT
Y2hlZHVsZVBhaXIuaCIKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5oCmluZGV4IDM3NzU3OTEzNjlkNmE2ZTA4
NGNiMWY1MjZmM2JjOWY1YTNlMTUzOGUuLjI1MDQxMWMzYjg5ZGYwZWYyYjNkMjY3NmRmMThhOThk
MTNkYzMyMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVz
b3VyY2VSZXNwb25zZUJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr
L1Jlc291cmNlUmVzcG9uc2VCYXNlLmgKQEAgLTM1LDYgKzM1LDEwIEBACiAjaW5jbHVkZSA8d3Rm
L1Bhc3NPd25QdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CiAKKyNpZiBPUyhTT0xBUklT
KQorI2luY2x1ZGUgPHN5cy90aW1lLmg+IC8vIEZvciB0aW1lX3Qgc3RydWN0dXJlLgorI2VuZGlm
CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgUmVzb3VyY2VSZXNwb25zZTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>