57529 2011-03-31 00:51:19 -0700 WebKit2: Save as PDF in Safari provides Untitled as default file name 2011-04-01 16:08:40 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 jer.noble jer.noble oldest_to_newest 376982 0 jer.noble 2011-03-31 00:51:19 -0700 When saving as PDF from Safari, the default file name provided is Untitled. 376983 1 jer.noble 2011-03-31 00:51:36 -0700 <rdar://problem/8998510> 376991 2 87679 jer.noble 2011-03-31 01:26:00 -0700 Created attachment 87679 Patch 377844 3 87679 ap 2011-04-01 09:15:18 -0700 Comment on attachment 87679 Patch Interestingly, this is not how it works in WebKit1 - my theory is that NSPrintOperation gets job title from window title by default, but WKPrintingView doesn't have a window. 377886 4 jer.noble 2011-04-01 10:10:04 -0700 That's exactly right. [NSPrintOperation setJobTitle:] overrides the default behavior, which is to call [NSView printJobTitle], which returns the document's displayName. 378170 5 jer.noble 2011-04-01 16:08:40 -0700 Committed r82737: <http://trac.webkit.org/changeset/82737> 87679 2011-03-31 01:26:00 -0700 2011-04-01 09:15:18 -0700 Patch bug-57529-20110331012600.patch text/plain 1626 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODI0NzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAwYjFkNWM1MjRjYWU5N2Qy ZjU2NTFlOTg1MDkwMTNmMzRiNDNkMTMyLi5kNTZlYzUzNjcwNzcwNzU3YmEyZmUxNzViMjhhMWI2 MWNlM2E3NzljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTggQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBXZWJLaXQyOiBTYXZlIGFzIFBERiBpbiBT YWZhcmkgcHJvdmlkZXMgVW50aXRsZWQgYXMgZGVmYXVsdCBmaWxlIG5hbWUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NTI5CisKKyAgICAgICAgU2V0 IHRoZSBOU1ByaW50T3BlcmF0aW9uJ3Mgam9iVGl0bGUgdG8gdGhlIHByaW50aW5nIGZyYW1lJ3Mg dGl0bGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAgICAg ICgtW1dLVmlldyBwcmludE9wZXJhdGlvbldpdGhQcmludEluZm86Zm9yRnJhbWU6XSk6CisKKzIw MTEtMDMtMzEgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgV2ViS2l0MjogTGluayBmcm9tIFBE RiBvcGVucyBpbiBhIG5ldyB0YWIgaW5zdGVhZCBvZiBpbiB0aGUgc2FtZSB0YWIKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NTI4CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbSBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQppbmRleCAwNTY5M2VmMjgxYzlkMDU1 NjI2M2E4NjVmYWFiOTRmZmJlYWRhYWUwLi4zN2VmOWY0NTgzNzM0MTkyOTExZWIwMWQzNTIxNTA3 MmEzNDgxODJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1t CkBAIC0xNjY3LDYgKzE2NjcsNyBAQCBzdGF0aWMgdm9pZCBkcmF3UGFnZUJhY2tncm91bmQoQ0dD b250ZXh0UmVmIGNvbnRleHQsIFdlYlBhZ2VQcm94eSogcGFnZSwgY29uc3QgSQogICAgICAgICAv LyBOU1ByaW50T3BlcmF0aW9uIHRha2VzIG93bmVyc2hpcCBvZiB0aGUgdmlldy4KICAgICAgICAg TlNQcmludE9wZXJhdGlvbiAqcHJpbnRPcGVyYXRpb24gPSBbTlNQcmludE9wZXJhdGlvbiBwcmlu dE9wZXJhdGlvbldpdGhWaWV3OnByaW50aW5nVmlldy5nZXQoKV07CiAgICAgICAgIFtwcmludE9w ZXJhdGlvbiBzZXRDYW5TcGF3blNlcGFyYXRlVGhyZWFkOllFU107CisgICAgICAgIFtwcmludE9w ZXJhdGlvbiBzZXRKb2JUaXRsZTp0b0ltcGwoZnJhbWVSZWYpLT50aXRsZSgpXTsKICAgICAgICAg cHJpbnRpbmdWaWV3LT5fcHJpbnRPcGVyYXRpb24gPSBwcmludE9wZXJhdGlvbjsKICAgICAgICAg cmV0dXJuIHByaW50T3BlcmF0aW9uOwogICAgIH0K