57517 2011-03-30 18:04:05 -0700 Downloading a file fails due to a sandbox violation if the destination path is a symlink 2011-03-30 18:11:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 376832 0 andersca 2011-03-30 18:04:05 -0700 Downloading a file fails due to a sandbox violation if the destination path is a symlink 376833 1 87649 andersca 2011-03-30 18:06:18 -0700 Created attachment 87649 Patch 376834 2 87649 sam 2011-03-30 18:07:46 -0700 Comment on attachment 87649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87649&action=review > Source/WebKit2/Shared/mac/SandboxExtensionMac.mm:123 > + char *slashPtr = strrchr(path.data(), '/'); * on wrong side. 376836 3 andersca 2011-03-30 18:11:33 -0700 Committed r82527: <http://trac.webkit.org/changeset/82527> 87649 2011-03-30 18:06:18 -0700 2011-03-30 18:07:46 -0700 Patch bug-57517-20110330180617.patch text/plain 3940 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyNTI1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDMtMzAgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEb3dubG9hZGluZyBhIGZpbGUgZmFpbHMgZHVlIHRvIGEg c2FuZGJveCB2aW9sYXRpb24gaWYgdGhlIGRlc3RpbmF0aW9uIHBhdGggaXMgYSBzeW1saW5rCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzUxNworICAg ICAgICA8cmRhcjovL3Byb2JsZW0vODk0Mzg2NT4KKworICAgICAgICBNYWtlIHN1cmUgdG8gcmVz b2x2ZSBhbnkgc3ltbGlua3MgaW4gdGhlIGdpdmVuIHBhdGggd2hlbiBjcmVhdGluZyBhIHNhbmRi b3ggZXh0ZW5zaW9uIGhhbmRsZS4KKyAgICAgICAgTm90ZSB0aGF0IHdlIGNhbid0IHVzZSByZWFs cGF0aCBvciAtW05TU3RyaW5nIHN0cmluZ0J5UmVzb2x2aW5nU3ltbGlua3NJblBhdGhdLCBiZWNh dXNlIHRob3NlIGNhbGxzCisgICAgICAgIHdpbGwgZmFpbCBpZiB0aGUgcG9pbnRlZCB0byBmaWxl IGRvZXNuJ3QgZXhpc3QuCisKKyAgICAgICAgKiBTaGFyZWQvbWFjL1NhbmRib3hFeHRlbnNpb25N YWMubW06CisgICAgICAgIChXZWJLaXQ6OnJlc29sdmVTeW1saW5rc0luUGF0aCk6CisgICAgICAg IE5ldyBmdW5jdGlvbiB0aGF0IHJlc29sdmVzIGFsbCB0aGUgc3ltbGlua3MgaW4gdGhlIGdpdmVu IHBhdGguCisKKyAgICAgICAgKFdlYktpdDo6U2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxl KToKKyAgICAgICAgQ2FsbCByZXNvbHZlU3ltbGlua3NJblBhdGggb24gdGhlIHJlc3VsdGluZyBw YXRoLgorCiAyMDExLTAzLTMwICBTdGV2ZSBGYWxrZW5idXJnICA8c2ZhbGtlbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1NoYXJlZC9tYWMvU2FuZGJveEV4dGVuc2lvbk1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvbWFjL1NhbmRib3hFeHRlbnNpb25NYWMubW0JKHJldmlzaW9uIDgyNDg4 KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9TYW5kYm94RXh0ZW5zaW9uTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3IEBACiAjaW1wb3J0ICJEYXRhUmVmZXJlbmNlLmgi CiAjaW1wb3J0ICJXZWJLaXRTeXN0ZW1JbnRlcmZhY2UuaCIKICNpbXBvcnQgPFdlYkNvcmUvRmls ZVN5c3RlbS5oPgorI2ltcG9ydCA8c3lzL3N0YXQuaD4KICNpbXBvcnQgPHd0Zi90ZXh0L0NTdHJp bmcuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CkBAIC0xMDgsMTIgKzEwOSw1NSBAQCBz dGF0aWMgV0tTYW5kYm94RXh0ZW5zaW9uVHlwZSB3a1NhbmRib3hFCiAgICAgcmV0dXJuIFdLU2Fu ZGJveEV4dGVuc2lvblR5cGVSZWFkT25seTsKIH0KIAorc3RhdGljIENTdHJpbmcgcmVzb2x2ZVN5 bWxpbmtzSW5QYXRoKGNvbnN0IENTdHJpbmcmIHBhdGgpCit7CisgICAgc3RydWN0IHN0YXQgc3Rh dEJ1ZjsKKworICAgIC8vIENoZWNrIGlmIHRoaXMgZmlsZSBleGlzdHMuCisgICAgaWYgKCFzdGF0 KHBhdGguZGF0YSgpLCAmc3RhdEJ1ZikpIHsKKyAgICAgICAgY2hhciByZXNvbHZlZE5hbWVbUEFU SF9NQVhdOworCisgICAgICAgIHJldHVybiByZWFscGF0aChwYXRoLmRhdGEoKSwgcmVzb2x2ZWRO YW1lKTsKKyAgICB9CisKKyAgICBjaGFyICpzbGFzaFB0ciA9IHN0cnJjaHIocGF0aC5kYXRhKCks ICcvJyk7CisgICAgaWYgKHNsYXNoUHRyID09IHBhdGguZGF0YSgpKQorICAgICAgICByZXR1cm4g cGF0aDsKKworICAgIHNpemVfdCBwYXJlbnREaXJlY3RvcnlMZW5ndGggPSBzbGFzaFB0ciAtIHBh dGguZGF0YSgpOworICAgIGlmIChwYXJlbnREaXJlY3RvcnlMZW5ndGggPj0gUEFUSF9NQVgpCisg ICAgICAgIHJldHVybiBDU3RyaW5nKCk7CisKKyAgICAvLyBHZXQgdGhlIHBhcmVudCBkaXJlY3Rv cnkuCisgICAgY2hhciBwYXJlbnREaXJlY3RvcnlbUEFUSF9NQVhdOworICAgIG1lbWNweShwYXJl bnREaXJlY3RvcnksIHBhdGguZGF0YSgpLCBwYXJlbnREaXJlY3RvcnlMZW5ndGgpOworICAgIHBh cmVudERpcmVjdG9yeVtwYXJlbnREaXJlY3RvcnlMZW5ndGhdID0gJ1wwJzsKKworICAgIC8vIFJl c29sdmUgaXQuCisgICAgQ1N0cmluZyByZXNvbHZlZFBhcmVudERpcmVjdG9yeSA9IHJlc29sdmVT eW1saW5rc0luUGF0aChDU3RyaW5nKHBhcmVudERpcmVjdG9yeSkpOworICAgIGlmIChyZXNvbHZl ZFBhcmVudERpcmVjdG9yeS5pc051bGwoKSkKKyAgICAgICAgcmV0dXJuIENTdHJpbmcoKTsKKwor ICAgIHNpemVfdCBsYXN0UGF0aENvbXBvbmVudExlbmd0aCA9IHBhdGgubGVuZ3RoKCkgLSBwYXJl bnREaXJlY3RvcnlMZW5ndGg7CisgICAgc2l6ZV90IHJlc29sdmVkUGF0aExlbmd0aCA9IHJlc29s dmVkUGFyZW50RGlyZWN0b3J5Lmxlbmd0aCgpICsgbGFzdFBhdGhDb21wb25lbnRMZW5ndGg7Cisg ICAgaWYgKHJlc29sdmVkUGF0aExlbmd0aCA+PSBQQVRIX01BWCkKKyAgICAgICAgcmV0dXJuIENT dHJpbmcoKTsKKworICAgIC8vIENvbWJpbmUgdGhlIHJlc29sdmVkIHBhcmVudCBkaXJlY3Rvcnkg d2l0aCB0aGUgbGFzdCBwYXRoIGNvbXBvbmVudC4KKyAgICBjaGFyKiByZXNvbHZlZFBhdGhCdWZm ZXI7CisgICAgQ1N0cmluZyByZXNvbHZlZFBhdGggPSBDU3RyaW5nOjpuZXdVbmluaXRpYWxpemVk KHJlc29sdmVkUGF0aExlbmd0aCwgcmVzb2x2ZWRQYXRoQnVmZmVyKTsKKyAgICBtZW1jcHkocmVz b2x2ZWRQYXRoQnVmZmVyLCByZXNvbHZlZFBhcmVudERpcmVjdG9yeS5kYXRhKCksIHJlc29sdmVk UGFyZW50RGlyZWN0b3J5Lmxlbmd0aCgpKTsKKyAgICBtZW1jcHkocmVzb2x2ZWRQYXRoQnVmZmVy ICsgcmVzb2x2ZWRQYXJlbnREaXJlY3RvcnkubGVuZ3RoKCksIHNsYXNoUHRyLCBsYXN0UGF0aENv bXBvbmVudExlbmd0aCk7CisKKyAgICByZXR1cm4gcmVzb2x2ZWRQYXRoOworfQorCiB2b2lkIFNh bmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZShjb25zdCBTdHJpbmcmIHBhdGgsIFR5cGUgdHlw ZSwgSGFuZGxlJiBoYW5kbGUpCiB7CiAgICAgQVNTRVJUKCFoYW5kbGUubV9zYW5kYm94RXh0ZW5z aW9uKTsKIAotICAgIE5TU3RyaW5nICpzdGFuZGFyZGl6ZWRQYXRoID0gWyhOU1N0cmluZyAqKXBh dGggc3RyaW5nQnlTdGFuZGFyZGl6aW5nUGF0aF07Ci0gICAgaGFuZGxlLm1fc2FuZGJveEV4dGVu c2lvbiA9IFdLU2FuZGJveEV4dGVuc2lvbkNyZWF0ZShbc3RhbmRhcmRpemVkUGF0aCBmaWxlU3lz dGVtUmVwcmVzZW50YXRpb25dLCB3a1NhbmRib3hFeHRlbnNpb25UeXBlKHR5cGUpKTsKKyAgICBD U3RyaW5nIHN0YW5kYXJkaXplZFBhdGggPSByZXNvbHZlU3ltbGlua3NJblBhdGgoW1soTlNTdHJp bmcgKilwYXRoIHN0cmluZ0J5U3RhbmRhcmRpemluZ1BhdGhdIGZpbGVTeXN0ZW1SZXByZXNlbnRh dGlvbl0pOworICAgIGhhbmRsZS5tX3NhbmRib3hFeHRlbnNpb24gPSBXS1NhbmRib3hFeHRlbnNp b25DcmVhdGUoc3RhbmRhcmRpemVkUGF0aC5kYXRhKCksIHdrU2FuZGJveEV4dGVuc2lvblR5cGUo dHlwZSkpOwogfQogICAgIAogU3RyaW5nIFNhbmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZUZv clRlbXBvcmFyeUZpbGUoY29uc3QgU3RyaW5nJiBwcmVmaXgsIFR5cGUgdHlwZSwgSGFuZGxlJiBo YW5kbGUpCg==