57498 2011-03-30 12:37:53 -0700 SheriffBot rollouts take too long 2011-03-30 21:29:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth aroben eric oldest_to_newest 376597 0 abarth 2011-03-30 12:37:53 -0700 SheriffBot rollouts take too long 376599 1 87597 abarth 2011-03-30 12:39:32 -0700 Created attachment 87597 Patch 376602 2 abarth 2011-03-30 12:43:50 -0700 Committed r82484: <http://trac.webkit.org/changeset/82484> 376931 3 87597 eric 2011-03-30 21:29:27 -0700 Comment on attachment 87597 Patch Sigh. I agree, it's a better tradeoff. I'm just going to be sad when I get flame mail about it producing an invalid rollout patch. :p 376932 4 eric 2011-03-30 21:29:57 -0700 This sort of abundance-of-caution decision was made in a time when the community was much more hostile to things like teh commit-queue and sheriff-bot. 87597 2011-03-30 12:39:32 -0700 2011-03-30 21:29:27 -0700 Patch bug-57498-20110330123931.patch text/plain 3322 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgyNDgyKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDMtMzAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaGVyaWZmQm90 IHJvbGxvdXRzIHRha2UgdG9vIGxvbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU3NDk4CisKKyAgICAgICAgV2UgdXNlZCB0byBidWlsZCBiZWZvcmUg bGFuZGluZyByb2xsb3V0cyB2aWEgdGhlIGNvbW1pdC1xdWV1ZSB0bworICAgICAgICBwcmV2ZW50 IGZ1cnRoZXIgYnJlYWthZ2UsIGJ1dCBub3cgdGhhdCBvdXIgaW5kaXZpZHVhbCBjb21taXQtcXVl dWUKKyAgICAgICAgbWFjaGluZXMgYXJlIHNsb3dlciwgYnVpbGRpbmcgdGFrZXMgdG9vIGxvbmcu ICBJIGNhbid0IHJlbWVtYmVyIHRoZQorICAgICAgICBsYXN0IHRpbWUgYSByb2xsb3V0IGJyb2tl IGNvbXBpbGUuICBJdCBzZWVtcyBsaWtlIGp1c3QgbGFuZGluZyB0aGUKKyAgICAgICAgcGF0Y2gg aXMgdGhlIGJldHRlciB0cmFkZS1vZmYuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rv b2wvYm90L2NvbW1pdHF1ZXVldGFzay5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rv b2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5OgorCiAyMDExLTAzLTMwICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHBsYXRmb3JtL2Nocm9taXVt LW1hYy1zbm93bGVvcGFyZApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9j b21taXRxdWV1ZXRhc2sucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2JvdC9jb21taXRxdWV1ZXRhc2sucHkJKHJldmlzaW9uIDgyNDgxKQorKysgVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2sucHkJKHdvcmtpbmcgY29weSkK QEAgLTE3OCw4ICsxNzgsNiBAQCBjbGFzcyBDb21taXRRdWV1ZVRhc2sob2JqZWN0KToKICAgICAg ICAgc2VsZi5fZGVsZWdhdGUucmVwb3J0X2ZsYWt5X3Rlc3RzKHNlbGYuX3BhdGNoLCBmbGFreV90 ZXN0X3Jlc3VsdHMsIHJlc3VsdHNfYXJjaGl2ZSkKIAogICAgIGRlZiBfdGVzdF9wYXRjaChzZWxm KToKLSAgICAgICAgaWYgc2VsZi5fcGF0Y2guaXNfcm9sbG91dCgpOgotICAgICAgICAgICAgcmV0 dXJuIFRydWUKICAgICAgICAgaWYgc2VsZi5fdGVzdCgpOgogICAgICAgICAgICAgcmV0dXJuIFRy dWUKIApAQCAtMjIwLDEyICsyMTgsMTMgQEAgY2xhc3MgQ29tbWl0UXVldWVUYXNrKG9iamVjdCk6 CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgaWYgbm90IHNlbGYuX2FwcGx5KCk6 CiAgICAgICAgICAgICByZXR1cm4gc2VsZi5yZXBvcnRfZmFpbHVyZSgpCi0gICAgICAgIGlmIG5v dCBzZWxmLl9idWlsZCgpOgotICAgICAgICAgICAgaWYgbm90IHNlbGYuX2J1aWxkX3dpdGhvdXRf cGF0Y2goKToKKyAgICAgICAgaWYgbm90IHNlbGYuX3BhdGNoLmlzX3JvbGxvdXQoKToKKyAgICAg ICAgICAgIGlmIG5vdCBzZWxmLl9idWlsZCgpOgorICAgICAgICAgICAgICAgIGlmIG5vdCBzZWxm Ll9idWlsZF93aXRob3V0X3BhdGNoKCk6CisgICAgICAgICAgICAgICAgICAgIHJldHVybiBGYWxz ZQorICAgICAgICAgICAgICAgIHJldHVybiBzZWxmLnJlcG9ydF9mYWlsdXJlKCkKKyAgICAgICAg ICAgIGlmIG5vdCBzZWxmLl90ZXN0X3BhdGNoKCk6CiAgICAgICAgICAgICAgICAgcmV0dXJuIEZh bHNlCi0gICAgICAgICAgICByZXR1cm4gc2VsZi5yZXBvcnRfZmFpbHVyZSgpCi0gICAgICAgIGlm IG5vdCBzZWxmLl90ZXN0X3BhdGNoKCk6Ci0gICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAg ICAgIyBNYWtlIHN1cmUgdGhlIHBhdGNoIGlzIHN0aWxsIHZhbGlkIGJlZm9yZSBsYW5kaW5nIChl LmcuLCBtYWtlIHN1cmUKICAgICAgICAgIyBubyBvbmUgaGFzIHNldCBjb21taXQtcXVldWUtIHNp bmNlIHdlIHN0YXJ0ZWQgd29ya2luZyBvbiB0aGUgcGF0Y2guKQogICAgICAgICBpZiBub3Qgc2Vs Zi5fdmFsaWRhdGUoKToKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9xdWV1ZXNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weQkocmV2aXNpb24gODI0ODEpCisrKyBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5CSh3 b3JraW5nIGNvcHkpCkBAIC0yOTMsOCArMjkzLDYgQEAgTU9DSyBydW5fYW5kX3Rocm93X2lmX2Zh aWw6IFsnZWNobycsICctLQogTU9DSzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIFVwZGF0 ZWQgd29ya2luZyBkaXJlY3RvcnkKIE1PQ0sgcnVuX2FuZF90aHJvd19pZl9mYWlsOiBbJ2VjaG8n LCAnLS1zdGF0dXMtaG9zdD1leGFtcGxlLmNvbScsICdhcHBseS1hdHRhY2htZW50JywgJy0tbm8t dXBkYXRlJywgJy0tbm9uLWludGVyYWN0aXZlJywgMTA2XQogTU9DSzogdXBkYXRlX3N0YXR1czog Y29tbWl0LXF1ZXVlIEFwcGxpZWQgcGF0Y2gKLU1PQ0sgcnVuX2FuZF90aHJvd19pZl9mYWlsOiBb J2VjaG8nLCAnLS1zdGF0dXMtaG9zdD1leGFtcGxlLmNvbScsICdidWlsZCcsICctLW5vLWNsZWFu JywgJy0tbm8tdXBkYXRlJywgJy0tYnVpbGQtc3R5bGU9Ym90aCddCi1NT0NLOiB1cGRhdGVfc3Rh dHVzOiBjb21taXQtcXVldWUgQnVpbHQgcGF0Y2gKIE1PQ0sgcnVuX2FuZF90aHJvd19pZl9mYWls OiBbJ2VjaG8nLCAnLS1zdGF0dXMtaG9zdD1leGFtcGxlLmNvbScsICdsYW5kLWF0dGFjaG1lbnQn LCAnLS1mb3JjZS1jbGVhbicsICctLWlnbm9yZS1idWlsZGVycycsICctLW5vbi1pbnRlcmFjdGl2 ZScsICctLXBhcmVudC1jb21tYW5kPWNvbW1pdC1xdWV1ZScsIDEwNl0KIE1PQ0s6IHVwZGF0ZV9z dGF0dXM6IGNvbW1pdC1xdWV1ZSBMYW5kZWQgcGF0Y2gKIE1PQ0s6IHVwZGF0ZV9zdGF0dXM6IGNv bW1pdC1xdWV1ZSBQYXNzCg==