57483 2011-03-30 11:30:02 -0700 Chromium Mac crashes when entering fullscreen 2011-04-04 13:36:04 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 0 ddorwin webkit-unassigned commit-queue jer.noble oldest_to_newest 376512 0 ddorwin 2011-03-30 11:30:02 -0700 The Mac version of Chromium crashes when entering fullscreen because it hits ASSERT_NOT_REACHED in RenderThemeMac::extraFullScreenStyleSheet(), which was added in changeset 82053. I have a fix. 376532 1 jer.noble 2011-03-30 11:42:46 -0700 David, this may be a dup of bug #57400. 376534 2 jer.noble 2011-03-30 11:43:11 -0700 Oh, disregard. This is indeed a different issue. 376557 3 87591 ddorwin 2011-03-30 11:58:52 -0700 Created attachment 87591 Override extraFullScreenStyleSheet in RenderThemeChromiumMac. 376573 4 jer.noble 2011-03-30 12:13:06 -0700 Looks good to me. 379022 5 87591 commit-queue 2011-04-04 13:36:00 -0700 Comment on attachment 87591 Override extraFullScreenStyleSheet in RenderThemeChromiumMac. Clearing flags on attachment: 87591 Committed r82863: <http://trac.webkit.org/changeset/82863> 379023 6 commit-queue 2011-04-04 13:36:04 -0700 All reviewed patches have been landed. Closing bug. 87591 2011-03-30 11:58:52 -0700 2011-04-04 13:36:00 -0700 Override extraFullScreenStyleSheet in RenderThemeChromiumMac. bug-57483-20110330115851.patch text/plain 3326 ddorwin U3VidmVyc2lvbiBSZXZpc2lvbjogODIzNDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YTk5NWY2ZTJhNmE3ZDdm ZWJiYmMyYmZmYWZlYzEyODM4Zjg4MTY4Li5hYzM5N2YxN2VmMzRmZmFlY2Y1MjNmNWZlZmUyODZh Mzk1ZDBkNWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMzAgIERhdmlk IERvcndpbiAgPGRkb3J3aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9taXVtIE1hYyBjcmFzaGVzIHdoZW4gZW50ZXJp bmcgZnVsbHNjcmVlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTc0ODMKKworICAgICAgICBPdmVycmlkZSBleHRyYUZ1bGxTY3JlZW5TdHlsZVNoZWV0 IGluIFJlbmRlclRoZW1lQ2hyb21pdW1NYWMgdG8gYXZvaWQgaGl0dGluZyB0aGUgQVNTRVJUX05P VF9SRUFDSEVEIGluIFJlbmRlclRoZW1lTWFjLgorCisgICAgICAgICogV2ViQ29yZS5neXAvV2Vi Q29yZS5neXA6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMuaDoK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5tbToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1NYWM6OmV4dHJhRnVsbFNjcmVlblN0eWxlU2hl ZXQpOgorCiAyMDExLTAzLTI5ICBHYXZpbiBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgR2VudGlsY29yZS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS5neXAvV2ViQ29yZS5neXAKaW5kZXggZTY5MmY1NDJkMzUzZWQ0Y2YwMDE0MzQxOWZiZDViNzVj N2UyNzI1Yi4uYjYyYzI3NGFkZmNiNjkzMDA3OTJlOTAxYzVhNjA1MmM4NTVjZDM1ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKKysrIGIvU291cmNl L1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKQEAgLTYyMyw2ICs2MjMsNyBAQAogICAg ICAgICAgICAgJy4uL2Nzcy9tZWRpYUNvbnRyb2xzLmNzcycsCiAgICAgICAgICAgICAnLi4vY3Nz L21lZGlhQ29udHJvbHNDaHJvbWl1bS5jc3MnLAogICAgICAgICAgICAgJy4uL2Nzcy9mdWxsc2Ny ZWVuLmNzcycsCisgICAgICAgICAgICAjIFNraXAgZnVsbHNjcmVlblF1aWNrVGltZS4KICAgICAg ICAgICBdLAogICAgICAgICAgICdvdXRwdXRzJzogWwogICAgICAgICAgICAgJzwoU0hBUkVEX0lO VEVSTUVESUFURV9ESVIpL3dlYmtpdC9Vc2VyQWdlbnRTdHlsZVNoZWV0cy5oJywKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLmggYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5oCmluZGV4IDRm ZDM3MWZhZTc1OTVmYjM3NTRhY2I2Y2EzNjg1YjYyMWM5YzA1ZTIuLjBjMzRmNmQ0ODU3ZmI0ODE5 ODI0ZWZkZDU5MDc5N2ZiMWY4ZjEyZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMuaApAQCAtNDAsNyArNDAsMTAgQEAgcHJvdGVjdGVk OgogICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlhQ29udHJvbHNCYWNrZ3JvdW5kKFJlbmRlck9i amVjdCosIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEludFJlY3QmKTsKICAgICB2aXJ0dWFsIGJv b2wgc2hvdWxkUmVuZGVyTWVkaWFDb250cm9sUGFydChDb250cm9sUGFydCwgRWxlbWVudCopOwog ICAgIHZpcnR1YWwgU3RyaW5nIGV4dHJhTWVkaWFDb250cm9sc1N0eWxlU2hlZXQoKTsKLQorI2lm IEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKKyAgICB2aXJ0dWFsIFN0cmluZyBleHRyYUZ1bGxTY3Jl ZW5TdHlsZVNoZWV0KCk7CisjZW5kaWYKKyAgCiAgICAgdmlydHVhbCBib29sIHBhaW50TWVkaWFT bGlkZXJUaHVtYihSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25zdCBJbnRSZWN0 Jik7CiAgICAgdmlydHVhbCBib29sIHBhaW50TWVkaWFWb2x1bWVTbGlkZXJDb250YWluZXIoUmVu ZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogICAgIHZpcnR1 YWwgYm9vbCBwYWludE1lZGlhVm9sdW1lU2xpZGVyVHJhY2soUmVuZGVyT2JqZWN0KiwgY29uc3Qg UGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5tbQppbmRleCBhN2Q1OWE5ZGRiODY0MTM5YzYx YjllZjgwNzNlYzNkODZkYjk0ZTA0Li4wMzcxZjI0ZGU0YzkzYTJhZjhmYWIyNWQ0ZDYwMjBmMTQx ZjIzOWE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVD aHJvbWl1bU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVD aHJvbWl1bU1hYy5tbQpAQCAtMTM1LDYgKzEzNSwxNCBAQCBTdHJpbmcgUmVuZGVyVGhlbWVDaHJv bWl1bU1hYzo6ZXh0cmFNZWRpYUNvbnRyb2xzU3R5bGVTaGVldCgpCiAgICAgcmV0dXJuIFN0cmlu ZyhtZWRpYUNvbnRyb2xzQ2hyb21pdW1Vc2VyQWdlbnRTdHlsZVNoZWV0LCBzaXplb2YobWVkaWFD b250cm9sc0Nocm9taXVtVXNlckFnZW50U3R5bGVTaGVldCkpOwogfQogCisjaWYgRU5BQkxFKEZV TExTQ1JFRU5fQVBJKQorU3RyaW5nIFJlbmRlclRoZW1lQ2hyb21pdW1NYWM6OmV4dHJhRnVsbFNj cmVlblN0eWxlU2hlZXQoKQoreworICAgIC8vIEZJWE1FOiBDaHJvbWl1bSBtYXkgd2lzaCB0byBz dHlsZSBpdHMgZGVmYXVsdCBtZWRpYSBjb250cm9scyBkaWZmZXJlbnRseSBpbiBmdWxsc2NyZWVu LgorICAgIHJldHVybiBTdHJpbmcoKTsKK30KKyNlbmRpZgorCiBib29sIFJlbmRlclRoZW1lQ2hy b21pdW1NYWM6OnBhaW50TWVkaWFWb2x1bWVTbGlkZXJDb250YWluZXIoUmVuZGVyT2JqZWN0KiBv YmplY3QsIGNvbnN0IFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBJbnRSZWN0JiByZWN0KQog ewogICAgIHJldHVybiB0cnVlOwo=