57477 2011-03-30 10:56:04 -0700 ASSERT(cookieStorageAdapter) when calling stopObservingCookieChanges after WebProcess has crashed 2011-03-30 11:13:04 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 bweinstein bweinstein jberlin oldest_to_newest 376474 0 bweinstein 2011-03-30 10:56:04 -0700 If we have called CookieStorageMac::startObservingCookieChanges, and then the WebProcess crashes, the WebProcess will restart, and when we call stopObservingCookieChanges, cookieStorageAdapter won't have been initialized yet, and the ASSERT(cookieStorageAdapter) will fail. We don't need this assert, as it can be clearly incorrect, and there isn't harm in dispatching a message to nil if cookieStorageAdapter hasn't been defined yet. <rdar://problem/9178751> 376477 1 87575 bweinstein 2011-03-30 10:59:16 -0700 Created attachment 87575 [PATCH] Fix 376479 2 87575 jberlin 2011-03-30 11:01:49 -0700 Comment on attachment 87575 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=87575&action=review > Source/WebCore/platform/network/mac/CookieStorageMac.mm:119 > [cookieStorageAdapter stopListeningForCookieChangeNotifications]; I know that dispatching a message to nil won't crash, but I think it is very unclear here that it is ok for the cookieStorageAdapter to be null. I think a comment and an early return would be better. 376485 3 87576 bweinstein 2011-03-30 11:06:16 -0700 Created attachment 87576 [PATCH] Fix w/ early return + comment 376486 4 87576 jberlin 2011-03-30 11:07:20 -0700 Comment on attachment 87576 [PATCH] Fix w/ early return + comment Unofficially, as I am not a reviewer, r=me. 376488 5 bweinstein 2011-03-30 11:12:59 -0700 Landed in r82473. 87575 2011-03-30 10:59:16 -0700 2011-03-30 11:06:16 -0700 [PATCH] Fix remove_assert.patch text/plain 1548 bweinstein SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyNDY4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDMtMzAgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQVNTRVJUKGNvb2tpZVN0b3JhZ2VBZGFw dGVyKSB3aGVuIGNhbGxpbmcgc3RvcE9ic2VydmluZ0Nvb2tpZUNoYW5nZXMgYWZ0ZXIgV2ViUHJv Y2VzcyBoYXMgY3Jhc2hlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTc0NzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzkxNzg3NTE+CisgICAgICAg IAorICAgICAgICBJZiBzb21lb25lIGhhcyBjYWxsZWQgc3RhcnRPYnNlcnZpbmdDb29raWVDaGFu Z2VzLCBhbmQgdGhlIFdlYlByb2Nlc3MgY3Jhc2hlcyBhbmQgcmVzdGFydHMsIHRoZSBVSVByb2Nl c3MKKyAgICAgICAgd2lsbCBjYWxsIHN0b3BPYnNlcnZpbmdDb29raWVDaGFuZ2VzIHdoZW4gY29v a2llU3RvcmFnZUFkYXB0ZXIgaXMgbmlsLgorICAgICAgICAKKyAgICAgICAgVGhlIGFzc2VydCBp cyB3cm9uZyB3aGVuIHRoZSB3ZWIgcHJvY2VzcyBjcmFzaGVzLCBhbmQgdGhlcmUgaXMgbm8gaGFy bSBpbiBkaXNwYXRjaGluZyBhIG1lc3NhZ2UgdG8gbmlsLAorICAgICAgICBzbyByZW1vdmUgdGhl IGFzc2VydC4KKyAgICAgICAgCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9tYWMvQ29va2ll U3RvcmFnZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OnN0b3BPYnNlcnZpbmdDb29raWVDaGFu Z2VzKToKKwogMjAxMS0wMy0zMCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvbWFjL0Nvb2tpZVN0b3JhZ2VNYWMubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvQ29va2llU3RvcmFnZU1hYy5tbQkocmV2 aXNpb24gODIzNjkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9Db29r aWVTdG9yYWdlTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNyArMTE2LDYgQEAgdm9pZCBz dGFydE9ic2VydmluZ0Nvb2tpZUNoYW5nZXMoKQogCiB2b2lkIHN0b3BPYnNlcnZpbmdDb29raWVD aGFuZ2VzKCkKIHsKLSAgICBBU1NFUlQoY29va2llU3RvcmFnZUFkYXB0ZXIpOwogICAgIFtjb29r aWVTdG9yYWdlQWRhcHRlciBzdG9wTGlzdGVuaW5nRm9yQ29va2llQ2hhbmdlTm90aWZpY2F0aW9u c107CiB9CiAK 87576 2011-03-30 11:06:16 -0700 2011-03-30 11:10:58 -0700 [PATCH] Fix w/ early return + comment remove_assert.patch text/plain 1807 bweinstein SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyNDY4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDMtMzAgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQVNTRVJUKGNvb2tpZVN0b3JhZ2VBZGFw dGVyKSB3aGVuIGNhbGxpbmcgc3RvcE9ic2VydmluZ0Nvb2tpZUNoYW5nZXMgYWZ0ZXIgV2ViUHJv Y2VzcyBoYXMgY3Jhc2hlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTc0NzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzkxNzg3NTE+CisgICAgICAg IAorICAgICAgICBJZiBzb21lb25lIGhhcyBjYWxsZWQgc3RhcnRPYnNlcnZpbmdDb29raWVDaGFu Z2VzLCBhbmQgdGhlIFdlYlByb2Nlc3MgY3Jhc2hlcyBhbmQgcmVzdGFydHMsIHRoZSBVSVByb2Nl c3MKKyAgICAgICAgd2lsbCBjYWxsIHN0b3BPYnNlcnZpbmdDb29raWVDaGFuZ2VzIHdoZW4gY29v a2llU3RvcmFnZUFkYXB0ZXIgaXMgbmlsLgorICAgICAgICAKKyAgICAgICAgVGhlIGFzc2VydCBp cyB3cm9uZyB3aGVuIHRoZSB3ZWIgcHJvY2VzcyBjcmFzaGVzLCBhbmQgdGhlcmUgaXMgbm8gaGFy bSBpbiBkaXNwYXRjaGluZyBhIG1lc3NhZ2UgdG8gbmlsLAorICAgICAgICBzbyByZW1vdmUgdGhl IGFzc2VydC4KKyAgICAgICAgCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9tYWMvQ29va2ll U3RvcmFnZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OnN0b3BPYnNlcnZpbmdDb29raWVDaGFu Z2VzKToKKwogMjAxMS0wMy0zMCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvbWFjL0Nvb2tpZVN0b3JhZ2VNYWMubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvQ29va2llU3RvcmFnZU1hYy5tbQkocmV2 aXNpb24gODIzNjkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9Db29r aWVTdG9yYWdlTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNyArMTE2LDEwIEBAIHZvaWQg c3RhcnRPYnNlcnZpbmdDb29raWVDaGFuZ2VzKCkKIAogdm9pZCBzdG9wT2JzZXJ2aW5nQ29va2ll Q2hhbmdlcygpCiB7Ci0gICAgQVNTRVJUKGNvb2tpZVN0b3JhZ2VBZGFwdGVyKTsKKyAgICAvLyBj b29raWVTdG9yYWdlQWRhcHRlciBjYW4gYmUgbmlsIGhlcmUsIGlmIHRoZSBXZWJQcm9jZXNzIGNy YXNoZWQgYW5kIHdhcyByZXN0YXJ0ZWQgYmV0d2VlbgorICAgIC8vIHdoZW4gc3RhcnRPYnNlcnZp bmdDb29raWVDaGFuZ2VzIHdhcyBjYWxsZWQsIGFuZCBzdG9wT2JzZXJ2aW5nQ29va2llQ2hhbmdl cyBpcyBjdXJyZW50bHkgYmVpbmcgY2FsbGVkLgorICAgIGlmICghY29va2llU3RvcmFnZUFkYXB0 ZXIpCisgICAgICAgIHJldHVybjsKICAgICBbY29va2llU3RvcmFnZUFkYXB0ZXIgc3RvcExpc3Rl bmluZ0ZvckNvb2tpZUNoYW5nZU5vdGlmaWNhdGlvbnNdOwogfQogCg==