57454 2011-03-30 07:49:39 -0700 Web Inspector: remove dead code from Script.js. 2011-09-02 02:31:33 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein domenic joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 376312 0 podivilov 2011-03-30 07:49:39 -0700 Web Inspector: remove dead code from Script.js. 376313 1 87534 podivilov 2011-03-30 07:50:11 -0700 Created attachment 87534 Patch. 377703 2 podivilov 2011-04-01 03:57:27 -0700 Committed r82670: <http://trac.webkit.org/changeset/82670> 460908 3 domenic 2011-09-01 16:35:23 -0700 My team is working with an embedded instance of WebKit (Chromium branch, build 742) and we can't get the "//@ sourceURL" feature to work. After looking at the original commit linked to from http://pmuellr.blogspot.com/2009/06/debugger-friendly.html and tracing the removal of that code to here, we've hit a dead end. Since this is "dead code," where did sourceURL support go? Where can we look to see what's going wrong? Presumably sourceURL is still supported by WebKit, since it works fine in Chrome. So it must be something weird about our custom embedded instance, and we'd love some help debugging it. Thanks for your time, and hope this is an OK venue to ask for help. 461103 4 podivilov 2011-09-02 02:31:33 -0700 This code became dead when we stopped pushing script source to frontend to make loading faster. SourceURL values are now extracted on backend side by JS engine. It was implemented in V8 but not in JSC. There is a bug report opened for this - https://bugs.webkit.org/show_bug.cgi?id=65532. 87534 2011-03-30 07:50:11 -0700 2011-03-30 08:20:48 -0700 Patch. patch text/plain 5428 podivilov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZWQ0OTQ4Li5mOTI5YTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDMtMzAgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIElu c3BlY3RvcjogcmVtb3ZlIGRlYWQgY29kZSBmcm9tIFNjcmlwdC5qcy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NDU0CisKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL0RlYnVnZ2VyTW9kZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu RGVidWdnZXJNb2RlbC5wcm90b3R5cGUuX3BhcnNlZFNjcmlwdFNvdXJjZSk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuRGVidWdnZXJNb2RlbC5wcm90b3R5cGUuX2ZhaWxlZFRvUGFyc2VTY3JpcHRT b3VyY2UpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0LmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlNjcmlwdCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0LnBy b3RvdHlwZS5yZXF1ZXN0U291cmNlLmRpZEdldFNjcmlwdFNvdXJjZSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuU2NyaXB0LnByb3RvdHlwZS5yZXF1ZXN0U291cmNlKToKKwogMjAxMS0wMy0yOSAg RGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92 ZSB0aGUgZXh0cmFuZW91cyBkZWNsYXJhdGlvbiBJIGFjY2lkZW50YWxseSBhZGRlZCBpbiByODIz NzYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlYnVn Z2VyTW9kZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlYnVnZ2Vy TW9kZWwuanMKaW5kZXggZDAxZWFiNi4uYmM5M2JlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWJ1Z2dlck1vZGVsLmpzCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVidWdnZXJNb2RlbC5qcwpAQCAtMjEyLDE0ICsyMTIs MTQgQEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTW9kZWwucHJvdG90eXBlID0gewogCiAgICAgX3Bh cnNlZFNjcmlwdFNvdXJjZTogZnVuY3Rpb24oc291cmNlSUQsIHNvdXJjZVVSTCwgbGluZU9mZnNl dCwgY29sdW1uT2Zmc2V0LCBsZW5ndGgsIHNjcmlwdFdvcmxkVHlwZSkKICAgICB7Ci0gICAgICAg IHZhciBzY3JpcHQgPSBuZXcgV2ViSW5zcGVjdG9yLlNjcmlwdChzb3VyY2VJRCwgc291cmNlVVJM LCAiIiwgbGluZU9mZnNldCwgY29sdW1uT2Zmc2V0LCBsZW5ndGgsIHVuZGVmaW5lZCwgdW5kZWZp bmVkLCBzY3JpcHRXb3JsZFR5cGUpOworICAgICAgICB2YXIgc2NyaXB0ID0gbmV3IFdlYkluc3Bl Y3Rvci5TY3JpcHQoc291cmNlSUQsIHNvdXJjZVVSTCwgbGluZU9mZnNldCwgY29sdW1uT2Zmc2V0 LCBsZW5ndGgsIHVuZGVmaW5lZCwgdW5kZWZpbmVkLCBzY3JpcHRXb3JsZFR5cGUpOwogICAgICAg ICB0aGlzLl9zY3JpcHRzW3NvdXJjZUlEXSA9IHNjcmlwdDsKICAgICAgICAgdGhpcy5kaXNwYXRj aEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTW9kZWwuRXZlbnRzLlBhcnNl ZFNjcmlwdFNvdXJjZSwgc2NyaXB0KTsKICAgICB9LAogCiAgICAgX2ZhaWxlZFRvUGFyc2VTY3Jp cHRTb3VyY2U6IGZ1bmN0aW9uKHNvdXJjZVVSTCwgc291cmNlLCBzdGFydGluZ0xpbmUsIGVycm9y TGluZSwgZXJyb3JNZXNzYWdlKQogICAgIHsKLSAgICAgICAgdmFyIHNjcmlwdCA9IG5ldyBXZWJJ bnNwZWN0b3IuU2NyaXB0KG51bGwsIHNvdXJjZVVSTCwgc291cmNlLCBzdGFydGluZ0xpbmUsIGVy cm9yTGluZSwgZXJyb3JNZXNzYWdlLCB1bmRlZmluZWQpOworICAgICAgICB2YXIgc2NyaXB0ID0g bmV3IFdlYkluc3BlY3Rvci5TY3JpcHQobnVsbCwgc291cmNlVVJMLCBzdGFydGluZ0xpbmUsIGVy cm9yTGluZSwgZXJyb3JNZXNzYWdlLCB1bmRlZmluZWQpOwogICAgICAgICB0aGlzLmRpc3BhdGNo RXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuRGVidWdnZXJNb2RlbC5FdmVudHMuRmFpbGVk VG9QYXJzZVNjcmlwdFNvdXJjZSwgc2NyaXB0KTsKICAgICB9CiB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdC5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0LmpzCmluZGV4IDgwNWUxOTEuLjA3YmE4MzkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0LmpzCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0LmpzCkBAIC0yMyw3 ICsyMyw3IEBACiAgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKLVdlYkluc3BlY3Rvci5TY3JpcHQgPSBm dW5jdGlvbihzb3VyY2VJRCwgc291cmNlVVJMLCBzb3VyY2UsIGxpbmVPZmZzZXQsIGNvbHVtbk9m ZnNldCwgbGVuZ3RoLCBlcnJvckxpbmUsIGVycm9yTWVzc2FnZSwgd29ybGRUeXBlKQorV2ViSW5z cGVjdG9yLlNjcmlwdCA9IGZ1bmN0aW9uKHNvdXJjZUlELCBzb3VyY2VVUkwsIGxpbmVPZmZzZXQs IGNvbHVtbk9mZnNldCwgbGVuZ3RoLCBlcnJvckxpbmUsIGVycm9yTWVzc2FnZSwgd29ybGRUeXBl KQogewogICAgIHRoaXMuc291cmNlSUQgPSBzb3VyY2VJRDsKICAgICB0aGlzLnNvdXJjZVVSTCA9 IHNvdXJjZVVSTDsKQEAgLTM0LDI0ICszNCw2IEBAIFdlYkluc3BlY3Rvci5TY3JpcHQgPSBmdW5j dGlvbihzb3VyY2VJRCwgc291cmNlVVJMLCBzb3VyY2UsIGxpbmVPZmZzZXQsIGNvbHVtbk9mCiAg ICAgdGhpcy5lcnJvckxpbmUgPSBlcnJvckxpbmU7CiAgICAgdGhpcy5lcnJvck1lc3NhZ2UgPSBl cnJvck1lc3NhZ2U7CiAgICAgdGhpcy53b3JsZFR5cGUgPSB3b3JsZFR5cGU7Ci0KLSAgICAvLyBp ZiBubyBVUkwsIGxvb2sgZm9yICIvL0Agc291cmNlVVJMPSIgZGVjb3JhdG9yCi0gICAgLy8gbm90 ZSB0aGF0IHRoaXMgc291cmNlVVJMIGNvbW1lbnQgZGVjb3JhdG9yIGlzIGJlaGF2aW9yIHRoYXQg RmlyZUJ1ZyBhZGRlZAotICAgIC8vIGluIGl0J3MgMS4xIHJlbGVhc2UgYXMgbm90ZWQgaW4gdGhl IHJlbGVhc2Ugbm90ZXM6Ci0gICAgLy8gaHR0cDovL2ZidWcuZ29vZ2xlY29kZS5jb20vc3ZuL2Jy YW5jaGVzL2ZpcmVidWcxLjEvZG9jcy9SZWxlYXNlTm90ZXNfMS4xLnR4dAotICAgIGlmICghc291 cmNlVVJMKSB7Ci0gICAgICAgIC8vIHVzZSBvZiBbIFx0XSByYXRoZXIgdGhhbiBccyBpcyB0byBw cmV2ZW50IFxuIGZyb20gbWF0Y2hpbmcKLSAgICAgICAgdmFyIHBhdHRlcm4gPSAvXlxzKlwvXC9b IFx0XSpAWyBcdF0qc291cmNlVVJMWyBcdF0qPVsgXHRdKihcUyspLiokL207Ci0gICAgICAgIHZh ciBtYXRjaCA9IHBhdHRlcm4uZXhlYyhzb3VyY2UpOwotCi0gICAgICAgIGlmIChtYXRjaCkKLSAg ICAgICAgICAgIHRoaXMuc291cmNlVVJMID0gbWF0Y2hbMV07Ci0gICAgfQotfQotCi1XZWJJbnNw ZWN0b3IuU2NyaXB0LldvcmxkVHlwZSA9IHsKLSAgICBNQUlOX1dPUkxEOiAwLAotICAgIEVYVEVO U0lPTlNfV09STEQ6IDEKIH0KIAogV2ViSW5zcGVjdG9yLlNjcmlwdC5Xb3JsZFR5cGUgPSB7CkBA IC02MCw1NCArNDIsNiBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0LldvcmxkVHlwZSA9IHsKIH0KIAog V2ViSW5zcGVjdG9yLlNjcmlwdC5wcm90b3R5cGUgPSB7Ci0gICAgZ2V0IHN0YXJ0aW5nTGluZSgp Ci0gICAgewotICAgICAgICByZXR1cm4gdGhpcy5saW5lT2Zmc2V0ICsgMTsKLSAgICB9LAotCi0g ICAgZ2V0IGxpbmVzQ291bnQoKQotICAgIHsKLSAgICAgICAgaWYgKCF0aGlzLnNvdXJjZSkKLSAg ICAgICAgICAgIHJldHVybiAwOwotICAgICAgICBpZiAoIXRoaXMuX2xpbmVFbmRpbmdzKQotICAg ICAgICAgICAgdGhpcy5fbGluZUVuZGluZ3MgPSB0aGlzLl9zb3VyY2UuZmluZEFsbCgiXG4iKTsK LSAgICAgICAgcmV0dXJuIHRoaXMuX2xpbmVFbmRpbmdzLmxlbmd0aCArIDE7Ci0gICAgfSwKLQot ICAgIHNvdXJjZUxpbmU6IGZ1bmN0aW9uKGxpbmVOdW1iZXIsIGNhbGxiYWNrKQotICAgIHsKLSAg ICAgICAgZnVuY3Rpb24gZXh0cmFjdFNvdXJjZUxpbmUoKQotICAgICAgICB7Ci0gICAgICAgICAg ICBsaW5lTnVtYmVyIC09IHRoaXMubGluZU9mZnNldDsKLSAgICAgICAgICAgIGNhbGxiYWNrKHRo aXMuX3NvdXJjZS5zdWJzdHJpbmcodGhpcy5fbGluZUVuZGluZ3NbbGluZU51bWJlciAtIDFdLCB0 aGlzLl9saW5lRW5kaW5nc1tsaW5lTnVtYmVyXSkpOwotICAgICAgICB9Ci0KLSAgICAgICAgaWYg KHRoaXMuX2xpbmVFbmRpbmdzKSB7Ci0gICAgICAgICAgICBleHRyYWN0U291cmNlTGluZS5jYWxs KHRoaXMpOwotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB9Ci0KLSAgICAgICAgZnVuY3Rp b24gZGlkUmVxdWVzdFNvdXJjZSgpCi0gICAgICAgIHsKLSAgICAgICAgICAgIHRoaXMuX2xpbmVF bmRpbmdzID0gdGhpcy5fc291cmNlLmZpbmRBbGwoIlxuIik7Ci0gICAgICAgICAgICBleHRyYWN0 U291cmNlTGluZS5jYWxsKHRoaXMpOwotICAgICAgICB9Ci0gICAgICAgIHRoaXMucmVxdWVzdFNv dXJjZShkaWRSZXF1ZXN0U291cmNlLmJpbmQodGhpcykpOwotICAgIH0sCi0KLSAgICBnZXQgc291 cmNlKCkKLSAgICB7Ci0gICAgICAgIGlmICghdGhpcy5fc291cmNlICYmIHRoaXMucmVzb3VyY2Up Ci0gICAgICAgICAgICB0aGlzLl9zb3VyY2UgPSB0aGlzLnJlc291cmNlLmNvbnRlbnQ7Ci0gICAg ICAgIHJldHVybiB0aGlzLl9zb3VyY2U7Ci0gICAgfSwKLQotICAgIHNldCBzb3VyY2Uoc291cmNl KQotICAgIHsKLSAgICAgICAgdGhpcy5fc291cmNlID0gc291cmNlOwotICAgICAgICBkZWxldGUg dGhpcy5fbGluZUVuZGluZ3M7Ci0gICAgfSwKLQogICAgIHJlcXVlc3RTb3VyY2U6IGZ1bmN0aW9u KGNhbGxiYWNrKQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX3NvdXJjZSkgewpAQCAtMTE3LDgg KzUxLDYgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdC5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgZnVu Y3Rpb24gZGlkR2V0U2NyaXB0U291cmNlKGVycm9yLCBzb3VyY2UpCiAgICAgICAgIHsKLSAgICAg ICAgICAgIGlmIChlcnJvcikKLSAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB0 aGlzLl9zb3VyY2UgPSBzb3VyY2U7CiAgICAgICAgICAgICBjYWxsYmFjayh0aGlzLl9zb3VyY2Up OwogICAgICAgICB9Cg==