57440 2011-03-30 03:44:00 -0700 Web Inspector: Make the getStylesForNode result "styleAttributes" value an array rather than a map 2011-03-30 06:39:15 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 376175 0 apavlov 2011-03-30 03:44:00 -0700 Having a map instead of an array does not enable us to define the object keys domain, and also prevents a proper documentation of the data types in Inspector.json 376195 1 87502 apavlov 2011-03-30 04:52:57 -0700 Created attachment 87502 [PATCH] Suggested solution 376197 2 webkit.review.bot 2011-03-30 04:55:09 -0700 Attachment 87502 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1 Source/WebCore/inspector/InspectorCSSAgent.h:94: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 376265 3 apavlov 2011-03-30 06:39:15 -0700 Landed with a style fix. Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/styles/styles-new-API.html M Source/WebCore/ChangeLog M Source/WebCore/inspector/InspectorCSSAgent.cpp M Source/WebCore/inspector/InspectorCSSAgent.h M Source/WebCore/inspector/front-end/CSSStyleModel.js Committed r82433 87502 2011-03-30 04:52:57 -0700 2011-03-30 05:19:47 -0700 [PATCH] Suggested solution styleattrs.patch text/plain 6675 apavlov Y29tbWl0IGQ3OTM2YjY1OGU5YTIzMjNhYWIwNTg4NzVkYjQxNjgwYjdmM2VjZjgKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBXZWQgTWFyIDMw IDE1OjM2OjA5IDIwMTEgKzA0MDAKCiAgICBDaGFuZ2Ugc3RydWN0dXJlCgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDViYTM0 MDguLmUyODkxODIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wMy0zMCAgQWxleGFuZGVy IFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1ha2UgdGhlIGdldFN0eWxl c0Zvck5vZGUgcmVzdWx0ICJzdHlsZUF0dHJpYnV0ZXMiIHZhbHVlIGFuIGFycmF5IHJhdGhlciB0 aGFuIGEgbWFwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NzQ0MAorCisgICAgICAgICogaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtbmV3LUFQSS5odG1s OgorCiAyMDExLTAzLTMwICBMZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy1uZXctQVBJLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNw ZWN0b3Ivc3R5bGVzL3N0eWxlcy1uZXctQVBJLmh0bWwKaW5kZXggNmM5MjUxMi4uM2QyYWJmYSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtbmV3LUFQSS5o dG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvc3R5bGVzLW5ldy1BUEkuaHRt bApAQCAtNjksOSArNjksMTAgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgICAgICB9CiAgICAg ICAgICAgICBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdCgiIik7CiAgICAgICAgICAgICBJbnNwZWN0 b3JUZXN0LmFkZFJlc3VsdCgiPT09IEF0dHJpYnV0ZSBzdHlsZXMgZm9yIHRhYmxlID09PSIpOwot ICAgICAgICAgICAgZm9yICh2YXIgYXR0ciBpbiBzdHlsZXMuc3R5bGVBdHRyaWJ1dGVzKSB7Ci0g ICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoIkF0dHJpYnV0ZTogIiArIGF0 dHIpOwotICAgICAgICAgICAgICAgIGR1bXBSdWxlT3JTdHlsZShzdHlsZXMuc3R5bGVBdHRyaWJ1 dGVzW2F0dHJdKTsKKyAgICAgICAgICAgIHZhciBzdHlsZUF0dHJpYnV0ZXMgPSBzdHlsZXMuc3R5 bGVBdHRyaWJ1dGVzOworICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBzdHlsZUF0dHJp YnV0ZXMubGVuZ3RoOyArK2kpIHsKKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFkZFJl c3VsdCgiQXR0cmlidXRlOiAiICsgc3R5bGVBdHRyaWJ1dGVzW2ldLm5hbWUpOworICAgICAgICAg ICAgICAgIGR1bXBSdWxlT3JTdHlsZShzdHlsZUF0dHJpYnV0ZXNbaV0uc3R5bGUpOwogICAgICAg ICAgICAgfQogICAgICAgICAgICAgdGVzdF9zdHlsZVNoZWV0cygpOwogICAgICAgICB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggNmQ3MWUwNC4uOTg4YTk3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisy MDExLTAzLTMwICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogTWFrZSB0aGUgZ2V0U3R5bGVzRm9yTm9kZSByZXN1bHQgInN0eWxlQXR0cmlidXRlcyIgdmFs dWUgYW4gYXJyYXkgcmF0aGVyIHRoYW4gYSBtYXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NDQwCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVj dG9yQ1NTQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ1NTQWdlbnQ6Omdl dFN0eWxlc0Zvck5vZGUpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ1NTQWdlbnQ6OmJ1 aWxkQXJyYXlGb3JBdHRyaWJ1dGVTdHlsZXMpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0 b3JDU1NBZ2VudC5oOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ1NTU3R5bGVNb2Rl bC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DU1NTdHlsZU1vZGVsLnByb3RvdHlwZS5nZXRT dHlsZXNBc3luYyk6CisKIDIwMTEtMDMtMzAgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDU1NBZ2VudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ1NTQWdlbnQuY3BwCmluZGV4IGVkNGUyNDUuLjk4 MGZjZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDU1NB Z2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNTU0FnZW50 LmNwcApAQCAtMTk1LDcgKzE5NSw3IEBAIHZvaWQgSW5zcGVjdG9yQ1NTQWdlbnQ6OmdldFN0eWxl c0Zvck5vZGUoRXJyb3JTdHJpbmcqIGVycm9yU3RyaW5nLCBpbnQgbm9kZUlkLCBSCiAgICAgUmVm UHRyPENTU1J1bGVMaXN0PiBtYXRjaGVkUnVsZXMgPSBzZWxlY3Rvci0+c3R5bGVSdWxlc0ZvckVs ZW1lbnQoZWxlbWVudCwgZmFsc2UsIHRydWUpOwogICAgIHJlc3VsdE9iamVjdC0+c2V0QXJyYXko Im1hdGNoZWRDU1NSdWxlcyIsIGJ1aWxkQXJyYXlGb3JSdWxlTGlzdChtYXRjaGVkUnVsZXMuZ2V0 KCkpKTsKIAotICAgIHJlc3VsdE9iamVjdC0+c2V0T2JqZWN0KCJzdHlsZUF0dHJpYnV0ZXMiLCBi dWlsZE9iamVjdEZvckF0dHJpYnV0ZVN0eWxlcyhlbGVtZW50KSk7CisgICAgcmVzdWx0T2JqZWN0 LT5zZXRBcnJheSgic3R5bGVBdHRyaWJ1dGVzIiwgYnVpbGRBcnJheUZvckF0dHJpYnV0ZVN0eWxl cyhlbGVtZW50KSk7CiAKICAgICBSZWZQdHI8SW5zcGVjdG9yQXJyYXk+IHBzZXVkb0VsZW1lbnRz ID0gSW5zcGVjdG9yQXJyYXk6OmNyZWF0ZSgpOwogICAgIGZvciAoUHNldWRvSWQgcHNldWRvSWQg PSBGSVJTVF9QVUJMSUNfUFNFVURPSUQ7IHBzZXVkb0lkIDwgQUZURVJfTEFTVF9JTlRFUk5BTF9Q U0VVRE9JRDsgcHNldWRvSWQgPSBzdGF0aWNfY2FzdDxQc2V1ZG9JZD4ocHNldWRvSWQgKyAxKSkg ewpAQCAtNTEyLDIwICs1MTIsMjMgQEAgUGFzc1JlZlB0cjxJbnNwZWN0b3JBcnJheT4gSW5zcGVj dG9yQ1NTQWdlbnQ6OmJ1aWxkQXJyYXlGb3JSdWxlTGlzdChDU1NSdWxlTGlzdCoKICAgICByZXR1 cm4gcmVzdWx0LnJlbGVhc2UoKTsKIH0KIAotUGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IElu c3BlY3RvckNTU0FnZW50OjpidWlsZE9iamVjdEZvckF0dHJpYnV0ZVN0eWxlcyhFbGVtZW50KiBl bGVtZW50KQorUGFzc1JlZlB0cjxJbnNwZWN0b3JBcnJheT4gSW5zcGVjdG9yQ1NTQWdlbnQ6OmJ1 aWxkQXJyYXlGb3JBdHRyaWJ1dGVTdHlsZXMoRWxlbWVudCogZWxlbWVudCkKIHsKLSAgICBSZWZQ dHI8SW5zcGVjdG9yT2JqZWN0PiBzdHlsZUF0dHJpYnV0ZXMgPSBJbnNwZWN0b3JPYmplY3Q6OmNy ZWF0ZSgpOworICAgIFJlZlB0cjxJbnNwZWN0b3JBcnJheT4gYXR0clN0eWxlcyA9IEluc3BlY3Rv ckFycmF5OjpjcmVhdGUoKTsKICAgICBOYW1lZE5vZGVNYXAqIGF0dHJpYnV0ZXMgPSBlbGVtZW50 LT5hdHRyaWJ1dGVzKCk7CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgYXR0cmlidXRlcyAmJiBp IDwgYXR0cmlidXRlcy0+bGVuZ3RoKCk7ICsraSkgewogICAgICAgICBBdHRyaWJ1dGUqIGF0dHJp YnV0ZSA9IGF0dHJpYnV0ZXMtPmF0dHJpYnV0ZUl0ZW0oaSk7CiAgICAgICAgIGlmIChhdHRyaWJ1 dGUtPnN0eWxlKCkpIHsKKyAgICAgICAgICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGF0dHJT dHlsZU9iamVjdCA9IEluc3BlY3Rvck9iamVjdDo6Y3JlYXRlKCk7CiAgICAgICAgICAgICBTdHJp bmcgYXR0cmlidXRlTmFtZSA9IGF0dHJpYnV0ZS0+bG9jYWxOYW1lKCk7CiAgICAgICAgICAgICBS ZWZQdHI8SW5zcGVjdG9yU3R5bGU+IGluc3BlY3RvclN0eWxlID0gSW5zcGVjdG9yU3R5bGU6OmNy ZWF0ZShJbnNwZWN0b3JDU1NJZCgpLCBhdHRyaWJ1dGUtPnN0eWxlKCksIDApOwotICAgICAgICAg ICAgc3R5bGVBdHRyaWJ1dGVzLT5zZXRPYmplY3QoYXR0cmlidXRlTmFtZS51dGY4KCkuZGF0YSgp LCBpbnNwZWN0b3JTdHlsZS0+YnVpbGRPYmplY3RGb3JTdHlsZSgpKTsKKyAgICAgICAgICAgIGF0 dHJTdHlsZU9iamVjdC0+c2V0U3RyaW5nKCJuYW1lIiwgYXR0cmlidXRlTmFtZS51dGY4KCkuZGF0 YSgpKTsKKyAgICAgICAgICAgIGF0dHJTdHlsZU9iamVjdC0+c2V0T2JqZWN0KCJzdHlsZSIsIGlu c3BlY3RvclN0eWxlLT5idWlsZE9iamVjdEZvclN0eWxlKCkpOworICAgICAgICAgICAgYXR0clN0 eWxlcy0+cHVzaE9iamVjdChhdHRyU3R5bGVPYmplY3QucmVsZWFzZSgpKTsKICAgICAgICAgfQog ICAgIH0KIAotICAgIHJldHVybiBzdHlsZUF0dHJpYnV0ZXM7CisgICAgcmV0dXJuIGF0dHJTdHls ZXMucmVsZWFzZSgpOwogfQogCiB2b2lkIEluc3BlY3RvckNTU0FnZW50OjpkaWRSZW1vdmVEb2N1 bWVudChEb2N1bWVudCogZG9jdW1lbnQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yQ1NTQWdlbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JDU1NBZ2VudC5oCmluZGV4IDJkOWVhMmMuLjg5ZTg2NjYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDU1NBZ2VudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDU1NBZ2VudC5oCkBAIC05MSw3ICs5MSw3IEBAIHByaXZh dGU6CiAgICAgU3RyaW5nIGRldGVjdE9yaWdpbihDU1NTdHlsZVNoZWV0KiBwYWdlU3R5bGVTaGVl dCwgRG9jdW1lbnQqIG93bmVyRG9jdW1lbnQpOwogCiAgICAgUGFzc1JlZlB0cjxJbnNwZWN0b3JB cnJheT4gYnVpbGRBcnJheUZvclJ1bGVMaXN0KENTU1J1bGVMaXN0KiBydWxlTGlzdCk7Ci0gICAg UGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGJ1aWxkT2JqZWN0Rm9yQXR0cmlidXRlU3R5bGVz KEVsZW1lbnQqIGVsZW1lbnQpOworICAgIFBhc3NSZWZQdHI8SW5zcGVjdG9yQXJyYXk+IGJ1aWxk QXJyYXlGb3JBdHRyaWJ1dGVTdHlsZXMoRWxlbWVudCogZWxlbWVudCk7CiAKICAgICAvLyBJbnNw ZWN0b3JET01BZ2VudDo6RE9NTGlzdGVuZXIgaW50ZXJmYWNlCiAgICAgdmlydHVhbCB2b2lkIGRp ZFJlbW92ZURvY3VtZW50KERvY3VtZW50Kik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0NTU1N0eWxlTW9kZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NTU1N0eWxlTW9kZWwuanMKaW5kZXggNjg2Y2Y0Yi4uMTQ4YmZkOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DU1NTdHlsZU1v ZGVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1NTU3R5bGVN b2RlbC5qcwpAQCAtNTksOCArNTksMTEgQEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlTW9kZWwucHJv dG90eXBlID0gewogICAgICAgICAgICAgcmVzdWx0Lm1hdGNoZWRDU1NSdWxlcyA9IFdlYkluc3Bl Y3Rvci5DU1NTdHlsZU1vZGVsLnBhcnNlUnVsZUFycmF5UGF5bG9hZChwYXlsb2FkLm1hdGNoZWRD U1NSdWxlcyk7CiAKICAgICAgICAgICAgIHJlc3VsdC5zdHlsZUF0dHJpYnV0ZXMgPSB7fTsKLSAg ICAgICAgICAgIGZvciAodmFyIG5hbWUgaW4gcGF5bG9hZC5zdHlsZUF0dHJpYnV0ZXMpCi0gICAg ICAgICAgICAgICAgcmVzdWx0LnN0eWxlQXR0cmlidXRlc1tuYW1lXSA9IFdlYkluc3BlY3Rvci5D U1NTdHlsZURlY2xhcmF0aW9uLnBhcnNlUGF5bG9hZChwYXlsb2FkLnN0eWxlQXR0cmlidXRlc1tu YW1lXSk7CisgICAgICAgICAgICB2YXIgcGF5bG9hZFN0eWxlQXR0cmlidXRlcyA9IHBheWxvYWQu c3R5bGVBdHRyaWJ1dGVzOworICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBwYXlsb2Fk U3R5bGVBdHRyaWJ1dGVzLmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICAgICAgdmFyIG5hbWUg PSBwYXlsb2FkU3R5bGVBdHRyaWJ1dGVzW2ldLm5hbWU7CisgICAgICAgICAgICAgICAgcmVzdWx0 LnN0eWxlQXR0cmlidXRlc1tuYW1lXSA9IFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9u LnBhcnNlUGF5bG9hZChwYXlsb2FkU3R5bGVBdHRyaWJ1dGVzW2ldLnN0eWxlKTsKKyAgICAgICAg ICAgIH0KIAogICAgICAgICAgICAgcmVzdWx0LnBzZXVkb0VsZW1lbnRzID0gW107CiAgICAgICAg ICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHBheWxvYWQucHNldWRvRWxlbWVudHMubGVuZ3RoOyAr K2kpIHsK