57430 2011-03-30 00:42:41 -0700 [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled 2011-03-30 02:17:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yutak webkit-unassigned abarth tkent oldest_to_newest 376110 0 yutak 2011-03-30 00:42:41 -0700 http://trac.webkit.org/changeset/82399 adds dependency to LayoutTestController::setPluginsEnabled(). 376131 1 87482 yutak 2011-03-30 01:55:26 -0700 Created attachment 87482 Patch 376132 2 yutak 2011-03-30 01:59:08 -0700 Could anybody review this? 376133 3 87482 tkent 2011-03-30 02:06:20 -0700 Comment on attachment 87482 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87482&action=review > Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1702 > + bool pluginsEnabled = arguments[0].toBoolean(); > + m_shell->preferences()->pluginsEnabled = pluginsEnabled; nit: You can omit the variable pluginsEnabled. 376136 4 yutak 2011-03-30 02:10:39 -0700 (In reply to comment #3) > nit: You can omit the variable pluginsEnabled. Thanks, I have fixed it locally and will commit manually. 376142 5 yutak 2011-03-30 02:17:09 -0700 Committed r82416: <http://trac.webkit.org/changeset/82416> 87482 2011-03-30 01:55:26 -0700 2011-03-30 02:06:20 -0700 Patch bug-57430-20110330175523.patch text/plain 4937 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogODI0MTAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwYjJhZmNhZTM1ZTc4ODcwYmU3N2U4 ZTUzZDk5NjRlMDNjYjk0ZmNlLi45NTZjMTUyNjA1ZGYyMjc0MTVhNjRmMDg0M2Y0N2FhMDZmNzg3 OWU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTEtMDMtMzAgIFl1dGEgS2l0YW11cmEgIDx5 dXRha0BjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0Nocm9taXVtXSBEdW1wUmVuZGVyVHJlZTogSW1wbGVtZW50IExheW91dFRl c3RDb250cm9sbGVyOjpzZXRQbHVnaW5zRW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc0MzAKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDogUmV2ZXJ0IHRoZSBleHBlY3RhdGlvbiBjaGFuZ2Vz IGNhdXNlZCBieSByODIzOTkuCisKKzIwMTEtMDMtMzAgIFl1dGEgS2l0YW11cmEgIDx5dXRha0Bj aHJvbWl1bS5vcmc+CisKICAgICAgICAgVW5yZXZpZXdlZCwgcmVtb3ZlIGR1cGxpY2F0ZSBDaHJv bWl1bSB0ZXN0IGV4cGVjdGF0aW9ucy4KIAogICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rl c3RfZXhwZWN0YXRpb25zLnR4dDoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9t aXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCBlYmEzMzIxM2IyZGY2NGVhYWVmNDg1NmIy MjMyNjg2MzM2OWRmNmRhLi5iZDY3MDBkY2Y0NTViNzAwMDcyOGM3MWNlZGMzMGY5OGViNjUzZGEx IDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0 aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0CkBAIC0zMjAzLDcgKzMyMDMsNyBAQCBCVUdDUjc3NTgyIEJVR19EUlQgV0lOIExJ TlVYIERFQlVHIFNMT1cgOiBpbnNwZWN0b3IvZGVidWdnZXIvZGVidWdnZXItYWN0aXZhdGlvbgog CiAvLyBSZWdyZXNzaW9uIHNpbmNlIHI4MjAwMS4KIEJVR0NSNzc2MTkgTUFDIFNOT1dMRU9QQVJE IDogcGx1Z2lucy9wbHVnaW4tamF2YXNjcmlwdC1hY2Nlc3MuaHRtbCA9IFRFWFQKLS8vIEJVR0NS Nzc2MjggTUFDIDogZmFzdC9pbWFnZXMvbW92ZS1pbWFnZS10by1uZXctZG9jdW1lbnQuaHRtbCA9 IFRJTUVPVVQKK0JVR0NSNzc2MjggTUFDIDogZmFzdC9pbWFnZXMvbW92ZS1pbWFnZS10by1uZXct ZG9jdW1lbnQuaHRtbCA9IFRJTUVPVVQKIAogLy8gTmV3IHRlc3QgaW4gcjgyMDEzLgogQlVHV0s4 MjAxMyBXSU4gTElOVVggOiBmYXN0L3RleHQvanVzdGlmeS1pZGVvZ3JhcGgtbGVhZGluZy1leHBh bnNpb24uaHRtbCA9IElNQUdFK1RFWFQKQEAgLTMyMzYsNiArMzIzNiwzIEBAIEJVR1hYWCBHUFUg TUFDIFNOT1dMRU9QQVJEIDogY29tcG9zaXRpbmcvc2VsZi1wYWludGluZy1sYXllcnMuaHRtbCA9 IEZBSUwKIAogLy8gQ2hyb21lIGRvZXNuJ3QgbG9hZCBmYXZpY29ucyBpbiBEUlQgdGVzdHMuCiBC VUdXSzU3MjU5IDogaHR0cC90ZXN0cy9taXNjL2xpbmstcmVsLWljb24tYmVmb3JlbG9hZC5odG1s ID0gRkFJTCBQQVNTCi0KLS8vIE5lZWRzIExheW91dFRlc3RDb250cm9sbGVyLnNldFBsdWdpbnNF bmFibGVkLgotQlVHV0s1NzQzMCA6IGZhc3QvaW1hZ2VzL21vdmUtaW1hZ2UtdG8tbmV3LWRvY3Vt ZW50Lmh0bWwgPSBURVhUCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFu Z2VMb2cKaW5kZXggMDAwZTJiZjIwN2QzNzgxOWNkYTJlMDQyN2EyZjAxY2E5Y2NhNDVkNC4uMzBk M2NmNTkxNzMzZDM2NTBhMWZhMzg5ZjIzOWY2MjBlMWFlYWE1NiAxMDA2NDQKLS0tIGEvVG9vbHMv Q2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAz LTMwICBZdXRhIEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gRHVtcFJlbmRlclRy ZWU6IEltcGxlbWVudCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0UGx1Z2luc0VuYWJsZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NDMwCisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHA6 CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6TGF5b3V0VGVzdENvbnRyb2xsZXIpOgor ICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFBsdWdpbnNFbmFibGVkKToKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5oOgorCiAy MDExLTAzLTMwICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAppbmRleCBhYjM2MGE0MjMzYjc5NjJh ZGQ5MzZjMzA3OWVkMzYzM2VjZjk5NGYwLi5iNDY3ZTRlNDE3ZTg0MDVlNGQ4NzE5ZjRmMmNlOWQ1 YmY3ZDc4ZWE1IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlv dXRUZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v TGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCkBAIC0xNTUsNiArMTU1LDcgQEAgTGF5b3V0VGVzdENv bnRyb2xsZXI6OkxheW91dFRlc3RDb250cm9sbGVyKFRlc3RTaGVsbCogc2hlbGwpCiAgICAgYmlu ZE1ldGhvZCgic2V0TW9ja0dlb2xvY2F0aW9uRXJyb3IiLCAmTGF5b3V0VGVzdENvbnRyb2xsZXI6 OnNldE1vY2tHZW9sb2NhdGlvbkVycm9yKTsKICAgICBiaW5kTWV0aG9kKCJzZXRNb2NrR2VvbG9j YXRpb25Qb3NpdGlvbiIsICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0TW9ja0dlb2xvY2F0aW9u UG9zaXRpb24pOwogICAgIGJpbmRNZXRob2QoImFkZE1vY2tTcGVlY2hJbnB1dFJlc3VsdCIsICZM YXlvdXRUZXN0Q29udHJvbGxlcjo6YWRkTW9ja1NwZWVjaElucHV0UmVzdWx0KTsKKyAgICBiaW5k TWV0aG9kKCJzZXRQbHVnaW5zRW5hYmxlZCIsICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0UGx1 Z2luc0VuYWJsZWQpOwogICAgIGJpbmRNZXRob2QoInNldFBvcHVwQmxvY2tpbmdFbmFibGVkIiwg JkxheW91dFRlc3RDb250cm9sbGVyOjpzZXRQb3B1cEJsb2NraW5nRW5hYmxlZCk7CiAgICAgYmlu ZE1ldGhvZCgic2V0UE9TSVhMb2NhbGUiLCAmTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFBPU0lY TG9jYWxlKTsKICAgICBiaW5kTWV0aG9kKCJzZXRTY3JvbGxiYXJQb2xpY3kiLCAmTGF5b3V0VGVz dENvbnRyb2xsZXI6OnNldFNjcm9sbGJhclBvbGljeSk7CkBAIC0xNjkzLDMgKzE2OTQsMTMgQEAg dm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c3luY0xvY2FsU3RvcmFnZShjb25zdCBDcHBBcmd1 bWVudExpc3QmLCBDcHBWYXJpYW50KikKIHsKICAgICAvLyBOb3QgSW1wbGVtZW50ZWQKIH0KKwor dm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0UGx1Z2luc0VuYWJsZWQoY29uc3QgQ3BwQXJn dW1lbnRMaXN0JiBhcmd1bWVudHMsIENwcFZhcmlhbnQqIHJlc3VsdCkKK3sKKyAgICBpZiAoYXJn dW1lbnRzLnNpemUoKSA+IDAgJiYgYXJndW1lbnRzWzBdLmlzQm9vbCgpKSB7CisgICAgICAgIGJv b2wgcGx1Z2luc0VuYWJsZWQgPSBhcmd1bWVudHNbMF0udG9Cb29sZWFuKCk7CisgICAgICAgIG1f c2hlbGwtPnByZWZlcmVuY2VzKCktPnBsdWdpbnNFbmFibGVkID0gcGx1Z2luc0VuYWJsZWQ7Cisg ICAgICAgIG1fc2hlbGwtPmFwcGx5UHJlZmVyZW5jZXMoKTsKKyAgICB9CisgICAgcmVzdWx0LT5z ZXROdWxsKCk7Cit9CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9M YXlvdXRUZXN0Q29udHJvbGxlci5oIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5 b3V0VGVzdENvbnRyb2xsZXIuaAppbmRleCA3MWFjMThkOTg4M2QzYzU2ZGU3YzYxNzZhZWYyMTJk ZWI1YjIyYzI0Li42N2YwYjRiZDgwMjM1ODdjN2Y2NTc1NzkyZmE2MjMyMTAwNmFkMGRhIDEwMDY0 NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxl ci5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9s bGVyLmgKQEAgLTM1OCw2ICszNTgsOSBAQCBwdWJsaWM6CiAgICAgdm9pZCBvYnNlcnZlU3RvcmFn ZVRyYWNrZXJOb3RpZmljYXRpb25zKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYsIENwcFZhcmlhbnQq KTsKICAgICB2b2lkIHN5bmNMb2NhbFN0b3JhZ2UoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiwgQ3Bw VmFyaWFudCopOwogCisgICAgLy8gRW5hYmxlIG9yIGRpc2FibGUgcGx1Z2lucy4KKyAgICB2b2lk IHNldFBsdWdpbnNFbmFibGVkKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYsIENwcFZhcmlhbnQqKTsK KwogcHVibGljOgogICAgIC8vIFRoZSBmb2xsb3dpbmcgbWV0aG9kcyBhcmUgbm90IGV4cG9zZWQg dG8gSmF2YVNjcmlwdC4KICAgICB2b2lkIHNldFdvcmtRdWV1ZUZyb3plbihib29sIGZyb3plbikg eyBtX3dvcmtRdWV1ZS5zZXRGcm96ZW4oZnJvemVuKTsgfQo=