57425 2011-03-29 23:45:10 -0700 make webkit-patch upload respect -d 2011-03-30 01:08:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs mjs abarth eric oldest_to_newest 376070 0 mjs 2011-03-29 23:45:10 -0700 make webkit-patch upload respect -d 376071 1 87470 mjs 2011-03-29 23:45:28 -0700 Created attachment 87470 Patch 376111 2 87478 mjs 2011-03-30 00:46:42 -0700 Created attachment 87478 Patch 376116 3 87478 abarth 2011-03-30 00:55:05 -0700 Comment on attachment 87478 Patch This looks correct. Ideally we would add a test as well. 376117 4 mjs 2011-03-30 00:56:25 -0700 Committed r82407: <http://trac.webkit.org/changeset/82407> 376123 5 eric 2011-03-30 01:04:01 -0700 Be strong abarth! /me is very sad at lack of testing. :( 376124 6 mjs 2011-03-30 01:05:14 -0700 I will learn how to operate the Python unit tests some day. scm_unitests.py boggles my mind at present. 376126 7 eric 2011-03-30 01:08:23 -0700 scm_unitteset.py is our oldest and worst unit test file. But you can run a single class of tests with: test-webkitpy webkitpy.common.checkout.scm_unittest.SCMClassTests or even just a single test: test-webkitpy webkitpy.common.checkout.scm_unittest.SCMClassTests.test_run_command_with_pipe 87470 2011-03-29 23:45:28 -0700 2011-03-30 00:46:39 -0700 Patch bug-57425-20110329234527.patch text/plain 1124 mjs SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgyMzk4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDMtMjkgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtYWtlIHdl YmtpdC1wYXRjaCB1cGxvYWQgcmVzcGVjdCAtZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc0MjUKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NoZWNrb3V0L3NjbS5weToKKwogMjAxMS0wMy0yOSAgU2hlcmlmZiBCb3QgIDx3ZWJr aXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjgyMzgzLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQv c2NtLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L3NjbS5weQkocmV2aXNpb24gODIwNTkpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jaGVja291dC9zY20ucHkJKHdvcmtpbmcgY29weSkKQEAgLTU2OSw2ICs1NjksOSBAQCBj bGFzcyBTVk4oU0NNKToKICAgICAgICAgICAgIHN2bl9jb21taXRfYXJncy5leHRlbmQoWyItLXVz ZXJuYW1lIiwgdXNlcm5hbWVdKQogCiAgICAgICAgIHN2bl9jb21taXRfYXJncy5leHRlbmQoWyIt bSIsIG1lc3NhZ2VdKQorCisgICAgICAgIHN0YXR1c19jb21tYW5kLmV4dGVuZChzZWxmLl9wYXRj aF9kaXJlY3RvcmllcykKKwogICAgICAgICAjIEZJWE1FOiBTaG91bGQgdGhpcyB1c2UgY3dkPXNl bGYuY2hlY2tvdXRfcm9vdD8KICAgICAgICAgcmV0dXJuIHNlbGYucnVuKHN2bl9jb21taXRfYXJn cywgZXJyb3JfaGFuZGxlcj1jb21taXRfZXJyb3JfaGFuZGxlcikKIAo= 87478 2011-03-30 00:46:42 -0700 2011-03-30 00:55:05 -0700 Patch bug-57425-20110330004641.patch text/plain 3561 mjs SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgyNDA0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDMtMzAgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtYWtlIHdl YmtpdC1wYXRjaCB1cGxvYWQgcmVzcGVjdCAtZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc0MjUKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NoZWNrb3V0L3NjbS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c3RlcHMvY29tbWl0LnB5OgorCiAyMDExLTAzLTMwICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0Bh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkJKHJldmlzaW9uIDgy NDAyKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC0yOTEsNyArMjkxLDcgQEAgY2xhc3MgU0NNOgogICAgIGRlZiByZXZl cnRfZmlsZXMoc2VsZiwgZmlsZV9wYXRocyk6CiAgICAgICAgIHNlbGYuX3N1YmNsYXNzX211c3Rf aW1wbGVtZW50KCkKIAotICAgIGRlZiBjb21taXRfd2l0aF9tZXNzYWdlKHNlbGYsIG1lc3NhZ2Us IHVzZXJuYW1lPU5vbmUsIGdpdF9jb21taXQ9Tm9uZSwgZm9yY2Vfc3F1YXNoPUZhbHNlKToKKyAg ICBkZWYgY29tbWl0X3dpdGhfbWVzc2FnZShzZWxmLCBtZXNzYWdlLCB1c2VybmFtZT1Ob25lLCBn aXRfY29tbWl0PU5vbmUsIGZvcmNlX3NxdWFzaD1GYWxzZSwgY2hhbmdlZF9maWxlcz1Ob25lKToK ICAgICAgICAgc2VsZi5fc3ViY2xhc3NfbXVzdF9pbXBsZW1lbnQoKQogCiAgICAgZGVmIHN2bl9j b21taXRfbG9nKHNlbGYsIHN2bl9yZXZpc2lvbik6CkBAIC01NTYsNyArNTU2LDcgQEAgY2xhc3Mg U1ZOKFNDTSk6CiAgICAgICAgICMgRklYTUU6IFRoaXMgc2hvdWxkIHByb2JhYmx5IHVzZSBjd2Q9 c2VsZi5jaGVja291dF9yb290LgogICAgICAgICBzZWxmLnJ1bihbJ3N2bicsICdyZXZlcnQnXSAr IGZpbGVfcGF0aHMpCiAKLSAgICBkZWYgY29tbWl0X3dpdGhfbWVzc2FnZShzZWxmLCBtZXNzYWdl LCB1c2VybmFtZT1Ob25lLCBnaXRfY29tbWl0PU5vbmUsIGZvcmNlX3NxdWFzaD1GYWxzZSk6Cisg ICAgZGVmIGNvbW1pdF93aXRoX21lc3NhZ2Uoc2VsZiwgbWVzc2FnZSwgdXNlcm5hbWU9Tm9uZSwg Z2l0X2NvbW1pdD1Ob25lLCBmb3JjZV9zcXVhc2g9RmFsc2UsIGNoYW5nZWRfZmlsZXM9Tm9uZSk6 CiAgICAgICAgICMgZ2l0LWNvbW1pdCBhbmQgZm9yY2UgYXJlIG5vdCB1c2VkIGJ5IFNWTi4KICAg ICAgICAgc3ZuX2NvbW1pdF9hcmdzID0gWyJzdm4iLCAiY29tbWl0Il0KIApAQCAtNTY3LDYgKzU2 Nyw5IEBAIGNsYXNzIFNWTihTQ00pOgogCiAgICAgICAgIHN2bl9jb21taXRfYXJncy5leHRlbmQo WyItbSIsIG1lc3NhZ2VdKQogCisgICAgICAgIGlmIGNoYW5nZWRfZmlsZXM6CisgICAgICAgICAg ICBzdm5fY29tbWl0X2FyZ3MuZXh0ZW5kKGNoYW5nZWRfZmlsZXMpCisKICAgICAgICAgaWYgc2Vs Zi5kcnlydW46CiAgICAgICAgICAgICBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoIndlYmtpdHB5 LmNvbW1vbi5zeXN0ZW0iKQogICAgICAgICAgICAgX2xvZy5kZWJ1ZygnV291bGQgcnVuIFNWTiBj b21tYW5kOiAiJyArICIgIi5qb2luKHN2bl9jb21taXRfYXJncykgKyAnIicpCkBAIC04MzEsNyAr ODM0LDcgQEAgY2xhc3MgR2l0KFNDTSk6CiAgICAgICAgICAgICBpZiBudW1fbG9jYWxfY29tbWl0 cyA+IDEgb3IgKG51bV9sb2NhbF9jb21taXRzID4gMCBhbmQgbm90IHdvcmtpbmdfZGlyZWN0b3J5 X2lzX2NsZWFuKToKICAgICAgICAgICAgICAgICByYWlzZSBBbWJpZ3VvdXNDb21taXRFcnJvcihu dW1fbG9jYWxfY29tbWl0cywgd29ya2luZ19kaXJlY3RvcnlfaXNfY2xlYW4pCiAKLSAgICBkZWYg Y29tbWl0X3dpdGhfbWVzc2FnZShzZWxmLCBtZXNzYWdlLCB1c2VybmFtZT1Ob25lLCBnaXRfY29t bWl0PU5vbmUsIGZvcmNlX3NxdWFzaD1GYWxzZSk6CisgICAgZGVmIGNvbW1pdF93aXRoX21lc3Nh Z2Uoc2VsZiwgbWVzc2FnZSwgdXNlcm5hbWU9Tm9uZSwgZ2l0X2NvbW1pdD1Ob25lLCBmb3JjZV9z cXVhc2g9RmFsc2UsIGNoYW5nZWRfZmlsZXM9Tm9uZSk6CiAgICAgICAgICMgVXNlcm5hbWUgaXMg aWdub3JlZCBkdXJpbmcgR2l0IGNvbW1pdHMuCiAgICAgICAgIHdvcmtpbmdfZGlyZWN0b3J5X2lz X2NsZWFuID0gc2VsZi53b3JraW5nX2RpcmVjdG9yeV9pc19jbGVhbigpCiAKSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb21taXQucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2NvbW1pdC5weQkocmV2aXNpb24gODIwNTkp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29tbWl0LnB5CSh3b3JraW5n IGNvcHkpCkBAIC01OCw3ICs1OCw3IEBAIGNsYXNzIENvbW1pdChBYnN0cmFjdFN0ZXApOgogCiAg ICAgICAgICAgICB0cnk6CiAgICAgICAgICAgICAgICAgc2NtID0gc2VsZi5fdG9vbC5zY20oKQot ICAgICAgICAgICAgICAgIGNvbW1pdF90ZXh0ID0gc2NtLmNvbW1pdF93aXRoX21lc3NhZ2Uoc2Vs Zi5fY29tbWl0X21lc3NhZ2UsIGdpdF9jb21taXQ9c2VsZi5fb3B0aW9ucy5naXRfY29tbWl0LCB1 c2VybmFtZT11c2VybmFtZSwgZm9yY2Vfc3F1YXNoPWZvcmNlX3NxdWFzaCkKKyAgICAgICAgICAg ICAgICBjb21taXRfdGV4dCA9IHNjbS5jb21taXRfd2l0aF9tZXNzYWdlKHNlbGYuX2NvbW1pdF9t ZXNzYWdlLCBnaXRfY29tbWl0PXNlbGYuX29wdGlvbnMuZ2l0X2NvbW1pdCwgdXNlcm5hbWU9dXNl cm5hbWUsIGZvcmNlX3NxdWFzaD1mb3JjZV9zcXVhc2gsIGNoYW5nZWRfZmlsZXM9c2VsZi5fY2hh bmdlZF9maWxlcyhzdGF0ZSkpCiAgICAgICAgICAgICAgICAgc3ZuX3JldmlzaW9uID0gc2NtLnN2 bl9yZXZpc2lvbl9mcm9tX2NvbW1pdF90ZXh0KGNvbW1pdF90ZXh0KQogICAgICAgICAgICAgICAg IGxvZygiQ29tbWl0dGVkIHIlczogPCVzPiIgJSAoc3ZuX3JldmlzaW9uLCB1cmxzLnZpZXdfcmV2 aXNpb25fdXJsKHN2bl9yZXZpc2lvbikpKQogICAgICAgICAgICAgICAgIHNlbGYuX3N0YXRlWyJj b21taXRfdGV4dCJdID0gY29tbWl0X3RleHQK