57420 2011-03-29 21:40:29 -0700 [WinCairo] ENABLE(VIDEO) Broken 2014-03-03 09:18:25 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham alex.christensen commit-queue eric.carlson esprehn+autocc glenn jer.noble kondapallykalyan mrobinson pnormand oldest_to_newest 376031 0 bfulgham 2011-03-29 21:40:29 -0700 It's been a long time since I built with ENABLE(VIDEO) active. It turns out that a lot of CG-specific rendering code has crept into the Windows common routines, preventing WinCairo from building with other video support (e.g., GStreamer). This bug tracks the correction of this problem. 380785 1 pnormand 2011-04-06 13:46:08 -0700 It's been a while since last I played with VIDEO on WinCairo, but what are the specific issues you have? WinCairo should use the ImageGStreamerCairo interface, just as GTK does. No CG stuff should be involved :) 949694 2 216684 alex.christensen 2013-11-12 09:15:47 -0800 Created attachment 216684 Patch 949699 3 216684 pnormand 2013-11-12 09:25:09 -0800 Comment on attachment 216684 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216684&action=review > Source/WebCore/ChangeLog:3 > + Preparation for GStreamer on Windows. nit, this is not the right bug title 949725 4 alex.christensen 2013-11-12 10:21:41 -0800 committed in http://trac.webkit.org/changeset/159122 with the title "[WinCairo] Preparation for ENABLE(VIDEO)." 986282 5 pnormand 2014-03-03 00:17:45 -0800 So this bug can be closed then? 986358 6 alex.christensen 2014-03-03 08:56:12 -0800 Yep. For some reason, I don't have access to close it, though. 216684 2013-11-12 09:15:47 -0800 2014-03-03 09:18:16 -0800 Patch bug-57420-20131112101546.patch text/plain 4324 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTExMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTExLTEyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUHJlcGFyYXRp b24gZm9yIEdTdHJlYW1lciBvbiBXaW5kb3dzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc0MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL0ZpbGVTeXN0ZW0uaDoKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHA6CisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlck1lZGlhQ29udHJvbHMuY3BwOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZVdp bi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZVdpbjo6YWRqdXN0U2xpZGVyVGh1 bWJTaXplKToKKyAgICAgICAgU2VwYXJhdGVkIENHIGNvZGUgZnJvbSBHU3RyZWFtZXIgY29kZS4K KwogMjAxMy0xMS0xMiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAg ICAgVGV4dCBvbiBzaW1wbGUgbGluZXMgc29tZXRpbWVzIHBhaW50cyBvbmUgcGl4ZWwgb2ZmCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmlsZVN5c3RlbS5oCShyZXZpc2lvbiAxNTkxMTIpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgJKHdvcmtpbmcgY29weSkKQEAg LTEwMSw3ICsxMDEsNyBAQCB0eXBlZGVmIHVuc2lnbmVkIFBsYXRmb3JtTW9kdWxlVmVyc2lvbjsK ICNlbmRpZgogCiAvLyBQbGF0Zm9ybUZpbGVIYW5kbGUKLSNpZiBVU0UoR0xJQikgJiYgIVBMQVRG T1JNKEVGTCkKKyNpZiBVU0UoR0xJQikgJiYgIVBMQVRGT1JNKEVGTCkgJiYgIVBMQVRGT1JNKFdJ TikKIHR5cGVkZWYgR0ZpbGVJT1N0cmVhbSogUGxhdGZvcm1GaWxlSGFuZGxlOwogY29uc3QgUGxh dGZvcm1GaWxlSGFuZGxlIGludmFsaWRQbGF0Zm9ybUZpbGVIYW5kbGUgPSAwOwogI2VsaWYgT1Mo V0lORE9XUykKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxh eWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9N ZWRpYVBsYXllci5jcHAJKHJldmlzaW9uIDE1OTExMikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEsNyArNjEs NyBAQAogI2VsaWYgT1MoV0lOQ0UpCiAjaW5jbHVkZSAiTWVkaWFQbGF5ZXJQcml2YXRlV2luQ0Uu aCIKICNkZWZpbmUgUGxhdGZvcm1NZWRpYUVuZ2luZUNsYXNzTmFtZSBNZWRpYVBsYXllclByaXZh dGUKLSNlbGlmIFBMQVRGT1JNKFdJTikKKyNlbGlmIFBMQVRGT1JNKFdJTikgJiYgIVVTRShHU1RS RUFNRVIpCiAjaW5jbHVkZSAiTWVkaWFQbGF5ZXJQcml2YXRlUXVpY2tUaW1lVmlzdWFsQ29udGV4 dC5oIgogI2RlZmluZSBQbGF0Zm9ybU1lZGlhRW5naW5lQ2xhc3NOYW1lIE1lZGlhUGxheWVyUHJp dmF0ZVF1aWNrVGltZVZpc3VhbENvbnRleHQKICNpZiBVU0UoQVZGT1VOREFUSU9OKQpJbmRleDog U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHMuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZWRpYUNvbnRyb2xzLmNwcAko cmV2aXNpb24gMTU5MTEyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlh Q29udHJvbHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICszNiw3IEBACiAjaW5jbHVkZSAi UmVuZGVyVGhlbWUuaCIKIAogLy8gRklYTUU6IFVuaWZ5IG1vcmUgb2YgdGhlIGNvZGUgZm9yIE1h YyBhbmQgV2luLgotI2lmIFBMQVRGT1JNKFdJTikKKyNpZiBQTEFURk9STShXSU4pICYmIFVTRShD RykKIAogI2luY2x1ZGUgPENvcmVHcmFwaGljcy9Db3JlR3JhcGhpY3MuaD4KICNpbmNsdWRlIDxX ZWJLaXRTeXN0ZW1JbnRlcmZhY2UvV2ViS2l0U3lzdGVtSW50ZXJmYWNlLmg+CkBAIC02OCw3ICs2 OCw3IEBAIGlubGluZSB2b2lkIHdrRHJhd01lZGlhU2xpZGVyVHJhY2soQ0dDb24KIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCi0jaWYgUExBVEZPUk0oV0lOKQorI2lmIFBMQVRGT1JNKFdJTikgJiYg VVNFKENHKQogCiBzdGF0aWMgV0tNZWRpYUNvbnRyb2xsZXJUaGVtZVN0YXRlIGRldGVybWluZVN0 YXRlKFJlbmRlck9iamVjdCogbykKIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUaGVtZVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRoZW1lV2luLmNwcAkocmV2aXNpb24gMTU5MTEyKQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODk2LDcgKzg5 Niw3IEBAIHZvaWQgUmVuZGVyVGhlbWVXaW46OmFkanVzdFNsaWRlclRodW1iU2kKICAgICAgICAg c3R5bGUtPnNldFdpZHRoKExlbmd0aChzbGlkZXJUaHVtYldpZHRoLCBGaXhlZCkpOwogICAgICAg ICBzdHlsZS0+c2V0SGVpZ2h0KExlbmd0aChzbGlkZXJUaHVtYkhlaWdodCwgRml4ZWQpKTsKICAg ICB9Ci0jaWYgRU5BQkxFKFZJREVPKQorI2lmIEVOQUJMRShWSURFTykgJiYgVVNFKENHKQogICAg IGVsc2UgaWYgKHBhcnQgPT0gTWVkaWFTbGlkZXJUaHVtYlBhcnQgfHwgcGFydCA9PSBNZWRpYVZv bHVtZVNsaWRlclRodW1iUGFydCkgCiAgICAgICAgIFJlbmRlck1lZGlhQ29udHJvbHM6OmFkanVz dE1lZGlhU2xpZGVyVGh1bWJTaXplKHN0eWxlKTsKICNlbmRpZgpJbmRleDogU291cmNlL1dlYktp dC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxv ZwkocmV2aXNpb24gMTU5MTEyKQorKysgU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTEtMTIgIEFsZXggQ2hyaXN0ZW5zZW4g IDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBQcmVwYXJhdGlvbiBmb3IgR1N0 cmVhbWVyIG9uIFdpbmRvd3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01NzQyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlci5jcHA6CisgICAgICAgIERvbid0 IGNvbXBpbGUgaWYgdXNpbmcgR1N0cmVhbWVyLgorCiAyMDEzLTExLTEwICBHeXV5b3VuZyBLaW0g IDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0FYXSBDbGVhbiB1cCBzdGF0 aWNfY2FzdDw+IHRvIGNhc3QgZnJvbSBBY2Nlc3NpYmlsaXR5T2JqZWN0IApJbmRleDogU291cmNl L1dlYktpdC93aW4vRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC93aW4vRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlci5jcHAJKHJldmlzaW9u IDE1OTExMikKKysrIFNvdXJjZS9XZWJLaXQvd2luL0Z1bGxzY3JlZW5WaWRlb0NvbnRyb2xsZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNSw3ICsyNSw3IEBACiAKICNpbmNsdWRlICJjb25maWcu aCIKIAotI2lmIEVOQUJMRShWSURFTykKKyNpZiBFTkFCTEUoVklERU8pICYmICFVU0UoR1NUUkVB TUVSKQogCiAjaW5jbHVkZSAiRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlci5oIgogCg==