<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>57373</bug_id>
          
          <creation_ts>2011-03-29 12:01:55 -0700</creation_ts>
          <short_desc>Make WinCairo a core builder</short_desc>
          <delta_ts>2011-03-29 15:00:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>375634</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-03-29 12:01:55 -0700</bug_when>
    <thetext>Make WinCairo a core builder to help reduce build breaks due to ongoing development.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375650</commentid>
    <comment_count>1</comment_count>
      <attachid>87387</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-03-29 12:12:20 -0700</bug_when>
    <thetext>Created attachment 87387
Make WinCairo a core builder.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375654</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-03-29 12:15:20 -0700</bug_when>
    <thetext>Attachment 87387 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Tools/ChangeLog&apos;, u&apos;Tools/Scripts/webkitpy...&quot; exit_code: 1

Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375682</commentid>
    <comment_count>3</comment_count>
      <attachid>87399</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-03-29 12:54:20 -0700</bug_when>
    <thetext>Created attachment 87399
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375683</commentid>
    <comment_count>4</comment_count>
      <attachid>87399</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-03-29 12:56:20 -0700</bug_when>
    <thetext>Comment on attachment 87399
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87399&amp;action=review

&gt; Tools/Scripts/update-webkit-support-libs:66
&gt; +print &quot;$extractedVersion compared to $expectedVersion&quot;;
&gt; +

Whoopsie! Please remove this</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375685</commentid>
    <comment_count>5</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-03-29 12:58:45 -0700</bug_when>
    <thetext>Whoops!  I&apos;ve removed the debugging message.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375725</commentid>
    <comment_count>6</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-03-29 13:56:09 -0700</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/82313.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375783</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-03-29 15:00:50 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/82313 might have broken Windows 7 Release (Tests)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>87387</attachid>
            <date>2011-03-29 12:12:20 -0700</date>
            <delta_ts>2011-03-29 12:54:17 -0700</delta_ts>
            <desc>Make WinCairo a core builder.</desc>
            <filename>wincairo_core.patch</filename>
            <type>text/plain</type>
            <size>1659</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDgyMjk3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTMgQEAKKzIwMTEtMDMtMjkgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ug
V2luQ2Fpcm8gYSBjb3JlIGJ1aWxkZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD01NzM3My4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29t
bW9uL25ldC9idWlsZGJvdC9idWlsZGJvdC5weTogQWRkIFdpbkNhaXJvLgorICAgICAgICAqIFNj
cmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC9idWlsZGJvdF91bml0dGVzdC5weTog
QWRkIFdpbkNhaXJvLgorCiAyMDExLTAzLTI5ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v
cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZhaS4KSW5kZXg6IFRvb2xzL1Njcmlw
dHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC9idWlsZGJvdC5weQo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3QucHkJ
KHJldmlzaW9uIDgyMjY0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1
aWxkYm90L2J1aWxkYm90LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yODUsNiArMjg1LDcgQEAgY2xh
c3MgQnVpbGRCb3Qob2JqZWN0KToKICAgICAgICAgICAgICJMZW9wYXJkLioiLAogICAgICAgICAg
ICAgIldpbmRvd3MuKkJ1aWxkIiwKICAgICAgICAgICAgICJXaW5kb3dzLipcKFRlc3QiLAorICAg
ICAgICAgICAgIldpbkNhaXJvIiwKICAgICAgICAgICAgICJXaW5DRSIsCiAgICAgICAgICAgICAi
RUZMIiwKICAgICAgICAgICAgICJHVEsuKjMyIiwKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0
cHkvY29tbW9uL25ldC9idWlsZGJvdC9idWlsZGJvdF91bml0dGVzdC5weQo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3RfdW5p
dHRlc3QucHkJKHJldmlzaW9uIDgyMjY0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t
b24vbmV0L2J1aWxkYm90L2J1aWxkYm90X3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0y
NjEsNiArMjYxLDcgQEAgY2xhc3MgQnVpbGRCb3RUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAg
ICAgICAgICAgICJMZW9wYXJkLioiLAogICAgICAgICAgICAgIldpbmRvd3MuKkJ1aWxkIiwKICAg
ICAgICAgICAgICJXaW5kb3dzLipcKFRlc3QiLAorICAgICAgICAgICAgIldpbkNhaXJvIiwKICAg
ICAgICAgICAgICJXaW5DRSIsCiAgICAgICAgICAgICAiRUZMIiwKICAgICAgICAgICAgICJHVEsu
KjMyIiwK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>87399</attachid>
            <date>2011-03-29 12:54:20 -0700</date>
            <delta_ts>2011-03-29 12:56:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-57373-20110329125419.patch</filename>
            <type>text/plain</type>
            <size>2658</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDgyMjk5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTMgQEAKKzIwMTEtMDMtMjkgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ug
V2luQ2Fpcm8gYSBjb3JlIGJ1aWxkZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD01NzM3MworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21t
b24vbmV0L2J1aWxkYm90L2J1aWxkYm90LnB5OiBBZGQgV2luQ2Fpcm8uCisgICAgICAgICogU2Ny
aXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxkYm90X3VuaXR0ZXN0LnB5OiBB
ZGQgV2luQ2Fpcm8uCisKIDIwMTEtMDMtMjkgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y
Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpJbmRleDogVG9vbHMvU2NyaXB0
cy91cGRhdGUtd2Via2l0LXN1cHBvcnQtbGlicwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz
L3VwZGF0ZS13ZWJraXQtc3VwcG9ydC1saWJzCShyZXZpc2lvbiA4MjI5OSkKKysrIFRvb2xzL1Nj
cmlwdHMvdXBkYXRlLXdlYmtpdC1zdXBwb3J0LWxpYnMJKHdvcmtpbmcgY29weSkKQEAgLTYyLDYg
KzYyLDggQEAgaWYgKCRleHRyYWN0ZWRWZXJzaW9uIG5lIE5PVEFWRVJTSU9OICYmCiAgICAgZXhp
dDsKIH0KIAorcHJpbnQgIiRleHRyYWN0ZWRWZXJzaW9uIGNvbXBhcmVkIHRvICRleHBlY3RlZFZl
cnNpb24iOworCiAjIENoZWNrIHdoZXRoZXIgdGhlIGRvd25sb2FkZWQgbGlicmFyeSBpcyB1cC10
by1kYXRlLiBJZiBpdCBpc24ndCwgdGhlIHVzZXIgbmVlZHMgdG8gZG93bmxvYWQgaXQuCiBteSAk
emlwRmlsZVZlcnNpb24gPSB6aXBGaWxlVmVyc2lvbigpOwogZGllQW5kSW5zdHJ1Y3RUb0Rvd25s
b2FkKCIkemlwRmlsZSBjb3VsZCBub3QgYmUgZm91bmQgaW4gJHppcERpcmVjdG9yeS4iKSBpZiAk
emlwRmlsZVZlcnNpb24gZXEgTk9UQVZFUlNJT047CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp
dHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3QucHkKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv
U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxkYm90LnB5CShyZXZpc2lv
biA4MjI5OSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC9i
dWlsZGJvdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjg1LDYgKzI4NSw3IEBAIGNsYXNzIEJ1aWxk
Qm90KG9iamVjdCk6CiAgICAgICAgICAgICAiTGVvcGFyZC4qIiwKICAgICAgICAgICAgICJXaW5k
b3dzLipCdWlsZCIsCiAgICAgICAgICAgICAiV2luZG93cy4qXChUZXN0IiwKKyAgICAgICAgICAg
ICJXaW5DYWlybyIsCiAgICAgICAgICAgICAiV2luQ0UiLAogICAgICAgICAgICAgIkVGTCIsCiAg
ICAgICAgICAgICAiR1RLLiozMiIsCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v
bi9uZXQvYnVpbGRib3QvYnVpbGRib3RfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv
U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxkYm90X3VuaXR0ZXN0LnB5
CShyZXZpc2lvbiA4MjI5OSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9i
dWlsZGJvdC9idWlsZGJvdF91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjYxLDYgKzI2
MSw3IEBAIGNsYXNzIEJ1aWxkQm90VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAg
ICAiTGVvcGFyZC4qIiwKICAgICAgICAgICAgICJXaW5kb3dzLipCdWlsZCIsCiAgICAgICAgICAg
ICAiV2luZG93cy4qXChUZXN0IiwKKyAgICAgICAgICAgICJXaW5DYWlybyIsCiAgICAgICAgICAg
ICAiV2luQ0UiLAogICAgICAgICAgICAgIkVGTCIsCiAgICAgICAgICAgICAiR1RLLiozMiIsCkBA
IC0yOTEsNiArMjkyLDcgQEAgY2xhc3MgQnVpbGRCb3RUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK
ICAgICAgICAgICAgIHsnbmFtZSc6IHUnQ2hyb21pdW0gV2luIFJlbGVhc2UnLCB9LAogICAgICAg
ICAgICAgeyduYW1lJzogdSdDaHJvbWl1bSBNYWMgUmVsZWFzZScsIH0sCiAgICAgICAgICAgICB7
J25hbWUnOiB1J0Nocm9taXVtIExpbnV4IFJlbGVhc2UnLCB9LAorICAgICAgICAgICAgeyduYW1l
JzogdSdXaW5DYWlybyBEZWJ1ZyAoQnVpbGQpJywgfSwKICAgICAgICAgICAgIHsnbmFtZSc6IHUn
V2luQ0UgUmVsZWFzZSAoQnVpbGQpJywgfSwKICAgICAgICAgICAgIHsnbmFtZSc6IHUnRUZMIExp
bnV4IFJlbGVhc2UgKEJ1aWxkKScsIH0sCiAgICAgICAgIF0K
</data>
<flag name="review"
          id="79827"
          type_id="1"
          status="+"
          setter="aroben"
    />
          </attachment>
      

    </bug>

</bugzilla>