57366 2011-03-29 11:22:29 -0700 CoreIPC::decodeResourceError() leaks a CFDataRef 2011-03-29 13:11:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm oldest_to_newest 375569 0 jeffm 2011-03-29 11:22:29 -0700 CoreIPC::decodeResourceError() leaks a CFDataRef 375574 1 87374 jeffm 2011-03-29 11:26:46 -0700 Created attachment 87374 Patch 375578 2 87374 darin 2011-03-29 11:29:35 -0700 Comment on attachment 87374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87374&action=review > Source/WebKit2/Shared/win/WebCoreArgumentCodersWin.cpp:149 > - resourceError = WebCore::ResourceError(domain, errorCode, failingURL, localizedDescription, WebCore::copyCertificateToData(certificateChain.first()).leakRef()); > + RetainPtr<CFDataRef> certData = WebCore::copyCertificateToData(certificateChain.first()); > + resourceError = WebCore::ResourceError(domain, errorCode, failingURL, localizedDescription, certData.get()); You could have fixed this by just changing leakRef to get, without adding a local variable. I would have liked that better. 375603 3 jeffm 2011-03-29 11:46:16 -0700 (In reply to comment #2) > (From update of attachment 87374 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87374&action=review > > > Source/WebKit2/Shared/win/WebCoreArgumentCodersWin.cpp:149 > > - resourceError = WebCore::ResourceError(domain, errorCode, failingURL, localizedDescription, WebCore::copyCertificateToData(certificateChain.first()).leakRef()); > > + RetainPtr<CFDataRef> certData = WebCore::copyCertificateToData(certificateChain.first()); > > + resourceError = WebCore::ResourceError(domain, errorCode, failingURL, localizedDescription, certData.get()); > > You could have fixed this by just changing leakRef to get, without adding a local variable. I would have liked that better. OK, I will do that instead. 375692 4 jeffm 2011-03-29 13:11:00 -0700 Committed r82306: <http://trac.webkit.org/changeset/82306> 87374 2011-03-29 11:26:46 -0700 2011-03-29 11:29:35 -0700 Patch bug-57366-20110329112645.patch text/plain 1617 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyMjg5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMjkgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENvcmVJUEM6OmRlY29kZVJlc291cmNlRXJyb3IoKSBsZWFrcyBhIENG RGF0YVJlZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTczNjYKKworICAgICAgICAqIFNoYXJlZC93aW4vV2ViQ29yZUFyZ3VtZW50Q29kZXJzV2luLmNw cDoKKyAgICAgICAgKENvcmVJUEM6OmRlY29kZVJlc291cmNlRXJyb3IpOiBEb24ndCBsZWFrIHRo ZSByZXN1bHQgb2YgV2ViQ29yZTo6Y29weUNlcnRpZmljYXRlVG9EYXRhKCksIHNpbmNlIHRoZSBS ZXNvdXJjZUVycm9yIHdpbGwgcmV0YWluIGl0LgorCiAyMDExLTAzLTI4ICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRl eDogU291cmNlL1dlYktpdDIvU2hhcmVkL3dpbi9XZWJDb3JlQXJndW1lbnRDb2RlcnNXaW4uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC93aW4vV2ViQ29yZUFyZ3VtZW50 Q29kZXJzV2luLmNwcAkocmV2aXNpb24gODIyNDcpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQv d2luL1dlYkNvcmVBcmd1bWVudENvZGVyc1dpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NSw3 ICsxNDUsOCBAQCBib29sIGRlY29kZVJlc291cmNlRXJyb3IoQXJndW1lbnREZWNvZGVyCiAgICAg Y29uc3QgVmVjdG9yPFBDQ0VSVF9DT05URVhUPiBjZXJ0aWZpY2F0ZUNoYWluID0gY2VydGlmaWNh dGUuY2VydGlmaWNhdGVDaGFpbigpOwogICAgIGlmICghY2VydGlmaWNhdGVDaGFpbi5pc0VtcHR5 KCkpIHsKICAgICAgICAgQVNTRVJUKGNlcnRpZmljYXRlQ2hhaW4uc2l6ZSgpID09IDEpOwotICAg ICAgICByZXNvdXJjZUVycm9yID0gV2ViQ29yZTo6UmVzb3VyY2VFcnJvcihkb21haW4sIGVycm9y Q29kZSwgZmFpbGluZ1VSTCwgbG9jYWxpemVkRGVzY3JpcHRpb24sIFdlYkNvcmU6OmNvcHlDZXJ0 aWZpY2F0ZVRvRGF0YShjZXJ0aWZpY2F0ZUNoYWluLmZpcnN0KCkpLmxlYWtSZWYoKSk7CisgICAg ICAgIFJldGFpblB0cjxDRkRhdGFSZWY+IGNlcnREYXRhID0gV2ViQ29yZTo6Y29weUNlcnRpZmlj YXRlVG9EYXRhKGNlcnRpZmljYXRlQ2hhaW4uZmlyc3QoKSk7CisgICAgICAgIHJlc291cmNlRXJy b3IgPSBXZWJDb3JlOjpSZXNvdXJjZUVycm9yKGRvbWFpbiwgZXJyb3JDb2RlLCBmYWlsaW5nVVJM LCBsb2NhbGl6ZWREZXNjcmlwdGlvbiwgY2VydERhdGEuZ2V0KCkpOwogICAgICAgICByZXR1cm4g dHJ1ZTsKICAgICB9CiAjZW5kaWYK