57356 2011-03-29 10:21:55 -0700 test_runner2.py can crash due to undefined variable 2011-03-29 15:00:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue dpranke eric oldest_to_newest 375470 0 abarth 2011-03-29 10:21:55 -0700 test_runner2.py can crash due to undefined variable 375473 1 87356 abarth 2011-03-29 10:23:27 -0700 Created attachment 87356 Patch 375474 2 abarth 2011-03-29 10:24:10 -0700 Stack from http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/5027/steps/webkit_tests/logs/stdio : 2011-03-29 10:12:30,431 2611 test_runner2.py:189 INFO Exception raised, exiting Traceback (most recent call last): File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 439, in <module> sys.exit(main()) File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 434, in main return run(port_obj, options, args) File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 120, in run num_unexpected_results = runner.run(result_summary) File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner.py", line 664, in run self._run_tests(self._test_files_list, result_summary)) File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py", line 164, in _run_tests manager_connection.run_message_loop(delay_secs=1.0) File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker2.py", line 192, in run_message_loop self._broker.run_message_loop(self._run_topic, self._client, delay_secs) File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker2.py", line 128, in run_message_loop self._run_loop(topic_name, client, block=True, delay_secs=delay_secs) File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker2.py", line 142, in _run_loop self._dispatch_message(msg, client) File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker2.py", line 151, in _dispatch_message message_handler(message.src, *optargs) File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py", line 227, in handle_finished_test _log.error("%s unwedged", w.name) NameError: global name 'w' is not defined 375563 3 dpranke 2011-03-29 11:19:37 -0700 The patch looks good; I guess it's a testament to the improvements in the threading code that we hadn't triggered this before. It is actually possible to test this through some careful manipulation of the thread scheduling; there are some tests in manager_worker_broker_unittest that are close to what you would need. I'll see if I can write a test for it just to get the coverage. Thanks for fixing this! 375782 4 87356 commit-queue 2011-03-29 15:00:48 -0700 Comment on attachment 87356 Patch Clearing flags on attachment: 87356 Committed r82329: <http://trac.webkit.org/changeset/82329> 375784 5 commit-queue 2011-03-29 15:00:53 -0700 All reviewed patches have been landed. Closing bug. 87356 2011-03-29 10:23:27 -0700 2011-03-29 15:00:48 -0700 Patch bug-57356-20110329102324.patch text/plain 1415 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgyMjcyKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDMtMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB0ZXN0X3J1bm5l cjIucHkgY2FuIGNyYXNoIGR1ZSB0byB1bmRlZmluZWQgdmFyaWFibGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MzU2CisKKyAgICAgICAgUmVwbGFj ZSByZWZlcmVuY2UgdG8gdW5kZWZpbmVkIHZhcmlhYmxlIHdpdGggYSB2YXJpYWJsZSB0aGF0J3Mg YWN0dWFsbHkKKyAgICAgICAgZGVmaW5lZC4gIEFGQUlDVCwgdGhlcmUncyBubyB3YXkgdG8gdGVz dCB0aGlzIGNvZGUuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9s YXlvdXRfcGFja2FnZS90ZXN0X3J1bm5lcjIucHk6CisKIDIwMTEtMDMtMjkgIFBoaWxpcHBlIE5v cm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5 IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcnVubmVyMi5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0X3J1 bm5lcjIucHkJKHJldmlzaW9uIDgyMjU3KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvdGVzdF9ydW5uZXIyLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0yMjQsNyArMjI0LDcgQEAgY2xhc3MgVGVzdFJ1bm5lcjIodGVzdF9ydW5uZXIuVGVzdFJ1bm5l cgogCiAgICAgICAgIGlmIHdvcmtlcl9zdGF0ZS53ZWRnZWQ6CiAgICAgICAgICAgICAjIFRoaXMg c2hvdWxkbid0IGhhcHBlbiBpZiB3ZSBoYXZlIG91ciB0aW1lb3V0cyB0dW5lZCBwcm9wZXJseS4K LSAgICAgICAgICAgIF9sb2cuZXJyb3IoIiVzIHVud2VkZ2VkIiwgdy5uYW1lKQorICAgICAgICAg ICAgX2xvZy5lcnJvcigiJXMgdW53ZWRnZWQiLCBzb3VyY2UpCiAKICAgICAgICAgc2VsZi5fYWxs X3Jlc3VsdHMuYXBwZW5kKHJlc3VsdCkKICAgICAgICAgc2VsZi5fdXBkYXRlX3N1bW1hcnlfd2l0 aF9yZXN1bHQoc2VsZi5fY3VycmVudF9yZXN1bHRfc3VtbWFyeSwgcmVzdWx0KQo=