57334 2011-03-29 07:02:18 -0700 DumpRenderTree on Windows doesn't block access to external URLs, but should (makes some tests fail) 2011-06-24 14:12:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 NEW http://build.webkit.org/results/Windows%207%20Release%20%28Tests%29/r82237%20(10912)/http/tests/uri/username-with-no-hostname-pretty-diff.html InRadar, LayoutTestFailure, PlatformOnly P2 Normal --- 1 aroben webkit-unassigned jberlin mjs zimmermann oldest_to_newest 375270 0 aroben 2011-03-29 07:02:18 -0700 http/tests/uri/username-with-no-hostname.html has been failing on Windows since r82189 when its expected results were updated. See the URL for the failure diff. 375356 1 aroben 2011-03-29 08:15:24 -0700 The test is failing because DRT/win's ResourceLoadDelegate doesn't have the "block access to external URLs" logic that DRT/mac has. That logic was added to DRT/mac in r33491. 375357 2 87335 aroben 2011-03-29 08:17:03 -0700 Created attachment 87335 Patch to add "block access to external URLs" logic to DRT/win This patch gives DRT/win the same smarts as DRT/mac. However, this causes the test to fail in a different way: the "Blocked access to external URL" message is printed twice (once for the real load, and once for a preload). I don't know why this doesn't happen on Mac. 375366 3 aroben 2011-03-29 08:27:43 -0700 I checked in new expected results for Windows in r82255. This bug can be used to track the task of adding the URL-blocking logic to DRT. 375367 4 aroben 2011-03-29 08:28:12 -0700 <rdar://problem/9202302> 375407 5 jberlin 2011-03-29 09:11:59 -0700 I think the new expected results for Windows broke WK2 Windows tests: http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r82253%20(4654)/results.html http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r82255%20(4655)/results.html 375519 6 aroben 2011-03-29 10:47:39 -0700 You're right! I'll take care of it. 375676 7 aroben 2011-03-29 12:44:00 -0700 Added win-wk2 passing results in r82301. 376582 8 aroben 2011-03-30 12:20:06 -0700 (In reply to comment #2) > Created an attachment (id=87335) [details] > Patch to add "block access to external URLs" logic to DRT/win > > This patch gives DRT/win the same smarts as DRT/mac. However, this causes the test to fail in a different way: the "Blocked access to external URL" message is printed twice (once for the real load, and once for a preload). I don't know why this doesn't happen on Mac. Ooh, it happened once on Mac! http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r82463%20(10201)/http/tests/uri/username-with-no-hostname-pretty-diff.html 384842 9 aroben 2011-04-13 06:46:45 -0700 *** Bug 58421 has been marked as a duplicate of this bug. *** 386740 10 jberlin 2011-04-15 10:46:37 -0700 Added more win-wk2 passing results in http://trac.webkit.org/changeset/83989 427132 11 jberlin 2011-06-24 14:12:07 -0700 Removing the MakingBotsRed keyword as this isn't actively making any bots red. 87335 2011-03-29 08:17:03 -0700 2011-03-29 08:17:03 -0700 Patch to add "block access to external URLs" logic to DRT/win patch.txt text/plain 2467 aroben ZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9SZXNvdXJjZUxvYWREZWxlZ2F0 ZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vUmVzb3VyY2VMb2FkRGVsZWdhdGUuY3Bw CmluZGV4IDA5YjA3ZDYuLmFkZjRjOGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L3dpbi9SZXNvdXJjZUxvYWREZWxlZ2F0ZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv d2luL1Jlc291cmNlTG9hZERlbGVnYXRlLmNwcApAQCAtMzUsNiArMzUsNyBAQAogI2luY2x1ZGUg PGNvbXV0aWwuaD4KICNpbmNsdWRlIDxzc3RyZWFtPgogI2luY2x1ZGUgPHRjaGFyLmg+CisjaW5j bHVkZSA8d3RmL1JldGFpblB0ci5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIAogdXNpbmcg bmFtZXNwYWNlIHN0ZDsKQEAgLTIzNyw2ICsyMzgsMzYgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxM VFlQRSBSZXNvdXJjZUxvYWREZWxlZ2F0ZTo6cmVtb3ZlSWRlbnRpZmllckZvclJlcXVlc3QoCiAg ICAgcmV0dXJuIFNfT0s7CiB9CiAKK3N0YXRpYyBSZXRhaW5QdHI8Q0ZVUkxSZWY+IHRvQ0ZVUkwo QlNUUiB1cmwpCit7CisgICAgcmV0dXJuIFJldGFpblB0cjxDRlVSTFJlZj4oQWRvcHRDRiwgQ0ZV UkxDcmVhdGVXaXRoQnl0ZXMoMCwgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBVSW50OCo+KHVybCks IDo6U3lzU3RyaW5nTGVuKHVybCkgKiBzaXplb2YodXJsWzBdKSwga0NGU3RyaW5nRW5jb2RpbmdV VEYxNiwgMCkpOworfQorCitzdGF0aWMgYm9vbCBjYXNlSW5zZW5zaXRpdmVFcXVhbChDRlN0cmlu Z1JlZiBhLCBDRlN0cmluZ1JlZiBiKQoreworICAgIHJldHVybiBDRlN0cmluZ0NvbXBhcmUoYSwg Yiwga0NGQ29tcGFyZUNhc2VJbnNlbnNpdGl2ZSkgPT0ga0NGQ29tcGFyZUVxdWFsVG87Cit9CisK K3N0YXRpYyBib29sIGlzRXh0ZXJuYWxVUkwoQlNUUiB1cmxCU1RSKQoreworICAgIFJldGFpblB0 cjxDRlVSTFJlZj4gdXJsID0gdG9DRlVSTCh1cmxCU1RSKTsKKyAgICBpZiAoIXVybCkKKyAgICAg ICAgcmV0dXJuIGZhbHNlOworICAgIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gc2NoZW1lKEFkb3B0 Q0YsIENGVVJMQ29weVNjaGVtZSh1cmwuZ2V0KCkpKTsKKyAgICBpZiAoIXNjaGVtZSkKKyAgICAg ICAgcmV0dXJuIGZhbHNlOworICAgIGlmICghY2FzZUluc2Vuc2l0aXZlRXF1YWwoc2NoZW1lLmdl dCgpLCBDRlNUUigiaHR0cCIpKSAmJiAhY2FzZUluc2Vuc2l0aXZlRXF1YWwoc2NoZW1lLmdldCgp LCBDRlNUUigiaHR0cHMiKSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBSZXRhaW5QdHI8 Q0ZTdHJpbmdSZWY+IGhvc3QoQWRvcHRDRiwgQ0ZVUkxDb3B5SG9zdE5hbWUodXJsLmdldCgpKSk7 CisgICAgaWYgKCFob3N0KQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgaWYgKENGRXF1YWwo aG9zdC5nZXQoKSwgQ0ZTVFIoIjEyNy4wLjAuMSIpKQorICAgICAgICB8fCBDRkVxdWFsKGhvc3Qu Z2V0KCksIENGU1RSKCIyNTUuMjU1LjI1NS4yNTUiKSkgLy8gVXNlZCBpbiBzb21lIHRlc3RzIHRo YXQgZXhwZWN0IHRvIGdldCBiYWNrIGFuIGVycm9yLgorICAgICAgICB8fCBjYXNlSW5zZW5zaXRp dmVFcXVhbChob3N0LmdldCgpLCBDRlNUUigibG9jYWxob3N0IikpKQorICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgcmV0dXJuIHRydWU7Cit9CisKIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUg UmVzb3VyY2VMb2FkRGVsZWdhdGU6OndpbGxTZW5kUmVxdWVzdCggCiAgICAgLyogW2luXSAqLyBJ V2ViVmlldyogd2ViVmlldywKICAgICAvKiBbaW5dICovIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmll ciwKQEAgLTI3MCw2ICszMDEsMTggQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBSZXNvdXJj ZUxvYWREZWxlZ2F0ZTo6d2lsbFNlbmRSZXF1ZXN0KAogICAgICAgICByZXR1cm4gU19PSzsKICAg ICB9CiAKKyAgICBCU1RSIHVybDsKKyAgICBpZiAoU1VDQ0VFREVEKHJlcXVlc3QtPlVSTCgmdXJs KSkpIHsKKyAgICAgICAgYm9vbCBpc0V4dGVybmFsID0gaXNFeHRlcm5hbFVSTCh1cmwpOworICAg ICAgICBpZiAoaXNFeHRlcm5hbCkKKyAgICAgICAgICAgIHByaW50ZigiQmxvY2tlZCBhY2Nlc3Mg dG8gZXh0ZXJuYWwgVVJMICVzXG4iLCB0b1VURjgodXJsKS5jX3N0cigpKTsKKyAgICAgICAgOjpT eXNGcmVlU3RyaW5nKHVybCk7CisgICAgICAgIGlmIChpc0V4dGVybmFsKSB7CisgICAgICAgICAg ICAqbmV3UmVxdWVzdCA9IDA7CisgICAgICAgICAgICByZXR1cm4gU19PSzsKKyAgICAgICAgfQor ICAgIH0KKwogICAgIElXZWJNdXRhYmxlVVJMUmVxdWVzdCogcmVxdWVzdENvcHkgPSAwOwogICAg IHJlcXVlc3QtPm11dGFibGVDb3B5KCZyZXF1ZXN0Q29weSk7CiAgICAgY29uc3Qgc2V0PHN0cmlu Zz4mIGNsZWFySGVhZGVycyA9IGdMYXlvdXRUZXN0Q29udHJvbGxlci0+d2lsbFNlbmRSZXF1ZXN0 Q2xlYXJIZWFkZXJzKCk7Cg==