57316 2011-03-29 02:17:51 -0700 Web Inspector: Fixing live edits tests on chromium. 2011-03-29 07:30:36 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey webkit-unassigned apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 375131 0 aandrey 2011-03-29 02:17:51 -0700 Original patch broke live edit tests. See: - https://bugs.webkit.org/show_bug.cgi?id=57002 - https://bugs.webkit.org/show_bug.cgi?id=57245 - rollout 375132 1 87284 aandrey 2011-03-29 02:20:34 -0700 Created attachment 87284 Patch 375224 2 87284 podivilov 2011-03-29 05:58:27 -0700 Comment on attachment 87284 Patch Clearing flags on attachment: 87284 Committed r82237: <http://trac.webkit.org/changeset/82237> 375225 3 podivilov 2011-03-29 05:58:36 -0700 All reviewed patches have been landed. Closing bug. 375303 4 commit-queue 2011-03-29 07:30:36 -0700 The commit-queue encountered the following flaky tests while processing attachment 87284: http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 87284 2011-03-29 02:20:34 -0700 2011-03-29 05:58:27 -0700 Patch bug-57316-20110329132030.patch text/plain 5391 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogODIyMDcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxMTVmZDdkYTRmNGY3MGVhMGU0MjRh ZGNiYmUyM2U5ZjUxZjU4ZjY4Li40NDAxYmM4OWYwYzNiOWM1ZDU2ODI1YjgxZWUyNjgyNTI1ZDM3 ZGRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMtMjkgIEFuZHJleSBBZGFpa2luICA8 YWFuZHJleUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEZpeGluZyBsaXZlIGVkaXRzIHRlc3RzIG9uIGNo cm9taXVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTczMTYKKworICAgICAgICAqIGluc3BlY3Rvci9kZWJ1Z2dlci9saXZlLWVkaXQuaHRtbDoKKwog MjAxMS0wMy0yOSAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rv ci9kZWJ1Z2dlci9saXZlLWVkaXQuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dl ci9saXZlLWVkaXQuaHRtbAppbmRleCA0NzBlYjViNmYwMWFiMDRjYWQ3MmM1ZTI5ODQzYmJkYzU0 ZGJmMmQ2Li42Y2QyYjQ3Njg5NzBkMzFmMjRlODdjN2NmOWMyODc1ODdiMTljYjdhIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvbGl2ZS1lZGl0Lmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2xpdmUtZWRpdC5odG1sCkBAIC0xOSw2ICsx OSw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgewogICAgICAgICAgICAgICAgIElu c3BlY3RvclRlc3QuYWRkU25pZmZlcihXZWJJbnNwZWN0b3IuZGVidWdnZXJNb2RlbCwgIl9kaWRF ZGl0U2NyaXB0U291cmNlIiwgZGlkRWRpdFNjcmlwdFNvdXJjZSk7CiAgICAgICAgICAgICAgICAg c291cmNlRnJhbWUuX3RleHRWaWV3ZXIucmVhZE9ubHkgPSBmYWxzZTsKKyAgICAgICAgICAgICAg ICBzb3VyY2VGcmFtZS5fc3RhcnRFZGl0aW5nKCk7CiAgICAgICAgICAgICAgICAgdmFyIG5ld1Rl eHQgPSBzb3VyY2VGcmFtZS5fdGV4dE1vZGVsLnRleHQucmVwbGFjZSgicmV0dXJuIDA7IiwgInJl dHVybiBcImxpdmUtZWRpdGVkIHN0cmluZ1wiOyIpOwogICAgICAgICAgICAgICAgIHNvdXJjZUZy YW1lLl90ZXh0TW9kZWwuc2V0VGV4dChudWxsLCBuZXdUZXh0KTsKICAgICAgICAgICAgICAgICBz b3VyY2VGcmFtZS5faGFuZGxlU2F2ZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDkzYjljYzViNjU1ZTc3MmFj MmY5NGM1NWQ0Mjc1ODBkNzQ3OWUwYWYuLmMyMDRmOGU4MjlmN2M0N2NmYmI4ZDg4NzcyMWMxNjI4 M2MxYjE0NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wMy0yOSAgQW5kcmV5 IEFkYWlraW4gIDxhYW5kcmV5QGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4aW5nIGxpdmUgZWRpdHMg dGVzdHMgb24gY2hyb21pdW0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01NzMxNgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRz UGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWVEZWxlZ2F0ZUZvclNj cmlwdHNQYW5lbC5wcm90b3R5cGUuZWRpdFNjcmlwdFNvdXJjZSk6CisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3Vy Y2VGcmFtZS5wcm90b3R5cGUuX2hhbmRsZVNhdmUuZGlkRWRpdFNjcmlwdFNvdXJjZSk6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlLl9oYW5kbGVTYXZlKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZURlbGVnYXRlLnByb3RvdHlwZS5lZGl0U2Ny aXB0U291cmNlKToKKwogMjAxMS0wMy0yOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjgyMTk4Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFu ZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5q cwppbmRleCA1NTdmNDA3YjgwOGEzNjNhYzE2OGE3ZDdhZjg0N2Q3ZmFkZDk4YmFlLi5hMWY1ZWEz ZGRmNmFiZmY2YTUyNmRlOTg0Y2RhYzkxYjc4Y2RmN2ZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwpAQCAtMTA2NiwxNCArMTA2 Niw3IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZURlbGVnYXRlRm9yU2NyaXB0c1BhbmVsLnBy b3RvdHlwZSA9IHsKIAogICAgIGVkaXRTY3JpcHRTb3VyY2U6IGZ1bmN0aW9uKHRleHQsIGNhbGxi YWNrKQogICAgIHsKLSAgICAgICAgZnVuY3Rpb24gZGlkRWRpdFNjcmlwdFNvdXJjZShzdWNjZXNz LCBuZXdCb2R5T3JFcnJvck1lc3NhZ2UpCi0gICAgICAgIHsKLSAgICAgICAgICAgIGlmICghc3Vj Y2VzcykgewotICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5sb2cobmV3Qm9keU9yRXJyb3JN ZXNzYWdlLCBXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UuTWVzc2FnZUxldmVsLldhcm5pbmcp OwotICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgIH0KLSAgICAgICAgfQotICAg ICAgICB0aGlzLl9tb2RlbC5lZGl0U2NyaXB0U291cmNlKHRoaXMuX3NvdXJjZUZpbGVJZCwgdGV4 dCwgZGlkRWRpdFNjcmlwdFNvdXJjZS5iaW5kKHRoaXMpKTsKKyAgICAgICAgdGhpcy5fbW9kZWwu ZWRpdFNjcmlwdFNvdXJjZSh0aGlzLl9zb3VyY2VGaWxlSWQsIHRleHQsIGNhbGxiYWNrKTsKICAg ICB9LAogCiAgICAgc2V0U2NyaXB0U291cmNlSXNCZWluZ0VkaXRlZDogZnVuY3Rpb24oaW5FZGl0 TW9kZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291 cmNlRnJhbWUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZy YW1lLmpzCmluZGV4IGY1NTBjZWJhYjBiMDdlNTJiNjM3N2FhMmI2NjA0NWVmOGU2ZDJhMDEuLjMw OWUwMzMwNDU4YTRkNWEyZGNmNWY0N2MxMTA1OWY1NDUyOTY5OTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwpAQCAtNzkyLDEyICs3 OTIsMzEgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZSA9IHsKICAgICAgICAg aWYgKHRoaXMuX3RleHRWaWV3ZXIucmVhZE9ubHkgfHwgIXRoaXMuX2RlbGVnYXRlLmNhbkVkaXRT Y3JpcHRTb3VyY2UoKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgICAgICBpZiAo dGhpcy5fb3JpZ2luYWxUZXh0TW9kZWxDb250ZW50ID09PSB1bmRlZmluZWQpIHsKKyAgICAgICAg ICAgIC8vIE5vIGVkaXRpbmcgd2FzIGFjdHVhbGx5IGRvbmUuCisgICAgICAgICAgICB0aGlzLl90 ZXh0Vmlld2VyLnJlYWRPbmx5ID0gdHJ1ZTsKKyAgICAgICAgICAgIHRoaXMuX2RlbGVnYXRlLnNl dFNjcmlwdFNvdXJjZUlzQmVpbmdFZGl0ZWQoZmFsc2UpOworICAgICAgICAgICAgcmV0dXJuIHRy dWU7CisgICAgICAgIH0KKworICAgICAgICB2YXIgb3JpZ2luYWxUZXh0TW9kZWxDb250ZW50ID0g dGhpcy5fb3JpZ2luYWxUZXh0TW9kZWxDb250ZW50OwogICAgICAgICB2YXIgbmV3U291cmNlID0g dGhpcy5fdGV4dE1vZGVsLnRleHQ7Ci0gICAgICAgIGlmICh0aGlzLl9vcmlnaW5hbFRleHRNb2Rl bENvbnRlbnQgIT09IG5ld1NvdXJjZSkKLSAgICAgICAgICAgIHRoaXMuX2RlbGVnYXRlLmVkaXRT Y3JpcHRTb3VyY2UobmV3U291cmNlKTsKKwogICAgICAgICBkZWxldGUgdGhpcy5fb3JpZ2luYWxU ZXh0TW9kZWxDb250ZW50OwogICAgICAgICB0aGlzLl90ZXh0Vmlld2VyLnJlYWRPbmx5ID0gdHJ1 ZTsKICAgICAgICAgdGhpcy5fZGVsZWdhdGUuc2V0U2NyaXB0U291cmNlSXNCZWluZ0VkaXRlZChm YWxzZSk7CisKKyAgICAgICAgZnVuY3Rpb24gZGlkRWRpdFNjcmlwdFNvdXJjZShzdWNjZXNzLCBu ZXdCb2R5T3JFcnJvck1lc3NhZ2UpCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICghc3VjY2Vz cyAmJiB0aGlzLl9vcmlnaW5hbFRleHRNb2RlbENvbnRlbnQgPT09IHVuZGVmaW5lZCAmJiB0aGlz Ll90ZXh0TW9kZWwudGV4dCA9PT0gbmV3U291cmNlKSB7CisgICAgICAgICAgICAgICAgdGhpcy5f b3JpZ2luYWxUZXh0TW9kZWxDb250ZW50ID0gb3JpZ2luYWxUZXh0TW9kZWxDb250ZW50OworICAg ICAgICAgICAgICAgIHRoaXMuX3RleHRWaWV3ZXIucmVhZE9ubHkgPSBmYWxzZTsKKyAgICAgICAg ICAgICAgICB0aGlzLl9kZWxlZ2F0ZS5zZXRTY3JpcHRTb3VyY2VJc0JlaW5nRWRpdGVkKHRydWUp OworICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5sb2cobmV3Qm9keU9yRXJyb3JNZXNzYWdl LCBXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UuTWVzc2FnZUxldmVsLkVycm9yKTsKKyAgICAg ICAgICAgICAgICBXZWJJbnNwZWN0b3Iuc2hvd0NvbnNvbGUoKTsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgfQorICAgICAgICB0aGlzLl9kZWxlZ2F0ZS5lZGl0U2NyaXB0U291cmNlKG5ld1NvdXJj ZSwgZGlkRWRpdFNjcmlwdFNvdXJjZS5iaW5kKHRoaXMpKTsKICAgICAgICAgcmV0dXJuIHRydWU7 CiAgICAgfSwKIApAQCAtODc4LDcgKzg5Nyw3IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZURl bGVnYXRlLnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0sCiAKLSAg ICBlZGl0U2NyaXB0U291cmNlOiBmdW5jdGlvbih0ZXh0KQorICAgIGVkaXRTY3JpcHRTb3VyY2U6 IGZ1bmN0aW9uKHRleHQsIGNhbGxiYWNrKQogICAgIHsKICAgICAgICAgLy8gU2hvdWxkIGJlIGlt cGxlbWVudGVkIGJ5IHN1YmNsYXNzZXMuCiAgICAgfSwK