57304 2011-03-28 23:40:50 -0700 REGRESSION(r82198): Broke Chromium Win build. (Requested by dave_levin on #webkit). 2011-03-28 23:59:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 54406 1 webkit.review.bot webkit.review.bot commit-queue levin oldest_to_newest 375060 0 webkit.review.bot 2011-03-28 23:40:50 -0700 http://trac.webkit.org/changeset/82198 broke the build: Broke Chromium Win build. (Requested by dave_levin on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 375061 1 87268 webkit.review.bot 2011-03-28 23:41:12 -0700 Created attachment 87268 ROLLOUT of r82198 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 375072 2 87268 commit-queue 2011-03-28 23:59:42 -0700 Comment on attachment 87268 ROLLOUT of r82198 Clearing flags on attachment: 87268 Committed r82202: <http://trac.webkit.org/changeset/82202> 375073 3 commit-queue 2011-03-28 23:59:47 -0700 All reviewed patches have been landed. Closing bug. 87268 2011-03-28 23:41:12 -0700 2011-03-28 23:59:42 -0700 ROLLOUT of r82198 bug-57304-20110329063857.patch text/plain 3008 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogODIxOTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzOWI4MmZmMzkyZWFmMGYw MzRjMzg4MDAyMTkyMzE2ZjJkZDU4Mjc3Li5lNDZiYzUzNGIzMTc5NWY0ZmM0NGI3YTA4ZTE2ZTlh YTBjYmRmNGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMjggIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHI4MjE5OC4KKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9j aGFuZ2VzZXQvODIxOTgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU3MzA0CisKKyAgICAgICAgQnJva2UgQ2hyb21pdW0gV2luIGJ1aWxkLiAoUmVxdWVz dGVkIGJ5IGRhdmVfbGV2aW4gb24KKyAgICAgICAgI3dlYmtpdCkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9pbWFnZS1kZWNvZGVycy9wbmcvUE5HSW1hZ2VEZWNvZGVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlBOR0ltYWdlRGVjb2Rlcjo6aGVhZGVyQXZhaWxhYmxlKToKKyAgICAgICAgKFdlYkNv cmU6OlBOR0ltYWdlRGVjb2Rlcjo6cm93QXZhaWxhYmxlKToKKwogMjAxMS0wMy0yOCAgS3dhbmcg WXVsIFNlbyAgPHNreXVsQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJl bmphbWluIFBvdWxhaW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFn ZS1kZWNvZGVycy9wbmcvUE5HSW1hZ2VEZWNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2ltYWdlLWRlY29kZXJzL3BuZy9QTkdJbWFnZURlY29kZXIuY3BwCmluZGV4IDg0MTlhOTcy M2MwZjYxM2VjYTg4NmRmM2YwZDNmMGE2ODY5ODhlZWYuLjhlZGZlMzZjZWRlOGVlMGRhNzllOTY4 NjQwNmZmMmY2ZTBjOGJmYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lt YWdlLWRlY29kZXJzL3BuZy9QTkdJbWFnZURlY29kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3BuZy9QTkdJbWFnZURlY29kZXIuY3BwCkBAIC0yNDEs MTEgKzI0MSwxMSBAQCB2b2lkIFBOR0ltYWdlRGVjb2Rlcjo6aGVhZGVyQXZhaWxhYmxlKCkKIHsK ICAgICBwbmdfc3RydWN0cCBwbmcgPSBtX3JlYWRlci0+cG5nUHRyKCk7CiAgICAgcG5nX2luZm9w IGluZm8gPSBtX3JlYWRlci0+aW5mb1B0cigpOwotICAgIHBuZ191aW50XzMyIHdpZHRoID0gcG5n X2dldF9pbWFnZV93aWR0aChwbmcsIGluZm8pOwotICAgIHBuZ191aW50XzMyIGhlaWdodCA9IHBu Z19nZXRfaW1hZ2VfaGVpZ2h0KHBuZywgaW5mbyk7CisgICAgcG5nX3VpbnRfMzIgd2lkdGggPSBw bmctPndpZHRoOworICAgIHBuZ191aW50XzMyIGhlaWdodCA9IHBuZy0+aGVpZ2h0OwogICAgIAog ICAgIC8vIFByb3RlY3QgYWdhaW5zdCBsYXJnZSBpbWFnZXMuCi0gICAgaWYgKHdpZHRoID4gY01h eFBOR1NpemUgfHwgaGVpZ2h0ID4gY01heFBOR1NpemUpIHsKKyAgICBpZiAocG5nLT53aWR0aCA+ IGNNYXhQTkdTaXplIHx8IHBuZy0+aGVpZ2h0ID4gY01heFBOR1NpemUpIHsKICAgICAgICAgbG9u Z2ptcChKTVBCVUYocG5nKSwgMSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0zMTgsMTQg KzMxOCw5IEBAIHZvaWQgUE5HSW1hZ2VEZWNvZGVyOjpoZWFkZXJBdmFpbGFibGUoKQogICAgIG1f cmVhZGVyLT5zZXRIYXNBbHBoYShjaGFubmVscyA9PSA0KTsKIAogICAgIGlmIChtX3JlYWRlci0+ ZGVjb2RpbmdTaXplT25seSgpKSB7Ci0gICAgICAgIC8vIElmIHdlIG9ubHkgbmVlZGVkIHRoZSBz aXplLCBoYWx0IHRoZSByZWFkZXIuCi0jaWYgZGVmaW5lZChQTkdfTElCUE5HX1ZFUl9NQUpPUikg JiYgZGVmaW5lZChQTkdfTElCUE5HX1ZFUl9NSU5PUikgJiYgKFBOR19MSUJQTkdfVkVSX01BSk9S ID4gMSB8fCAoUE5HX0xJQlBOR19WRVJfTUFKT1IgPT0gMSAmJiBQTkdfTElCUE5HX1ZFUl9NSU5P UiA+PSA1KSkKLSAgICAgICAgLy8gJzAnIGFyZ3VtZW50IHRvIHBuZ19wcm9jZXNzX2RhdGFfcGF1 c2UgbWVhbnM6IERvIG5vdCBjYWNoZSB1bnByb2Nlc3NlZCBkYXRhLgotICAgICAgICBtX3JlYWRl ci0+c2V0UmVhZE9mZnNldChtX3JlYWRlci0+Y3VycmVudEJ1ZmZlclNpemUoKSAtIHBuZ19wcm9j ZXNzX2RhdGFfcGF1c2UocG5nLCAwKSk7Ci0jZWxzZQorICAgICAgICAvLyBJZiB3ZSBvbmx5IG5l ZWRlZCB0aGUgc2l6ZSwgaGFsdCB0aGUgcmVhZGVyLiAgICAgCiAgICAgICAgIG1fcmVhZGVyLT5z ZXRSZWFkT2Zmc2V0KG1fcmVhZGVyLT5jdXJyZW50QnVmZmVyU2l6ZSgpIC0gcG5nLT5idWZmZXJf c2l6ZSk7CiAgICAgICAgIHBuZy0+YnVmZmVyX3NpemUgPSAwOwotI2VuZGlmCiAgICAgfQogfQog CkBAIC0zNDgsNyArMzQzLDcgQEAgdm9pZCBQTkdJbWFnZURlY29kZXI6OnJvd0F2YWlsYWJsZSh1 bnNpZ25lZCBjaGFyKiByb3dCdWZmZXIsIHVuc2lnbmVkIHJvd0luZGV4LAogICAgICAgICAvLyBG b3IgUE5HcywgdGhlIGZyYW1lIGFsd2F5cyBmaWxscyB0aGUgZW50aXJlIGltYWdlLgogICAgICAg ICBidWZmZXIuc2V0T3JpZ2luYWxGcmFtZVJlY3QoSW50UmVjdChJbnRQb2ludCgpLCBzaXplKCkp KTsKIAotICAgICAgICBpZiAocG5nX2dldF9pbnRlcmxhY2VfdHlwZShtX3JlYWRlci0+cG5nUHRy KCksIG1fcmVhZGVyLT5pbmZvUHRyKCkpICE9IFBOR19JTlRFUkxBQ0VfTk9ORSkKKyAgICAgICAg aWYgKG1fcmVhZGVyLT5wbmdQdHIoKS0+aW50ZXJsYWNlZCkKICAgICAgICAgICAgIG1fcmVhZGVy LT5jcmVhdGVJbnRlcmxhY2VCdWZmZXIoKG1fcmVhZGVyLT5oYXNBbHBoYSgpID8gNCA6IDMpICog c2l6ZSgpLndpZHRoKCkgKiBzaXplKCkuaGVpZ2h0KCkpOwogICAgIH0KIAo=