57301 2011-03-28 23:18:33 -0700 close before open WebSocket doesn't fire close event 2011-05-24 01:11:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ukai webkit-unassigned abarth ap eric oldest_to_newest 375039 0 ukai 2011-03-28 23:18:33 -0700 If it opens WebSocket and close in the same context (before receiving open event), it misses firing close event. var ws = new WebSocket(wsUrl); ws.onclose = function() { alert("closed"); } ws.close(); 375062 1 87269 ukai 2011-03-28 23:41:56 -0700 Created attachment 87269 Patch 408341 2 eric 2011-05-23 14:57:19 -0700 ap, abarth? It's been a month, this one looks like an easy review. 408348 3 87269 abarth 2011-05-23 14:59:43 -0700 Comment on attachment 87269 Patch Ok. 408361 4 ap 2011-05-23 15:09:26 -0700 Sorry, overlooked it. Looks good to me, too - thanks for fixing this! 408712 5 87269 ukai 2011-05-24 01:11:11 -0700 Comment on attachment 87269 Patch Clearing flags on attachment: 87269 Committed r87135: <http://trac.webkit.org/changeset/87135> 408713 6 ukai 2011-05-24 01:11:17 -0700 All reviewed patches have been landed. Closing bug. 87269 2011-03-28 23:41:56 -0700 2011-05-24 01:11:11 -0700 Patch bug-57301-20110329154154.patch text/plain 4423 ukai U3VidmVyc2lvbiBSZXZpc2lvbjogODIxOTQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0NjZiZGFlZGYwYjk3MTBiOTYwZWQz OGE2MTdiM2ZjMzVkOTgwMmJmLi42NWQ4ZmUyNTNhNzg1ZWQyNWJhZDNiM2FjYTgzMWFiMjQ3NTBi YzkxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMjggIEZ1bWl0b3NoaSBVa2FpICA8 dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgY2xvc2UgYmVmb3JlIG9wZW4gV2ViU29ja2V0IGRvZXNuJ3QgZmlyZSBjbG9z ZSBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU3MzAxCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9jbG9zZS1iZWZv cmUtb3Blbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvd2Vic29j a2V0L3Rlc3RzL2Nsb3NlLWJlZm9yZS1vcGVuLmh0bWw6IEFkZGVkLgorCiAyMDExLTAzLTI4ICBZ dXRhIEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQu IENsZWFuIHVwIENocm9taXVtIHRlc3QgZXhwZWN0YXRpb25zIGZvciBwbHVnaW5zL2VtYmVkLXBy ZWZlcnMtcGx1Z2lucy1mb3ItaW1hZ2VzLmh0bWwuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9jbG9zZS1iZWZvcmUtb3Blbi1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9jbG9zZS1iZWZvcmUtb3Bl bi1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2E1ZDkyZmE4Y2MxYzNhM2IwZTVlMjA3MWVkZTY0 MGE4MmFiYjU3YgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vi c29ja2V0L3Rlc3RzL2Nsb3NlLWJlZm9yZS1vcGVuLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDkg QEAKK1Rlc3QgaWYgV2ViIFNvY2tldCBmaXJlcyBjbG9zZSBldmVudCB3aGVuIFdlYlNvY2tldCBp cyBvcGVuZWQgYW5kIGNsb3NlZCBmb3JlIG9wZW4gZXZlbnQgaXMgcmVjZWl2ZWQuCisKK09uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFIi4KKworY2xvc2VkCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy93ZWJzb2NrZXQvdGVzdHMvY2xvc2UtYmVmb3JlLW9wZW4uaHRtbCBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2Nsb3NlLWJlZm9yZS1vcGVuLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uZTU3YjZmMGZjZTgxZmEzYTNjN2VhZmM2NDg2MTM1NTFiZjBjOGU3YgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2Nsb3NlLWJl Zm9yZS1vcGVuLmh0bWwKQEAgLTAsMCArMSwyOSBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICIt Ly9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVz aGVldCIgaHJlZj0iLi4vLi4vLi4vanMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3Mi PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpz Ij48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9qcy10ZXN0LXJlc291cmNlcy9qcy10 ZXN0LXBvc3QtZnVuY3Rpb24uanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2IGlk PSJkZXNjcmlwdGlvbiI+PC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQg dHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KK2Rlc2NyaXB0aW9uKCJUZXN0IGlmIFdlYiBTb2NrZXQg ZmlyZXMgY2xvc2UgZXZlbnQgd2hlbiBXZWJTb2NrZXQgaXMgb3BlbmVkIGFuZCBjbG9zZWQgZm9y ZSBvcGVuIGV2ZW50IGlzIHJlY2VpdmVkLiIpOworCitpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKwordmFy IHdzID0gbmV3IFdlYlNvY2tldCgid3M6Ly8xMjcuMC4wLjE6ODg4MC93ZWJzb2NrZXQvdGVzdHMv aGFuZ2luZy1oYW5kc2hha2UiKTsKK3dzLm9uY2xvc2UgPSBmdW5jdGlvbigpIHsKKyAgICBkZWJ1 ZygiY2xvc2VkIik7CisgICAgaXNTdWNjZXNzZnVsbHlQYXJzZWQoKTsKKyAgICBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3Rp ZnlEb25lKCk7Cit9OwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cit3cy5jbG9zZSgp OworPC9zY3JpcHQ+CisKKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjY2QxNWViODE3 ZWMwMjBmNjg4YzRiZTQzNDk4OTI0Yjg0ZDhjZDNkLi4xZWZlNTU4NWM3MmUxYzBlN2JkYWVmMjIz OWY4YmNlMDJlMzU2ZmE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMjgg IEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY2xvc2UgYmVmb3JlIG9wZW4gV2ViU29ja2V0 IGRvZXNuJ3QgZmlyZSBjbG9zZSBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU3MzAxCisKKyAgICAgICAgSW4gcGxhdGZvcm1DbG9zZSgpLCBt X3JlYWRTdHJlYW0gbWF5IGJlIDAgdW50aWwgcHJveHkgaXMgcmVzb2x2ZWQuCisgICAgICAgIEl0 IHNob3VsZCBjYWxsYmFjayBkaWRDbG9zZSgpIGluIHN1Y2ggY2FzZS4KKyAgICAgICAgCisgICAg ICAgIFRlc3Q6IGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2Nsb3NlLWJlZm9yZS1vcGVuLmh0 bWwKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvU29ja2V0U3RyZWFtSGFuZGxlQ0ZO ZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U29ja2V0U3RyZWFtSGFuZGxlOjpwbGF0Zm9ybUNs b3NlKToKKwogMjAxMS0wMy0yOCAgU3RldmUgQmxvY2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Tb2NrZXRTdHJlYW1IYW5kbGVDRk5ldC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1NvY2tldFN0cmVhbUhhbmRsZUNG TmV0LmNwcAppbmRleCBlZTA2YzY4OTM2YWI0OTdmZmVmZTJiMWI2YzI1OGYxNTk5NDNmMDlhLi43 MDA3OGU5ZTM3ZmFhODFhNmRhZjc5OThhYjlhOGY2MTk3MmQyZjdjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1NvY2tldFN0cmVhbUhhbmRsZUNGTmV0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1NvY2tldFN0cmVhbUhh bmRsZUNGTmV0LmNwcApAQCAtNjQzLDggKzY0MywxMSBAQCB2b2lkIFNvY2tldFN0cmVhbUhhbmRs ZTo6cGxhdGZvcm1DbG9zZSgpCiAjZW5kaWYKIAogICAgIEFTU0VSVCghbV9yZWFkU3RyZWFtID09 ICFtX3dyaXRlU3RyZWFtKTsKLSAgICBpZiAoIW1fcmVhZFN0cmVhbSkKKyAgICBpZiAoIW1fcmVh ZFN0cmVhbSkgeworICAgICAgICBpZiAobV9jb25uZWN0aW5nU3Vic3RhdGUgPT0gTmV3IHx8IG1f Y29ubmVjdGluZ1N1YnN0YXRlID09IEV4ZWN1dGluZ1BBQ0ZpbGUpCisgICAgICAgICAgICBtX2Ns aWVudC0+ZGlkQ2xvc2UodGhpcyk7CiAgICAgICAgIHJldHVybjsKKyAgICB9CiAKICAgICBDRlJl YWRTdHJlYW1VbnNjaGVkdWxlRnJvbVJ1bkxvb3AobV9yZWFkU3RyZWFtLmdldCgpLCBDRlJ1bkxv b3BHZXRDdXJyZW50KCksIGtDRlJ1bkxvb3BDb21tb25Nb2Rlcyk7CiAgICAgQ0ZXcml0ZVN0cmVh bVVuc2NoZWR1bGVGcm9tUnVuTG9vcChtX3dyaXRlU3RyZWFtLmdldCgpLCBDRlJ1bkxvb3BHZXRD dXJyZW50KCksIGtDRlJ1bkxvb3BDb21tb25Nb2Rlcyk7Cg==