57295 2011-03-28 20:08:26 -0700 ES5 Strict mode does not allow getter and setter for same propId 2011-05-01 21:52:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED http://static.ryanberdeen.com/share/2011/03/strict-accessor.html P2 Normal --- 1 ryan oliver oliver oldest_to_newest 374965 0 ryan 2011-03-28 20:08:26 -0700 In strict mode, an object literal with a getter and setter for the same property will cause WebKit to raise a syntax error. This should be valid, but raises a syntax error due to the presence of the setter: 'use strict'; var o = { get x () {}, set x () {} }; Changing the property name for either getter or setter will eliminate the syntax error. This behavior does not seem to follow §11.1.5. 396205 1 oliver 2011-05-01 20:00:26 -0700 Whoops, I think i left in a piece of code from when i was debugging. Need to verify but the fix is trivial. Please CC me on any other strict mode bugs that you find. 396216 2 91879 oliver 2011-05-01 21:47:56 -0700 Created attachment 91879 Patch 396218 3 oliver 2011-05-01 21:52:10 -0700 Committed r85455: <http://trac.webkit.org/changeset/85455> 91879 2011-05-01 21:47:56 -0700 2011-05-01 21:49:09 -0700 Patch bug-57295-20110501214755.patch text/plain 4899 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODU0NTQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhYmIxYmNlZGYxNTg3OWI0M2UwMWFj N2QyNWZmYTAxYzNhNDRkYzRlLi4wYzZlYWMzOGRjN2VjMDg0NTE5M2ZiZWViYTE1ZmE5M2VmZTI5 NTJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTEtMDUtMDEgIE9saXZlciBIdW50ICA8b2xp dmVyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBFUzUgU3RyaWN0IG1vZGUgZG9lcyBub3QgYWxsb3cgZ2V0dGVyIGFuZCBzZXR0ZXIg Zm9yIHNhbWUgcHJvcElkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NzI5NQorCisgICAgICAgIFVwZGF0ZSBmb3IgY29ycmVjdCByZXN1bHRzCisKKyAg ICAgICAgKiBmYXN0L2pzL21vemlsbGEvc3RyaWN0LzExLjEuNS1leHBlY3RlZC50eHQ6CisKKzIw MTEtMDUtMDEgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZp ZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KIAogICAgICAgICBBc3NpZ25pbmcgdG8gZnVuY3Rp b24gaWRlbnRpZmllciB1bmRlciBzdHJpY3Qgc2hvdWxkIHRocm93CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2pzL21vemlsbGEvc3RyaWN0LzExLjEuNS1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9mYXN0L2pzL21vemlsbGEvc3RyaWN0LzExLjEuNS1leHBlY3RlZC50eHQKaW5kZXgg YzY4ZjcyZTBiNGQ3MTcwZjhlNDJmZjdmNzQ4NWQ5NDQxNjY1YTZjOC4uM2I3ZGU2ZTU2ZGVhM2Vk NjgwY2I5Y2YyZGMxMmU5ZGM5ZTMzNjg2NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9q cy9tb3ppbGxhL3N0cmljdC8xMS4xLjUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zh c3QvanMvbW96aWxsYS9zdHJpY3QvMTEuMS41LWV4cGVjdGVkLnR4dApAQCAtNzAsMTAgKzcwLDEw IEBAIFBBU1MgdHJ1ZSA9PT0gdHJ1ZQogUEFTUyBGdW5jdGlvbigiJ3VzZSBzdHJpY3QnOyAoe3Nl dCAxKHEpIHt9LCBcIjFcIjoxfSkiKSB0aHJldyBleGNlcHRpb24gb2YgdHlwZSBTeW50YXhFcnJv ci4KIFBBU1MgRnVuY3Rpb24oIih7c2V0IDEocSkge30sIFwiMVwiOjF9KSIpIHRocmV3IGV4Y2Vw dGlvbiBvZiB0eXBlIFN5bnRheEVycm9yLgogUEFTUyB0cnVlID09PSB0cnVlCi1GQUlMICEhRnVu Y3Rpb24oIid1c2Ugc3RyaWN0JzsgKHtnZXQgeCgpIHt9LCBzZXQgeChxKSB7fX0pIikgc2hvdWxk IGJlIHRydWUuIFRocmV3IGV4Y2VwdGlvbiBTeW50YXhFcnJvcjogUGFyc2UgZXJyb3IKK1BBU1Mg ISFGdW5jdGlvbigiJ3VzZSBzdHJpY3QnOyAoe2dldCB4KCkge30sIHNldCB4KHEpIHt9fSkiKSBp cyB0cnVlCiBQQVNTICEhRnVuY3Rpb24oIih7Z2V0IHgoKSB7fSwgc2V0IHgocSkge319KSIpIGlz IHRydWUKIFBBU1MgdHJ1ZSA9PT0gdHJ1ZQotRkFJTCAhIUZ1bmN0aW9uKCIndXNlIHN0cmljdCc7 ICh7c2V0IHgocSkge30sIGdldCB4KCkge319KSIpIHNob3VsZCBiZSB0cnVlLiBUaHJldyBleGNl cHRpb24gU3ludGF4RXJyb3I6IFBhcnNlIGVycm9yCitQQVNTICEhRnVuY3Rpb24oIid1c2Ugc3Ry aWN0JzsgKHtzZXQgeChxKSB7fSwgZ2V0IHgoKSB7fX0pIikgaXMgdHJ1ZQogUEFTUyAhIUZ1bmN0 aW9uKCIoe3NldCB4KHEpIHt9LCBnZXQgeCgpIHt9fSkiKSBpcyB0cnVlCiBQQVNTIHRydWUgPT09 IHRydWUKIFBBU1MgRnVuY3Rpb24oIid1c2Ugc3RyaWN0JzsgKHtnZXQgeCgpIHt9LCBzZXQgeChx KSB7fSwgeDoxfSkiKSB0aHJldyBleGNlcHRpb24gb2YgdHlwZSBTeW50YXhFcnJvci4KQEAgLTg4 LDcgKzg4LDcgQEAgUEFTUyB0cnVlID09PSB0cnVlCiBQQVNTIEZ1bmN0aW9uKCIndXNlIHN0cmlj dCc7ICh7c2V0IHgoKSB7fSwgc2V0IHgoKSB7fX0pIikgdGhyZXcgZXhjZXB0aW9uIG9mIHR5cGUg U3ludGF4RXJyb3IuCiBQQVNTIEZ1bmN0aW9uKCIoe3NldCB4KCkge30sIHNldCB4KCkge319KSIp IHRocmV3IGV4Y2VwdGlvbiBvZiB0eXBlIFN5bnRheEVycm9yLgogUEFTUyB0cnVlID09PSB0cnVl Ci1GQUlMICEhRnVuY3Rpb24oIid1c2Ugc3RyaWN0JzsgKHtnZXQgeCgpIHt9LCBzZXQgeChxKSB7 fSwgeToxfSkiKSBzaG91bGQgYmUgdHJ1ZS4gVGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBQ YXJzZSBlcnJvcgorUEFTUyAhIUZ1bmN0aW9uKCIndXNlIHN0cmljdCc7ICh7Z2V0IHgoKSB7fSwg c2V0IHgocSkge30sIHk6MX0pIikgaXMgdHJ1ZQogUEFTUyAhIUZ1bmN0aW9uKCIoe2dldCB4KCkg e30sIHNldCB4KHEpIHt9LCB5OjF9KSIpIGlzIHRydWUKIFBBU1MgdHJ1ZSA9PT0gdHJ1ZQogIFBB U1NFRCEgCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1ZWEwMjBjY2JmNWI1M2VjMzg0ODFm NGY0MTQ5ZDk3MTc1ZDJmYWQyLi5kNjA3NDA0MGY1ZDhiNDM2NTE2MjdiOTk4Y2E0ODYwNzliYzUw OGFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxMS0wNS0w MSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVTNSBTdHJpY3QgbW9kZSBkb2VzIG5vdCBhbGxv dyBnZXR0ZXIgYW5kIHNldHRlciBmb3Igc2FtZSBwcm9wSWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3Mjk1CisKKyAgICAgICAgU2ltcGxpZnkgYW5k IGNvcnJlY3QgdGhlIGxvZ2ljIGZvciBzdHJpY3QgbW9kZSBvYmplY3QgbGl0ZXJhbHMuCisKKyAg ICAgICAgKiBwYXJzZXIvSlNQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpKU1BhcnNlcjo6cGFy c2VTdHJpY3RPYmplY3RMaXRlcmFsKToKKworMjAxMS0wNS0wMSAgT2xpdmVyIEh1bnQgIDxvbGl2 ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgog CiAgICAgICAgIEFzc2lnbmluZyB0byBmdW5jdGlvbiBpZGVudGlmaWVyIHVuZGVyIHN0cmljdCBz aG91bGQgdGhyb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvSlNQ YXJzZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9KU1BhcnNlci5jcHAKaW5k ZXggOTQ3YTJjNjdkMjVjN2VmNTViNzdjM2NjNWRjNmY5ODk3Y2IzMDIwNC4uYWM5OWQ3OGEyN2Qx YzY2NjdkMjdlNmNkN2FlZDg1ZDk1MjJiMjQ2NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3BhcnNlci9KU1BhcnNlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Bh cnNlci9KU1BhcnNlci5jcHAKQEAgLTE4MDksMTMgKzE4MDksMTAgQEAgdGVtcGxhdGUgPGNsYXNz IFRyZWVCdWlsZGVyPiBUcmVlRXhwcmVzc2lvbiBKU1BhcnNlcjo6cGFyc2VTdHJpY3RPYmplY3RM aXRlcmFsKFQKICAgICAgICAgaWYgKCFtX3N5bnRheEFscmVhZHlWYWxpZGF0ZWQpIHsKICAgICAg ICAgICAgIHN0ZDo6cGFpcjxPYmplY3RWYWxpZGF0aW9uTWFwOjppdGVyYXRvciwgYm9vbD4gcHJv cGVydHlFbnRyeUl0ZXIgPSBvYmplY3RWYWxpZGF0b3IuYWRkKGNvbnRleHQuZ2V0TmFtZShwcm9w ZXJ0eSkuaW1wbCgpLCBjb250ZXh0LmdldFR5cGUocHJvcGVydHkpKTsKICAgICAgICAgICAgIGlm ICghcHJvcGVydHlFbnRyeUl0ZXIuc2Vjb25kKSB7Ci0gICAgICAgICAgICAgICAgZmFpbElmVHJ1 ZShzdHJpY3RNb2RlKCkpOwotICAgICAgICAgICAgICAgIGlmICgoY29udGV4dC5nZXRUeXBlKHBy b3BlcnR5KSAmIHByb3BlcnR5RW50cnlJdGVyLmZpcnN0LT5zZWNvbmQpICE9IFByb3BlcnR5Tm9k ZTo6Q29uc3RhbnQpIHsKLSAgICAgICAgICAgICAgICAgICAgLy8gQ2FuJ3QgaGF2ZSBtdWx0aXBs ZSBnZXR0ZXJzIG9yIHNldHRlcnMgd2l0aCB0aGUgc2FtZSBuYW1lLCBub3IgY2FuIHdlIGRlZmlu ZSAKLSAgICAgICAgICAgICAgICAgICAgLy8gYSBwcm9wZXJ0eSBhcyBib3RoIGFuIGFjY2Vzc29y IGFuZCBhIGNvbnN0YW50IHZhbHVlCi0gICAgICAgICAgICAgICAgICAgIGZhaWxJZlRydWUoY29u dGV4dC5nZXRUeXBlKHByb3BlcnR5KSAmIHByb3BlcnR5RW50cnlJdGVyLmZpcnN0LT5zZWNvbmQp OwotICAgICAgICAgICAgICAgICAgICBmYWlsSWZUcnVlKChjb250ZXh0LmdldFR5cGUocHJvcGVy dHkpIHwgcHJvcGVydHlFbnRyeUl0ZXIuZmlyc3QtPnNlY29uZCkgJiBQcm9wZXJ0eU5vZGU6OkNv bnN0YW50KTsKLSAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgZmFpbElmVHJ1ZShw cm9wZXJ0eUVudHJ5SXRlci5maXJzdC0+c2Vjb25kID09IFByb3BlcnR5Tm9kZTo6Q29uc3RhbnQp OworICAgICAgICAgICAgICAgIGZhaWxJZlRydWUoY29udGV4dC5nZXRUeXBlKHByb3BlcnR5KSA9 PSBQcm9wZXJ0eU5vZGU6OkNvbnN0YW50KTsKKyAgICAgICAgICAgICAgICBmYWlsSWZUcnVlKGNv bnRleHQuZ2V0VHlwZShwcm9wZXJ0eSkgJiBwcm9wZXJ0eUVudHJ5SXRlci5maXJzdC0+c2Vjb25k KTsKKyAgICAgICAgICAgICAgICBwcm9wZXJ0eUVudHJ5SXRlci5maXJzdC0+c2Vjb25kIHw9IGNv bnRleHQuZ2V0VHlwZShwcm9wZXJ0eSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAg ICAgdGFpbCA9IGNvbnRleHQuY3JlYXRlUHJvcGVydHlMaXN0KHByb3BlcnR5LCB0YWlsKTsK