57294 2011-03-28 19:31:13 -0700 Crash when closing "Add Bookmark" Dialog using the Enter Key 2011-03-30 12:58:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 bweinstein bweinstein ap aroben oldest_to_newest 374949 0 bweinstein 2011-03-28 19:31:13 -0700 If a WebView is set to close using the Enter Key (if it was a dialog that closes when you press enter), it can crash when closed this way. The FrameView isn't protected in EventHandler::keyEvent, like it is in EventHandler::handleMousePressEvent, EventHandler::handleMouseDoubleClickEvent, EventHandler::handleMouseMoveEvent, EventHandler::handleMouseReleaseEvent, and EventHandler::handleWheelEvent. <rdar://problem/9044756> 374951 1 87249 bweinstein 2011-03-28 19:33:39 -0700 Created attachment 87249 [PATCH] Fix 374962 2 87249 darin 2011-03-28 20:05:50 -0700 Comment on attachment 87249 [PATCH] Fix It’s not at all clear why we protect the FrameView and not some other reference-counted object. 374968 3 bweinstein 2011-03-28 20:15:01 -0700 (In reply to comment #2) > (From update of attachment 87249 [details]) > It’s not at all clear why we protect the FrameView and not some other reference-counted object. I'm not sure either. I was going by existing style w/ other functions in the class + it fixed the crash. I can talk to someone about it later tonight or in the morning before landing. 375192 4 87249 aroben 2011-03-29 04:49:51 -0700 Comment on attachment 87249 [PATCH] Fix Is it possible to make a test for this? If not a test for run-webkit-tests, then maybe one for run-api-tests? 375732 5 bweinstein 2011-03-29 14:01:54 -0700 (In reply to comment #4) > (From update of attachment 87249 [details]) > Is it possible to make a test for this? If not a test for run-webkit-tests, then maybe one for run-api-tests? I tried making a test that opens a window using window.open, and that window is closed by any key-press, but that didn't reproduce the crash. 375738 6 ap 2011-03-29 14:05:46 -0700 > I tried making a test that opens a window using window.open, and that window is closed by any key-press, but that didn't reproduce the crash. Not sure if it's worth spending more time on this, but the inability to make a test suggests that there is some general difference between normal web views and those the problem was observed with, and that difference would be good to find and eliminate. 376603 7 bweinstein 2011-03-30 12:45:37 -0700 Adding some additional steps to reproduce: 1) Go to any page (http://reddit.com - was used for testing). 2) Click the + button in the URL field, to add a bookmark 3) Press Enter to close the "Add Bookmark" Dialog 376608 8 bweinstein 2011-03-30 12:58:49 -0700 Landed in r82487. 87249 2011-03-28 19:33:39 -0700 2011-03-29 04:49:51 -0700 [PATCH] Fix crash_enter.patch text/plain 1352 bweinstein SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyMTgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMjggIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQ3Jhc2ggd2hlbiBjbG9zaW5nIFdlYlZp ZXcgdXNpbmcgdGhlIEVudGVyIEtleQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTcyOTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzkwNDQ3NTY+CisK KyAgICAgICAgUHJvdGVjdCB0aGUgRnJhbWVWaWV3IGluIEV2ZW50SGFuZGxlcjo6a2V5RXZlbnQs IGxpa2Ugd2UgZG8gaW4gb3RoZXIgRXZlbnRIYW5kbGVyCisgICAgICAgIGZ1bmN0aW9ucyB0aGF0 IGNvdWxkIGRlc3Ryb3kgdGhlIGZyYW1lLgorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjprZXlFdmVudCk6CisKIDIwMTEt MDMtMjcgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBbnR0aSBLb2l2aXN0by4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5k bGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5j cHAJKHJldmlzaW9uIDgyMTQwKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzc1LDYgKzIzNzUsOCBAQCBib29sIEV2ZW50SGFuZGxl cjo6bmVlZHNLZXlib2FyZEV2ZW50RGlzCiAKIGJvb2wgRXZlbnRIYW5kbGVyOjprZXlFdmVudChj b25zdCBQbGF0Zm9ybUtleWJvYXJkRXZlbnQmIGluaXRpYWxLZXlFdmVudCkKIHsKKyAgICBSZWZQ dHI8RnJhbWVWaWV3PiBwcm90ZWN0b3IobV9mcmFtZS0+dmlldygpKTsgCisKICNpZiBFTkFCTEUo UEFOX1NDUk9MTElORykKICAgICBpZiAoUGFnZSogcGFnZSA9IG1fZnJhbWUtPnBhZ2UoKSkgewog ICAgICAgICBpZiAocGFnZS0+bWFpbkZyYW1lKCktPmV2ZW50SGFuZGxlcigpLT5wYW5TY3JvbGxJ blByb2dyZXNzKCkgfHwgbV9hdXRvc2Nyb2xsSW5Qcm9ncmVzcykgewo=