57286 2011-03-28 17:02:48 -0700 Alternative fix for: Horizontal scroller stops appearing after going Forward 2011-06-26 22:24:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin dongjae1.kim oldest_to_newest 374906 0 bdakin 2011-03-28 17:02:48 -0700 http://trac.webkit.org/changeset/79053 was a fix for a long-standing WebKit bug. Hyatt proposed that we actually fix it in a different way though. I will soon post a patch that rolls out the original fix and implements Hyatt's suggested fix. <rdar://problem/9026946> Oh, and to reproduce: 1. Visit any page, say nytimes.com 2. Now visit another page -- one that you know will go into the back-forward cache. I visited a local test file I have that is just text inside a <body> with a fixed width. Make sure the window is narrow enough to have a horizontal scrollbar. 3. Click the back button. 4. Click the forward button. The bug was that the horizontal scrollbar would not be there even though scrolling horizontally was possible. 374908 1 87242 bdakin 2011-03-28 17:09:19 -0700 Created attachment 87242 Patch 374917 2 87242 darin 2011-03-28 17:44:01 -0700 Comment on attachment 87242 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87242&action=review > Source/WebCore/dom/Document.cpp:3947 > + v->resetScrollbars(FrameView::ClearContentsSize); Since the work to clear the contents size is completely separate, why not add a separate function call instead of having an enum to add more work onto this function? 374954 3 bdakin 2011-03-28 19:38:13 -0700 (In reply to comment #2) > (From update of attachment 87242 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87242&action=review > > > Source/WebCore/dom/Document.cpp:3947 > > + v->resetScrollbars(FrameView::ClearContentsSize); > > Since the work to clear the contents size is completely separate, why not add a separate function call instead of having an enum to add more work onto this function? I took Darin's advice and added a separate function. He gave me an r=him in person, so I am going mark the + flag. 374955 4 bdakin 2011-03-28 19:39:52 -0700 Fixed with r 82185. 427657 5 dongjae1.kim 2011-06-26 22:24:23 -0700 This bug was fixed, Currently EFL Port Page Cache was disabled. so I try to enable EFL Page Cache Function. but Horizontal Scroll Bar was not displayed. I want to know, why below code was deleted. if (!m_isRestoringFromBackForward) setScrollbarsSuppressed(true); else { setScrollbarsSuppressed(false); m_isRestoringFromBackForward = false; } 87242 2011-03-28 17:09:19 -0700 2011-03-28 19:38:40 -0700 Patch for-review.txt text/plain 5592 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyMTc1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzIgQEAKKzIwMTEtMDMtMjggIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU3Mjg2IEFsdGVybmF0aXZlIGZpeCBmb3I6IAorICAgICAgICBIb3Jpem9udGFsIHNj cm9sbGVyIHN0b3BzIGFwcGVhcmluZyBhZnRlciBnb2luZyBGb3J3YXJkCisgICAgICAgIC1hbmQg Y29ycmVzcG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzkwMjY5NDY+CisKKyAgICAg ICAgVGhpcyBwYXRjaCByb2xscyBvdXQgcmV2aXNpb24gNzkwNTMgYW5kIGZpeGVzIHRoZSBzYW1l IGJ1ZyBpbiBhICBiZXR0ZXIgd2F5LgorCisgICAgICAgIEZyYW1lVmlldzo6cmVzZXRTY3JvbGxi YXJzKCkgbm93IHRha2VzIGEgcGFyYW1ldGVyIGluZGljYXRpbmcgd2hldGhlciBvciBub3QgdG8g CisgICAgICAgIGNsZWFyIHRoZSBjb250ZW50cyBzaXplIG9uIHJlc2V0LgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVWaWV3OjpyZXNldFNjcm9sbGJhcnMpOgorCisgICAgICAgIFNlbmQgRnJhbWVW aWV3OjpDbGVhckNvbnRlbnRzU2l6ZSBoZXJlIGluIHRoZSBjYXNlIHdoZXJlIHRoZSBkb2N1bWVu dCBpcyBnb2luZyBpbnRvIAorICAgICAgICB0aGUgcGFnZSBjYWNoZS4KKyAgICAgICAgKiBkb20v RG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldEluUGFnZUNhY2hl KToKKworICAgICAgICBSb2xsLW91dCBvZiA3OTA1My4KKyAgICAgICAgKiBoaXN0b3J5L0NhY2hl ZEZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZEZyYW1lQmFzZTo6cmVzdG9yZSk6 CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVW aWV3OjpGcmFtZVZpZXcpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpyZXNldCk6Cisg ICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmxheW91dCk6CisgICAgICAgICogcGFnZS9GcmFt ZVZpZXcuaDoKKwogMjAxMS0wMy0yOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVuLgpJbmRleDogU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCShyZXZpc2lvbiA4MjE0MCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5NDQsNyArMzk0NCw3IEBAIHZvaWQgRG9jdW1lbnQ6 OnNldEluUGFnZUNhY2hlKGJvb2wgZmxhZykKICAgICAgICAgQVNTRVJUKCFtX3NhdmVkUmVuZGVy ZXIpOwogICAgICAgICBtX3NhdmVkUmVuZGVyZXIgPSByZW5kZXJlcigpOwogICAgICAgICBpZiAo RnJhbWVWaWV3KiB2ID0gdmlldygpKQotICAgICAgICAgICAgdi0+cmVzZXRTY3JvbGxiYXJzKCk7 CisgICAgICAgICAgICB2LT5yZXNldFNjcm9sbGJhcnMoRnJhbWVWaWV3OjpDbGVhckNvbnRlbnRz U2l6ZSk7CiAgICAgICAgIG1fc3R5bGVSZWNhbGNUaW1lci5zdG9wKCk7CiAgICAgfSBlbHNlIHsK ICAgICAgICAgQVNTRVJUKCFyZW5kZXJlcigpIHx8IHJlbmRlcmVyKCkgPT0gbV9zYXZlZFJlbmRl cmVyKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQ2FjaGVkRnJhbWUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQ2FjaGVkRnJhbWUuY3BwCShyZXZpc2lv biA4MjE0MCkKKysrIFNvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQ2FjaGVkRnJhbWUuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC04Myw4ICs4Myw2IEBAIHZvaWQgQ2FjaGVkRnJhbWVCYXNlOjpyZXN0b3Jl KCkKIHsKICAgICBBU1NFUlQobV9kb2N1bWVudC0+dmlldygpID09IG1fdmlldyk7CiAKLSAgICBt X3ZpZXctPnNldElzUmVzdG9yaW5nRnJvbUJhY2tGb3J3YXJkKHRydWUpOwotCiAgICAgRnJhbWUq IGZyYW1lID0gbV92aWV3LT5mcmFtZSgpOwogICAgIG1fY2FjaGVkRnJhbWVTY3JpcHREYXRhLT5y ZXN0b3JlKGZyYW1lKTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkocmV2aXNp b24gODIxNzEpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEzMiw3ICsxMzIsNiBAQCBGcmFtZVZpZXc6OkZyYW1lVmlldyhGcmFtZSogZnJh bWUpCiAgICAgLCBtX3Nob3VsZFVwZGF0ZVdoaWxlT2Zmc2NyZWVuKHRydWUpCiAgICAgLCBtX2Rl ZmVyU2V0TmVlZHNMYXlvdXRzKDApCiAgICAgLCBtX3NldE5lZWRzTGF5b3V0V2FzRGVmZXJyZWQo ZmFsc2UpCi0gICAgLCBtX2lzUmVzdG9yaW5nRnJvbUJhY2tGb3J3YXJkKGZhbHNlKQogICAgICwg bV9zY3JvbGxDb3JuZXIoMCkKIHsKICAgICBpbml0KCk7CkBAIC0yMjcsNyArMjI2LDYgQEAgdm9p ZCBGcmFtZVZpZXc6OnJlc2V0KCkKICAgICBtX2lzUGFpbnRpbmcgPSBmYWxzZTsKICAgICBtX2lz VmlzdWFsbHlOb25FbXB0eSA9IGZhbHNlOwogICAgIG1fZmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5 b3V0Q2FsbGJhY2tQZW5kaW5nID0gdHJ1ZTsKLSAgICBtX2lzUmVzdG9yaW5nRnJvbUJhY2tGb3J3 YXJkID0gZmFsc2U7CiAgICAgbV9tYWludGFpblNjcm9sbFBvc2l0aW9uQW5jaG9yID0gMDsKIH0K IApAQCAtMjQxLDcgKzIzOSw3IEBAIHZvaWQgRnJhbWVWaWV3OjpjbGVhckZyYW1lKCkKICAgICBt X2ZyYW1lID0gMDsKIH0KIAotdm9pZCBGcmFtZVZpZXc6OnJlc2V0U2Nyb2xsYmFycygpCit2b2lk IEZyYW1lVmlldzo6cmVzZXRTY3JvbGxiYXJzKEFmZmVjdHNDb250ZW50c1NpemUgYWZmZWN0cykK IHsKICAgICAvLyBSZXNldCB0aGUgZG9jdW1lbnQncyBzY3JvbGxiYXJzIGJhY2sgdG8gb3VyIGRl ZmF1bHRzIGJlZm9yZSB3ZSB5aWVsZCB0aGUgZmxvb3IuCiAgICAgbV9maXJzdExheW91dCA9IHRy dWU7CkBAIC0yNTEsNiArMjQ5LDEyIEBAIHZvaWQgRnJhbWVWaWV3OjpyZXNldFNjcm9sbGJhcnMo KQogICAgIGVsc2UKICAgICAgICAgc2V0U2Nyb2xsYmFyTW9kZXMoU2Nyb2xsYmFyQWx3YXlzT2Zm LCBTY3JvbGxiYXJBbHdheXNPZmYpOwogICAgIHNldFNjcm9sbGJhcnNTdXBwcmVzc2VkKGZhbHNl KTsKKworICAgIGlmIChhZmZlY3RzID09IENsZWFyQ29udGVudHNTaXplKSB7CisgICAgICAgIHNl dFNjcm9sbGJhcnNTdXBwcmVzc2VkKHRydWUpOworICAgICAgICBzZXRDb250ZW50c1NpemUoSW50 U2l6ZSgpKTsKKyAgICAgICAgc2V0U2Nyb2xsYmFyc1N1cHByZXNzZWQoZmFsc2UpOworICAgIH0K IH0KIAogdm9pZCBGcmFtZVZpZXc6OmluaXQoKQpAQCAtODQ3LDEyICs4NTEsNyBAQCB2b2lkIEZy YW1lVmlldzo6bGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlCiAKICAgICAgICAgaWYgKG1fZmlyc3RM YXlvdXQgfHwgKGhNb2RlICE9IGN1cnJlbnRITW9kZSB8fCB2TW9kZSAhPSBjdXJyZW50Vk1vZGUp KSB7CiAgICAgICAgICAgICBpZiAobV9maXJzdExheW91dCkgewotICAgICAgICAgICAgICAgIGlm ICghbV9pc1Jlc3RvcmluZ0Zyb21CYWNrRm9yd2FyZCkKLSAgICAgICAgICAgICAgICAgICAgc2V0 U2Nyb2xsYmFyc1N1cHByZXNzZWQodHJ1ZSk7Ci0gICAgICAgICAgICAgICAgZWxzZSB7Ci0gICAg ICAgICAgICAgICAgICAgIHNldFNjcm9sbGJhcnNTdXBwcmVzc2VkKGZhbHNlKTsKLSAgICAgICAg ICAgICAgICAgICAgbV9pc1Jlc3RvcmluZ0Zyb21CYWNrRm9yd2FyZCA9IGZhbHNlOwotICAgICAg ICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICBzZXRTY3JvbGxiYXJzU3VwcHJlc3NlZCh0cnVl KTsKIAogICAgICAgICAgICAgICAgIG1fZmlyc3RMYXlvdXQgPSBmYWxzZTsKICAgICAgICAgICAg ICAgICBtX2ZpcnN0TGF5b3V0Q2FsbGJhY2tQZW5kaW5nID0gdHJ1ZTsKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuaAkocmV2aXNpb24gODIxNzEpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzAsNyArMTMwLDggQEAgcHVibGljOgogICAg IHZvaWQgZGlkTW92ZU9uc2NyZWVuKCk7CiAgICAgdm9pZCB3aWxsTW92ZU9mZnNjcmVlbigpOwog Ci0gICAgdm9pZCByZXNldFNjcm9sbGJhcnMoKTsKKyAgICBlbnVtIEFmZmVjdHNDb250ZW50c1Np emUgeyBDb250ZW50c1NpemVVbmNoYW5nZWQsIENsZWFyQ29udGVudHNTaXplIH07CisgICAgdm9p ZCByZXNldFNjcm9sbGJhcnMoQWZmZWN0c0NvbnRlbnRzU2l6ZSA9IENvbnRlbnRzU2l6ZVVuY2hh bmdlZCk7CiAgICAgdm9pZCBkZXRhY2hDdXN0b21TY3JvbGxiYXJzKCk7CiAKICAgICB2b2lkIGNs ZWFyKCk7CkBAIC0yNjgsOSArMjY5LDYgQEAgcHVibGljOgogICAgIC8vIEZJWE1FOiBSZW1vdmUg dGhpcyBtZXRob2Qgb25jZSBwbHVnaW4gbG9hZGluZyBpcyBkZWNvdXBsZWQgZnJvbSBsYXlvdXQu CiAgICAgdm9pZCBmbHVzaEFueVBlbmRpbmdQb3N0TGF5b3V0VGFza3MoKTsKIAotICAgIHZvaWQg c2V0SXNSZXN0b3JpbmdGcm9tQmFja0ZvcndhcmQoYm9vbCBpc1Jlc3RvcmluZykgeyBtX2lzUmVz dG9yaW5nRnJvbUJhY2tGb3J3YXJkID0gaXNSZXN0b3Jpbmc7IH0KLSAgICBib29sIGlzUmVzdG9y aW5nRnJvbUJhY2tGb3J3YXJkKCkgY29uc3QgeyByZXR1cm4gbV9pc1Jlc3RvcmluZ0Zyb21CYWNr Rm9yd2FyZDsgfQotCiAgICAgdmlydHVhbCBib29sIHNob3VsZFN1c3BlbmRTY3JvbGxBbmltYXRp b25zKCkgY29uc3Q7CiAKIHByb3RlY3RlZDoKQEAgLTQxNSw4ICs0MTMsNiBAQCBwcml2YXRlOgog ICAgIGJvb2wgbV9pc1Zpc3VhbGx5Tm9uRW1wdHk7CiAgICAgYm9vbCBtX2ZpcnN0VmlzdWFsbHlO b25FbXB0eUxheW91dENhbGxiYWNrUGVuZGluZzsKIAotICAgIGJvb2wgbV9pc1Jlc3RvcmluZ0Zy b21CYWNrRm9yd2FyZDsKLQogICAgIFJlZlB0cjxOb2RlPiBtX21haW50YWluU2Nyb2xsUG9zaXRp b25BbmNob3I7CiAKICAgICAvLyBSZW5kZXJlciB0byBob2xkIG91ciBjdXN0b20gc2Nyb2xsIGNv cm5lci4K