<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>57256</bug_id>
          
          <creation_ts>2011-03-28 11:49:09 -0700</creation_ts>
          <short_desc>Fix crash on Solaris 10 for misaligned reads on Sparc processors</short_desc>
          <delta_ts>2011-06-03 07:19:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Ben Taylor">bentaylor.solx86</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ademar</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>374650</commentid>
    <comment_count>0</comment_count>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-03-28 11:49:09 -0700</bug_when>
    <thetext>Sparc cannot do 32-bit reads on misaligned boundaries. The program
crashes if you try to do so.

t@1 (l@1) signal BUS (invalid address alignment) in WebCore::equal at 0xffffffff7e2719fc
0xffffffff7e2719fc: equal+0x002c:       ld       [%o1], %g1

(originally reported from https://bugs.webkit.org/show_bug.cgi?id=24932
by Thiago Macieria, patch 05/17)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>374710</commentid>
    <comment_count>1</comment_count>
      <attachid>87185</attachid>
    <who name="Ben Taylor">bentaylor.solx86</who>
    <bug_when>2011-03-28 13:15:34 -0700</bug_when>
    <thetext>Created attachment 87185
Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler

Fix crash on misaligned reads on Solaris 10/Sparc. Original bug reported
and proposed fix by Thiago Macieria in bug https://bugs.webkit.org/show_bug.cgi?id=24932</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375093</commentid>
    <comment_count>2</comment_count>
      <attachid>87185</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-03-29 00:59:37 -0700</bug_when>
    <thetext>Comment on attachment 87185
Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler

Clearing flags on attachment: 87185

Committed r82207: &lt;http://trac.webkit.org/changeset/82207&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375094</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-03-29 00:59:40 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>414863</commentid>
    <comment_count>4</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2011-06-03 07:19:30 -0700</bug_when>
    <thetext>Looks like the patch attached to this bug was incomplete. See bug 29407, I attached a patch there with the missing checks.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>87185</attachid>
            <date>2011-03-28 13:15:34 -0700</date>
            <delta_ts>2011-03-29 00:59:37 -0700</delta_ts>
            <desc>Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler</desc>
            <filename>webkit-bug-57256-fix-unaligned-access-on-Solaris10Sparc.diff</filename>
            <type>text/plain</type>
            <size>1328</size>
            <attacher name="Ben Taylor">bentaylor.solx86</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODIxNDApCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK
KzIwMTEtMDMtMjggIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcyNTYKKworICAgICAgICBGaXggY3Jhc2gg
b24gbWlzYWxpZ25lZCByZWFkcyBvbiBTb2xhcmlzIDEwL1NwYXJjCisKKyAgICAgICAgKiB3dGYv
dGV4dC9BdG9taWNTdHJpbmcuY3BwOgorICAgICAgICAoV1RGOjplcXVhbCk6CisKIDIwMTEtMDMt
MjggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O
KHI4MjEzMCk6IEl0IG1hZGUgYWxsIHRlc3RzIGNyYXNoIChSZXF1ZXN0ZWQgYnkgT3NzeSBvbiAj
d2Via2l0KS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9taWNTdHJp
bmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9t
aWNTdHJpbmcuY3BwCShyZXZpc2lvbiA4MjExMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93
dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDIsNyArMTQyLDcg
QEAgc3RhdGljIGlubGluZSBib29sIGVxdWFsKFN0cmluZ0ltcGwqIHN0cgogCiAgICAgLy8gRklY
TUU6IHBlcmhhcHMgd2Ugc2hvdWxkIGhhdmUgYSBtb3JlIGFic3RyYWN0IG1hY3JvIHRoYXQgaW5k
aWNhdGVzIHdoZW4KICAgICAvLyBnb2luZyA0IGJ5dGVzIGF0IGEgdGltZSBpcyB1bnNhZmUKLSNp
ZiBDUFUoQVJNKSB8fCBDUFUoU0g0KSB8fCBDUFUoTUlQUykKKyNpZiBDUFUoQVJNKSB8fCBDUFUo
U0g0KSB8fCBDUFUoTUlQUykgfHwgQ1BVKFNQQVJDKQogICAgIGNvbnN0IFVDaGFyKiBzdHJpbmdD
aGFyYWN0ZXJzID0gc3RyaW5nLT5jaGFyYWN0ZXJzKCk7CiAgICAgZm9yICh1bnNpZ25lZCBpID0g
MDsgaSAhPSBsZW5ndGg7ICsraSkgewogICAgICAgICBpZiAoKnN0cmluZ0NoYXJhY3RlcnMrKyAh
PSAqY2hhcmFjdGVycysrKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>