57255 2011-03-28 11:45:52 -0700 [chromium] have DRT write the png checksum into a png comment 2011-03-28 16:49:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 56286 1 tony tony ojan tkent oldest_to_newest 374647 0 tony 2011-03-28 11:45:52 -0700 [chromium] have DRT write the png checksum into a png comment 374648 1 87175 tony 2011-03-28 11:46:49 -0700 Created attachment 87175 Patch 374649 2 tony 2011-03-28 11:48:38 -0700 There will be follow up changes for NRWT and the rebaseline tool. 374878 3 87175 abarth 2011-03-28 16:26:11 -0700 Comment on attachment 87175 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87175&action=review > Tools/DumpRenderTree/chromium/TestShell.cpp:561 > - static_cast<int>(sourceBitmap.rowBytes()), discardTransparency, &png); > + static_cast<int>(sourceBitmap.rowBytes()), discardTransparency, > + md5hash, &png); This should be on one line. 374894 4 tony 2011-03-28 16:49:18 -0700 Committed r82174: <http://trac.webkit.org/changeset/82174> 87175 2011-03-28 11:46:49 -0700 2011-03-28 16:26:11 -0700 Patch bug-57255-20110328114713.patch text/plain 2974 tony U3VidmVyc2lvbiBSZXZpc2lvbjogODIxMzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZDI0ZjAyNWUwNmJiMDlmNTY2ODAwZjhmMDY3N2Y4Y2I2OWU3YmYyYy4uYzgyY2QyZGQ4YmRkM2Ex NjZhMGUxODhkYTcyOWFlYWRjNGRiMTE1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMiBAQAorMjAxMS0wMy0yOCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJv bWl1bV0gaGF2ZSBEUlQgd3JpdGUgdGhlIHBuZyBjaGVja3N1bSBpbnRvIGEgcG5nIGNvbW1lbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MjU1CisK KyAgICAgICAgKiBERVBTOiBQdWxsIGluIHZlcnNpb24gb2YgY2hyb21pdW0gd2l0aCBjb21tZW50 IHdyaXRpbmcKKwogMjAxMS0wMy0yOCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQ6IGZpeGVkIGNocm9taXVtIGJ1aWxkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9ERVBTCmluZGV4IDcxZTQyMTgxMTEwM2IxMWEzNTRlZTJiOGI2MDMxZjNiYjRlYmMzODQu LmRiMjlmZjg4N2Y2OWI1MzI0ODU4MjNmMmFmOTFhM2FjMWE0NGMzMGYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RF UFMKQEAgLTMyLDcgKzMyLDcgQEAKIAogdmFycyA9IHsKICAgJ2Nocm9taXVtX3N2bic6ICdodHRw Oi8vc3JjLmNocm9taXVtLm9yZy9zdm4vdHJ1bmsvc3JjJywKLSAgJ2Nocm9taXVtX3Jldic6ICc3 OTM3OScKKyAgJ2Nocm9taXVtX3Jldic6ICc3OTU5MicKIH0KIAogZGVwcyA9IHsKZGlmZiAtLWdp dCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyOTkzZTZjNTEzOTVm NTg2MDBmZmFiZDk1NGYwOWE3YjA4MDBmY2UyLi5lOGMyYTZkY2ZmNTA5ZDlkNDc3Mjk1MTY5MDRl OTk0YzMxMjU5OGQ4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMjggIFRvbnkgQ2hhbmcgIDx0b255QGNo cm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbY2hyb21pdW1dIGhhdmUgRFJUIHdyaXRlIHRoZSBwbmcgY2hlY2tzdW0gaW50byBhIHBu ZyBjb21tZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NzI1NQorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNw cDoKKyAgICAgICAgKFRlc3RTaGVsbDo6ZHVtcEltYWdlKToKKwogMjAxMS0wMy0yOCAgQmVuamFt aW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9UZXN0U2hlbGwuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVz dFNoZWxsLmNwcAppbmRleCAwNTk5OGNjMDYzNGYwODlkMGUxNWZiNWI2YWVjMWViMTkyNDJiOTkz Li4zNDdmOGE0ZmEyMDk2MWE4ZGFjZWRhMDJmYTAxNDk0ZDU3NGNlNGNiIDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKQEAgLTU1MCwxNCArNTUwLDE1IEBA IHZvaWQgVGVzdFNoZWxsOjpkdW1wSW1hZ2Uoc2tpYTo6UGxhdGZvcm1DYW52YXMqIGNhbnZhcykg Y29uc3QKICAgICAgICAgbWQ1aGFzaC5hcHBlbmQoaGV4KTsKICAgICB9CiAKLSAgICAvLyBPbmx5 IGVuY29kZSBhbmQgZHVtcCB0aGUgcG5nIGlmIHRoZSBoYXNoZXMgZG9uJ3QgbWF0Y2guIEVuY29k aW5nIHRoZSBpbWFnZQotICAgIC8vIGlzIHJlYWxseSBleHBlbnNpdmUuCisgICAgLy8gT25seSBl bmNvZGUgYW5kIGR1bXAgdGhlIHBuZyBpZiB0aGUgaGFzaGVzIGRvbid0IG1hdGNoLiBFbmNvZGlu ZyB0aGUKKyAgICAvLyBpbWFnZSBpcyByZWFsbHkgZXhwZW5zaXZlLgogICAgIGlmIChtZDVoYXNo LmNvbXBhcmUobV9wYXJhbXMucGl4ZWxIYXNoKSkgewogICAgICAgICBzdGQ6OnZlY3Rvcjx1bnNp Z25lZCBjaGFyPiBwbmc7Ci0gICAgICAgIHdlYmtpdF9zdXBwb3J0OjpFbmNvZGVCR1JBUE5HKAor ICAgICAgICB3ZWJraXRfc3VwcG9ydDo6RW5jb2RlQkdSQVBOR1dpdGhDaGVja3N1bSgKICAgICAg ICAgICAgIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdW5zaWduZWQgY2hhcio+KHNvdXJjZUJpdG1h cC5nZXRQaXhlbHMoKSksCiAgICAgICAgICAgICBzb3VyY2VCaXRtYXAud2lkdGgoKSwgc291cmNl Qml0bWFwLmhlaWdodCgpLAotICAgICAgICAgICAgc3RhdGljX2Nhc3Q8aW50Pihzb3VyY2VCaXRt YXAucm93Qnl0ZXMoKSksIGRpc2NhcmRUcmFuc3BhcmVuY3ksICZwbmcpOworICAgICAgICAgICAg c3RhdGljX2Nhc3Q8aW50Pihzb3VyY2VCaXRtYXAucm93Qnl0ZXMoKSksIGRpc2NhcmRUcmFuc3Bh cmVuY3ksCisgICAgICAgICAgICBtZDVoYXNoLCAmcG5nKTsKIAogICAgICAgICBtX3ByaW50ZXIt PmhhbmRsZUltYWdlKG1kNWhhc2guY19zdHIoKSwgbV9wYXJhbXMucGl4ZWxIYXNoLmNfc3RyKCks ICZwbmdbMF0sIHBuZy5zaXplKCksIG1fcGFyYW1zLnBpeGVsRmlsZU5hbWUuY19zdHIoKSk7CiAg ICAgfSBlbHNlCg==