57252 2011-03-28 11:10:09 -0700 Web Inspector: Eliminate LayoutTests/inspector/styles/styles-add-blank-property.html flakiness 2011-03-29 09:06:05 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 374623 0 apavlov 2011-03-28 11:10:09 -0700 The test is flaky on several platforms (it plain fails for me on GTK) and it starts failing for all platforms (except Qt) once a patch for bug 56310 get landed. 374627 1 87169 apavlov 2011-03-28 11:17:46 -0700 Created attachment 87169 [PATCH] Suggested fix 374699 2 87169 bweinstein 2011-03-28 12:54:55 -0700 Comment on attachment 87169 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=87169&action=review > LayoutTests/ChangeLog:7 > + A sentence or two about what is causing the flakiness would be nice. 375400 3 apavlov 2011-03-29 09:06:05 -0700 The fix was landed as part of r82252 with a comment for the affected test in the ChangeLog. 87169 2011-03-28 11:17:46 -0700 2011-03-28 12:54:55 -0700 [PATCH] Suggested fix unflaky.patch text/plain 1851 apavlov Y29tbWl0IDExMzZiODg4MzY1NjdiY2Q0YmU2MDJkYTY5NzAwYmMxNmMxMzRkODkKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBNb24gTWFyIDI4 IDIyOjEzOjIyIDIwMTEgKzA0MDAKCiAgICBmaXgKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2IzMjQ5Yi4uYWQ2ODliMiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTAzLTI4ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRWxpbWluYXRlIExheW91dFRlc3RzL2luc3BlY3Rv ci9zdHlsZXMvc3R5bGVzLWFkZC1ibGFuay1wcm9wZXJ0eS5odG1sIGZsYWtpbmVzcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcyNTIKKworICAgICAg ICAqIGluc3BlY3Rvci9zdHlsZXMvc3R5bGVzLWFkZC1ibGFuay1wcm9wZXJ0eS5odG1sOgorCiAy MDExLTAzLTI4ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIGFkZGVkIG5ldyBHVEsrIHRlc3QgZXhwZWN0YXRpb25zLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtYWRkLWJsYW5rLXBy b3BlcnR5Lmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy1hZGQtYmxh bmstcHJvcGVydHkuaHRtbAppbmRleCAxYjMyZGM1Li4wYjM1ODZmIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy1hZGQtYmxhbmstcHJvcGVydHkuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy1hZGQtYmxhbmstcHJvcGVy dHkuaHRtbApAQCAtNywxOCArNywyMyBAQAogZnVuY3Rpb24gdGVzdCgpCiB7CiAgICAgV2ViSW5z cGVjdG9yLnNob3dQYW5lbCgiZWxlbWVudHMiKTsKLSAgICBJbnNwZWN0b3JUZXN0LnNlbGVjdE5v ZGVXaXRoSWQoImluc3BlY3RlZCIsIHN0ZXAxKTsKKyAgICBJbnNwZWN0b3JUZXN0LnNlbGVjdE5v ZGVXaXRoSWQoImluc3BlY3RlZCIsIHN0ZXAwKTsKIAorICAgIHZhciBzZWN0aW9uOwogICAgIHZh ciB0cmVlRWxlbWVudDsKIAotICAgIGZ1bmN0aW9uIHN0ZXAxKCkKKyAgICBmdW5jdGlvbiBzdGVw MCgpCiAgICAgewogICAgICAgICBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdCgiQmVmb3JlIGFwcGVu ZDoiKTsKICAgICAgICAgSW5zcGVjdG9yVGVzdC5kdW1wU2VsZWN0ZWRFbGVtZW50U3R5bGVzKHRy dWUpOwogCi0gICAgICAgIHZhciBzZWN0aW9uID0gV2ViSW5zcGVjdG9yLnBhbmVscy5lbGVtZW50 cy5zaWRlYmFyUGFuZXMuc3R5bGVzLnNlY3Rpb25zWzBdWzFdOworICAgICAgICBzZWN0aW9uID0g V2ViSW5zcGVjdG9yLnBhbmVscy5lbGVtZW50cy5zaWRlYmFyUGFuZXMuc3R5bGVzLnNlY3Rpb25z WzBdWzFdOwogICAgICAgICBzZWN0aW9uLmV4cGFuZCgpOworICAgICAgICBJbnNwZWN0b3JUZXN0 LnJ1bkFmdGVyUGVuZGluZ0Rpc3BhdGNoZXMoc3RlcDEpOworICAgIH0KIAorICAgIGZ1bmN0aW9u IHN0ZXAxKCkKKyAgICB7CiAgICAgICAgIC8vIENyZWF0ZSBhbmQgaW5jcmVtZW50LgogICAgICAg ICB0cmVlRWxlbWVudCA9IHNlY3Rpb24uYWRkTmV3QmxhbmtQcm9wZXJ0eSgpOwogICAgICAgICB0 cmVlRWxlbWVudC5zdGFydEVkaXRpbmcoKTsK