57241 2011-03-28 09:38:45 -0700 check-webkit-style: "using namespace foo;" should be flagged as an error in headers 2013-07-16 16:51:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ddkilzer webkit-unassigned brian.holt commit-queue dpranke glenn levin mrobinson rniwa skyul oldest_to_newest 374547 0 ddkilzer 2011-03-28 09:38:45 -0700 In Bug 57239, a "using namespace WebCore;" statement caused issues when compiling WebCore on iOS (even though the body of HTMLConverter.mm was commented out). Such "using namespace" statements are very dangerous in headers, so check-webkit-style should flag them as an error. I'm told that llvm (clang) may warn about "using namespace" statements in headers in the future, but since not all ports will be using llvm to compile WebKit, it would still be good to have this in check-webkit-style. 375471 1 levin 2011-03-29 10:22:19 -0700 fwiw, the code is here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py And I'm willing to give pointers (and reviews) to anyone who wants to add checks. 908821 2 206762 brian.holt 2013-07-16 04:38:50 -0700 Created attachment 206762 Patch 908849 3 206762 commit-queue 2013-07-16 06:04:23 -0700 Comment on attachment 206762 Patch Clearing flags on attachment: 206762 Committed r152719: <http://trac.webkit.org/changeset/152719> 908850 4 commit-queue 2013-07-16 06:04:28 -0700 All reviewed patches have been landed. Closing bug. 909065 5 skyul 2013-07-16 16:28:44 -0700 This patch is buggy. It seems check-webkit-style checks "using namespace" statements not only in headers but also in cpp files too. See https://bugs.webkit.org/show_bug.cgi?id=110136#c14 Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:45: Do not use 'using namespace WebCore;'. [build/using_namespace] [4] 909073 6 skyul 2013-07-16 16:51:47 -0700 (In reply to comment #5) > This patch is buggy. It seems check-webkit-style checks "using namespace" statements not only in headers but also in cpp files too. > > See https://bugs.webkit.org/show_bug.cgi?id=110136#c14 > Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:45: Do not use 'using namespace WebCore;'. [build/using_namespace] [4] I filed Bug 118755 to fix this. 206762 2013-07-16 04:38:50 -0700 2013-07-16 06:04:23 -0700 Patch bug-57241-20130716123847.patch text/plain 4242 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNjMxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2Y0MTk3ZDU0ZTYzNDRkMDU2NzA2OWZhNmFlZjJjMzQ5 Mjk4MmFiYi4uMDVlYmZkNmI4YTY1NmQzNzJjMDRhYWI1ZDFkODUyM2JjMGYyZDZjZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTA3LTE2ICBCcmlhbiBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6ICJ1c2luZyBuYW1lc3BhY2UgZm9vOyIgc2hvdWxk IGJlIGZsYWdnZWQgYXMgYW4gZXJyb3IgaW4gaGVhZGVycworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcyNDEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBjaGVjayBmb3IgInVzaW5nIG5hbWVzcGFj ZSBmb28iIGFuZCB1bml0IHRlc3QuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX3VzaW5nX25hbWVzcGFjZSk6CisgICAg ICAgIChjaGVja19zdHlsZSk6CisgICAgICAgIChDcHBDaGVja2VyKToKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKFdl YktpdFN0eWxlVGVzdC50ZXN0X3VzaW5nX25hbWVzcGFjZSk6CisKIDIwMTMtMDctMTUgIFhhYmll ciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RL XSBJbmNyZWFzZSB0aGUgSkhCdWlsZCB2ZXJzaW9uIG9mIEdTdHJlYW1lciB0byAxLjAuNwpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCBhZTJmMTUz ZjBkMTA2NjM4MDcwYjE3NzUwNmRhODU5YjBjNTk2OTlkLi44YmUzYmViYmQyMDE5YWQ0MDQ5MWI5 Njg4NWU5NmY5OTNjN2RmYjdlIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcC5weQpAQCAtMjE2MSw2ICsyMTYxLDMxIEBAIGRlZiBjaGVja191c2luZ19zdGQo Y2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcik6CiAgICAgICAgICAg IlVzZSAndXNpbmcgbmFtZXNwYWNlIHN0ZDsnIGluc3RlYWQgb2YgJ3VzaW5nIHN0ZDo6JXM7Jy4i ICUgbWV0aG9kX25hbWUpCiAKIAorZGVmIGNoZWNrX3VzaW5nX25hbWVzcGFjZShjbGVhbl9saW5l cywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKToKKyAgICAiIiJMb29rcyBmb3IgJ3Vz aW5nIG5hbWVzcGFjZSBmb287JyB3aGljaCBzaG91bGQgYmUgcmVtb3ZlZC4KKworICAgIEFyZ3M6 CisgICAgICBjbGVhbl9saW5lczogQSBDbGVhbnNlZExpbmVzIGluc3RhbmNlIGNvbnRhaW5pbmcg dGhlIGZpbGUuCisgICAgICBsaW5lX251bWJlcjogVGhlIG51bWJlciBvZiB0aGUgbGluZSB0byBj aGVjay4KKyAgICAgIGZpbGVfc3RhdGU6IEEgX0ZpbGVTdGF0ZSBpbnN0YW5jZSB3aGljaCBtYWlu dGFpbnMgaW5mb3JtYXRpb24gYWJvdXQKKyAgICAgICAgICAgICAgICAgIHRoZSBzdGF0ZSBvZiB0 aGluZ3MgaW4gdGhlIGZpbGUuCisgICAgICBlcnJvcjogVGhlIGZ1bmN0aW9uIHRvIGNhbGwgd2l0 aCBhbnkgZXJyb3JzIGZvdW5kLgorICAgICIiIgorCisgICAgIyBUaGlzIGNoZWNrIGRvZXNuJ3Qg YXBwbHkgdG8gQyBvciBPYmplY3RpdmUtQyBpbXBsZW1lbnRhdGlvbiBmaWxlcy4KKyAgICBpZiBm aWxlX3N0YXRlLmlzX2Nfb3Jfb2JqZWN0aXZlX2MoKToKKyAgICAgICAgcmV0dXJuCisKKyAgICBs aW5lID0gY2xlYW5fbGluZXMuZWxpZGVkW2xpbmVfbnVtYmVyXSAgIyBHZXQgcmlkIG9mIGNvbW1l bnRzIGFuZCBzdHJpbmdzLgorCisgICAgdXNpbmdfbmFtZXNwYWNlX21hdGNoID0gbWF0Y2gocidc cyp1c2luZ1xzK25hbWVzcGFjZVxzKyg/UDxtZXRob2RfbmFtZT5cUyspXHMqO1xzKiQnLCBsaW5l KQorICAgIGlmIG5vdCB1c2luZ19uYW1lc3BhY2VfbWF0Y2g6CisgICAgICAgIHJldHVybgorCisg ICAgbWV0aG9kX25hbWUgPSB1c2luZ19uYW1lc3BhY2VfbWF0Y2guZ3JvdXAoJ21ldGhvZF9uYW1l JykKKyAgICBlcnJvcihsaW5lX251bWJlciwgJ2J1aWxkL3VzaW5nX25hbWVzcGFjZScsIDQsCisg ICAgICAgICAgIkRvIG5vdCB1c2UgJ3VzaW5nIG5hbWVzcGFjZSAlczsnLiIgJSBtZXRob2RfbmFt ZSkKKwogZGVmIGNoZWNrX21heF9taW5fbWFjcm9zKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwg ZmlsZV9zdGF0ZSwgZXJyb3IpOgogICAgICIiIkxvb2tzIHVzZSBvZiBNQVgoKSBhbmQgTUlOKCkg bWFjcm9zIHRoYXQgc2hvdWxkIGJlIHJlcGxhY2VkIHdpdGggc3RkOjptYXgoKSBhbmQgc3RkOjpt aW4oKS4KIApAQCAtMjY0NSw2ICsyNjcwLDcgQEAgZGVmIGNoZWNrX3N0eWxlKGNsZWFuX2xpbmVz LCBsaW5lX251bWJlciwgZmlsZV9leHRlbnNpb24sIGNsYXNzX3N0YXRlLCBmaWxlX3N0YXQKICAg ICBjaGVja19uYW1lc3BhY2VfaW5kZW50YXRpb24oY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBm aWxlX2V4dGVuc2lvbiwgZmlsZV9zdGF0ZSwgZXJyb3IpCiAgICAgY2hlY2tfZGlyZWN0aXZlX2lu ZGVudGF0aW9uKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9zdGF0ZSwgZXJyb3IpCiAg ICAgY2hlY2tfdXNpbmdfc3RkKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9zdGF0ZSwg ZXJyb3IpCisgICAgY2hlY2tfdXNpbmdfbmFtZXNwYWNlKGNsZWFuX2xpbmVzLCBsaW5lX251bWJl ciwgZmlsZV9zdGF0ZSwgZXJyb3IpCiAgICAgY2hlY2tfbWF4X21pbl9tYWNyb3MoY2xlYW5fbGlu ZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcikKICAgICBjaGVja19jdHlwZV9mdW5j dGlvbnMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcikKICAgICBj aGVja19zd2l0Y2hfaW5kZW50YXRpb24oY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcikK QEAgLTM2MzAsNiArMzY1Niw3IEBAIGNsYXNzIENwcENoZWNrZXIob2JqZWN0KToKICAgICAgICAg J2J1aWxkL3ByaW50Zl9mb3JtYXQnLAogICAgICAgICAnYnVpbGQvc3RvcmFnZV9jbGFzcycsCiAg ICAgICAgICdidWlsZC91c2luZ19zdGQnLAorICAgICAgICAnYnVpbGQvdXNpbmdfbmFtZXNwYWNl JywKICAgICAgICAgJ2xlZ2FsL2NvcHlyaWdodCcsCiAgICAgICAgICdyZWFkYWJpbGl0eS9icmFj ZXMnLAogICAgICAgICAncmVhZGFiaWxpdHkvY2FzdGluZycsCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDFiZjk0 OTc5M2Q5YTczMGMxNGU4YjI4MTlkYjFkODJjZDMyN2I2MzMuLmUxMGJiZmVmYjZhOWVlN2ZiNDdi N2M2ZDE2ZDQzMWNmN2ZlZDA0OWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC00NDkwLDYgKzQ0OTAsMTMgQEAg Y2xhc3MgV2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgIiAg W2J1aWxkL3VzaW5nX3N0ZF0gWzRdIiwKICAgICAgICAgICAgICdmb28uY3BwJykKIAorICAgIGRl ZiB0ZXN0X3VzaW5nX25hbWVzcGFjZShzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgK KyAgICAgICAgICAgICd1c2luZyBuYW1lc3BhY2UgZm9vOycsCisgICAgICAgICAgICAiRG8gbm90 IHVzZSAndXNpbmcgbmFtZXNwYWNlIGZvbzsnLiIKKyAgICAgICAgICAgICIgIFtidWlsZC91c2lu Z19uYW1lc3BhY2VdIFs0XSIsCisgICAgICAgICAgICAnZm9vLmNwcCcpCisKICAgICBkZWYgdGVz dF9tYXhfbWFjcm8oc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAgICAg ICAnaW50IGkgPSBNQVgoMCwgMSk7JywK