57239 2011-03-28 09:26:43 -0700 Use forward class declaration instead of including header 2011-03-28 10:41:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer abarth enrica eric mitz webkit.review.bot oldest_to_newest 374539 0 87153 ddkilzer 2011-03-28 09:26:43 -0700 Created attachment 87153 Patch Reviewed by NOBODY (OOPS!). Adding a "using namespace WebCore;" statement in a header may cause issues when <WebCore/Length.h> is included before <CoreText/CoreText.h>. Length.h defines the LengthType enum with a 'Fixed' value. CoreText.h includes MacTypes.h, which has a "typedef SInt32 Fixed;" statement, and then CoreText.h includes other headers that also use 'Fixed', but expect the typedef to be defined, not the enum. If another header includes "using namespace WebCore;" before CoreText.h, the following compiler errors result (paths abbreviated): CoreText.framework/Headers/SFNTLayoutTypes.h:689: error: reference to 'Fixed' is ambiguous MacTypes.h:184: error: candidates are: typedef SInt32 Fixed Length.h:37: error: WebCore::LengthType WebCore::Fixed SFNTLayoutTypes.h:689: error: 'Fixed' does not name a type * platform/mac/HTMLConverter.h: Use forward declaration of DocumentLoader class instead of including header. Remove the unused "using namespace WebCore;" statement. --- 2 files changed, 31 insertions(+), 3 deletions(-) 374544 1 webkit.review.bot 2011-03-28 09:29:46 -0700 Attachment 87153 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 374550 2 ddkilzer 2011-03-28 09:42:04 -0700 I filed Bug 57241 about check-webkit-style flagging "using namespace Foo;" statements in headers. 374551 3 ddkilzer 2011-03-28 09:42:26 -0700 <rdar://problem/9192997> 374563 4 ddkilzer 2011-03-28 09:55:36 -0700 (In reply to comment #1) > Attachment 87153 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > > Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Total errors found: 1 in 2 files > > If any of these errors are false positives, please file a bug against check-webkit-style. I want webkit-patch to support a placeholder for the bug number. I filed: Bug 57242. 374572 5 ddkilzer 2011-03-28 10:08:27 -0700 Committed r82128: <http://trac.webkit.org/changeset/82128> 374596 6 webkit.review.bot 2011-03-28 10:41:47 -0700 http://trac.webkit.org/changeset/82128 might have broken Leopard Intel Debug (Tests) 87153 2011-03-28 09:26:43 -0700 2011-03-28 09:29:19 -0700 Patch 20110328092642.patch text/plain 2612 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogODIxMTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkYTE5ZjYzY2E2ZDY4ZTVi YTcyNDYxM2E1OWNmZDQ4NjcyNDdmODdkLi5kY2E3ZmEzMzIyOWY5YzFjMjhmNjVhMWJkODc3NjZm ZDZjZGY5MTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTEtMDMtMjggIERhdmlk IEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgZm9yd2FyZCBjbGFz cyBkZWNsYXJhdGlvbiBpbnN0ZWFkIG9mIGluY2x1ZGluZyBoZWFkZXIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgYSAidXNpbmcgbmFtZXNw YWNlIFdlYkNvcmU7IiBzdGF0ZW1lbnQgaW4gYSBoZWFkZXIgbWF5CisgICAgICAgIGNhdXNlIGlz c3VlcyB3aGVuIDxXZWJDb3JlL0xlbmd0aC5oPiBpcyBpbmNsdWRlZCBiZWZvcmUKKyAgICAgICAg PENvcmVUZXh0L0NvcmVUZXh0Lmg+LgorCisgICAgICAgIExlbmd0aC5oIGRlZmluZXMgdGhlIExl bmd0aFR5cGUgZW51bSB3aXRoIGEgJ0ZpeGVkJyB2YWx1ZS4KKyAgICAgICAgQ29yZVRleHQuaCBp bmNsdWRlcyBNYWNUeXBlcy5oLCB3aGljaCBoYXMgYQorICAgICAgICAidHlwZWRlZiBTSW50MzIg Rml4ZWQ7IiBzdGF0ZW1lbnQsIGFuZCB0aGVuIENvcmVUZXh0LmggaW5jbHVkZXMKKyAgICAgICAg b3RoZXIgaGVhZGVycyB0aGF0IGFsc28gdXNlICdGaXhlZCcsIGJ1dCBleHBlY3QgdGhlIHR5cGVk ZWYgdG8KKyAgICAgICAgYmUgZGVmaW5lZCwgbm90IHRoZSBlbnVtLiAgSWYgYW5vdGhlciBoZWFk ZXIgaW5jbHVkZXMKKyAgICAgICAgInVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOyIgYmVmb3JlIENv cmVUZXh0LmgsIHRoZQorICAgICAgICBmb2xsb3dpbmcgY29tcGlsZXIgZXJyb3JzIHJlc3VsdCAo cGF0aHMgYWJicmV2aWF0ZWQpOgorCisgICAgICAgICAgICBDb3JlVGV4dC5mcmFtZXdvcmsvSGVh ZGVycy9TRk5UTGF5b3V0VHlwZXMuaDo2ODk6IGVycm9yOiByZWZlcmVuY2UgdG8gJ0ZpeGVkJyBp cyBhbWJpZ3VvdXMKKyAgICAgICAgICAgIE1hY1R5cGVzLmg6MTg0OiBlcnJvcjogY2FuZGlkYXRl cyBhcmU6IHR5cGVkZWYgU0ludDMyIEZpeGVkCisgICAgICAgICAgICBMZW5ndGguaDozNzogZXJy b3I6ICAgICAgICAgICAgICAgICBXZWJDb3JlOjpMZW5ndGhUeXBlIFdlYkNvcmU6OkZpeGVkCisg ICAgICAgICAgICBTRk5UTGF5b3V0VHlwZXMuaDo2ODk6IGVycm9yOiAnRml4ZWQnIGRvZXMgbm90 IG5hbWUgYSB0eXBlCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvSFRNTENvbnZlcnRlci5oOiBV c2UgZm9yd2FyZCBkZWNsYXJhdGlvbiBvZgorICAgICAgICBEb2N1bWVudExvYWRlciBjbGFzcyBp bnN0ZWFkIG9mIGluY2x1ZGluZyBoZWFkZXIuICBSZW1vdmUgdGhlCisgICAgICAgIHVudXNlZCAi dXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7IiBzdGF0ZW1lbnQuCisKIDIwMTEtMDMtMjggIE1pa2hh aWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L0hUTUxDb252ZXJ0ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9IVE1MQ29udmVy dGVyLmgKaW5kZXggM2Y2NTQ4NjQwNjEyNmQwYmNjZmRjZjQ2NWNiYjk5ZWUyZGIzNzBjMi4uNjQ1 YzFkNzgyMWQ0NjdkODZjMjg1MWE5M2Q4ZThlZjViNWI1MGYxYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL0hUTUxDb252ZXJ0ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvSFRNTENvbnZlcnRlci5oCkBAIC0yMywxMiArMjMsMTMgQEAKICAqIFRI RSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCi0jaW1wb3J0ICJEb2N1bWVudExv YWRlci5oIgogI2ltcG9ydCAiRE9NLmgiCiAjaW1wb3J0ICJET01Eb2N1bWVudC5oIgogI2ltcG9y dCAiRE9NUmFuZ2UuaCIKIAotdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CituYW1lc3BhY2UgV2Vi Q29yZSB7CitjbGFzcyBEb2N1bWVudExvYWRlcjsKK30KIAogQGludGVyZmFjZSBXZWJIVE1MQ29u dmVydGVyIDogTlNPYmplY3QgewogICAgIE5TTXV0YWJsZUF0dHJpYnV0ZWRTdHJpbmcgKl9hdHRy U3RyOwpAQCAtMzYsNyArMzcsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKICAgICBET01E b2N1bWVudCAqX2RvY3VtZW50OwogICAgIERPTVJhbmdlICpfZG9tUmFuZ2U7CiAgICAgTlNNdXRh YmxlQXJyYXkgKl9kb21TdGFydEFuY2VzdG9yczsKLSAgICBEb2N1bWVudExvYWRlciAqX2RhdGFT b3VyY2U7CisgICAgV2ViQ29yZTo6RG9jdW1lbnRMb2FkZXIgKl9kYXRhU291cmNlOwogICAgIE5T U3RyaW5nICpfc3RhbmRhcmRGb250RmFtaWx5OwogICAgIENHRmxvYXQgX3RleHRTaXplTXVsdGlw bGllcjsKICAgICBDR0Zsb2F0IF93ZWJWaWV3VGV4dFNpemVNdWx0aXBsaWVyOwo=