57235 2011-03-28 08:10:06 -0700 Web Inspector: [Chromium] Fix detailed heap snapshots UI 2011-03-29 05:34:51 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 374495 0 mnaganov 2011-03-28 08:10:06 -0700 Fix two problems: 1. Text color of grid cells under selection needs to be white, otherwise it's unreadable for some colors; 2. Long strings need to be truncated in grid, their contents can be shown on hover. 374497 1 87146 mnaganov 2011-03-28 08:13:04 -0700 Created attachment 87146 patch 375188 2 mnaganov 2011-03-29 04:35:56 -0700 Manually committed http://trac.webkit.org/changeset/82229 2011-03-29 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: [Chromium] Fix detailed heap snapshots UI. https://bugs.webkit.org/show_bug.cgi?id=57235 Fix two problems: 1. Text color of grid cells under selection needs to be white, otherwise it's unreadable for some colors; 2. Long strings need to be truncated in grid, their contents can be shown on hover. * inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup): * inspector/front-end/heapProfiler.css: (.detailed-heapshot-view .console-formatted-string): (.detailed-heapshot-view .data-grid tr.selected *): (.detailed-heapshot-view .data-grid:focus tr.selected *): 375213 3 webkit.review.bot 2011-03-29 05:34:51 -0700 http://trac.webkit.org/changeset/82229 might have broken GTK Linux 64-bit Debug The following tests are not passing: svg/text/text-deco-01-b.svg 87146 2011-03-28 08:13:04 -0700 2011-03-29 04:14:54 -0700 patch patch-57235 text/plain 4161 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNGY5MjI4Li5mMTEyZDkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDMtMjggIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ2hyb21pdW1dIEZpeCBkZXRhaWxlZCBoZWFwIHNuYXBzaG90cyBVSS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MjM1CisKKyAgICAg ICAgRml4IHR3byBwcm9ibGVtczoKKyAgICAgICAgICAxLiBUZXh0IGNvbG9yIG9mIGdyaWQgY2Vs bHMgdW5kZXIgc2VsZWN0aW9uIG5lZWRzIHRvIGJlIHdoaXRlLCBvdGhlcndpc2UgaXQncyB1bnJl YWRhYmxlIGZvciBzb21lIGNvbG9yczsKKyAgICAgICAgICAyLiBMb25nIHN0cmluZ3MgbmVlZCB0 byBiZSB0cnVuY2F0ZWQgaW4gZ3JpZCwgdGhlaXIgY29udGVudHMgY2FuIGJlIHNob3duIG9uIGhv dmVyLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmll dy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EZXRhaWxlZEhlYXBzaG90Vmlldy5wcm90b3R5 cGUuX2dldEhvdmVyQW5jaG9yKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EZXRhaWxlZEhlYXBz aG90Vmlldy5wcm90b3R5cGUuX3Nob3dTdHJpbmdDb250ZW50UG9wdXApOgorICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvaGVhcFByb2ZpbGVyLmNzczoKKyAgICAgICAgKC5kZXRhaWxlZC1o ZWFwc2hvdC12aWV3IC5jb25zb2xlLWZvcm1hdHRlZC1zdHJpbmcpOgorICAgICAgICAoLmRldGFp bGVkLWhlYXBzaG90LXZpZXcgLmRhdGEtZ3JpZCB0ci5zZWxlY3RlZCAqKToKKyAgICAgICAgKC5k ZXRhaWxlZC1oZWFwc2hvdC12aWV3IC5kYXRhLWdyaWQ6Zm9jdXMgdHIuc2VsZWN0ZWQgKik6CisK IDIwMTEtMDMtMjcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGV0YWlsZWRIZWFwc2hvdFZpZXcuanMgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RldGFpbGVkSGVhcHNob3RWaWV3LmpzCmlu ZGV4IDU0NTU0YmIuLjVjNTZmMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRGV0YWlsZWRIZWFwc2hvdFZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmlldy5qcwpAQCAtNDUwLDYgKzQ1 MCw4IEBAIFdlYkluc3BlY3Rvci5EZXRhaWxlZEhlYXBzaG90VmlldyA9IGZ1bmN0aW9uKHBhcmVu dCwgcHJvZmlsZSkKICAgICB0aGlzLmhlbHBCdXR0b24gPSBuZXcgV2ViSW5zcGVjdG9yLlN0YXR1 c0JhckJ1dHRvbigiIiwgImhlYXBzaG90LWhlbHAtc3RhdHVzLWJhci1pdGVtIHN0YXR1cy1iYXIt aXRlbSIpOwogICAgIHRoaXMuaGVscEJ1dHRvbi5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRo aXMuX2hlbHBDbGlja2VkLmJpbmQodGhpcyksIGZhbHNlKTsKIAorICAgIHZhciBwb3BvdmVySGVs cGVyID0gbmV3IFdlYkluc3BlY3Rvci5Qb3BvdmVySGVscGVyKHRoaXMuZWxlbWVudCwgdGhpcy5f Z2V0SG92ZXJBbmNob3IuYmluZCh0aGlzKSwgdGhpcy5fc2hvd1N0cmluZ0NvbnRlbnRQb3B1cC5i aW5kKHRoaXMpKTsKKwogICAgIHRoaXMuX2xvYWRQcm9maWxlKHRoaXMuX3Byb2ZpbGVVaWQsIHBy b2ZpbGVDYWxsYmFjay5iaW5kKHRoaXMpKTsKIAogICAgIGZ1bmN0aW9uIHByb2ZpbGVDYWxsYmFj ayhwcm9maWxlKQpAQCAtODM1LDYgKzgzNywyMSBAQCBXZWJJbnNwZWN0b3IuRGV0YWlsZWRIZWFw c2hvdFZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLnJldGFpbm1lbnREYXRhR3JpZC5y ZWZyZXNoKCk7CiAgICAgfSwKIAorICAgIF9nZXRIb3ZlckFuY2hvcjogZnVuY3Rpb24odGFyZ2V0 KQorICAgIHsKKyAgICAgICAgdmFyIHNwYW4gPSB0YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldp dGhOb2RlTmFtZSgic3BhbiIpOworICAgICAgICBpZiAoIXNwYW4gfHwgIXNwYW4uaGFzU3R5bGVD bGFzcygiY29uc29sZS1mb3JtYXR0ZWQtc3RyaW5nIikpCisgICAgICAgICAgICByZXR1cm47Cisg ICAgICAgIHZhciByb3cgPSB0YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhOb2RlTmFtZSgi dHIiKTsKKyAgICAgICAgaWYgKCFyb3cpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIHZh ciBncmlkTm9kZSA9IHJvdy5fZGF0YUdyaWROb2RlOworICAgICAgICBpZiAoIWdyaWROb2RlLnNu YXBzaG90Tm9kZUluZGV4KQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBzcGFuLnNuYXBz aG90Tm9kZUluZGV4ID0gZ3JpZE5vZGUuc25hcHNob3ROb2RlSW5kZXg7CisgICAgICAgIHJldHVy biBzcGFuOworICAgIH0sCisKICAgICBnZXQgaXNUcmFjaW5nVG9XaW5kb3dPYmplY3RzKCkKICAg ICB7CiAgICAgICAgIHJldHVybiB0aGlzLnJldGFpbmluZ1BhdGhzUm9vdC5zZWxlY3RlZEluZGV4 ID09PSAxOwpAQCAtODU0LDYgKzg3MSwxOCBAQCBXZWJJbnNwZWN0b3IuRGV0YWlsZWRIZWFwc2hv dFZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLnJlZnJlc2hTaG93QXNQZXJjZW50cygp OwogICAgIH0sCiAKKyAgICBfc2hvd1N0cmluZ0NvbnRlbnRQb3B1cDogZnVuY3Rpb24oc3BhbikK KyAgICB7CisgICAgICAgIHZhciBzbmFwc2hvdE5vZGUgPSBuZXcgV2ViSW5zcGVjdG9yLkhlYXBT bmFwc2hvdE5vZGUodGhpcy5wcm9maWxlV3JhcHBlciwgc3Bhbi5zbmFwc2hvdE5vZGVJbmRleCk7 CisgICAgICAgIHZhciBzdHJpbmdDb250ZW50RWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoInNwYW4iKTsKKyAgICAgICAgc3RyaW5nQ29udGVudEVsZW1lbnQuY2xhc3NOYW1lID0gIm1v bm9zcGFjZSBjb25zb2xlLWZvcm1hdHRlZC1zdHJpbmciOworICAgICAgICBzdHJpbmdDb250ZW50 RWxlbWVudC5zdHlsZS53aGl0ZVNwYWNlID0gInByZSI7CisgICAgICAgIHN0cmluZ0NvbnRlbnRF bGVtZW50LnRleHRDb250ZW50ID0gIlwiIiArIHNuYXBzaG90Tm9kZS5uYW1lICsgIlwiIjsKKyAg ICAgICAgdmFyIHBvcG92ZXIgPSBuZXcgV2ViSW5zcGVjdG9yLlBvcG92ZXIoc3RyaW5nQ29udGVu dEVsZW1lbnQpOworICAgICAgICBwb3BvdmVyLnNob3coc3Bhbik7CisgICAgICAgIHJldHVybiBw b3BvdmVyOworICAgIH0sCisKICAgICBfaGVscENsaWNrZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAg IHsKICAgICAgICAgaWYgKCF0aGlzLmhlbHBQb3BvdmVyKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2hlYXBQcm9maWxlci5jc3MgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2hlYXBQcm9maWxlci5jc3MKaW5kZXggZmI4NDg1ZC4u Y2VlYWZjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9o ZWFwUHJvZmlsZXIuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv aGVhcFByb2ZpbGVyLmNzcwpAQCAtMjA3LDYgKzIwNywxOCBAQAogICAgIHBvc2l0aW9uOiBzdGF0 aWM7CiB9CiAKKy5kZXRhaWxlZC1oZWFwc2hvdC12aWV3IC5jb25zb2xlLWZvcm1hdHRlZC1zdHJp bmcgeworICAgIHdoaXRlLXNwYWNlOiBub3dyYXA7Cit9CisKKy5kZXRhaWxlZC1oZWFwc2hvdC12 aWV3IC5kYXRhLWdyaWQgdHIuc2VsZWN0ZWQgKiB7CisgICAgY29sb3I6IGluaGVyaXQ7Cit9CisK Ky5kZXRhaWxlZC1oZWFwc2hvdC12aWV3IC5kYXRhLWdyaWQ6Zm9jdXMgdHIuc2VsZWN0ZWQgKiB7 CisgICAgY29sb3I6IHdoaXRlOworfQorCiAuZGV0YWlsZWQtaGVhcHNob3QtdmlldyAuZGVsaW1p dGVyIHsKICAgICBoZWlnaHQ6IDI0cHg7CiAgICAgYmFja2dyb3VuZC1jb2xvcjogI2Q2ZGRlNTsK