57234 2011-03-28 07:57:07 -0700 [GTK] Use glib API instead of fork + execl in ProcessLauncherGtk 2011-04-08 03:07:12 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 49791 57540 1 cgarcia webkit-unassigned alex mrobinson oldest_to_newest 374491 0 cgarcia 2011-03-28 07:57:07 -0700 The code will be simpler and easier to maintain. 374493 1 87144 cgarcia 2011-03-28 08:02:08 -0700 Created attachment 87144 Patch 377029 2 87688 cgarcia 2011-03-31 03:24:07 -0700 Created attachment 87688 Updated patch I have updated the patch to call prctl(PR_SET_PDEATHSIG, SIGKILL), (Linux only) to kill the child process when the parent dies like the qt port does. 377261 3 87688 mrobinson 2011-03-31 09:52:49 -0700 Comment on attachment 87688 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=87688&action=review Great stuff. > Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:48 > +static void childSetupFunc(gpointer userData) Perhaps rename this to childSetupFunction or childSetupCallback. 382114 4 cgarcia 2011-04-08 03:06:47 -0700 Committed r83277: <http://trac.webkit.org/changeset/83277> 87144 2011-03-28 08:02:08 -0700 2011-03-31 03:24:07 -0700 Patch process-launcher.diff text/plain 3509 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NjMxY2NjLi40ZGI4OGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDMtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IFVzZSBnbGliIEFQSSBpbnN0ZWFkIG9mIGZvcmsgKyBleGVjbCBpbiBQcm9jZXNzTGF1bmNoZXJH dGsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MjM0 CisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5j cHA6CisgICAgICAgIChXZWJLaXQ6OmNoaWxkU2V0dXBGdW5jKToKKyAgICAgICAgKFdlYktpdDo6 UHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKToKKwogMjAxMS0wMy0yNyAgQW5keSBFc3Rl cyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNo b3dpYWsuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvZ3Rr L1Byb2Nlc3NMYXVuY2hlckd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNo ZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5jcHAKaW5kZXggMDRkOGEwMy4uMTU3YjE4YSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL2d0ay9Qcm9jZXNzTGF1 bmNoZXJHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9ndGsv UHJvY2Vzc0xhdW5jaGVyR3RrLmNwcApAQCAtMzIsOCArMzIsNiBAQAogI2luY2x1ZGUgPFdlYkNv cmUvRmlsZVN5c3RlbS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VIYW5kbGUuaD4KICNp bmNsdWRlIDxlcnJuby5oPgotI2luY2x1ZGUgPHN0ZGlvLmg+Ci0jaW5jbHVkZSA8dW5pc3RkLmg+ CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0 cmluZy5oPgogI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dPd25QdHIuaD4KQEAgLTQ0LDMyICs0Miw0 MCBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogY29uc3QgY2hhciogZ1dlYktpdFdlYlByb2Nlc3NO YW1lID0gIldlYktpdFdlYlByb2Nlc3MiOwogCitzdGF0aWMgdm9pZCBjaGlsZFNldHVwRnVuYyhn cG9pbnRlciB1c2VyRGF0YSkKK3sKKyAgICBpbnQgc29ja2V0ID0gR1BPSU5URVJfVE9fSU5UKHVz ZXJEYXRhKTsKKyAgICBjbG9zZShzb2NrZXQpOworfQorCiB2b2lkIFByb2Nlc3NMYXVuY2hlcjo6 bGF1bmNoUHJvY2VzcygpCiB7Ci0gICAgcGlkX3QgcGlkID0gMDsKKyAgICBHUGlkIHBpZCA9IDA7 CiAKICAgICBpbnQgc29ja2V0c1syXTsKLSAgICBpZiAoc29ja2V0cGFpcihBRl9VTklYLCBTT0NL X1NUUkVBTSwgMCwgc29ja2V0cykgPCAwKSB7Ci0gICAgICAgIGZwcmludGYoc3RkZXJyLCAiQ3Jl YXRpb24gb2Ygc29ja2V0IGZhaWxlZCB3aXRoIGVycm5vICVkLlxuIiwgZXJybm8pOworICAgIGlm IChzb2NrZXRwYWlyKEFGX1VOSVgsIFNPQ0tfREdSQU0sIDAsIHNvY2tldHMpIDwgMCkgeworICAg ICAgICBnX3ByaW50ZXJyKCJDcmVhdGlvbiBvZiBzb2NrZXQgZmFpbGVkOiAlcy5cbiIsIGdfc3Ry ZXJyb3IoZXJybm8pKTsKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgIHJl dHVybjsKICAgICB9CiAKLSAgICBwaWQgPSBmb3JrKCk7Ci0gICAgaWYgKCFwaWQpIHsgLy8gY2hp bGQgcHJvY2VzcwotICAgICAgICBjbG9zZShzb2NrZXRzWzFdKTsKLSAgICAgICAgU3RyaW5nIHNv Y2tldCA9IFN0cmluZzo6Zm9ybWF0KCIlZCIsIHNvY2tldHNbMF0pOwotICAgICAgICBHT3duUHRy PGdjaGFyPiBiaW5hcnlQYXRoKGdfYnVpbGRfZmlsZW5hbWUoYXBwbGljYXRpb25EaXJlY3RvcnlQ YXRoKCkuZGF0YSgpLCBnV2ViS2l0V2ViUHJvY2Vzc05hbWUsIE5VTEwpKTsKLSAgICAgICAgZXhl Y2woYmluYXJ5UGF0aC5nZXQoKSwgZ1dlYktpdFdlYlByb2Nlc3NOYW1lLCBzb2NrZXQudXRmOCgp LmRhdGEoKSwgTlVMTCk7Ci0gICAgfSBlbHNlIGlmIChwaWQgPiAwKSB7IC8vIHBhcmVudCBwcm9j ZXNzCi0gICAgICAgIGNsb3NlKHNvY2tldHNbMF0pOwotICAgICAgICBtX3Byb2Nlc3NJZGVudGlm aWVyID0gcGlkOwotICAgICAgICAvLyBXZSd2ZSBmaW5pc2hlZCBsYXVuY2hpbmcgdGhlIHByb2Nl c3MsIG1lc3NhZ2UgYmFjayB0byB0aGUgbWFpbiBydW4gbG9vcC4KLSAgICAgICAgUnVuTG9vcDo6 bWFpbigpLT5zY2hlZHVsZVdvcmsoV29ya0l0ZW06OmNyZWF0ZSh0aGlzLCAmUHJvY2Vzc0xhdW5j aGVyOjpkaWRGaW5pc2hMYXVuY2hpbmdQcm9jZXNzLCBwaWQsIHNvY2tldHNbMV0pKTsKLSAgICB9 IGVsc2UgewotICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIlVuYWJsZSB0byBmb3JrIGEgbmV3IFdl YlByb2Nlc3Mgd2l0aCBlcnJubzogJWQuXG4iLCBlcnJubyk7CisgICAgR093blB0cjxnY2hhcj4g YmluYXJ5UGF0aChnX2J1aWxkX2ZpbGVuYW1lKGFwcGxpY2F0aW9uRGlyZWN0b3J5UGF0aCgpLmRh dGEoKSwgZ1dlYktpdFdlYlByb2Nlc3NOYW1lLCBOVUxMKSk7CisgICAgR093blB0cjxnY2hhcj4g c29ja2V0KGdfc3RyZHVwX3ByaW50ZigiJWQiLCBzb2NrZXRzWzBdKSk7CisgICAgY2hhciogYXJn dlszXTsKKyAgICBhcmd2WzBdID0gYmluYXJ5UGF0aC5nZXQoKTsKKyAgICBhcmd2WzFdID0gc29j a2V0LmdldCgpOworICAgIGFyZ3ZbMl0gPSAwOworCisgICAgR093blB0cjxHRXJyb3I+IGVycm9y OworICAgIGlmICghZ19zcGF3bl9hc3luYygwLCBhcmd2LCAwLCBHX1NQQVdOX0xFQVZFX0RFU0NS SVBUT1JTX09QRU4sIGNoaWxkU2V0dXBGdW5jLCBHSU5UX1RPX1BPSU5URVIoc29ja2V0c1sxXSks ICZwaWQsICZlcnJvci5vdXRQdHIoKSkpIHsKKyAgICAgICAgZ19wcmludGVycigiVW5hYmxlIHRv IGZvcmsgYSBuZXcgV2ViUHJvY2VzczogJXMuXG4iLCBlcnJvci0+bWVzc2FnZSk7CiAgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KKworICAgIGNsb3NlKHNvY2tldHNbMF0pOwor ICAgIG1fcHJvY2Vzc0lkZW50aWZpZXIgPSBzdGF0aWNfY2FzdDxwaWRfdD4ocGlkKTsKKyAgICAv LyBXZSd2ZSBmaW5pc2hlZCBsYXVuY2hpbmcgdGhlIHByb2Nlc3MsIG1lc3NhZ2UgYmFjayB0byB0 aGUgbWFpbiBydW4gbG9vcC4KKyAgICBSdW5Mb29wOjptYWluKCktPnNjaGVkdWxlV29yayhXb3Jr SXRlbTo6Y3JlYXRlKHRoaXMsICZQcm9jZXNzTGF1bmNoZXI6OmRpZEZpbmlzaExhdW5jaGluZ1By b2Nlc3MsIG1fcHJvY2Vzc0lkZW50aWZpZXIsIHNvY2tldHNbMV0pKTsKIH0KIAogdm9pZCBQcm9j ZXNzTGF1bmNoZXI6OnRlcm1pbmF0ZVByb2Nlc3MoKQo= 87688 2011-03-31 03:24:07 -0700 2011-04-08 03:07:12 -0700 Updated patch proccess-launch-glib.diff text/plain 3875 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5Zjc2ODI0Li42MjQwZjY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDMtMzEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IFVzZSBnbGliIEFQSSBpbnN0ZWFkIG9mIGZvcmsgKyBleGVjbCBpbiBQcm9jZXNzTGF1bmNoZXJH dGsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MjM0 CisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5j cHA6CisgICAgICAgIChXZWJLaXQ6OmNoaWxkU2V0dXBGdW5jKTogY2xvc2UgdGhlIHNvY2tldCBh bmQgdXNlIHByY3RsKCkgd2hlbgorICAgICAgICBwbGF0Zm9ybSBpcyBMaW51eCB0byBraWxsIHRo ZSBjaGlsZCBwcm9jZXNzIHdoZW4gdGhlIHBhcmVudAorICAgICAgICBmaW5pc2hlcy4KKyAgICAg ICAgKFdlYktpdDo6UHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKTogVXNlIGdfc3Bhd25f YXN5bmMoKSB0bworICAgICAgICBsYXVuY2ggdGhlIHdlYiBwcm9jZXNzLgorCiAyMDExLTAzLTMw ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv TGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5jcHAKaW5kZXggYTliYTFjMS4u ZWVlYWIyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL2d0 ay9Qcm9jZXNzTGF1bmNoZXJHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9M YXVuY2hlci9ndGsvUHJvY2Vzc0xhdW5jaGVyR3RrLmNwcApAQCAtMzIsOCArMzIsOSBAQAogI2lu Y2x1ZGUgPFdlYkNvcmUvRmlsZVN5c3RlbS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VI YW5kbGUuaD4KICNpbmNsdWRlIDxlcnJuby5oPgotI2luY2x1ZGUgPHN0ZGlvLmg+Ci0jaW5jbHVk ZSA8dW5pc3RkLmg+CisjaWYgT1MoTElOVVgpCisjaW5jbHVkZSA8c3lzL3ByY3RsLmg+CisjZW5k aWYKICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RG U3RyaW5nLmg+CiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR093blB0ci5oPgpAQCAtNDQsMzIgKzQ1 LDQ2IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiBjb25zdCBjaGFyKiBnV2ViS2l0V2ViUHJvY2Vz c05hbWUgPSAiV2ViS2l0V2ViUHJvY2VzcyI7CiAKK3N0YXRpYyB2b2lkIGNoaWxkU2V0dXBGdW5j KGdwb2ludGVyIHVzZXJEYXRhKQoreworICAgIGludCBzb2NrZXQgPSBHUE9JTlRFUl9UT19JTlQo dXNlckRhdGEpOworICAgIGNsb3NlKHNvY2tldCk7CisKKyNpZiBPUyhMSU5VWCkKKyAgICAvLyBL aWxsIGNoaWxkIHByb2Nlc3Mgd2hlbiBwYXJlbnQgZGllcy4KKyAgICBwcmN0bChQUl9TRVRfUERF QVRIU0lHLCBTSUdLSUxMKTsKKyNlbmRpZgorfQorCiB2b2lkIFByb2Nlc3NMYXVuY2hlcjo6bGF1 bmNoUHJvY2VzcygpCiB7Ci0gICAgcGlkX3QgcGlkID0gMDsKKyAgICBHUGlkIHBpZCA9IDA7CiAK ICAgICBpbnQgc29ja2V0c1syXTsKICAgICBpZiAoc29ja2V0cGFpcihBRl9VTklYLCBTT0NLX0RH UkFNLCAwLCBzb2NrZXRzKSA8IDApIHsKLSAgICAgICAgZnByaW50ZihzdGRlcnIsICJDcmVhdGlv biBvZiBzb2NrZXQgZmFpbGVkIHdpdGggZXJybm8gJWQuXG4iLCBlcnJubyk7CisgICAgICAgIGdf cHJpbnRlcnIoIkNyZWF0aW9uIG9mIHNvY2tldCBmYWlsZWQ6ICVzLlxuIiwgZ19zdHJlcnJvcihl cnJubykpOwogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgcmV0dXJuOwog ICAgIH0KIAotICAgIHBpZCA9IGZvcmsoKTsKLSAgICBpZiAoIXBpZCkgeyAvLyBjaGlsZCBwcm9j ZXNzCi0gICAgICAgIGNsb3NlKHNvY2tldHNbMV0pOwotICAgICAgICBTdHJpbmcgc29ja2V0ID0g U3RyaW5nOjpmb3JtYXQoIiVkIiwgc29ja2V0c1swXSk7Ci0gICAgICAgIEdPd25QdHI8Z2NoYXI+ IGJpbmFyeVBhdGgoZ19idWlsZF9maWxlbmFtZShhcHBsaWNhdGlvbkRpcmVjdG9yeVBhdGgoKS5k YXRhKCksIGdXZWJLaXRXZWJQcm9jZXNzTmFtZSwgTlVMTCkpOwotICAgICAgICBleGVjbChiaW5h cnlQYXRoLmdldCgpLCBnV2ViS2l0V2ViUHJvY2Vzc05hbWUsIHNvY2tldC51dGY4KCkuZGF0YSgp LCBOVUxMKTsKLSAgICB9IGVsc2UgaWYgKHBpZCA+IDApIHsgLy8gcGFyZW50IHByb2Nlc3MKLSAg ICAgICAgY2xvc2Uoc29ja2V0c1swXSk7Ci0gICAgICAgIG1fcHJvY2Vzc0lkZW50aWZpZXIgPSBw aWQ7Ci0gICAgICAgIC8vIFdlJ3ZlIGZpbmlzaGVkIGxhdW5jaGluZyB0aGUgcHJvY2VzcywgbWVz c2FnZSBiYWNrIHRvIHRoZSBtYWluIHJ1biBsb29wLgotICAgICAgICBSdW5Mb29wOjptYWluKCkt PnNjaGVkdWxlV29yayhXb3JrSXRlbTo6Y3JlYXRlKHRoaXMsICZQcm9jZXNzTGF1bmNoZXI6OmRp ZEZpbmlzaExhdW5jaGluZ1Byb2Nlc3MsIHBpZCwgc29ja2V0c1sxXSkpOwotICAgIH0gZWxzZSB7 Ci0gICAgICAgIGZwcmludGYoc3RkZXJyLCAiVW5hYmxlIHRvIGZvcmsgYSBuZXcgV2ViUHJvY2Vz cyB3aXRoIGVycm5vOiAlZC5cbiIsIGVycm5vKTsKKyAgICBHT3duUHRyPGdjaGFyPiBiaW5hcnlQ YXRoKGdfYnVpbGRfZmlsZW5hbWUoYXBwbGljYXRpb25EaXJlY3RvcnlQYXRoKCkuZGF0YSgpLCBn V2ViS2l0V2ViUHJvY2Vzc05hbWUsIE5VTEwpKTsKKyAgICBHT3duUHRyPGdjaGFyPiBzb2NrZXQo Z19zdHJkdXBfcHJpbnRmKCIlZCIsIHNvY2tldHNbMF0pKTsKKyAgICBjaGFyKiBhcmd2WzNdOwor ICAgIGFyZ3ZbMF0gPSBiaW5hcnlQYXRoLmdldCgpOworICAgIGFyZ3ZbMV0gPSBzb2NrZXQuZ2V0 KCk7CisgICAgYXJndlsyXSA9IDA7CisKKyAgICBHT3duUHRyPEdFcnJvcj4gZXJyb3I7CisgICAg aW50IHNwYXduRmxhZ3MgPSBHX1NQQVdOX0xFQVZFX0RFU0NSSVBUT1JTX09QRU4gfCBHX1NQQVdO X0RPX05PVF9SRUFQX0NISUxEOworICAgIGlmICghZ19zcGF3bl9hc3luYygwLCBhcmd2LCAwLCBz dGF0aWNfY2FzdDxHU3Bhd25GbGFncz4oc3Bhd25GbGFncyksIGNoaWxkU2V0dXBGdW5jLCBHSU5U X1RPX1BPSU5URVIoc29ja2V0c1sxXSksICZwaWQsICZlcnJvci5vdXRQdHIoKSkpIHsKKyAgICAg ICAgZ19wcmludGVycigiVW5hYmxlIHRvIGZvcmsgYSBuZXcgV2ViUHJvY2VzczogJXMuXG4iLCBl cnJvci0+bWVzc2FnZSk7CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KKwor ICAgIGNsb3NlKHNvY2tldHNbMF0pOworICAgIG1fcHJvY2Vzc0lkZW50aWZpZXIgPSBzdGF0aWNf Y2FzdDxwaWRfdD4ocGlkKTsKKyAgICAvLyBXZSd2ZSBmaW5pc2hlZCBsYXVuY2hpbmcgdGhlIHBy b2Nlc3MsIG1lc3NhZ2UgYmFjayB0byB0aGUgbWFpbiBydW4gbG9vcC4KKyAgICBSdW5Mb29wOjpt YWluKCktPnNjaGVkdWxlV29yayhXb3JrSXRlbTo6Y3JlYXRlKHRoaXMsICZQcm9jZXNzTGF1bmNo ZXI6OmRpZEZpbmlzaExhdW5jaGluZ1Byb2Nlc3MsIG1fcHJvY2Vzc0lkZW50aWZpZXIsIHNvY2tl dHNbMV0pKTsKIH0KIAogdm9pZCBQcm9jZXNzTGF1bmNoZXI6OnRlcm1pbmF0ZVByb2Nlc3MoKQo=