57232 2011-03-28 07:42:30 -0700 Change default alignment for LI elements to -webkit-match-parent 2011-06-18 12:52:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 playmobil playmobil aharon eric mitz rniwa webkit.review.bot oldest_to_newest 374482 0 playmobil 2011-03-28 07:42:30 -0700 Change default alignment for LI elements to -webkit-match-parent 374487 1 87143 playmobil 2011-03-28 07:48:07 -0700 Created attachment 87143 Patch 374488 2 87143 eric 2011-03-28 07:54:11 -0700 Comment on attachment 87143 Patch LGTM. I assume other browsers don't pass this yet? 374489 3 eric 2011-03-28 07:55:19 -0700 Would be nice if your ChangeLog could give more justification for this change. (Like citations of the spec, or the style mailing list.) Has this changed in HTML5? If not, will you please file a bug against the HTML5 spec and reference it form this bug (and ideally your ChangeLog). 375158 4 aharon 2011-03-29 03:30:59 -0700 (In reply to comment #3) > Would be nice if your ChangeLog could give more justification for this change. (Like citations of the spec, or the style mailing list.) > > Has this changed in HTML5? If not, will you please file a bug against the HTML5 spec and reference it form this bug (and ideally your ChangeLog). This has been discussed on the CSS list, see http://lists.w3.org/Archives/Public/www-style/2011Feb/0066.html and keep going in the thread. It includes the status vis-a-vis the HTML5 spec. 375259 5 playmobil 2011-03-29 06:40:32 -0700 HTML5 bug: http://www.w3.org/Bugs/Public/show_bug.cgi?id=10824 378493 6 rniwa 2011-04-03 00:13:12 -0700 Has this been landed or not? 423128 7 rniwa 2011-06-18 10:21:01 -0700 Jeremy, have you landed this patch yet? 423194 8 87143 webkit.review.bot 2011-06-18 12:52:47 -0700 Comment on attachment 87143 Patch Clearing flags on attachment: 87143 Committed r89199: <http://trac.webkit.org/changeset/89199> 423195 9 webkit.review.bot 2011-06-18 12:52:52 -0700 All reviewed patches have been landed. Closing bug. 87143 2011-03-28 07:48:07 -0700 2011-06-18 12:52:47 -0700 Patch bug-57232-20110328164805.patch text/plain 5567 playmobil U3VidmVyc2lvbiBSZXZpc2lvbjogODIxMTAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxOTUxOTk1YzYzMjIxM2QwZTU3YWMy YjdmY2E5YzZkOTIwZTY5M2EwLi5hZDM3ZDdiNTA5YTFkYTcyZDYwZGQ0YmU4ODdkNGVjNDRkMjRk NDA0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMjggIEplcmVteSBNb3Nrb3ZpY2gg IDxqZXJlbXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFNldCB0ZXh0LWFsaWduOi13ZWJraXQtbWF0Y2gtcGFyZW50IGZvciBs aSBlbGVtZW50cyBpbiB0aGUgZGVmYXVsdCBzdHlsZSBzaGVldC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MjMyCisKKyAgICAgICAgKiBmYXN0L2Nz cy9saXN0LWl0ZW0tdGV4dC1hbGlnbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvY3NzL2xpc3QtaXRlbS10ZXh0LWFsaWduLmh0bWw6IEFkZGVkLgorCiAyMDExLTAzLTI3ICBK ZXJlbXkgTW9za292aWNoICA8amVyZW15QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xpc3Qt aXRlbS10ZXh0LWFsaWduLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xpc3Qt aXRlbS10ZXh0LWFsaWduLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jNTc5NDNiMjNmMWVkNzUy NTFjZDc1ODViOTAzMTEzMjJjYTljNmE3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9jc3MvbGlzdC1pdGVtLXRleHQtYWxpZ24tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTcg QEAKK1RoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IHRleHQtYWxpZ246LXdlYmtpdC1tYXRjaC1wYXJl bnQgaXMgdGhlIGRlZmF1bHQgc3R5bGUgZm9yIGxpc3QgZWxlbWVudHMuCisKK1RoZSB0ZXN0IHBh c3NlcyBpZiBhbGwgdGhlIGxpbmVzIGNvbnRhaW5pbmcgdGhlIHRleHQgIkxlZnQgQWxpZ24iIGFy ZSBhbGlnbmVkIHRvIHRoZSBsZWZ0IGFuZCB2aWNlLXZlcnNhIGZvciAiUmlnaHQgQWxpZ24iLgor UEFTUworUEFTUworUEFTUworUEFTUworUEFTUworUEFTUworUEFTUworUEFTUworUEFTUworUEFT UworUEFTUworUEFTUworUEFTUworUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9j c3MvbGlzdC1pdGVtLXRleHQtYWxpZ24uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xpc3Qt aXRlbS10ZXh0LWFsaWduLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjZlZWJkNmJhODQzYTEzMjE4YzIxMjhk ZDg1ODY3NjEyNDk4Mjc2NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L2xpc3QtaXRlbS10ZXh0LWFsaWduLmh0bWwKQEAgLTAsMCArMSw4NSBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aDM+CitUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCB0ZXh0LWFsaWduOi13ZWJraXQtbWF0 Y2gtcGFyZW50IGlzIHRoZSBkZWZhdWx0IHN0eWxlIGZvciBsaXN0IGVsZW1lbnRzLgorPC9oMz4K KworPGRpdj4KK1RoZSB0ZXN0IHBhc3NlcyBpZiBhbGwgdGhlIGxpbmVzIGNvbnRhaW5pbmcgdGhl IHRleHQgIkxlZnQgQWxpZ24iIGFyZSBhbGlnbmVkIHRvIHRoZSBsZWZ0IGFuZCB2aWNlLXZlcnNh IGZvciAiUmlnaHQgQWxpZ24iLgorPC9kaXY+CisKKzx1bCBkaXI9bHRyPgorICA8bGkgZGlyPWx0 ciBjbGFzcz1sPjxzcGFuPkxlZnQgYWxpZ25lZDwvc3Bhbj48L2xpPgorICA8bGkgZGlyPXJ0bCBj bGFzcz1yPjxzcGFuPlJpZ2h0IGFsaWduZWQ8L3NwYW4+PC9saT4KKzwvdWw+CisKKzx1bCBkaXI9 bHRyIHN0eWxlPSJ0ZXh0LWFsaWduOnN0YXJ0Ij4KKyAgPGxpIGRpcj1sdHIgY2xhc3M9bD5MZWZ0 IGFsaWduZWQ8L2xpPgorICA8bGkgZGlyPXJ0bCBjbGFzcz1sPkxlZnQgYWxpZ25lZDwvbGk+Cis8 L3VsPgorCis8dWwgZGlyPWx0ciBzdHlsZT0idGV4dC1hbGlnbjplbmQiPgorICA8bGkgZGlyPWx0 ciBjbGFzcz1yPlJpZ2h0IGFsaWduZWQ8L2xpPgorICA8bGkgZGlyPXJ0bCBjbGFzcz1yPlJpZ2h0 IGFsaWduZWQ8L2xpPgorPC91bD4KKworPHVsIGRpcj1ydGwgc3R5bGU9InRleHQtYWxpZ246c3Rh cnQiPgorICA8bGkgZGlyPWx0ciBjbGFzcz1yPlJpZ2h0IGFsaWduZWQ8L2xpPgorICA8bGkgZGly PXJ0bCBjbGFzcz1yPlJpZ2h0IGFsaWduZWQ8L2xpPgorPC91bD4KKworPHVsIGRpcj1ydGwgc3R5 bGU9InRleHQtYWxpZ246ZW5kIj4KKyAgPGxpIGRpcj1sdHIgY2xhc3M9bD5MZWZ0IGFsaWduZWQ8 L2xpPgorICA8bGkgZGlyPXJ0bCBjbGFzcz1sPkxlZnQgYWxpZ25lZDwvbGk+Cis8L3VsPgorCis8 dWwgZGlyPXJ0bCBzdHlsZT0idGV4dC1hbGlnbjpsZWZ0Ij4KKyAgPGxpIGRpcj1sdHIgY2xhc3M9 bD5MZWZ0IGFsaWduZWQ8L2xpPgorICA8bGkgZGlyPXJ0bCBjbGFzcz1sPkxlZnQgYWxpZ25lZDwv bGk+Cis8L3VsPgorCis8dWwgZGlyPXJ0bCBzdHlsZT0idGV4dC1hbGlnbjpyaWdodCI+CisgIDxs aSBkaXI9bHRyIGNsYXNzPXI+UmlnaHQgYWxpZ25lZDwvbGk+CisgIDxsaSBkaXI9cnRsIGNsYXNz PXI+UmlnaHQgYWxpZ25lZDwvbGk+Cis8L3VsPgorCisKKzxzY3JpcHQ+CitpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKKworLy8gQ2hlY2tzIHRoYXQgdGhlIGdpdmVuIGVsZW1lbnQgaXMgbGVmdCBhbGlnbmVkIGlm IGV4cGVjdGVkQWxpZ25tZW50IGlzICdsZWZ0Jywgb3IgcmlnaHQgYWxpZ25lZCBpZgorLy8gZXhw ZWN0ZWRBbGlnbm1lbnQgaXMgJ3JpZ2h0Jy4KK2Z1bmN0aW9uIGFzc2VydEFsaWdubWVudChlbmNs b3NpbmdMaXN0RWxlbWVudCwgaSwgZXhwZWN0ZWRBbGlnbm1lbnQpCit7CisgICAgdmFyIGNvbXB1 dGVkU3R5bGUgPSB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShlbmNsb3NpbmdMaXN0RWxlbWVudCwg bnVsbCk7CisgICAgdmFyIGxlZnRBbGlnbiA9IGV4cGVjdGVkQWxpZ25tZW50ID09ICdsZWZ0JzsK KworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgaWYgKGNv bXB1dGVkU3R5bGUudGV4dEFsaWduID09ICctd2Via2l0LWF1dG8nKSB7CisgICAgICAgICAgICAv LyBGb3IgdGhlIGNhc2Ugb2YgLXdlYmtpdC1hdXRvIGNoZWNrIHRoZSBvZmZzZXQgb2YgdGhlIHRl eHQgb24gc2NyZWVuCisgICAgICAgICAgICAvLyByYXRoZXIgdGhhbiBleGFtaW5pbmcgdGhlIGNv bXB1dGVkIHN0eWxlLgorICAgICAgICAgICAgdmFyIGVsZW1lbnRMZWZ0RWRnZSA9IGVuY2xvc2lu Z0xpc3RFbGVtZW50LmNoaWxkcmVuWzBdLm9mZnNldExlZnQ7CisgICAgICAgICAgICBpc0xlZnRB bGlnbmVkID0gZWxlbWVudExlZnRFZGdlIDwgZG9jdW1lbnQuYm9keS5jbGllbnRXaWR0aC8yOwor ICAgICAgICAgICAgZW5jbG9zaW5nTGlzdEVsZW1lbnQuaW5uZXJIVE1MID0gKGxlZnRBbGlnbiA9 PSBpc0xlZnRBbGlnbmVkID8gJ1BBU1MnIDogJ0ZBSUwnKTsKKyAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgaWYgKGxlZnRBbGlnbiAmJiBjb21wdXRlZFN0 eWxlLnRleHRBbGlnbiA9PSAnbGVmdCcpCisgICAgICAgICAgICBlbmNsb3NpbmdMaXN0RWxlbWVu dC5pbm5lckhUTUwgPSAnUEFTUyc7CisgICAgICAgIGVsc2UgaWYgKCFsZWZ0QWxpZ24gJiYgY29t cHV0ZWRTdHlsZS50ZXh0QWxpZ24gPT0gJ3JpZ2h0JykKKyAgICAgICAgICAgIGVuY2xvc2luZ0xp c3RFbGVtZW50LmlubmVySFRNTCA9ICdQQVNTJzsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAg ZW5jbG9zaW5nTGlzdEVsZW1lbnQuaW5uZXJIVE1MID0gJ0ZBSUwnOworICAgIH0KK30KKworLy8g QWN0dWFsIHRlc3QuCit2YXIgbGVmdEFsaWduZWREaXZzID0gZG9jdW1lbnQucXVlcnlTZWxlY3Rv ckFsbCgiLmwiKTsKK2ZvciAodmFyIGkgPSAwOyBpIDwgbGVmdEFsaWduZWREaXZzLmxlbmd0aDsg aSsrKQorICAgIGFzc2VydEFsaWdubWVudChsZWZ0QWxpZ25lZERpdnNbaV0sIGksICdsZWZ0Jyk7 CisKK3ZhciByaWdodEFsaWduZWREaXZzID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgiLnIi KTsKK2ZvciAodmFyIGkgPSAwOyBpIDwgcmlnaHRBbGlnbmVkRGl2cy5sZW5ndGg7IGkrKykKKyAg ICBhc3NlcnRBbGlnbm1lbnQocmlnaHRBbGlnbmVkRGl2c1tpXSwgaSwgJ3JpZ2h0Jyk7CisKKzwv c2NyaXB0PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3ZjM5YWNj YmM1MDg1ZTRkNWIyMzFmNWYyOWEzOTgyNzkyMzU2M2Y1Li5hMGFmYjE5MjQ1NmYzMTFlZjFmN2Jm NTNkYzIzZGQ5NWIyYzExODY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMt MjggIEplcmVteSBNb3Nrb3ZpY2ggIDxqZXJlbXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldCB0ZXh0LWFsaWduOi13ZWJr aXQtbWF0Y2gtcGFyZW50IGZvciBsaSBlbGVtZW50cyBpbiB0aGUgZGVmYXVsdCBzdHlsZSBzaGVl dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MjMy CisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvbGlzdC1pdGVtLXRleHQtYWxpZ24uaHRtbAorCisg ICAgICAgICogY3NzL2h0bWwuY3NzOgorICAgICAgICAobGkpOiBTcGVjaWZ5IHRleHQtYWxpZ246 LXdlYmtpdC1tYXRjaC1wYXJlbnQgLgorCiAyMDExLTAzLTI3ICBKZXJlbXkgTW9za292aWNoICA8 amVyZW15QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9odG1sLmNzcyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9odG1sLmNzcwppbmRleCBiOWJlNTBlNjMwYTM1OWE3N2U3YzhlYTBjNTVhYzA0ODA5OWFl ZmIzLi5mYWIyOTIxZDc5MzI5NzcwYmFmOThhYjkwMjA0ZDJkNzhiYjVhNGE1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvaHRtbC5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL2h0 bWwuY3NzCkBAIC0yODQsNyArMjg0LDggQEAgb2wgewogfQogCiBsaSB7Ci0gICAgZGlzcGxheTog bGlzdC1pdGVtCisgICAgZGlzcGxheTogbGlzdC1pdGVtOworICAgIHRleHQtYWxpZ246IC13ZWJr aXQtbWF0Y2gtcGFyZW50OwogfQogCiB1bCB1bCwgb2wgdWwgewo=