57222 2011-03-28 03:59:40 -0700 [EFL] Remove unnecessary ewk_view_viewport_attributes_set() invocation 2011-03-29 00:31:17 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue kenneth tonikitoo oldest_to_newest 374391 0 gyuyoung.kim 2011-03-28 03:59:40 -0700 Now, FrameLoaderClientEfl::dispatchDidCommitLoad() invokes ewk_view_viewport_attributes_set() unconditionally. When WebCore didn't support to switch between mobile page and desktop page, we needed to send dummy viewport signal to application in order to set viewport for desktop width. (as soon as page starts to load.) But, latest WebCore sends viewport signal whenever viewport is changed by Page::updateViewportArguments(). Thus, IMO, we don't need to call ewk_view_viewport_attributes_set() with dummy viewport data anymore. 374394 1 87122 gyuyoung.kim 2011-03-28 04:06:07 -0700 Created attachment 87122 Proposed Patch 375080 2 87122 commit-queue 2011-03-29 00:31:13 -0700 Comment on attachment 87122 Proposed Patch Clearing flags on attachment: 87122 Committed r82205: <http://trac.webkit.org/changeset/82205> 375081 3 commit-queue 2011-03-29 00:31:17 -0700 All reviewed patches have been landed. Closing bug. 87122 2011-03-28 04:06:07 -0700 2011-03-29 00:31:13 -0700 Proposed Patch patch-viewport.patch text/plain 1675 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBkMzhkOTUyLi5mNDliYzEzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMjggIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBSZW1vdmUgdW5uZWNlc3NhcnkgZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRl c19zZXQoKSBpbnZvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01NzIyMgorCisgICAgICAgIFdlYkNvcmUgc2VuZHMgdmlld3BvcnQgc2lnbmFs IHdoZW5ldmVyIHZpZXdwb3J0IGlzIGNoYW5nZWQgYnkgUGFnZTo6dXBkYXRlVmlld3BvcnRBcmd1 bWVudHMoKS4KKyAgICAgICAgVGh1cywgd2UgZG9uJ3QgbmVlZCB0byBjYWxsIGV3a192aWV3X3Zp ZXdwb3J0X2F0dHJpYnV0ZXNfc2V0KCkgd2l0aCBkdW1teSB2aWV3cG9ydCBkYXRhCisgICAgICAg IGFueW1vcmUuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVm bC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEVmbDo6ZGlzcGF0Y2hE aWRDb21taXRMb2FkKToKKwogMjAxMS0wMy0yNyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRF ZmwuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll bnRFZmwuY3BwCmluZGV4IGY5Y2QwZDMuLmZhMzRhYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHAKQEAg LTUwLDcgKzUwLDYgQEAKICNpbmNsdWRlICJQcm9ncmVzc1RyYWNrZXIuaCIKICNpbmNsdWRlICJS ZW5kZXJQYXJ0LmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VSZXF1ZXN0LmgiCi0jaW5jbHVkZSAiVmll d3BvcnRBcmd1bWVudHMuaCIKICNpbmNsdWRlICJXZWJLaXRWZXJzaW9uLmgiCiAjaW5jbHVkZSAi ZXdrX3ByaXZhdGUuaCIKICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CkBAIC01OTksOSAr NTk4LDYgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEVmbDo6ZGlzcGF0Y2hEaWRDb21taXRMb2Fk KCkKICAgICAgICAgcmV0dXJuOwogICAgIGV3a192aWV3X3RpdGxlX3NldChtX3ZpZXcsIDApOwog ICAgIGV3a192aWV3X3VyaV9jaGFuZ2VkKG1fdmlldyk7Ci0KLSAgICBWaWV3cG9ydEFyZ3VtZW50 cyBhcmd1bWVudHM7Ci0gICAgZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19zZXQobV92aWV3 LCBhcmd1bWVudHMpOwogfQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpkaXNwYXRjaERp ZEZpbmlzaERvY3VtZW50TG9hZCgpCg==