57215 2011-03-28 01:38:31 -0700 refactor duplicate code in HTMLTextElement 2011-03-28 02:09:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan evan eric rniwa oldest_to_newest 374341 0 evan 2011-03-28 01:38:31 -0700 refactor duplicate code in HTMLTextElement 374343 1 87113 evan 2011-03-28 01:40:19 -0700 Created attachment 87113 Patch 374344 2 evan 2011-03-28 01:40:58 -0700 (click the 'expand' button below the diff to see the duplicate code) 374349 3 evan 2011-03-28 01:57:36 -0700 Committed r82090: <http://trac.webkit.org/changeset/82090> 374359 4 eric 2011-03-28 02:09:59 -0700 You are my hero. 87113 2011-03-28 01:40:19 -0700 2011-03-28 01:43:32 -0700 Patch bug-57215-20110328014413.patch text/plain 1603 evan U3VidmVyc2lvbiBSZXZpc2lvbjogODE5NzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1MzAzMThiNGY2Zjg5MjQ3 ODIwYWJmMzY4NTZlYjliZTRlNTY2NzNjLi5jZjE0NWIzMmYxNmU3MTk2MjFiY2QxNzY0YTM1MTY1 N2UwNmQzYWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMjggIEV2YW4g TWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVmYWN0b3IgZHVwbGljYXRlIGNvZGUgaW4gSFRNTFRleHRF bGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NzIxNQorCisgICAgICAgICogaHRtbC9IVE1MVGl0bGVFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxUaXRsZUVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZCk6CisgICAgICAgIFRoaXMg bWV0aG9kIGRpZCBhbiBlcXVpdmFsZW50IGxvb3AgdG8gdGhlIHRleHQoKSBtZXRob2Qgb24KKyAg ICAgICAgdGhlIHNhbWUgb2JqZWN0LgorCiAyMDExLTAzLTI1ICBEYXZlIEh5YXR0ICA8aHlhdHRA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlIFBldGVyc29uLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGl0bGVFbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTFRpdGxlRWxlbWVudC5jcHAKaW5kZXggNzc2YzM3Y2I1NDJkYjQ1NGNm MjczYjk0Y2E4NzUyNmZhOGEzYmI5Mi4uMzFiMWIyYmNkMmI4ZTRlMWE2MzhhNzUwOGJkMDdlYjdm YWE3NzViMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGl0bGVFbGVtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUaXRsZUVsZW1lbnQuY3BwCkBAIC01 NywxMCArNTcsNyBAQCB2b2lkIEhUTUxUaXRsZUVsZW1lbnQ6OnJlbW92ZWRGcm9tRG9jdW1lbnQo KQogCiB2b2lkIEhUTUxUaXRsZUVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZChib29sIGNoYW5nZWRC eVBhcnNlciwgTm9kZSogYmVmb3JlQ2hhbmdlLCBOb2RlKiBhZnRlckNoYW5nZSwgaW50IGNoaWxk Q291bnREZWx0YSkKIHsKLSAgICBtX3RpdGxlID0gIiI7Ci0gICAgZm9yIChOb2RlKiBjID0gZmly c3RDaGlsZCgpOyBjICE9IDA7IGMgPSBjLT5uZXh0U2libGluZygpKQotICAgICAgICBpZiAoYy0+ bm9kZVR5cGUoKSA9PSBURVhUX05PREUgfHwgYy0+bm9kZVR5cGUoKSA9PSBDREFUQV9TRUNUSU9O X05PREUpCi0gICAgICAgICAgICBtX3RpdGxlICs9IGMtPm5vZGVWYWx1ZSgpOworICAgIG1fdGl0 bGUgPSB0ZXh0KCk7CiAgICAgaWYgKGluRG9jdW1lbnQoKSkKICAgICAgICAgZG9jdW1lbnQoKS0+ c2V0VGl0bGUobV90aXRsZSwgdGhpcyk7CiAgICAgSFRNTEVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdl ZChjaGFuZ2VkQnlQYXJzZXIsIGJlZm9yZUNoYW5nZSwgYWZ0ZXJDaGFuZ2UsIGNoaWxkQ291bnRE ZWx0YSk7Cg==