57209 2011-03-28 00:25:25 -0700 Assigning location.path to something that doesn't start with / mangles the authority 2011-03-28 08:51:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 374312 0 mjs 2011-03-28 00:25:25 -0700 Assigning location.path to something that doesn't start with / mangles the authority 374313 1 87108 mjs 2011-03-28 00:26:31 -0700 Created attachment 87108 Patch 374320 2 87108 abarth 2011-03-28 01:00:45 -0700 Comment on attachment 87108 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87108&action=review > Source/WebCore/platform/KURL.cpp:864 > + if (path.length() < 1 || path[0] != '/') > + path = "/" + path; I'd just test for path.isEmpty() instead of path.length() < 1. 374364 3 mjs 2011-03-28 02:34:30 -0700 Committed r82093: <http://trac.webkit.org/changeset/82093> 374513 4 87108 darin 2011-03-28 08:51:04 -0700 Comment on attachment 87108 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87108&action=review >> Source/WebCore/platform/KURL.cpp:864 >> + path = "/" + path; > > I'd just test for path.isEmpty() instead of path.length() < 1. Since string subscripting does a length check, there is no need to check path.length() or path.isEmpty(). The value path[0] will be 0 if the path is empty. 87108 2011-03-28 00:26:31 -0700 2011-03-28 08:51:04 -0700 Patch bug-57209-20110328002630.patch text/plain 5734 mjs SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyMDg4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMjggIE1hY2llaiBT dGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBc3NpZ25pbmcgbG9jYXRpb24ucGF0aCB0byBzb21ldGhpbmcg dGhhdCBkb2Vzbid0IHN0YXJ0IHdpdGggLyBtYW5nbGVzIHRoZSBhdXRob3JpdHkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MjA5CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS85MTk1MTMyPgorICAgICAgICAKKyAgICAgICAgVGVzdHM6IGh0dHAvdGVz dHMvdXJpL2Fzc2lnbi1wYXRoLXdpdGgtbGVhZGluZy1zbGFzaC5odG1sCisgICAgICAgICAgICAg ICBodHRwL3Rlc3RzL3VyaS9hc3NpZ24tcGF0aC13aXRob3V0LWxlYWRpbmctc2xhc2guaHRtbAor CisgICAgICAgICogcGxhdGZvcm0vS1VSTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpLVVJMOjpz ZXRQYXRoKTogSWYgdGhlIG5ldyBwYXRoIGRvZXMgbm90IGhhdmUgYSBsZWFkaW5nIHNsYXNoLCBh ZGQgb25lLgorCiAyMDExLTAzLTI3ICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9LVVJMLmNwcAkocmV2aXNpb24gODIwNTkpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9LVVJMLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODU5LDcgKzg1OSwxMSBAQCB2b2lk IEtVUkw6OnNldFBhdGgoY29uc3QgU3RyaW5nJiBzKQogCiAgICAgLy8gRklYTUU6IGVuY29kZVdp dGhVUkxFc2NhcGVTZXF1ZW5jZXMgZG9lcyBub3QgY29ycmVjdGx5IGVzY2FwZSAnIycgYW5kICc/ Jywgc28gZnJhZ21lbnQgYW5kIHF1ZXJ5IHBhcnRzCiAgICAgLy8gbWF5IGJlIGluYWR2ZXJ0ZW50 bHkgYWZmZWN0ZWQuCi0gICAgcGFyc2UobV9zdHJpbmcubGVmdChtX3BvcnRFbmQpICsgZW5jb2Rl V2l0aFVSTEVzY2FwZVNlcXVlbmNlcyhzKSArIG1fc3RyaW5nLnN1YnN0cmluZyhtX3BhdGhFbmQp KTsKKyAgICBTdHJpbmcgcGF0aCA9IHM7CisgICAgaWYgKHBhdGgubGVuZ3RoKCkgPCAxIHx8IHBh dGhbMF0gIT0gJy8nKQorICAgICAgICBwYXRoID0gIi8iICsgcGF0aDsKKworICAgIHBhcnNlKG1f c3RyaW5nLmxlZnQobV9wb3J0RW5kKSArIGVuY29kZVdpdGhVUkxFc2NhcGVTZXF1ZW5jZXMocGF0 aCkgKyBtX3N0cmluZy5zdWJzdHJpbmcobV9wYXRoRW5kKSk7CiB9CiAKIFN0cmluZyBLVVJMOjpw cmV0dHlVUkwoKSBjb25zdApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODIwODgpCisrKyBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wMy0yOCAg TWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzc2lnbmluZyBsb2NhdGlvbi5wYXRoIHRvIHNv bWV0aGluZyB0aGF0IGRvZXNuJ3Qgc3RhcnQgd2l0aCAvIG1hbmdsZXMgdGhlIGF1dGhvcml0eQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcyMDkKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzkxOTUxMzI+CisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3Vy aS9hc3NpZ24tcGF0aC13aXRoLWxlYWRpbmctc2xhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBodHRwL3Rlc3RzL3VyaS9hc3NpZ24tcGF0aC13aXRoLWxlYWRpbmctc2xhc2guaHRt bDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy91cmkvYXNzaWduLXBhdGgtd2l0aG91dC1s ZWFkaW5nLXNsYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy91 cmkvYXNzaWduLXBhdGgtd2l0aG91dC1sZWFkaW5nLXNsYXNoLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIGh0dHAvdGVzdHMvdXJpL3Jlc291cmNlcy9hc3NpZ24tcGF0aC1sYW5kaW5nLmh0bWw6IEFk ZGVkLgorCiAyMDExLTAzLTI3ICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBMYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3VyaS9hc3NpZ24tcGF0aC13aXRoLWxlYWRpbmctc2xhc2gtZXhwZWN0 ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvdXJpL2Fzc2lnbi1w YXRoLXdpdGgtbGVhZGluZy1zbGFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3VyaS9hc3NpZ24tcGF0aC13aXRoLWxlYWRpbmctc2xhc2gtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKK1RoZSBwYXRoIGFzc2lnbm1l bnQgdGVzdCByZWRpcmVjdGVkIHN1Y2Nlc3NmdWxseS4gQ2hlY2tpbmcgcGF0aC4uLgorUEFTUyBs b2NhdGlvbi5wYXRobmFtZSBpcyAnL3VyaS9yZXNvdXJjZXMvYXNzaWduLXBhdGgtbGFuZGluZy5o dG1sJworCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3VyaS9hc3NpZ24tcGF0aC13aXRo LWxlYWRpbmctc2xhc2guaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L3VyaS9hc3NpZ24tcGF0aC13aXRoLWxlYWRpbmctc2xhc2guaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2h0dHAvdGVzdHMvdXJpL2Fzc2lnbi1wYXRoLXdpdGgtbGVhZGluZy1zbGFz aC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxi b2R5PgorVGhpcyB0ZXN0IHNob3VsZCByZWRpcmVjdCB0byBhIGxhbmRpbmcgcGFnZSB3aXRoIG5v IGRvdWJsZWQgc2xhc2hlcyBpbiB0aGUgcGF0aC4KKworPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorPC9zY3Jp cHQ+CisKKzxzY3JpcHQ+Citsb2NhdGlvbi5wYXRobmFtZT0iL3VyaS9yZXNvdXJjZXMvYXNzaWdu LXBhdGgtbGFuZGluZy5odG1sIjsKKzwvc2NyaXB0PgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy91cmkvYXNzaWduLXBhdGgtd2l0aG91dC1sZWFkaW5nLXNsYXNoLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3VyaS9hc3NpZ24tcGF0aC13aXRo b3V0LWxlYWRpbmctc2xhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy91cmkvYXNzaWduLXBhdGgtd2l0aG91dC1sZWFkaW5nLXNsYXNoLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitUaGUgcGF0aCBhc3NpZ25tZW50 IHRlc3QgcmVkaXJlY3RlZCBzdWNjZXNzZnVsbHkuIENoZWNraW5nIHBhdGguLi4KK1BBU1MgbG9j YXRpb24ucGF0aG5hbWUgaXMgJy91cmkvcmVzb3VyY2VzL2Fzc2lnbi1wYXRoLWxhbmRpbmcuaHRt bCcKKwpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy91cmkvYXNzaWduLXBhdGgtd2l0aG91 dC1sZWFkaW5nLXNsYXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy91cmkvYXNzaWduLXBhdGgtd2l0aG91dC1sZWFkaW5nLXNsYXNoLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3VyaS9hc3NpZ24tcGF0aC13aXRob3V0LWxlYWRp bmctc2xhc2guaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNSBAQAorPCFET0NUWVBFIGh0 bWw+Cis8Ym9keT4KK1RoaXMgdGVzdCBzaG91bGQgcmVkaXJlY3QgdG8gYSBsYW5kaW5nIHBhZ2Ug d2l0aCBhIHN1Y2Nlc3MgcmVzdWx0LiBJZgoraXQgZmFpbHMgdG8gcmVkaXJlY3QsIG9yIHJlZGly ZWN0cyB0byBhbiBlcnJvciBwYWdlLCB0aGVuIHRoZXJlIGlzIGEgYnVnLgorCis8c2NyaXB0Pgor aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25l KCk7Cit9Cis8L3NjcmlwdD4KKworPHNjcmlwdD4KK2xvY2F0aW9uLnBhdGhuYW1lPSJ1cmkvcmVz b3VyY2VzL2Fzc2lnbi1wYXRoLWxhbmRpbmcuaHRtbCI7Cis8L3NjcmlwdD4KSW5kZXg6IExheW91 dFRlc3RzL2h0dHAvdGVzdHMvdXJpL3Jlc291cmNlcy9hc3NpZ24tcGF0aC1sYW5kaW5nLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy91cmkvcmVzb3VyY2VzL2Fzc2ln bi1wYXRoLWxhbmRpbmcuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVz dHMvdXJpL3Jlc291cmNlcy9hc3NpZ24tcGF0aC1sYW5kaW5nLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMjMgQEAKKzwhRE9DVFlQRSBodG1sPgorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4K KzxoZWFkPgorICA8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2pzLXRlc3QtcmVz b3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKyAgPHNjcmlwdCBzcmM9Ii4uLy4uL2pzLXRlc3Qt cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorVGhl IHBhdGggYXNzaWdubWVudCB0ZXN0IHJlZGlyZWN0ZWQgc3VjY2Vzc2Z1bGx5LiBDaGVja2luZyBw YXRoLi4uCisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9k aXY+CisKKworPHNjcmlwdD4KK3Nob3VsZEJlKCJsb2NhdGlvbi5wYXRobmFtZSIsICInL3VyaS9y ZXNvdXJjZXMvYXNzaWduLXBhdGgtbGFuZGluZy5odG1sJyIpOworPC9zY3JpcHQ+CisKKzxzY3Jp cHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250 cm9sbGVyLm5vdGlmeURvbmUoKTsKKzwvc2NyaXB0PgorCg==